Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: components/signin/core/browser/account_tracker_service.h

Issue 1091363002: Change ProfileDownloader to use AccountTrackerService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review feedback. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/account_tracker_service.h
diff --git a/components/signin/core/browser/account_tracker_service.h b/components/signin/core/browser/account_tracker_service.h
index a32b766394a5af373c73aea4f69b987a52752638..64f8a1b3c2211116eb820cd53d9889407c23dcaf 100644
--- a/components/signin/core/browser/account_tracker_service.h
+++ b/components/signin/core/browser/account_tracker_service.h
@@ -41,6 +41,9 @@ class AccountTrackerService : public KeyedService,
// Value representing no hosted domain in the kProfileHostedDomain preference.
static const char kNoHostedDomainFound[];
+ // Value representing no picture URL associated with and account.
Mike Lerman 2015/04/30 19:09:07 nit: s/and/an/
anthonyvd 2015/05/01 19:16:34 Done.
+ static const char kNoPictureURLFound[];
+
// Information about a specific account.
struct AccountInfo {
AccountInfo();
@@ -53,10 +56,11 @@ class AccountTrackerService : public KeyedService,
std::string given_name;
std::string hosted_domain;
std::string locale;
- // TODO(rogerta): eventually this structure will include other information
- // about the account, like full name, profile picture URL, etc.
+ std::string picture_url;
+ // TODO(anthonyvd): Eventually this structure should contain the account
+ // service flags.
- bool IsValid();
+ bool IsValid() const;
};
// Clients of AccountTrackerService can implement this interface and register

Powered by Google App Engine
This is Rietveld 408576698