Change ProfileDownloader to use AccountTrackerService.

chrome/browser/profiles/profile_downloader.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "chrome/browser/image_decoder.h"
+#include "components/signin/core/browser/account_tracker_service.h"
 #include "google_apis/gaia/gaia_oauth_client.h"

[Mike Lerman, 2015/04/20 13:25:23]

Probably don't need this include anymore.

[anthonyvd, 2015/04/29 15:15:08]

Done.

 #include "google_apis/gaia/oauth2_token_service.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "url/gurl.h"
 
 class ProfileDownloaderDelegate;
 class OAuth2AccessTokenFetcher;
 
 namespace net {
 class URLFetcher;
 }  // namespace net
 
 // Downloads user profile information. The profile picture is decoded in a
 // sandboxed process.
-class ProfileDownloader : public gaia::GaiaOAuthClient::Delegate,
-                          public net::URLFetcherDelegate,
+class ProfileDownloader : public net::URLFetcherDelegate,
                           public ImageDecoder::ImageRequest,
                           public OAuth2TokenService::Observer,
-                          public OAuth2TokenService::Consumer {
+                          public OAuth2TokenService::Consumer,
+                          public AccountTrackerService::Observer {
  public:
   enum PictureStatus {
     PICTURE_SUCCESS,
     PICTURE_FAILED,
     PICTURE_DEFAULT,
     PICTURE_CACHED,
   };
 
   explicit ProfileDownloader(ProfileDownloaderDelegate* delegate);
   ~ProfileDownloader() override;
 
   // Starts downloading profile information if the necessary authorization token
   // is ready. If not, subscribes to token service and starts fetching if the
   // token is available. Should not be called more than once.
   virtual void Start();
 
   // Starts downloading profile information if the necessary authorization token
   // is ready. If not, subscribes to token service and starts fetching if the
   // token is available. Should not be called more than once.
-  virtual void StartForAccount(const std::string& account_id);
+  virtual void StartForAccount(
+      const std::string& account_id,
+      AccountTrackerService* account_tracker_service = nullptr);

[Mike Lerman, 2015/04/20 13:25:23]

Pretty sure Chromium style guide doesn't permit default parameters.

Also - we can access the Profile* through the ProfileDownloaderDelegate and then
use the AccountTrackerServiceFactory to get the appropriate
AccountTrackerService*. Why add it here?

[anthonyvd, 2015/04/29 15:15:08]

You're right, it's a remain of my trying a few things to make the tests. It's
not needed anymore so it's removed now.

Thanks!

 
   // On successful download this returns the hosted domain of the user.
   virtual base::string16 GetProfileHostedDomain() const;
 
   // On successful download this returns the full name of the user. For example
   // "Pat Smith".
   virtual base::string16 GetProfileFullName() const;
 
   // On successful download this returns the given name of the user. For example
   // if the name is "Pat Smith", the given name is "Pat".
   virtual base::string16 GetProfileGivenName() const;
 
   // On successful download this returns G+ locale preference of the user.
   virtual std::string GetProfileLocale() const;
 
   // On successful download this returns the profile picture of the user.
   // For users with no profile picture set (that is, they have the default
   // profile picture) this will return an Null bitmap.
   virtual SkBitmap GetProfilePicture() const;
 
   // Gets the profile picture status.
   virtual PictureStatus GetProfilePictureStatus() const;
 
   // Gets the URL for the profile picture. This can be cached so that the same
   // picture is not downloaded multiple times. This value should only be used
   // when the picture status is PICTURE_SUCCESS.
   virtual std::string GetProfilePictureURL() const;
 
+  void StartFetchingImageForTesting(net::URLFetcher* image_fetcher);
+
  private:
   friend class ProfileDownloaderTest;
   FRIEND_TEST_ALL_PREFIXES(ProfileDownloaderTest, ParseData);
   FRIEND_TEST_ALL_PREFIXES(ProfileDownloaderTest, DefaultURL);
 
-  // gaia::GaiaOAuthClient::Delegate implementation.
-  void OnGetUserInfoResponse(
-      scoped_ptr<base::DictionaryValue> user_info) override;
-  void OnOAuthError() override;
-  void OnNetworkError(int response_code) override;
+  void FetchImageData(std::string image_url);
 
   // Overriden from net::URLFetcherDelegate:
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   // Overriden from ImageDecoder::ImageRequest:
   void OnImageDecoded(const SkBitmap& decoded_image) override;
   void OnDecodeImageFailed() override;
 
   // Overriden from OAuth2TokenService::Observer:
   void OnRefreshTokenAvailable(const std::string& account_id) override;
 
   // Overriden from OAuth2TokenService::Consumer:
   void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
                          const std::string& access_token,
                          const base::Time& expiration_time) override;
   void OnGetTokenFailure(const OAuth2TokenService::Request* request,
                          const GoogleServiceAuthError& error) override;
 
-  // Parses the entry response and gets the name, profile image URL and locale.
-  // |data| should be the JSON formatted data return by the response.
-  // Returns false to indicate a parsing error.
-  static bool ParseProfileJSON(base::DictionaryValue* root_dictionary,
-                               base::string16* full_name,
-                               base::string16* given_name,
-                               std::string* url,
-                               int image_size,
-                               std::string* profile_locale,
-                               base::string16* hosted_domain);
+
+  // Implementation of AccountTrackerService::Observer.
+  void OnAccountUpdated(
+      const AccountTrackerService::AccountInfo& info) override;
+  void OnAccountUpdateFailed(const std::string& account_id) override;
+
   // Returns true if the image url is url of the default profile picture.
   static bool IsDefaultProfileImageURL(const std::string& url);
 
   // Issues the first request to get user profile image.
   void StartFetchingImage();
 
   // Gets the authorization header.
   const char* GetAuthorizationHeader() const;
 
   // Starts fetching OAuth2 access token. This is needed before the GAIA info
   // can be downloaded.
   void StartFetchingOAuth2AccessToken();
 
   ProfileDownloaderDelegate* delegate_;
   std::string account_id_;
   std::string auth_token_;
-  scoped_ptr<gaia::GaiaOAuthClient> gaia_client_;
   scoped_ptr<net::URLFetcher> profile_image_fetcher_;
   scoped_ptr<OAuth2TokenService::Request> oauth2_access_token_request_;
-  base::string16 profile_hosted_domain_;
-  base::string16 profile_full_name_;
-  base::string16 profile_given_name_;
-  std::string profile_locale_;
+  AccountTrackerService::AccountInfo account_info_;

[Mike Lerman, 2015/04/20 13:25:23]

A profile has multiple AccountInfo objects associated to it. This tracks, I
believe, information from only the primary account? If so - can we rename this
to primary_account_info_?

[Roger Tawa OOO till Jul 10th, 2015/04/21 14:00:34]

Actually, StartForAccount() can be called with an arbitrary account_id.  so I
think the original name is fine.

[anthonyvd, 2015/04/29 15:15:08]

Acknowledged.

   SkBitmap profile_picture_;
   PictureStatus picture_status_;
-  std::string picture_url_;
+  AccountTrackerService* account_tracker_service_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileDownloader);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_DOWNLOADER_H_