Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1091353004: libjingle_nacl.gyp: Remove unused dependency on <(webrtc_base)/move.h (Closed)

Created:
5 years, 8 months ago by kwiberg-chromium
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libjingle_nacl.gyp: Remove unused dependency on <(webrtc_base)/move.h Committed: https://crrev.com/9801fc9c7beb9ec95d40b1b3d84f2542359611b6 Cr-Commit-Position: refs/heads/master@{#327475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/libjingle/libjingle_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
kwiberg-chromium
Once this goes in, I can remove WebRTC's base/move.h.
5 years, 7 months ago (2015-04-29 09:59:18 UTC) #2
kjellander_chromium
lgtm
5 years, 7 months ago (2015-04-29 10:33:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091353004/1
5 years, 7 months ago (2015-04-29 11:06:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091353004/1
5 years, 7 months ago (2015-04-29 11:58:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091353004/1
5 years, 7 months ago (2015-04-29 12:15:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 12:17:57 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 12:18:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9801fc9c7beb9ec95d40b1b3d84f2542359611b6
Cr-Commit-Position: refs/heads/master@{#327475}

Powered by Google App Engine
This is Rietveld 408576698