Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: pkg/unittest/interactive_html_config.dart

Issue 10913271: Move parseInt parseDouble to int/double classes as a static method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make int.parse directly native. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/html_layout_config.dart ('k') | runtime/lib/double_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/interactive_html_config.dart
diff --git a/pkg/unittest/interactive_html_config.dart b/pkg/unittest/interactive_html_config.dart
index 0269a935c95c39ce67539546d1ee60630c34fa9a..3443ab85aeb62f67f8eea5047d36667c4a70acff 100644
--- a/pkg/unittest/interactive_html_config.dart
+++ b/pkg/unittest/interactive_html_config.dart
@@ -43,7 +43,7 @@ class _Message {
messageType = msg.substring(0, idx);
++idx;
int idx2 = msg.indexOf(' ', idx);
- elapsed = parseInt(msg.substring(idx, idx2));
+ elapsed = int.parse(msg.substring(idx, idx2));
++idx2;
body = msg.substring(idx2);
}
@@ -91,7 +91,7 @@ class ChildInteractiveHtmlConfiguration extends Configuration {
String search = window.location.search;
int pos = search.indexOf('t=');
String ids = search.substring(pos+2);
- int id = parseInt(ids);
+ int id = int.parse(ids);
setSoloTest(id);
runTests();
}
@@ -288,7 +288,7 @@ class ParentInteractiveHtmlConfiguration extends Configuration {
for (Element t in tests.elements) {
cb = t.query('.testselect') as InputElement;
cb.checked = state;
- var testId = parseInt(t.id.substring(_testIdPrefix.length));
+ var testId = int.parse(t.id.substring(_testIdPrefix.length));
if (state) {
enableTest(testId);
} else {
@@ -305,7 +305,7 @@ class ParentInteractiveHtmlConfiguration extends Configuration {
<li id='$_testIdPrefix$id' class='test-it status-pending'>
<div class='test-info'>
<p class='test-title'>
- <input type='checkbox' checked='true' class='testselect'
+ <input type='checkbox' checked='true' class='testselect'
id='$_selectedIdPrefix$id'>
<span class='test-label'>
<span class='timer-result test-timer-result'></span>
@@ -315,7 +315,7 @@ class ParentInteractiveHtmlConfiguration extends Configuration {
</div>
<div class='scrollpane'>
<ol class='test-actions' id='$_actionIdPrefix$id'></ol>
- </div>
+ </div>
</li>""");
list.nodes.add(testItem);
testItem.query('#$_selectedIdPrefix$id').on.change.add((e) {
« no previous file with comments | « pkg/unittest/html_layout_config.dart ('k') | runtime/lib/double_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698