Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/history/query_parser.h

Issue 10913262: Implement Bookmark Autocomplete Provider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Fixed match position coalescing. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autocomplete/bookmark_provider_unittest.cc ('K') | « chrome/browser/bookmarks/bookmark_index_unittest.cc ('k') | chrome/browser/history/query_parser.cc » ('j') | chrome/browser/history/query_parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/query_parser.h
===================================================================
--- chrome/browser/history/query_parser.h (revision 159706)
+++ chrome/browser/history/query_parser.h (working copy)
@@ -40,9 +40,9 @@
// must exactly match. Otherwise, this uses a starts with comparison.
virtual bool Matches(const string16& word, bool exact) const = 0;
- // Returns true if this node matches at least one of the words in |words|. If
- // the node matches at least one word, an entry is added to |match_positions|
- // giving the matching region.
+ // Returns true if this node matches at least one of the words in |words|. An
+ // entry is added to |match_positions| for all matching words giving the
+ // matching regions.
virtual bool HasMatchIn(const std::vector<QueryWord>& words,
Snippet::MatchPositions* match_positions) const = 0;
« chrome/browser/autocomplete/bookmark_provider_unittest.cc ('K') | « chrome/browser/bookmarks/bookmark_index_unittest.cc ('k') | chrome/browser/history/query_parser.cc » ('j') | chrome/browser/history/query_parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698