Convert url request info to new proxy API.

Convert url request info to new proxy API.

This splits out the helper functions in the in-process version to a new file: url_request_info_util. This will be moved to content/renderer when we move the url_loader.

The unit test was moved from webkit/plugins/ppapi to content/renderer/ppapi. I made it a browsertest which allowed the removal of a little boilerplate.

I had to add "internal" functions for loading stuff with just the data struct rather than a resource so the proxy doesn't have to create an in-process URLRequestInfo resource (which can't be created now when running out-of-process) just to create a request. This should be a little more efficient now anyway, and these duplicates will go away when such code moves to the new proxy design.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157588

[brettw, 2012-09-13 23:23:59]

Lots of files but most changes are easy and existing stuff moved around.

https://codereview.chromium.org/10913257/diff/2002/ppapi/proxy/url_request_in...
File ppapi/proxy/url_request_info_resource.h (right):

https://codereview.chromium.org/10913257/diff/2002/ppapi/proxy/url_request_in...
ppapi/proxy/url_request_info_resource.h:18: class PPAPI_PROXY_EXPORT
URLRequestInfoResource
This was just moved from url_request_info_shared.h

https://codereview.chromium.org/10913257/diff/2002/ppapi/shared_impl/url_requ...
File ppapi/shared_impl/url_request_info_data.h (left):

https://codereview.chromium.org/10913257/diff/2002/ppapi/shared_impl/url_requ...
ppapi/shared_impl/url_request_info_data.h:91: class PPAPI_SHARED_EXPORT
PPB_URLRequestInfo_Shared
Note: moved to URLRequestInfoResource.

https://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/url_r...
File webkit/plugins/ppapi/url_request_info_util.cc (right):

https://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/url_r...
webkit/plugins/ppapi/url_request_info_util.cc:46: // given HTTP body, returning
true on success.
This stuff was moved from below (no longer exposed from the header).

[bbudge, 2012-09-14 17:48:52]

lgtm w/nits

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
File webkit/plugins/ppapi/ppb_url_loader_impl.cc (left):

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
webkit/plugins/ppapi/ppb_url_loader_impl.cc:104: 
Why don't we need this anymore?

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
File webkit/plugins/ppapi/ppb_url_loader_impl.cc (right):

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
webkit/plugins/ppapi/ppb_url_loader_impl.cc:112: int32_t
PPB_URLLoader_Impl::Open(const ::ppapi::URLRequestInfoData& in_data,
It would be clearer to me if 'in_data' was called 'request_data' and you named
the copy below 'filled_in_request_data' or something equivalent.

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
webkit/plugins/ppapi/ppb_url_loader_impl.cc:148: // this after ToWebURLRequest
since that fills out the file refs.
s/ToWebURLRequest/CreateWebURLRequest

[brettw, 2012-09-14 22:50:47]

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
File webkit/plugins/ppapi/ppb_url_loader_impl.cc (left):

http://codereview.chromium.org/10913257/diff/2002/webkit/plugins/ppapi/ppb_ur...
webkit/plugins/ppapi/ppb_url_loader_impl.cc:104: 
On 2012/09/14 17:48:52, bbudge1 wrote:
> Why don't we need this anymore?

I moved it to the internal version below (so it only exists in one place). I
couldn't think if why it needs to be above or below the request ID validation.