Issue 10913237: Allow the Views Delegate to provide the native widget.

Issue 10913237: Allow the Views Delegate to provide the native widget. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)

Modified:
8 years, 3 months ago

Reviewers:
jam, sky

CC:
chromium-reviews, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, yoshiki+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Allow the Views Delegate to provide the native widget. This is necessary because we will need to construct a different NW depending on the world that owns the parent window. BUG=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156660

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+193 lines, -321 lines)			Patch
M	chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc	View	1 2	2 chunks	+3 lines, -50 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View	1 2	3 chunks	+2 lines, -64 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_views_delegate.cc	View	1 2	4 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_aura.cc	View	1 2	3 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc	View	1 2	2 chunks	+8 lines, -2 lines	0 comments	Download
A +	chrome/browser/ui/views/frame/desktop_browser_frame_aura.h	View		4 chunks	+14 lines, -13 lines	0 comments	Download
A +	chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc	View		7 chunks	+28 lines, -45 lines	0 comments	Download
M	chrome/browser/ui/views/menu_model_adapter_test.cc	View	1 2	3 chunks	+1 line, -78 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_shell.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/shell_aura.cc	View	1 2	5 chunks	+12 lines, -54 lines	0 comments	Download
M	ui/views/examples/examples_window_with_content.cc	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/views/test/test_views_delegate.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/views/test/test_views_delegate.cc	View	1 2	2 chunks	+16 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/views_delegate.h	View	1 2	3 chunks	+11 lines, -1 line	0 comments	Download
A	ui/views/views_switches.h	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	ui/views/views_switches.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_aura.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/views/widget/widget.cc	View	1 2	2 chunks	+23 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

jam: content, everything else fyi sky: all else

8 years, 3 months ago (2012-09-13 16:38:22 UTC) #1

sky

LGTM http://codereview.chromium.org/10913237/diff/13021/ui/views/views.gyp File ui/views/views.gyp (right): http://codereview.chromium.org/10913237/diff/13021/ui/views/views.gyp#newcode306 ui/views/views.gyp:306: 'views_switches.cc', I think you forgot to svn add ...

8 years, 3 months ago (2012-09-13 16:42:13 UTC) #2

lgtm

Expand Messages | Collapse Messages