Remove the hack to use chromiumcodereview.appspot.com.

ABANDONNED. Replaced with https://codereview.chromium.org/10910225/.

Remove the hack to use chromiumcodereview.appspot.com.

It is not necessary anymore as the VIP has been set correctly. Using a VIP is
necessary since python doesn't support SNI certificates.

R=rogerta@chromium.org
BUG=

[Roger Tawa OOO till Jul 10th, 2012-09-12 16:52:56]

lgtm
Thanks,
Roger

-


On Wed, Sep 12, 2012 at 12:48 PM,  <maruel@chromium.org> wrote:
> Reviewers: Roger Tawa,
>
> Description:
> Remove the hack to use chromiumcodereview.appspot.com.
>
> It is not necessary anymore as the VIP has been set correctly. Using a VIP
> is
> necessary since python doesn't support SNI certificates.
>
> R=rogerta@chromium.org
> BUG=
>
>
> Please review this at https://codereview.chromium.org/10913226/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
>
> Affected files:
>   M gclient_utils.py
>   M tests/gclient_utils_test.py
>
>
> Index: gclient_utils.py
> diff --git a/gclient_utils.py b/gclient_utils.py
> index
>
c24be5229cc6a78c5ba8b7f80f2ae9b6e953b473..ab45d28cc6bed09de46c4163dde258dbf7de96c3
> 100644
> --- a/gclient_utils.py
> +++ b/gclient_utils.py
> @@ -752,9 +752,6 @@ def UpgradeToHttps(url):
>    # Do not automatically upgrade http to https if a port number is
> provided.
>    if parsed[0] == 'http' and not re.match(r'^.+?\:\d+$', parsed[1]):
>      parsed[0] = 'https'
> -  # Until GAE supports SNI, manually convert the url.
> -  if parsed[1] == 'codereview.chromium.org':
> -    parsed[1] = 'chromiumcodereview.appspot.com'
>    return urlparse.urlunparse(parsed)
>
>
> Index: tests/gclient_utils_test.py
> diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py
> index
>
d5c0c4ba322c63bc067488e6b8b49f19fdd9a87e..8dc69090fc3c074f127ece519b822414538196d3
> 100755
> --- a/tests/gclient_utils_test.py
> +++ b/tests/gclient_utils_test.py
> @@ -181,8 +181,8 @@ class GClientUtilsTest(trial_dir.TestCase):
>          ['foo/', 'https://foo/'],
>          ['ssh-svn://foo', 'ssh-svn://foo'],
>          ['ssh-svn://foo/bar/', 'ssh-svn://foo/bar/'],
> -        ['codereview.chromium.org',
> 'https://chromiumcodereview.appspot.com'],
> -        ['codereview.chromium.org/',
> 'https://chromiumcodereview.appspot.com/'],
> +        ['codereview.chromium.org', 'https://codereview.chromium.org'],
> +        ['codereview.chromium.org/', 'https://codereview.chromium.org/'],
>          ['http://foo:8080', 'http://foo:8080'],
>          ['http://foo:8080/bar', 'http://foo:8080/bar'],
>          ['foo:8080', 'http://foo:8080'],
>
>

[jam, 2012-09-12 16:56:21]

seems like no need to make another patch, since i already sent
https://codereview.chromium.org/10910225/?