media/formats/mpeg/mpeg_audio_stream_parser_base.h - Issue 1091293005: MSE: Relax the 'media segment must begin with keyframe' requirement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mpeg/mpeg_audio_stream_parser_base.h

Issue 1091293005: MSE: Relax the 'media segment must begin with keyframe' requirement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Checkpoint. Not ready for review yet. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mpeg/mpeg_audio_stream_parser_base.h

diff --git a/media/formats/mpeg/mpeg_audio_stream_parser_base.h b/media/formats/mpeg/mpeg_audio_stream_parser_base.h

index 832199389eb4b8d0add77118f991ed19e6dff344..d6a7b99e624ca5bfe8eed67722c4073bebddbb14 100644

--- a/media/formats/mpeg/mpeg_audio_stream_parser_base.h

+++ b/media/formats/mpeg/mpeg_audio_stream_parser_base.h

@@ -36,7 +36,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {

const NewBuffersCB& new_buffers_cb,

bool ignore_text_tracks,

const EncryptedMediaInitDataCB& encrypted_media_init_data_cb,

- const NewMediaSegmentCB& new_segment_cb,

+ const base::Closure& start_of_segment_cb,

const base::Closure& end_of_segment_cb,

const scoped_refptr<MediaLog>& media_log) override;

void Flush() override;

@@ -135,7 +135,7 @@ class MEDIA_EXPORT MPEGAudioStreamParserBase : public StreamParser {

InitCB init_cb_;

NewConfigCB config_cb_;

NewBuffersCB new_buffers_cb_;

- NewMediaSegmentCB new_segment_cb_;

+ base::Closure start_of_segment_cb_;

base::Closure end_of_segment_cb_;

scoped_refptr<MediaLog> media_log_;

« no previous file with comments | « media/formats/mp4/mp4_stream_parser.cc ('k') | media/formats/mpeg/mpeg_audio_stream_parser_base.cc » ('j') | no next file with comments »