Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: media/filters/source_buffer_stream_unittest.cc

Issue 1091293005: MSE: Relax the 'media segment must begin with keyframe' requirement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased(noop) + addressed comments from PS12 Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/source_buffer_stream.cc ('k') | media/formats/mp2t/mp2t_stream_parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/filters/source_buffer_stream.h" 5 #include "media/filters/source_buffer_stream.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 23 matching lines...) Expand all
34 34
35 typedef StreamParser::BufferQueue BufferQueue; 35 typedef StreamParser::BufferQueue BufferQueue;
36 36
37 static const int kDefaultFramesPerSecond = 30; 37 static const int kDefaultFramesPerSecond = 30;
38 static const int kDefaultKeyframesPerSecond = 6; 38 static const int kDefaultKeyframesPerSecond = 6;
39 static const uint8_t kDataA = 0x11; 39 static const uint8_t kDataA = 0x11;
40 static const uint8_t kDataB = 0x33; 40 static const uint8_t kDataB = 0x33;
41 static const int kDataSize = 1; 41 static const int kDataSize = 1;
42 42
43 // Matchers for verifying common media log entry strings. 43 // Matchers for verifying common media log entry strings.
44 MATCHER(ContainsMissingKeyframeLog, "") {
45 return CONTAINS_STRING(arg,
46 "Media segment did not begin with key frame. Support "
47 "for such segments will be available in a future "
48 "version. Please see https://crbug.com/229412.");
49 }
50
51 MATCHER(ContainsSameTimestampAt30MillisecondsLog, "") { 44 MATCHER(ContainsSameTimestampAt30MillisecondsLog, "") {
52 return CONTAINS_STRING(arg, 45 return CONTAINS_STRING(arg,
53 "Unexpected combination of buffers with the same " 46 "Unexpected combination of buffers with the same "
54 "timestamp detected at 0.03"); 47 "timestamp detected at 0.03");
55 } 48 }
56 49
57 MATCHER_P(ContainsTrackBufferExhaustionSkipLog, skip_milliseconds, "") { 50 MATCHER_P(ContainsTrackBufferExhaustionSkipLog, skip_milliseconds, "") {
58 return CONTAINS_STRING(arg, 51 return CONTAINS_STRING(arg,
59 "Media append that overlapped current playback " 52 "Media append that overlapped current playback "
60 "position caused time gap in playing VIDEO stream " 53 "position caused time gap in playing VIDEO stream "
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 EmptyExtraData(), 101 EmptyExtraData(),
109 false, 102 false,
110 base::TimeDelta(), 103 base::TimeDelta(),
111 0); 104 0);
112 stream_.reset(new SourceBufferStream(audio_config_, media_log_, true)); 105 stream_.reset(new SourceBufferStream(audio_config_, media_log_, true));
113 106
114 // Equivalent to 2ms per frame. 107 // Equivalent to 2ms per frame.
115 SetStreamInfo(500, 500); 108 SetStreamInfo(500, 500);
116 } 109 }
117 110
118 void NewSegmentAppend(int starting_position, int number_of_buffers) { 111 void NewCodedFrameGroupAppend(int starting_position, int number_of_buffers) {
119 AppendBuffers(starting_position, number_of_buffers, true, 112 AppendBuffers(starting_position, number_of_buffers, true,
120 base::TimeDelta(), true, &kDataA, kDataSize); 113 base::TimeDelta(), true, &kDataA, kDataSize);
121 } 114 }
122 115
123 void NewSegmentAppend(int starting_position, 116 void NewCodedFrameGroupAppend(int starting_position,
124 int number_of_buffers, 117 int number_of_buffers,
125 const uint8_t* data) { 118 const uint8_t* data) {
126 AppendBuffers(starting_position, number_of_buffers, true, 119 AppendBuffers(starting_position, number_of_buffers, true,
127 base::TimeDelta(), true, data, kDataSize); 120 base::TimeDelta(), true, data, kDataSize);
128 } 121 }
129 122
130 void NewSegmentAppend_OffsetFirstBuffer( 123 void NewCodedFrameGroupAppend_OffsetFirstBuffer(
131 int starting_position, int number_of_buffers, 124 int starting_position,
125 int number_of_buffers,
132 base::TimeDelta first_buffer_offset) { 126 base::TimeDelta first_buffer_offset) {
133 AppendBuffers(starting_position, number_of_buffers, true, 127 AppendBuffers(starting_position, number_of_buffers, true,
134 first_buffer_offset, true, &kDataA, kDataSize); 128 first_buffer_offset, true, &kDataA, kDataSize);
135 } 129 }
136 130
137 void NewSegmentAppend_ExpectFailure( 131 void NewCodedFrameGroupAppend_ExpectFailure(int starting_position,
138 int starting_position, int number_of_buffers) { 132 int number_of_buffers) {
139 AppendBuffers(starting_position, number_of_buffers, true, 133 AppendBuffers(starting_position, number_of_buffers, true,
140 base::TimeDelta(), false, &kDataA, kDataSize); 134 base::TimeDelta(), false, &kDataA, kDataSize);
141 } 135 }
142 136
143 void AppendBuffers(int starting_position, int number_of_buffers) { 137 void AppendBuffers(int starting_position, int number_of_buffers) {
144 AppendBuffers(starting_position, number_of_buffers, false, 138 AppendBuffers(starting_position, number_of_buffers, false,
145 base::TimeDelta(), true, &kDataA, kDataSize); 139 base::TimeDelta(), true, &kDataA, kDataSize);
146 } 140 }
147 141
148 void AppendBuffers(int starting_position, 142 void AppendBuffers(int starting_position,
149 int number_of_buffers, 143 int number_of_buffers,
150 const uint8_t* data) { 144 const uint8_t* data) {
151 AppendBuffers(starting_position, number_of_buffers, false, 145 AppendBuffers(starting_position, number_of_buffers, false,
152 base::TimeDelta(), true, data, kDataSize); 146 base::TimeDelta(), true, data, kDataSize);
153 } 147 }
154 148
155 void NewSegmentAppend(const std::string& buffers_to_append) { 149 void NewCodedFrameGroupAppend(const std::string& buffers_to_append) {
156 AppendBuffers(buffers_to_append, true, kNoTimestamp(), false, true); 150 AppendBuffers(buffers_to_append, true, kNoTimestamp(), false, true);
157 } 151 }
158 152
159 void NewSegmentAppend(base::TimeDelta start_timestamp, 153 void NewCodedFrameGroupAppend(base::TimeDelta start_timestamp,
160 const std::string& buffers_to_append) { 154 const std::string& buffers_to_append) {
161 AppendBuffers(buffers_to_append, true, start_timestamp, false, true); 155 AppendBuffers(buffers_to_append, true, start_timestamp, false, true);
162 } 156 }
163 157
164 void AppendBuffers(const std::string& buffers_to_append) { 158 void AppendBuffers(const std::string& buffers_to_append) {
165 AppendBuffers(buffers_to_append, false, kNoTimestamp(), false, true); 159 AppendBuffers(buffers_to_append, false, kNoTimestamp(), false, true);
166 } 160 }
167 161
168 void NewSegmentAppendOneByOne(const std::string& buffers_to_append) { 162 void NewCodedFrameGroupAppendOneByOne(const std::string& buffers_to_append) {
169 AppendBuffers(buffers_to_append, true, kNoTimestamp(), true, true); 163 AppendBuffers(buffers_to_append, true, kNoTimestamp(), true, true);
170 } 164 }
171 165
172 void AppendBuffersOneByOne(const std::string& buffers_to_append) { 166 void AppendBuffersOneByOne(const std::string& buffers_to_append) {
173 AppendBuffers(buffers_to_append, false, kNoTimestamp(), true, true); 167 AppendBuffers(buffers_to_append, false, kNoTimestamp(), true, true);
174 } 168 }
175 169
176 void NewSegmentAppend_ExpectFailure(const std::string& buffers_to_append) { 170 void NewCodedFrameGroupAppend_ExpectFailure(
171 const std::string& buffers_to_append) {
177 AppendBuffers(buffers_to_append, true, kNoTimestamp(), false, false); 172 AppendBuffers(buffers_to_append, true, kNoTimestamp(), false, false);
178 } 173 }
179 174
180 void AppendBuffers_ExpectFailure(const std::string& buffers_to_append) { 175 void AppendBuffers_ExpectFailure(const std::string& buffers_to_append) {
181 AppendBuffers(buffers_to_append, false, kNoTimestamp(), false, false); 176 AppendBuffers(buffers_to_append, false, kNoTimestamp(), false, false);
182 } 177 }
183 178
184 void Seek(int position) { 179 void Seek(int position) {
185 stream_->Seek(position * frame_duration_); 180 stream_->Seek(position * frame_duration_);
186 } 181 }
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 scoped_refptr<StrictMock<MockMediaLog>> media_log_; 427 scoped_refptr<StrictMock<MockMediaLog>> media_log_;
433 428
434 private: 429 private:
435 base::TimeDelta ConvertToFrameDuration(int frames_per_second) { 430 base::TimeDelta ConvertToFrameDuration(int frames_per_second) {
436 return base::TimeDelta::FromMicroseconds( 431 return base::TimeDelta::FromMicroseconds(
437 base::Time::kMicrosecondsPerSecond / frames_per_second); 432 base::Time::kMicrosecondsPerSecond / frames_per_second);
438 } 433 }
439 434
440 void AppendBuffers(int starting_position, 435 void AppendBuffers(int starting_position,
441 int number_of_buffers, 436 int number_of_buffers,
442 bool begin_media_segment, 437 bool begin_coded_frame_group,
443 base::TimeDelta first_buffer_offset, 438 base::TimeDelta first_buffer_offset,
444 bool expect_success, 439 bool expect_success,
445 const uint8_t* data, 440 const uint8_t* data,
446 int size) { 441 int size) {
447 if (begin_media_segment) 442 if (begin_coded_frame_group)
448 stream_->OnNewMediaSegment(DecodeTimestamp::FromPresentationTime( 443 stream_->OnStartOfCodedFrameGroup(DecodeTimestamp::FromPresentationTime(
449 starting_position * frame_duration_)); 444 starting_position * frame_duration_));
450 445
451 int keyframe_interval = frames_per_second_ / keyframes_per_second_; 446 int keyframe_interval = frames_per_second_ / keyframes_per_second_;
452 447
453 BufferQueue queue; 448 BufferQueue queue;
454 for (int i = 0; i < number_of_buffers; i++) { 449 for (int i = 0; i < number_of_buffers; i++) {
455 int position = starting_position + i; 450 int position = starting_position + i;
456 bool is_keyframe = position % keyframe_interval == 0; 451 bool is_keyframe = position % keyframe_interval == 0;
457 // Buffer type and track ID are meaningless to these tests. 452 // Buffer type and track ID are meaningless to these tests.
458 scoped_refptr<StreamParserBuffer> buffer = 453 scoped_refptr<StreamParserBuffer> buffer =
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 if (buffers.size() >= 2 && 675 if (buffers.size() >= 2 &&
681 buffers.back()->duration() <= base::TimeDelta()) { 676 buffers.back()->duration() <= base::TimeDelta()) {
682 buffers.back()->set_duration( 677 buffers.back()->set_duration(
683 buffers[buffers.size() - 2]->duration()); 678 buffers[buffers.size() - 2]->duration());
684 } 679 }
685 680
686 return buffers; 681 return buffers;
687 } 682 }
688 683
689 void AppendBuffers(const std::string& buffers_to_append, 684 void AppendBuffers(const std::string& buffers_to_append,
690 bool start_new_segment, 685 bool start_new_coded_frame_group,
691 base::TimeDelta segment_start_timestamp, 686 base::TimeDelta coded_frame_group_start_timestamp,
692 bool one_by_one, 687 bool one_by_one,
693 bool expect_success) { 688 bool expect_success) {
694 BufferQueue buffers = StringToBufferQueue(buffers_to_append); 689 BufferQueue buffers = StringToBufferQueue(buffers_to_append);
695 690
696 if (start_new_segment) { 691 if (start_new_coded_frame_group) {
697 base::TimeDelta start_timestamp = segment_start_timestamp; 692 base::TimeDelta start_timestamp = coded_frame_group_start_timestamp;
698 if (start_timestamp == kNoTimestamp()) 693 if (start_timestamp == kNoTimestamp())
699 start_timestamp = buffers[0]->timestamp(); 694 start_timestamp = buffers[0]->timestamp();
700 695
701 ASSERT_TRUE(start_timestamp <= buffers[0]->timestamp()); 696 ASSERT_TRUE(start_timestamp <= buffers[0]->timestamp());
702 697
703 stream_->OnNewMediaSegment( 698 stream_->OnStartOfCodedFrameGroup(
704 DecodeTimestamp::FromPresentationTime(start_timestamp)); 699 DecodeTimestamp::FromPresentationTime(start_timestamp));
705 } 700 }
706 701
707 if (!one_by_one) { 702 if (!one_by_one) {
708 EXPECT_EQ(expect_success, stream_->Append(buffers)); 703 EXPECT_EQ(expect_success, stream_->Append(buffers));
709 return; 704 return;
710 } 705 }
711 706
712 // Append each buffer one by one. 707 // Append each buffer one by one.
713 for (size_t i = 0; i < buffers.size(); i++) { 708 for (size_t i = 0; i < buffers.size(); i++) {
714 BufferQueue wrapper; 709 BufferQueue wrapper;
715 wrapper.push_back(buffers[i]); 710 wrapper.push_back(buffers[i]);
716 EXPECT_TRUE(stream_->Append(wrapper)); 711 EXPECT_TRUE(stream_->Append(wrapper));
717 } 712 }
718 } 713 }
719 714
720 int frames_per_second_; 715 int frames_per_second_;
721 int keyframes_per_second_; 716 int keyframes_per_second_;
722 base::TimeDelta frame_duration_; 717 base::TimeDelta frame_duration_;
723 DISALLOW_COPY_AND_ASSIGN(SourceBufferStreamTest); 718 DISALLOW_COPY_AND_ASSIGN(SourceBufferStreamTest);
724 }; 719 };
725 720
726 TEST_F(SourceBufferStreamTest, Append_SingleRange) { 721 TEST_F(SourceBufferStreamTest, Append_SingleRange) {
727 // Append 15 buffers at positions 0 through 14. 722 // Append 15 buffers at positions 0 through 14.
728 NewSegmentAppend(0, 15); 723 NewCodedFrameGroupAppend(0, 15);
729 724
730 // Check expected range. 725 // Check expected range.
731 CheckExpectedRanges("{ [0,14) }"); 726 CheckExpectedRanges("{ [0,14) }");
732 // Check buffers in range. 727 // Check buffers in range.
733 Seek(0); 728 Seek(0);
734 CheckExpectedBuffers(0, 14); 729 CheckExpectedBuffers(0, 14);
735 } 730 }
736 731
737 TEST_F(SourceBufferStreamTest, Append_SingleRange_OneBufferAtATime) { 732 TEST_F(SourceBufferStreamTest, Append_SingleRange_OneBufferAtATime) {
738 // Append 15 buffers starting at position 0, one buffer at a time. 733 // Append 15 buffers starting at position 0, one buffer at a time.
739 NewSegmentAppend(0, 1); 734 NewCodedFrameGroupAppend(0, 1);
740 for (int i = 1; i < 15; i++) 735 for (int i = 1; i < 15; i++)
741 AppendBuffers(i, 1); 736 AppendBuffers(i, 1);
742 737
743 // Check expected range. 738 // Check expected range.
744 CheckExpectedRanges("{ [0,14) }"); 739 CheckExpectedRanges("{ [0,14) }");
745 // Check buffers in range. 740 // Check buffers in range.
746 Seek(0); 741 Seek(0);
747 CheckExpectedBuffers(0, 14); 742 CheckExpectedBuffers(0, 14);
748 } 743 }
749 744
750 TEST_F(SourceBufferStreamTest, Append_DisjointRanges) { 745 TEST_F(SourceBufferStreamTest, Append_DisjointRanges) {
751 // Append 5 buffers at positions 0 through 4. 746 // Append 5 buffers at positions 0 through 4.
752 NewSegmentAppend(0, 5); 747 NewCodedFrameGroupAppend(0, 5);
753 748
754 // Append 10 buffers at positions 15 through 24. 749 // Append 10 buffers at positions 15 through 24.
755 NewSegmentAppend(15, 10); 750 NewCodedFrameGroupAppend(15, 10);
756 751
757 // Check expected ranges. 752 // Check expected ranges.
758 CheckExpectedRanges("{ [0,4) [15,24) }"); 753 CheckExpectedRanges("{ [0,4) [15,24) }");
759 // Check buffers in ranges. 754 // Check buffers in ranges.
760 Seek(0); 755 Seek(0);
761 CheckExpectedBuffers(0, 4); 756 CheckExpectedBuffers(0, 4);
762 Seek(15); 757 Seek(15);
763 CheckExpectedBuffers(15, 24); 758 CheckExpectedBuffers(15, 24);
764 } 759 }
765 760
766 TEST_F(SourceBufferStreamTest, Append_AdjacentRanges) { 761 TEST_F(SourceBufferStreamTest, Append_AdjacentRanges) {
767 // Append 10 buffers at positions 0 through 9. 762 // Append 10 buffers at positions 0 through 9.
768 NewSegmentAppend(0, 10); 763 NewCodedFrameGroupAppend(0, 10);
769 764
770 // Append 11 buffers at positions 15 through 25. 765 // Append 11 buffers at positions 15 through 25.
771 NewSegmentAppend(15, 11); 766 NewCodedFrameGroupAppend(15, 11);
772 767
773 // Append 5 buffers at positions 10 through 14 to bridge the gap. 768 // Append 5 buffers at positions 10 through 14 to bridge the gap.
774 NewSegmentAppend(10, 5); 769 NewCodedFrameGroupAppend(10, 5);
775 770
776 // Check expected range. 771 // Check expected range.
777 CheckExpectedRanges("{ [0,25) }"); 772 CheckExpectedRanges("{ [0,25) }");
778 // Check buffers in range. 773 // Check buffers in range.
779 Seek(0); 774 Seek(0);
780 CheckExpectedBuffers(0, 25); 775 CheckExpectedBuffers(0, 25);
781 } 776 }
782 777
783 TEST_F(SourceBufferStreamTest, Append_DoesNotBeginWithKeyframe) {
784 EXPECT_MEDIA_LOG(ContainsMissingKeyframeLog()).Times(2);
785
786 // Append fails because the range doesn't begin with a keyframe.
787 NewSegmentAppend_ExpectFailure(3, 2);
788
789 // Append 10 buffers at positions 5 through 14.
790 NewSegmentAppend(5, 10);
791
792 // Check expected range.
793 CheckExpectedRanges("{ [5,14) }");
794 // Check buffers in range.
795 Seek(5);
796 CheckExpectedBuffers(5, 14);
797
798 // Append fails because the range doesn't begin with a keyframe.
799 NewSegmentAppend_ExpectFailure(17, 3);
800
801 CheckExpectedRanges("{ [5,14) }");
802 Seek(5);
803 CheckExpectedBuffers(5, 14);
804 }
805
806 TEST_F(SourceBufferStreamTest, Append_DoesNotBeginWithKeyframe_Adjacent) {
807 EXPECT_MEDIA_LOG(ContainsMissingKeyframeLog());
808
809 // Append 8 buffers at positions 0 through 7.
810 NewSegmentAppend(0, 8);
811
812 // Now start a new media segment at position 8. Append should fail because
813 // the media segment does not begin with a keyframe.
814 NewSegmentAppend_ExpectFailure(8, 2);
815
816 // Check expected range.
817 CheckExpectedRanges("{ [0,7) }");
818 // Check buffers in range.
819 Seek(0);
820 CheckExpectedBuffers(0, 7);
821 }
822
823 TEST_F(SourceBufferStreamTest, Complete_Overlap) { 778 TEST_F(SourceBufferStreamTest, Complete_Overlap) {
824 // Append 5 buffers at positions 5 through 9. 779 // Append 5 buffers at positions 5 through 9.
825 NewSegmentAppend(5, 5); 780 NewCodedFrameGroupAppend(5, 5);
826 781
827 // Append 15 buffers at positions 0 through 14. 782 // Append 15 buffers at positions 0 through 14.
828 NewSegmentAppend(0, 15); 783 NewCodedFrameGroupAppend(0, 15);
829 784
830 // Check expected range. 785 // Check expected range.
831 CheckExpectedRanges("{ [0,14) }"); 786 CheckExpectedRanges("{ [0,14) }");
832 // Check buffers in range. 787 // Check buffers in range.
833 Seek(0); 788 Seek(0);
834 CheckExpectedBuffers(0, 14); 789 CheckExpectedBuffers(0, 14);
835 } 790 }
836 791
837 TEST_F(SourceBufferStreamTest, 792 TEST_F(SourceBufferStreamTest,
838 Complete_Overlap_AfterSegmentTimestampAndBeforeFirstBufferTimestamp) { 793 Complete_Overlap_AfterGroupTimestampAndBeforeFirstBufferTimestamp) {
839 // Append a segment with a start timestamp of 0, but the first 794 // Append a coded frame group with a start timestamp of 0, but the first
840 // buffer starts at 30ms. This can happen in muxed content where the 795 // buffer starts at 30ms. This can happen in muxed content where the
841 // audio starts before the first frame. 796 // audio starts before the first frame.
842 NewSegmentAppend(base::TimeDelta::FromMilliseconds(0), "30K 60K 90K 120K"); 797 NewCodedFrameGroupAppend(base::TimeDelta::FromMilliseconds(0),
798 "30K 60K 90K 120K");
843 799
844 CheckExpectedRangesByTimestamp("{ [0,150) }"); 800 CheckExpectedRangesByTimestamp("{ [0,150) }");
845 801
846 // Completely overlap the old buffers, with a segment that starts 802 // Completely overlap the old buffers, with a coded frame group that starts
847 // after the old segment start timestamp, but before the timestamp 803 // after the old coded frame group start timestamp, but before the timestamp
848 // of the first buffer in the segment. 804 // of the first buffer in the coded frame group.
849 NewSegmentAppend("20K 50K 80K 110D10K"); 805 NewCodedFrameGroupAppend("20K 50K 80K 110D10K");
850 806
851 // Verify that the buffered ranges are updated properly and we don't crash. 807 // Verify that the buffered ranges are updated properly and we don't crash.
852 CheckExpectedRangesByTimestamp("{ [20,150) }"); 808 CheckExpectedRangesByTimestamp("{ [20,150) }");
853 809
854 SeekToTimestampMs(20); 810 SeekToTimestampMs(20);
855 CheckExpectedBuffers("20K 50K 80K 110K 120K"); 811 CheckExpectedBuffers("20K 50K 80K 110K 120K");
856 } 812 }
857 813
858 TEST_F(SourceBufferStreamTest, Complete_Overlap_EdgeCase) { 814 TEST_F(SourceBufferStreamTest, Complete_Overlap_EdgeCase) {
859 // Make each frame a keyframe so that it's okay to overlap frames at any point 815 // Make each frame a keyframe so that it's okay to overlap frames at any point
860 // (instead of needing to respect keyframe boundaries). 816 // (instead of needing to respect keyframe boundaries).
861 SetStreamInfo(30, 30); 817 SetStreamInfo(30, 30);
862 818
863 // Append 6 buffers at positions 6 through 11. 819 // Append 6 buffers at positions 6 through 11.
864 NewSegmentAppend(6, 6); 820 NewCodedFrameGroupAppend(6, 6);
865 821
866 // Append 8 buffers at positions 5 through 12. 822 // Append 8 buffers at positions 5 through 12.
867 NewSegmentAppend(5, 8); 823 NewCodedFrameGroupAppend(5, 8);
868 824
869 // Check expected range. 825 // Check expected range.
870 CheckExpectedRanges("{ [5,12) }"); 826 CheckExpectedRanges("{ [5,12) }");
871 // Check buffers in range. 827 // Check buffers in range.
872 Seek(5); 828 Seek(5);
873 CheckExpectedBuffers(5, 12); 829 CheckExpectedBuffers(5, 12);
874 } 830 }
875 831
876 TEST_F(SourceBufferStreamTest, Start_Overlap) { 832 TEST_F(SourceBufferStreamTest, Start_Overlap) {
877 // Append 10 buffers at positions 5 through 14. 833 // Append 10 buffers at positions 5 through 14.
878 NewSegmentAppend(5, 5); 834 NewCodedFrameGroupAppend(5, 5);
879 835
880 // Append 6 buffers at positions 10 through 15. 836 // Append 6 buffers at positions 10 through 15.
881 NewSegmentAppend(10, 6); 837 NewCodedFrameGroupAppend(10, 6);
882 838
883 // Check expected range. 839 // Check expected range.
884 CheckExpectedRanges("{ [5,15) }"); 840 CheckExpectedRanges("{ [5,15) }");
885 // Check buffers in range. 841 // Check buffers in range.
886 Seek(5); 842 Seek(5);
887 CheckExpectedBuffers(5, 15); 843 CheckExpectedBuffers(5, 15);
888 } 844 }
889 845
890 TEST_F(SourceBufferStreamTest, End_Overlap) { 846 TEST_F(SourceBufferStreamTest, End_Overlap) {
891 // Append 10 buffers at positions 10 through 19. 847 // Append 10 buffers at positions 10 through 19.
892 NewSegmentAppend(10, 10); 848 NewCodedFrameGroupAppend(10, 10);
893 849
894 // Append 10 buffers at positions 5 through 14. 850 // Append 10 buffers at positions 5 through 14.
895 NewSegmentAppend(5, 10); 851 NewCodedFrameGroupAppend(5, 10);
896 852
897 // Check expected range. 853 // Check expected range.
898 CheckExpectedRanges("{ [5,19) }"); 854 CheckExpectedRanges("{ [5,19) }");
899 // Check buffers in range. 855 // Check buffers in range.
900 Seek(5); 856 Seek(5);
901 CheckExpectedBuffers(5, 19); 857 CheckExpectedBuffers(5, 19);
902 } 858 }
903 859
904 TEST_F(SourceBufferStreamTest, End_Overlap_Several) { 860 TEST_F(SourceBufferStreamTest, End_Overlap_Several) {
905 // Append 10 buffers at positions 10 through 19. 861 // Append 10 buffers at positions 10 through 19.
906 NewSegmentAppend(10, 10); 862 NewCodedFrameGroupAppend(10, 10);
907 863
908 // Append 8 buffers at positions 5 through 12. 864 // Append 8 buffers at positions 5 through 12.
909 NewSegmentAppend(5, 8); 865 NewCodedFrameGroupAppend(5, 8);
910 866
911 // Check expected ranges: stream should not have kept buffers 13 and 14 867 // Check expected ranges: stream should not have kept buffers 13 and 14
912 // because the keyframe on which they depended was overwritten. 868 // because the keyframe on which they depended was overwritten.
913 CheckExpectedRanges("{ [5,12) [15,19) }"); 869 CheckExpectedRanges("{ [5,12) [15,19) }");
914 870
915 // Check buffers in range. 871 // Check buffers in range.
916 Seek(5); 872 Seek(5);
917 CheckExpectedBuffers(5, 12); 873 CheckExpectedBuffers(5, 12);
918 CheckNoNextBuffer(); 874 CheckNoNextBuffer();
919 875
920 Seek(19); 876 Seek(19);
921 CheckExpectedBuffers(15, 19); 877 CheckExpectedBuffers(15, 19);
922 } 878 }
923 879
924 // Test an end overlap edge case where a single buffer overlaps the 880 // Test an end overlap edge case where a single buffer overlaps the
925 // beginning of a range. 881 // beginning of a range.
926 // old : *0K* 30 60 90 120K 150 882 // old : *0K* 30 60 90 120K 150
927 // new : *0K* 883 // new : *0K*
928 // after: *0K* *120K* 150K 884 // after: *0K* *120K* 150K
929 // track: 885 // track:
930 TEST_F(SourceBufferStreamTest, End_Overlap_SingleBuffer) { 886 TEST_F(SourceBufferStreamTest, End_Overlap_SingleBuffer) {
931 // Seek to start of stream. 887 // Seek to start of stream.
932 SeekToTimestampMs(0); 888 SeekToTimestampMs(0);
933 889
934 NewSegmentAppend("0K 30 60 90 120K 150"); 890 NewCodedFrameGroupAppend("0K 30 60 90 120K 150");
935 CheckExpectedRangesByTimestamp("{ [0,180) }"); 891 CheckExpectedRangesByTimestamp("{ [0,180) }");
936 892
937 NewSegmentAppend("0D30K"); 893 NewCodedFrameGroupAppend("0D30K");
938 CheckExpectedRangesByTimestamp("{ [0,30) [120,180) }"); 894 CheckExpectedRangesByTimestamp("{ [0,30) [120,180) }");
939 895
940 CheckExpectedBuffers("0K"); 896 CheckExpectedBuffers("0K");
941 CheckNoNextBuffer(); 897 CheckNoNextBuffer();
942 } 898 }
943 899
944 TEST_F(SourceBufferStreamTest, Complete_Overlap_Several) { 900 TEST_F(SourceBufferStreamTest, Complete_Overlap_Several) {
945 // Append 2 buffers at positions 5 through 6. 901 // Append 2 buffers at positions 5 through 6.
946 NewSegmentAppend(5, 2); 902 NewCodedFrameGroupAppend(5, 2);
947 903
948 // Append 2 buffers at positions 10 through 11. 904 // Append 2 buffers at positions 10 through 11.
949 NewSegmentAppend(10, 2); 905 NewCodedFrameGroupAppend(10, 2);
950 906
951 // Append 2 buffers at positions 15 through 16. 907 // Append 2 buffers at positions 15 through 16.
952 NewSegmentAppend(15, 2); 908 NewCodedFrameGroupAppend(15, 2);
953 909
954 // Check expected ranges. 910 // Check expected ranges.
955 CheckExpectedRanges("{ [5,6) [10,11) [15,16) }"); 911 CheckExpectedRanges("{ [5,6) [10,11) [15,16) }");
956 912
957 // Append buffers at positions 0 through 19. 913 // Append buffers at positions 0 through 19.
958 NewSegmentAppend(0, 20); 914 NewCodedFrameGroupAppend(0, 20);
959 915
960 // Check expected range. 916 // Check expected range.
961 CheckExpectedRanges("{ [0,19) }"); 917 CheckExpectedRanges("{ [0,19) }");
962 // Check buffers in range. 918 // Check buffers in range.
963 Seek(0); 919 Seek(0);
964 CheckExpectedBuffers(0, 19); 920 CheckExpectedBuffers(0, 19);
965 } 921 }
966 922
967 TEST_F(SourceBufferStreamTest, Complete_Overlap_Several_Then_Merge) { 923 TEST_F(SourceBufferStreamTest, Complete_Overlap_Several_Then_Merge) {
968 // Append 2 buffers at positions 5 through 6. 924 // Append 2 buffers at positions 5 through 6.
969 NewSegmentAppend(5, 2); 925 NewCodedFrameGroupAppend(5, 2);
970 926
971 // Append 2 buffers at positions 10 through 11. 927 // Append 2 buffers at positions 10 through 11.
972 NewSegmentAppend(10, 2); 928 NewCodedFrameGroupAppend(10, 2);
973 929
974 // Append 2 buffers at positions 15 through 16. 930 // Append 2 buffers at positions 15 through 16.
975 NewSegmentAppend(15, 2); 931 NewCodedFrameGroupAppend(15, 2);
976 932
977 // Append 2 buffers at positions 20 through 21. 933 // Append 2 buffers at positions 20 through 21.
978 NewSegmentAppend(20, 2); 934 NewCodedFrameGroupAppend(20, 2);
979 935
980 // Append buffers at positions 0 through 19. 936 // Append buffers at positions 0 through 19.
981 NewSegmentAppend(0, 20); 937 NewCodedFrameGroupAppend(0, 20);
982 938
983 // Check expected ranges. 939 // Check expected ranges.
984 CheckExpectedRanges("{ [0,21) }"); 940 CheckExpectedRanges("{ [0,21) }");
985 // Check buffers in range. 941 // Check buffers in range.
986 Seek(0); 942 Seek(0);
987 CheckExpectedBuffers(0, 21); 943 CheckExpectedBuffers(0, 21);
988 } 944 }
989 945
990 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected) { 946 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected) {
991 // Append 10 buffers at positions 5 through 14. 947 // Append 10 buffers at positions 5 through 14.
992 NewSegmentAppend(5, 10, &kDataA); 948 NewCodedFrameGroupAppend(5, 10, &kDataA);
993 949
994 // Seek to buffer at position 5. 950 // Seek to buffer at position 5.
995 Seek(5); 951 Seek(5);
996 952
997 // Replace old data with new data. 953 // Replace old data with new data.
998 NewSegmentAppend(5, 10, &kDataB); 954 NewCodedFrameGroupAppend(5, 10, &kDataB);
999 955
1000 // Check ranges are correct. 956 // Check ranges are correct.
1001 CheckExpectedRanges("{ [5,14) }"); 957 CheckExpectedRanges("{ [5,14) }");
1002 958
1003 // Check that data has been replaced with new data. 959 // Check that data has been replaced with new data.
1004 CheckExpectedBuffers(5, 14, &kDataB); 960 CheckExpectedBuffers(5, 14, &kDataB);
1005 } 961 }
1006 962
1007 // This test is testing that a client can append data to SourceBufferStream that 963 // This test is testing that a client can append data to SourceBufferStream that
1008 // overlaps the range from which the client is currently grabbing buffers. We 964 // overlaps the range from which the client is currently grabbing buffers. We
1009 // would expect that the SourceBufferStream would return old data until it hits 965 // would expect that the SourceBufferStream would return old data until it hits
1010 // the keyframe of the new data, after which it will return the new data. 966 // the keyframe of the new data, after which it will return the new data.
1011 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected_TrackBuffer) { 967 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected_TrackBuffer) {
1012 // Append 10 buffers at positions 5 through 14. 968 // Append 10 buffers at positions 5 through 14.
1013 NewSegmentAppend(5, 10, &kDataA); 969 NewCodedFrameGroupAppend(5, 10, &kDataA);
1014 970
1015 // Seek to buffer at position 5 and get next buffer. 971 // Seek to buffer at position 5 and get next buffer.
1016 Seek(5); 972 Seek(5);
1017 CheckExpectedBuffers(5, 5, &kDataA); 973 CheckExpectedBuffers(5, 5, &kDataA);
1018 974
1019 // Do a complete overlap by appending 20 buffers at positions 0 through 19. 975 // Do a complete overlap by appending 20 buffers at positions 0 through 19.
1020 NewSegmentAppend(0, 20, &kDataB); 976 NewCodedFrameGroupAppend(0, 20, &kDataB);
1021 977
1022 // Check range is correct. 978 // Check range is correct.
1023 CheckExpectedRanges("{ [0,19) }"); 979 CheckExpectedRanges("{ [0,19) }");
1024 980
1025 // Expect old data up until next keyframe in new data. 981 // Expect old data up until next keyframe in new data.
1026 CheckExpectedBuffers(6, 9, &kDataA); 982 CheckExpectedBuffers(6, 9, &kDataA);
1027 CheckExpectedBuffers(10, 10, &kDataB, true); 983 CheckExpectedBuffers(10, 10, &kDataB, true);
1028 984
1029 // Expect rest of data to be new. 985 // Expect rest of data to be new.
1030 CheckExpectedBuffers(11, 19, &kDataB); 986 CheckExpectedBuffers(11, 19, &kDataB);
1031 987
1032 // Seek back to beginning; all data should be new. 988 // Seek back to beginning; all data should be new.
1033 Seek(0); 989 Seek(0);
1034 CheckExpectedBuffers(0, 19, &kDataB); 990 CheckExpectedBuffers(0, 19, &kDataB);
1035 991
1036 // Check range continues to be correct. 992 // Check range continues to be correct.
1037 CheckExpectedRanges("{ [0,19) }"); 993 CheckExpectedRanges("{ [0,19) }");
1038 } 994 }
1039 995
1040 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected_EdgeCase) { 996 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected_EdgeCase) {
1041 // Append 10 buffers at positions 5 through 14. 997 // Append 10 buffers at positions 5 through 14.
1042 NewSegmentAppend(5, 10, &kDataA); 998 NewCodedFrameGroupAppend(5, 10, &kDataA);
1043 999
1044 // Seek to buffer at position 5 and get next buffer. 1000 // Seek to buffer at position 5 and get next buffer.
1045 Seek(5); 1001 Seek(5);
1046 CheckExpectedBuffers(5, 5, &kDataA); 1002 CheckExpectedBuffers(5, 5, &kDataA);
1047 1003
1048 // Replace existing data with new data. 1004 // Replace existing data with new data.
1049 NewSegmentAppend(5, 10, &kDataB); 1005 NewCodedFrameGroupAppend(5, 10, &kDataB);
1050 1006
1051 // Check ranges are correct. 1007 // Check ranges are correct.
1052 CheckExpectedRanges("{ [5,14) }"); 1008 CheckExpectedRanges("{ [5,14) }");
1053 1009
1054 // Expect old data up until next keyframe in new data. 1010 // Expect old data up until next keyframe in new data.
1055 CheckExpectedBuffers(6, 9, &kDataA); 1011 CheckExpectedBuffers(6, 9, &kDataA);
1056 CheckExpectedBuffers(10, 10, &kDataB, true); 1012 CheckExpectedBuffers(10, 10, &kDataB, true);
1057 1013
1058 // Expect rest of data to be new. 1014 // Expect rest of data to be new.
1059 CheckExpectedBuffers(11, 14, &kDataB); 1015 CheckExpectedBuffers(11, 14, &kDataB);
1060 1016
1061 // Seek back to beginning; all data should be new. 1017 // Seek back to beginning; all data should be new.
1062 Seek(5); 1018 Seek(5);
1063 CheckExpectedBuffers(5, 14, &kDataB); 1019 CheckExpectedBuffers(5, 14, &kDataB);
1064 1020
1065 // Check range continues to be correct. 1021 // Check range continues to be correct.
1066 CheckExpectedRanges("{ [5,14) }"); 1022 CheckExpectedRanges("{ [5,14) }");
1067 } 1023 }
1068 1024
1069 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected_Multiple) { 1025 TEST_F(SourceBufferStreamTest, Complete_Overlap_Selected_Multiple) {
1070 static const uint8_t kDataC = 0x55; 1026 static const uint8_t kDataC = 0x55;
1071 static const uint8_t kDataD = 0x77; 1027 static const uint8_t kDataD = 0x77;
1072 1028
1073 // Append 5 buffers at positions 5 through 9. 1029 // Append 5 buffers at positions 5 through 9.
1074 NewSegmentAppend(5, 5, &kDataA); 1030 NewCodedFrameGroupAppend(5, 5, &kDataA);
1075 1031
1076 // Seek to buffer at position 5 and get next buffer. 1032 // Seek to buffer at position 5 and get next buffer.
1077 Seek(5); 1033 Seek(5);
1078 CheckExpectedBuffers(5, 5, &kDataA); 1034 CheckExpectedBuffers(5, 5, &kDataA);
1079 1035
1080 // Replace existing data with new data. 1036 // Replace existing data with new data.
1081 NewSegmentAppend(5, 5, &kDataB); 1037 NewCodedFrameGroupAppend(5, 5, &kDataB);
1082 1038
1083 // Then replace it again with different data. 1039 // Then replace it again with different data.
1084 NewSegmentAppend(5, 5, &kDataC); 1040 NewCodedFrameGroupAppend(5, 5, &kDataC);
1085 1041
1086 // Now append 5 new buffers at positions 10 through 14. 1042 // Now append 5 new buffers at positions 10 through 14.
1087 NewSegmentAppend(10, 5, &kDataC); 1043 NewCodedFrameGroupAppend(10, 5, &kDataC);
1088 1044
1089 // Now replace all the data entirely. 1045 // Now replace all the data entirely.
1090 NewSegmentAppend(5, 10, &kDataD); 1046 NewCodedFrameGroupAppend(5, 10, &kDataD);
1091 1047
1092 // Expect buffers 6 through 9 to be DataA, and the remaining 1048 // Expect buffers 6 through 9 to be DataA, and the remaining
1093 // buffers to be kDataD. 1049 // buffers to be kDataD.
1094 CheckExpectedBuffers(6, 9, &kDataA); 1050 CheckExpectedBuffers(6, 9, &kDataA);
1095 CheckExpectedBuffers(10, 14, &kDataD); 1051 CheckExpectedBuffers(10, 14, &kDataD);
1096 1052
1097 // At this point we cannot fulfill request. 1053 // At this point we cannot fulfill request.
1098 CheckNoNextBuffer(); 1054 CheckNoNextBuffer();
1099 1055
1100 // Seek back to beginning; all data should be new. 1056 // Seek back to beginning; all data should be new.
1101 Seek(5); 1057 Seek(5);
1102 CheckExpectedBuffers(5, 14, &kDataD); 1058 CheckExpectedBuffers(5, 14, &kDataD);
1103 } 1059 }
1104 1060
1105 TEST_F(SourceBufferStreamTest, Start_Overlap_Selected) { 1061 TEST_F(SourceBufferStreamTest, Start_Overlap_Selected) {
1106 // Append 10 buffers at positions 0 through 9. 1062 // Append 10 buffers at positions 0 through 9.
1107 NewSegmentAppend(0, 10, &kDataA); 1063 NewCodedFrameGroupAppend(0, 10, &kDataA);
1108 1064
1109 // Seek to position 5, then add buffers to overlap data at that position. 1065 // Seek to position 5, then add buffers to overlap data at that position.
1110 Seek(5); 1066 Seek(5);
1111 NewSegmentAppend(5, 10, &kDataB); 1067 NewCodedFrameGroupAppend(5, 10, &kDataB);
1112 1068
1113 // Check expected range. 1069 // Check expected range.
1114 CheckExpectedRanges("{ [0,14) }"); 1070 CheckExpectedRanges("{ [0,14) }");
1115 1071
1116 // Because we seeked to a keyframe, the next buffers should all be new data. 1072 // Because we seeked to a keyframe, the next buffers should all be new data.
1117 CheckExpectedBuffers(5, 14, &kDataB); 1073 CheckExpectedBuffers(5, 14, &kDataB);
1118 1074
1119 // Make sure all data is correct. 1075 // Make sure all data is correct.
1120 Seek(0); 1076 Seek(0);
1121 CheckExpectedBuffers(0, 4, &kDataA); 1077 CheckExpectedBuffers(0, 4, &kDataA);
1122 CheckExpectedBuffers(5, 14, &kDataB); 1078 CheckExpectedBuffers(5, 14, &kDataB);
1123 } 1079 }
1124 1080
1125 TEST_F(SourceBufferStreamTest, Start_Overlap_Selected_TrackBuffer) { 1081 TEST_F(SourceBufferStreamTest, Start_Overlap_Selected_TrackBuffer) {
1126 // Append 15 buffers at positions 0 through 14. 1082 // Append 15 buffers at positions 0 through 14.
1127 NewSegmentAppend(0, 15, &kDataA); 1083 NewCodedFrameGroupAppend(0, 15, &kDataA);
1128 1084
1129 // Seek to 10 and get buffer. 1085 // Seek to 10 and get buffer.
1130 Seek(10); 1086 Seek(10);
1131 CheckExpectedBuffers(10, 10, &kDataA); 1087 CheckExpectedBuffers(10, 10, &kDataA);
1132 1088
1133 // Now append 10 buffers of new data at positions 10 through 19. 1089 // Now append 10 buffers of new data at positions 10 through 19.
1134 NewSegmentAppend(10, 10, &kDataB); 1090 NewCodedFrameGroupAppend(10, 10, &kDataB);
1135 1091
1136 // Check expected range. 1092 // Check expected range.
1137 CheckExpectedRanges("{ [0,19) }"); 1093 CheckExpectedRanges("{ [0,19) }");
1138 1094
1139 // The next 4 buffers should be a from the old buffer, followed by a keyframe 1095 // The next 4 buffers should be a from the old buffer, followed by a keyframe
1140 // from the new data. 1096 // from the new data.
1141 CheckExpectedBuffers(11, 14, &kDataA); 1097 CheckExpectedBuffers(11, 14, &kDataA);
1142 CheckExpectedBuffers(15, 15, &kDataB, true); 1098 CheckExpectedBuffers(15, 15, &kDataB, true);
1143 1099
1144 // The rest of the buffers should be new data. 1100 // The rest of the buffers should be new data.
1145 CheckExpectedBuffers(16, 19, &kDataB); 1101 CheckExpectedBuffers(16, 19, &kDataB);
1146 1102
1147 // Now seek to the beginning; positions 0 through 9 should be the original 1103 // Now seek to the beginning; positions 0 through 9 should be the original
1148 // data, positions 10 through 19 should be the new data. 1104 // data, positions 10 through 19 should be the new data.
1149 Seek(0); 1105 Seek(0);
1150 CheckExpectedBuffers(0, 9, &kDataA); 1106 CheckExpectedBuffers(0, 9, &kDataA);
1151 CheckExpectedBuffers(10, 19, &kDataB); 1107 CheckExpectedBuffers(10, 19, &kDataB);
1152 1108
1153 // Make sure range is still correct. 1109 // Make sure range is still correct.
1154 CheckExpectedRanges("{ [0,19) }"); 1110 CheckExpectedRanges("{ [0,19) }");
1155 } 1111 }
1156 1112
1157 TEST_F(SourceBufferStreamTest, Start_Overlap_Selected_EdgeCase) { 1113 TEST_F(SourceBufferStreamTest, Start_Overlap_Selected_EdgeCase) {
1158 // Append 10 buffers at positions 5 through 14. 1114 // Append 10 buffers at positions 5 through 14.
1159 NewSegmentAppend(5, 10, &kDataA); 1115 NewCodedFrameGroupAppend(5, 10, &kDataA);
1160 1116
1161 Seek(10); 1117 Seek(10);
1162 CheckExpectedBuffers(10, 10, &kDataA); 1118 CheckExpectedBuffers(10, 10, &kDataA);
1163 1119
1164 // Now replace the last 5 buffers with new data. 1120 // Now replace the last 5 buffers with new data.
1165 NewSegmentAppend(10, 5, &kDataB); 1121 NewCodedFrameGroupAppend(10, 5, &kDataB);
1166 1122
1167 // The next 4 buffers should be the origial data, held in the track buffer. 1123 // The next 4 buffers should be the origial data, held in the track buffer.
1168 CheckExpectedBuffers(11, 14, &kDataA); 1124 CheckExpectedBuffers(11, 14, &kDataA);
1169 1125
1170 // The next buffer is at position 15, so we should fail to fulfill the 1126 // The next buffer is at position 15, so we should fail to fulfill the
1171 // request. 1127 // request.
1172 CheckNoNextBuffer(); 1128 CheckNoNextBuffer();
1173 1129
1174 // Now append data at 15 through 19 and check to make sure it's correct. 1130 // Now append data at 15 through 19 and check to make sure it's correct.
1175 NewSegmentAppend(15, 5, &kDataB); 1131 NewCodedFrameGroupAppend(15, 5, &kDataB);
1176 CheckExpectedBuffers(15, 19, &kDataB); 1132 CheckExpectedBuffers(15, 19, &kDataB);
1177 1133
1178 // Seek to beginning of buffered range and check buffers. 1134 // Seek to beginning of buffered range and check buffers.
1179 Seek(5); 1135 Seek(5);
1180 CheckExpectedBuffers(5, 9, &kDataA); 1136 CheckExpectedBuffers(5, 9, &kDataA);
1181 CheckExpectedBuffers(10, 19, &kDataB); 1137 CheckExpectedBuffers(10, 19, &kDataB);
1182 1138
1183 // Check expected range. 1139 // Check expected range.
1184 CheckExpectedRanges("{ [5,19) }"); 1140 CheckExpectedRanges("{ [5,19) }");
1185 } 1141 }
1186 1142
1187 // This test covers the case where new buffers end-overlap an existing, selected 1143 // This test covers the case where new buffers end-overlap an existing, selected
1188 // range, and the next buffer is a keyframe that's being overlapped by new 1144 // range, and the next buffer is a keyframe that's being overlapped by new
1189 // buffers. 1145 // buffers.
1190 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1146 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1191 // old  : *A*a a a a A a a a a 1147 // old  : *A*a a a a A a a a a
1192 // new  : B b b b b B b b b b 1148 // new  : B b b b b B b b b b
1193 // after: B b b b b*B*b b b b A a a a a 1149 // after: B b b b b*B*b b b b A a a a a
1194 TEST_F(SourceBufferStreamTest, End_Overlap_Selected) { 1150 TEST_F(SourceBufferStreamTest, End_Overlap_Selected) {
1195 // Append 10 buffers at positions 5 through 14. 1151 // Append 10 buffers at positions 5 through 14.
1196 NewSegmentAppend(5, 10, &kDataA); 1152 NewCodedFrameGroupAppend(5, 10, &kDataA);
1197 1153
1198 // Seek to position 5. 1154 // Seek to position 5.
1199 Seek(5); 1155 Seek(5);
1200 1156
1201 // Now append 10 buffers at positions 0 through 9. 1157 // Now append 10 buffers at positions 0 through 9.
1202 NewSegmentAppend(0, 10, &kDataB); 1158 NewCodedFrameGroupAppend(0, 10, &kDataB);
1203 1159
1204 // Check expected range. 1160 // Check expected range.
1205 CheckExpectedRanges("{ [0,14) }"); 1161 CheckExpectedRanges("{ [0,14) }");
1206 1162
1207 // Because we seeked to a keyframe, the next buffers should be new. 1163 // Because we seeked to a keyframe, the next buffers should be new.
1208 CheckExpectedBuffers(5, 9, &kDataB); 1164 CheckExpectedBuffers(5, 9, &kDataB);
1209 1165
1210 // Make sure all data is correct. 1166 // Make sure all data is correct.
1211 Seek(0); 1167 Seek(0);
1212 CheckExpectedBuffers(0, 9, &kDataB); 1168 CheckExpectedBuffers(0, 9, &kDataB);
1213 CheckExpectedBuffers(10, 14, &kDataA); 1169 CheckExpectedBuffers(10, 14, &kDataA);
1214 } 1170 }
1215 1171
1216 // This test covers the case where new buffers end-overlap an existing, selected 1172 // This test covers the case where new buffers end-overlap an existing, selected
1217 // range, and the next buffer in the range is after the newly appended buffers. 1173 // range, and the next buffer in the range is after the newly appended buffers.
1218 // In this particular case, the end overlap does not require a split. 1174 // In this particular case, the end overlap does not require a split.
1219 // 1175 //
1220 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1176 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1221 // old  : |A a a a a A a a*a*a| 1177 // old  : |A a a a a A a a*a*a|
1222 // new  : B b b b b B b b b b 1178 // new  : B b b b b B b b b b
1223 // after: |B b b b b B b b b b A a a*a*a| 1179 // after: |B b b b b B b b b b A a a*a*a|
1224 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_AfterEndOfNew_1) { 1180 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_AfterEndOfNew_1) {
1225 // Append 10 buffers at positions 5 through 14. 1181 // Append 10 buffers at positions 5 through 14.
1226 NewSegmentAppend(5, 10, &kDataA); 1182 NewCodedFrameGroupAppend(5, 10, &kDataA);
1227 1183
1228 // Seek to position 10, then move to position 13. 1184 // Seek to position 10, then move to position 13.
1229 Seek(10); 1185 Seek(10);
1230 CheckExpectedBuffers(10, 12, &kDataA); 1186 CheckExpectedBuffers(10, 12, &kDataA);
1231 1187
1232 // Now append 10 buffers at positions 0 through 9. 1188 // Now append 10 buffers at positions 0 through 9.
1233 NewSegmentAppend(0, 10, &kDataB); 1189 NewCodedFrameGroupAppend(0, 10, &kDataB);
1234 1190
1235 // Check expected range. 1191 // Check expected range.
1236 CheckExpectedRanges("{ [0,14) }"); 1192 CheckExpectedRanges("{ [0,14) }");
1237 1193
1238 // Make sure rest of data is as expected. 1194 // Make sure rest of data is as expected.
1239 CheckExpectedBuffers(13, 14, &kDataA); 1195 CheckExpectedBuffers(13, 14, &kDataA);
1240 1196
1241 // Make sure all data is correct. 1197 // Make sure all data is correct.
1242 Seek(0); 1198 Seek(0);
1243 CheckExpectedBuffers(0, 9, &kDataB); 1199 CheckExpectedBuffers(0, 9, &kDataB);
1244 CheckExpectedBuffers(10, 14, &kDataA); 1200 CheckExpectedBuffers(10, 14, &kDataA);
1245 } 1201 }
1246 1202
1247 // This test covers the case where new buffers end-overlap an existing, selected 1203 // This test covers the case where new buffers end-overlap an existing, selected
1248 // range, and the next buffer in the range is after the newly appended buffers. 1204 // range, and the next buffer in the range is after the newly appended buffers.
1249 // In this particular case, the end overlap requires a split, and the next 1205 // In this particular case, the end overlap requires a split, and the next
1250 // buffer is in the split range. 1206 // buffer is in the split range.
1251 // 1207 //
1252 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1208 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1253 // old  : |A a a a a A a a*a*a| 1209 // old  : |A a a a a A a a*a*a|
1254 // new  : B b b b b B b b 1210 // new  : B b b b b B b b
1255 // after: |B b b b b B b b| |A a a*a*a| 1211 // after: |B b b b b B b b| |A a a*a*a|
1256 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_AfterEndOfNew_2) { 1212 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_AfterEndOfNew_2) {
1257 // Append 10 buffers at positions 5 through 14. 1213 // Append 10 buffers at positions 5 through 14.
1258 NewSegmentAppend(5, 10, &kDataA); 1214 NewCodedFrameGroupAppend(5, 10, &kDataA);
1259 1215
1260 // Seek to position 10, then move to position 13. 1216 // Seek to position 10, then move to position 13.
1261 Seek(10); 1217 Seek(10);
1262 CheckExpectedBuffers(10, 12, &kDataA); 1218 CheckExpectedBuffers(10, 12, &kDataA);
1263 1219
1264 // Now append 8 buffers at positions 0 through 7. 1220 // Now append 8 buffers at positions 0 through 7.
1265 NewSegmentAppend(0, 8, &kDataB); 1221 NewCodedFrameGroupAppend(0, 8, &kDataB);
1266 1222
1267 // Check expected ranges. 1223 // Check expected ranges.
1268 CheckExpectedRanges("{ [0,7) [10,14) }"); 1224 CheckExpectedRanges("{ [0,7) [10,14) }");
1269 1225
1270 // Make sure rest of data is as expected. 1226 // Make sure rest of data is as expected.
1271 CheckExpectedBuffers(13, 14, &kDataA); 1227 CheckExpectedBuffers(13, 14, &kDataA);
1272 1228
1273 // Make sure all data is correct. 1229 // Make sure all data is correct.
1274 Seek(0); 1230 Seek(0);
1275 CheckExpectedBuffers(0, 7, &kDataB); 1231 CheckExpectedBuffers(0, 7, &kDataB);
1276 CheckNoNextBuffer(); 1232 CheckNoNextBuffer();
1277 1233
1278 Seek(10); 1234 Seek(10);
1279 CheckExpectedBuffers(10, 14, &kDataA); 1235 CheckExpectedBuffers(10, 14, &kDataA);
1280 } 1236 }
1281 1237
1282 // This test covers the case where new buffers end-overlap an existing, selected 1238 // This test covers the case where new buffers end-overlap an existing, selected
1283 // range, and the next buffer in the range is after the newly appended buffers. 1239 // range, and the next buffer in the range is after the newly appended buffers.
1284 // In this particular case, the end overlap requires a split, and the next 1240 // In this particular case, the end overlap requires a split, and the next
1285 // buffer was in between the end of the new data and the split range. 1241 // buffer was in between the end of the new data and the split range.
1286 // 1242 //
1287 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1243 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1288 // old  : |A a a*a*a A a a a a| 1244 // old  : |A a a*a*a A a a a a|
1289 // new  : B b b b b B b b 1245 // new  : B b b b b B b b
1290 // after: |B b b b b B b b| |A a a a a| 1246 // after: |B b b b b B b b| |A a a a a|
1291 // track: |a a| 1247 // track: |a a|
1292 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_AfterEndOfNew_3) { 1248 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_AfterEndOfNew_3) {
1293 // Append 10 buffers at positions 5 through 14. 1249 // Append 10 buffers at positions 5 through 14.
1294 NewSegmentAppend(5, 10, &kDataA); 1250 NewCodedFrameGroupAppend(5, 10, &kDataA);
1295 1251
1296 // Seek to position 5, then move to position 8. 1252 // Seek to position 5, then move to position 8.
1297 Seek(5); 1253 Seek(5);
1298 CheckExpectedBuffers(5, 7, &kDataA); 1254 CheckExpectedBuffers(5, 7, &kDataA);
1299 1255
1300 // Now append 8 buffers at positions 0 through 7. 1256 // Now append 8 buffers at positions 0 through 7.
1301 NewSegmentAppend(0, 8, &kDataB); 1257 NewCodedFrameGroupAppend(0, 8, &kDataB);
1302 1258
1303 // Check expected ranges. 1259 // Check expected ranges.
1304 CheckExpectedRanges("{ [0,7) [10,14) }"); 1260 CheckExpectedRanges("{ [0,7) [10,14) }");
1305 1261
1306 // Check for data in the track buffer. 1262 // Check for data in the track buffer.
1307 CheckExpectedBuffers(8, 9, &kDataA); 1263 CheckExpectedBuffers(8, 9, &kDataA);
1308 // The buffer immediately after the track buffer should be a keyframe. 1264 // The buffer immediately after the track buffer should be a keyframe.
1309 CheckExpectedBuffers(10, 10, &kDataA, true); 1265 CheckExpectedBuffers(10, 10, &kDataA, true);
1310 1266
1311 // Make sure all data is correct. 1267 // Make sure all data is correct.
1312 Seek(0); 1268 Seek(0);
1313 CheckExpectedBuffers(0, 7, &kDataB); 1269 CheckExpectedBuffers(0, 7, &kDataB);
1314 Seek(10); 1270 Seek(10);
1315 CheckExpectedBuffers(10, 14, &kDataA); 1271 CheckExpectedBuffers(10, 14, &kDataA);
1316 } 1272 }
1317 1273
1318 // This test covers the case where new buffers end-overlap an existing, selected 1274 // This test covers the case where new buffers end-overlap an existing, selected
1319 // range, and the next buffer in the range is overlapped by the new buffers. 1275 // range, and the next buffer in the range is overlapped by the new buffers.
1320 // In this particular case, the end overlap does not require a split. 1276 // In this particular case, the end overlap does not require a split.
1321 // 1277 //
1322 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1278 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1323 // old  : |A a a*a*a A a a a a| 1279 // old  : |A a a*a*a A a a a a|
1324 // new  : B b b b b B b b b b 1280 // new  : B b b b b B b b b b
1325 // after: |B b b b b B b b b b A a a a a| 1281 // after: |B b b b b B b b b b A a a a a|
1326 // track: |a a| 1282 // track: |a a|
1327 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_OverlappedByNew_1) { 1283 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_OverlappedByNew_1) {
1328 // Append 10 buffers at positions 5 through 14. 1284 // Append 10 buffers at positions 5 through 14.
1329 NewSegmentAppend(5, 10, &kDataA); 1285 NewCodedFrameGroupAppend(5, 10, &kDataA);
1330 1286
1331 // Seek to position 5, then move to position 8. 1287 // Seek to position 5, then move to position 8.
1332 Seek(5); 1288 Seek(5);
1333 CheckExpectedBuffers(5, 7, &kDataA); 1289 CheckExpectedBuffers(5, 7, &kDataA);
1334 1290
1335 // Now append 10 buffers at positions 0 through 9. 1291 // Now append 10 buffers at positions 0 through 9.
1336 NewSegmentAppend(0, 10, &kDataB); 1292 NewCodedFrameGroupAppend(0, 10, &kDataB);
1337 1293
1338 // Check expected range. 1294 // Check expected range.
1339 CheckExpectedRanges("{ [0,14) }"); 1295 CheckExpectedRanges("{ [0,14) }");
1340 1296
1341 // Check for data in the track buffer. 1297 // Check for data in the track buffer.
1342 CheckExpectedBuffers(8, 9, &kDataA); 1298 CheckExpectedBuffers(8, 9, &kDataA);
1343 // The buffer immediately after the track buffer should be a keyframe. 1299 // The buffer immediately after the track buffer should be a keyframe.
1344 CheckExpectedBuffers(10, 10, &kDataA, true); 1300 CheckExpectedBuffers(10, 10, &kDataA, true);
1345 1301
1346 // Make sure all data is correct. 1302 // Make sure all data is correct.
1347 Seek(0); 1303 Seek(0);
1348 CheckExpectedBuffers(0, 9, &kDataB); 1304 CheckExpectedBuffers(0, 9, &kDataB);
1349 CheckExpectedBuffers(10, 14, &kDataA); 1305 CheckExpectedBuffers(10, 14, &kDataA);
1350 } 1306 }
1351 1307
1352 // This test covers the case where new buffers end-overlap an existing, selected 1308 // This test covers the case where new buffers end-overlap an existing, selected
1353 // range, and the next buffer in the range is overlapped by the new buffers. 1309 // range, and the next buffer in the range is overlapped by the new buffers.
1354 // In this particular case, the end overlap requires a split, and the next 1310 // In this particular case, the end overlap requires a split, and the next
1355 // keyframe after the track buffer is in the split range. 1311 // keyframe after the track buffer is in the split range.
1356 // 1312 //
1357 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1313 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1358 // old  : |A*a*a a a A a a a a| 1314 // old  : |A*a*a a a A a a a a|
1359 // new  : B b b b b B b 1315 // new  : B b b b b B b
1360 // after: |B b b b b B b| |A a a a a| 1316 // after: |B b b b b B b| |A a a a a|
1361 // track: |a a a a| 1317 // track: |a a a a|
1362 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_OverlappedByNew_2) { 1318 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_OverlappedByNew_2) {
1363 // Append 10 buffers at positions 5 through 14. 1319 // Append 10 buffers at positions 5 through 14.
1364 NewSegmentAppend(5, 10, &kDataA); 1320 NewCodedFrameGroupAppend(5, 10, &kDataA);
1365 1321
1366 // Seek to position 5, then move to position 6. 1322 // Seek to position 5, then move to position 6.
1367 Seek(5); 1323 Seek(5);
1368 CheckExpectedBuffers(5, 5, &kDataA); 1324 CheckExpectedBuffers(5, 5, &kDataA);
1369 1325
1370 // Now append 7 buffers at positions 0 through 6. 1326 // Now append 7 buffers at positions 0 through 6.
1371 NewSegmentAppend(0, 7, &kDataB); 1327 NewCodedFrameGroupAppend(0, 7, &kDataB);
1372 1328
1373 // Check expected ranges. 1329 // Check expected ranges.
1374 CheckExpectedRanges("{ [0,6) [10,14) }"); 1330 CheckExpectedRanges("{ [0,6) [10,14) }");
1375 1331
1376 // Check for data in the track buffer. 1332 // Check for data in the track buffer.
1377 CheckExpectedBuffers(6, 9, &kDataA); 1333 CheckExpectedBuffers(6, 9, &kDataA);
1378 // The buffer immediately after the track buffer should be a keyframe. 1334 // The buffer immediately after the track buffer should be a keyframe.
1379 CheckExpectedBuffers(10, 10, &kDataA, true); 1335 CheckExpectedBuffers(10, 10, &kDataA, true);
1380 1336
1381 // Make sure all data is correct. 1337 // Make sure all data is correct.
(...skipping 10 matching lines...) Expand all
1392 // In this particular case, the end overlap requires a split, and the next 1348 // In this particular case, the end overlap requires a split, and the next
1393 // keyframe after the track buffer is in the range with the new buffers. 1349 // keyframe after the track buffer is in the range with the new buffers.
1394 // 1350 //
1395 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1351 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1396 // old  : |A*a*a a a A a a a a A a a a a| 1352 // old  : |A*a*a a a A a a a a A a a a a|
1397 // new  : B b b b b B b b b b B b b 1353 // new  : B b b b b B b b b b B b b
1398 // after: |B b b b b B b b b b B b b| |A a a a a| 1354 // after: |B b b b b B b b b b B b b| |A a a a a|
1399 // track: |a a a a| 1355 // track: |a a a a|
1400 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_OverlappedByNew_3) { 1356 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_OverlappedByNew_3) {
1401 // Append 15 buffers at positions 5 through 19. 1357 // Append 15 buffers at positions 5 through 19.
1402 NewSegmentAppend(5, 15, &kDataA); 1358 NewCodedFrameGroupAppend(5, 15, &kDataA);
1403 1359
1404 // Seek to position 5, then move to position 6. 1360 // Seek to position 5, then move to position 6.
1405 Seek(5); 1361 Seek(5);
1406 CheckExpectedBuffers(5, 5, &kDataA); 1362 CheckExpectedBuffers(5, 5, &kDataA);
1407 1363
1408 // Now append 13 buffers at positions 0 through 12. 1364 // Now append 13 buffers at positions 0 through 12.
1409 NewSegmentAppend(0, 13, &kDataB); 1365 NewCodedFrameGroupAppend(0, 13, &kDataB);
1410 1366
1411 // Check expected ranges. 1367 // Check expected ranges.
1412 CheckExpectedRanges("{ [0,12) [15,19) }"); 1368 CheckExpectedRanges("{ [0,12) [15,19) }");
1413 1369
1414 // Check for data in the track buffer. 1370 // Check for data in the track buffer.
1415 CheckExpectedBuffers(6, 9, &kDataA); 1371 CheckExpectedBuffers(6, 9, &kDataA);
1416 // The buffer immediately after the track buffer should be a keyframe 1372 // The buffer immediately after the track buffer should be a keyframe
1417 // from the new data. 1373 // from the new data.
1418 CheckExpectedBuffers(10, 10, &kDataB, true); 1374 CheckExpectedBuffers(10, 10, &kDataB, true);
1419 1375
1420 // Make sure all data is correct. 1376 // Make sure all data is correct.
1421 Seek(0); 1377 Seek(0);
1422 CheckExpectedBuffers(0, 12, &kDataB); 1378 CheckExpectedBuffers(0, 12, &kDataB);
1423 CheckNoNextBuffer(); 1379 CheckNoNextBuffer();
1424 1380
1425 Seek(15); 1381 Seek(15);
1426 CheckExpectedBuffers(15, 19, &kDataA); 1382 CheckExpectedBuffers(15, 19, &kDataA);
1427 } 1383 }
1428 1384
1429 // This test covers the case where new buffers end-overlap an existing, selected 1385 // This test covers the case where new buffers end-overlap an existing, selected
1430 // range, and there is no keyframe after the end of the new buffers. 1386 // range, and there is no keyframe after the end of the new buffers.
1431 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1387 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1432 // old  : |A*a*a a a| 1388 // old  : |A*a*a a a|
1433 // new  : B b b b b B 1389 // new  : B b b b b B
1434 // after: |B b b b b B| 1390 // after: |B b b b b B|
1435 // track: |a a a a| 1391 // track: |a a a a|
1436 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_NoKeyframeAfterNew) { 1392 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_NoKeyframeAfterNew) {
1437 // Append 5 buffers at positions 5 through 9. 1393 // Append 5 buffers at positions 5 through 9.
1438 NewSegmentAppend(5, 5, &kDataA); 1394 NewCodedFrameGroupAppend(5, 5, &kDataA);
1439 1395
1440 // Seek to position 5, then move to position 6. 1396 // Seek to position 5, then move to position 6.
1441 Seek(5); 1397 Seek(5);
1442 CheckExpectedBuffers(5, 5, &kDataA); 1398 CheckExpectedBuffers(5, 5, &kDataA);
1443 1399
1444 // Now append 6 buffers at positions 0 through 5. 1400 // Now append 6 buffers at positions 0 through 5.
1445 NewSegmentAppend(0, 6, &kDataB); 1401 NewCodedFrameGroupAppend(0, 6, &kDataB);
1446 1402
1447 // Check expected range. 1403 // Check expected range.
1448 CheckExpectedRanges("{ [0,5) }"); 1404 CheckExpectedRanges("{ [0,5) }");
1449 1405
1450 // Check for data in the track buffer. 1406 // Check for data in the track buffer.
1451 CheckExpectedBuffers(6, 9, &kDataA); 1407 CheckExpectedBuffers(6, 9, &kDataA);
1452 1408
1453 // Now there's no data to fulfill the request. 1409 // Now there's no data to fulfill the request.
1454 CheckNoNextBuffer(); 1410 CheckNoNextBuffer();
1455 1411
(...skipping 11 matching lines...) Expand all
1467 // old  : |A a a a a A*a*| 1423 // old  : |A a a a a A*a*|
1468 // new  : B b b b b B b b b b B 1424 // new  : B b b b b B b b b b B
1469 // after: |B b b b b B b b b b B| 1425 // after: |B b b b b B b b b b B|
1470 // new  : A a a a a A 1426 // new  : A a a a a A
1471 // after: |A a a a a A| |B b b b b B| 1427 // after: |A a a a a A| |B b b b b B|
1472 // track: |a| 1428 // track: |a|
1473 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_NoKeyframeAfterNew2) { 1429 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_NoKeyframeAfterNew2) {
1474 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(133)); 1430 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(133));
1475 1431
1476 // Append 7 buffers at positions 10 through 16. 1432 // Append 7 buffers at positions 10 through 16.
1477 NewSegmentAppend(10, 7, &kDataA); 1433 NewCodedFrameGroupAppend(10, 7, &kDataA);
1478 1434
1479 // Seek to position 15, then move to position 16. 1435 // Seek to position 15, then move to position 16.
1480 Seek(15); 1436 Seek(15);
1481 CheckExpectedBuffers(15, 15, &kDataA); 1437 CheckExpectedBuffers(15, 15, &kDataA);
1482 1438
1483 // Now append 11 buffers at positions 5 through 15. 1439 // Now append 11 buffers at positions 5 through 15.
1484 NewSegmentAppend(5, 11, &kDataB); 1440 NewCodedFrameGroupAppend(5, 11, &kDataB);
1485 CheckExpectedRanges("{ [5,15) }"); 1441 CheckExpectedRanges("{ [5,15) }");
1486 1442
1487 // Now do another end-overlap to split the range into two parts, where the 1443 // Now do another end-overlap to split the range into two parts, where the
1488 // 2nd range should have the next buffer position. 1444 // 2nd range should have the next buffer position.
1489 NewSegmentAppend(0, 6, &kDataA); 1445 NewCodedFrameGroupAppend(0, 6, &kDataA);
1490 CheckExpectedRanges("{ [0,5) [10,15) }"); 1446 CheckExpectedRanges("{ [0,5) [10,15) }");
1491 1447
1492 // Check for data in the track buffer. 1448 // Check for data in the track buffer.
1493 CheckExpectedBuffers(16, 16, &kDataA); 1449 CheckExpectedBuffers(16, 16, &kDataA);
1494 1450
1495 // Now there's no data to fulfill the request. 1451 // Now there's no data to fulfill the request.
1496 CheckNoNextBuffer(); 1452 CheckNoNextBuffer();
1497 1453
1498 // Add data to the 2nd range, should not be able to fulfill the next read 1454 // Add data to the 2nd range, should not be able to fulfill the next read
1499 // until we've added a keyframe. 1455 // until we've added a keyframe.
1500 NewSegmentAppend(15, 1, &kDataB); 1456 NewCodedFrameGroupAppend(15, 1, &kDataB);
1501 CheckNoNextBuffer(); 1457 CheckNoNextBuffer();
1502 for (int i = 16; i <= 19; i++) { 1458 for (int i = 16; i <= 19; i++) {
1503 AppendBuffers(i, 1, &kDataB); 1459 AppendBuffers(i, 1, &kDataB);
1504 CheckNoNextBuffer(); 1460 CheckNoNextBuffer();
1505 } 1461 }
1506 1462
1507 // Now append a keyframe. 1463 // Now append a keyframe.
1508 AppendBuffers(20, 1, &kDataB); 1464 AppendBuffers(20, 1, &kDataB);
1509 1465
1510 // We should be able to get the next buffer. 1466 // We should be able to get the next buffer.
1511 CheckExpectedBuffers(20, 20, &kDataB, true); 1467 CheckExpectedBuffers(20, 20, &kDataB, true);
1512 } 1468 }
1513 1469
1514 // This test covers the case where new buffers end-overlap an existing, selected 1470 // This test covers the case where new buffers end-overlap an existing, selected
1515 // range, and the next keyframe in a separate range. 1471 // range, and the next keyframe in a separate range.
1516 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1472 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1517 // old  : |A*a*a a a| |A a a a a| 1473 // old  : |A*a*a a a| |A a a a a|
1518 // new  : B b b b b B 1474 // new  : B b b b b B
1519 // after: |B b b b b B| |A a a a a| 1475 // after: |B b b b b B| |A a a a a|
1520 // track: |a a a a| 1476 // track: |a a a a|
1521 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_NoKeyframeAfterNew3) { 1477 TEST_F(SourceBufferStreamTest, End_Overlap_Selected_NoKeyframeAfterNew3) {
1522 // Append 5 buffers at positions 5 through 9. 1478 // Append 5 buffers at positions 5 through 9.
1523 NewSegmentAppend(5, 5, &kDataA); 1479 NewCodedFrameGroupAppend(5, 5, &kDataA);
1524 1480
1525 // Append 5 buffers at positions 15 through 19. 1481 // Append 5 buffers at positions 15 through 19.
1526 NewSegmentAppend(15, 5, &kDataA); 1482 NewCodedFrameGroupAppend(15, 5, &kDataA);
1527 1483
1528 // Check expected range. 1484 // Check expected range.
1529 CheckExpectedRanges("{ [5,9) [15,19) }"); 1485 CheckExpectedRanges("{ [5,9) [15,19) }");
1530 1486
1531 // Seek to position 5, then move to position 6. 1487 // Seek to position 5, then move to position 6.
1532 Seek(5); 1488 Seek(5);
1533 CheckExpectedBuffers(5, 5, &kDataA); 1489 CheckExpectedBuffers(5, 5, &kDataA);
1534 1490
1535 // Now append 6 buffers at positions 0 through 5. 1491 // Now append 6 buffers at positions 0 through 5.
1536 NewSegmentAppend(0, 6, &kDataB); 1492 NewCodedFrameGroupAppend(0, 6, &kDataB);
1537 1493
1538 // Check expected range. 1494 // Check expected range.
1539 CheckExpectedRanges("{ [0,5) [15,19) }"); 1495 CheckExpectedRanges("{ [0,5) [15,19) }");
1540 1496
1541 // Check for data in the track buffer. 1497 // Check for data in the track buffer.
1542 CheckExpectedBuffers(6, 9, &kDataA); 1498 CheckExpectedBuffers(6, 9, &kDataA);
1543 1499
1544 // Now there's no data to fulfill the request. 1500 // Now there's no data to fulfill the request.
1545 CheckNoNextBuffer(); 1501 CheckNoNextBuffer();
1546 1502
(...skipping 12 matching lines...) Expand all
1559 1515
1560 // This test covers the case when new buffers overlap the middle of a selected 1516 // This test covers the case when new buffers overlap the middle of a selected
1561 // range. This tests the case when there is no split and the next buffer is a 1517 // range. This tests the case when there is no split and the next buffer is a
1562 // keyframe. 1518 // keyframe.
1563 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1519 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1564 // old  : A a a a a*A*a a a a A a a a a 1520 // old  : A a a a a*A*a a a a A a a a a
1565 // new  : B b b b b 1521 // new  : B b b b b
1566 // after: A a a a a*B*b b b b A a a a a 1522 // after: A a a a a*B*b b b b A a a a a
1567 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_1) { 1523 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_1) {
1568 // Append 15 buffers at positions 0 through 14. 1524 // Append 15 buffers at positions 0 through 14.
1569 NewSegmentAppend(0, 15, &kDataA); 1525 NewCodedFrameGroupAppend(0, 15, &kDataA);
1570 1526
1571 // Seek to position 5. 1527 // Seek to position 5.
1572 Seek(5); 1528 Seek(5);
1573 1529
1574 // Now append 5 buffers at positions 5 through 9. 1530 // Now append 5 buffers at positions 5 through 9.
1575 NewSegmentAppend(5, 5, &kDataB); 1531 NewCodedFrameGroupAppend(5, 5, &kDataB);
1576 1532
1577 // Check expected range. 1533 // Check expected range.
1578 CheckExpectedRanges("{ [0,14) }"); 1534 CheckExpectedRanges("{ [0,14) }");
1579 1535
1580 // Check for next data; should be new data. 1536 // Check for next data; should be new data.
1581 CheckExpectedBuffers(5, 9, &kDataB); 1537 CheckExpectedBuffers(5, 9, &kDataB);
1582 1538
1583 // Make sure all data is correct. 1539 // Make sure all data is correct.
1584 Seek(0); 1540 Seek(0);
1585 CheckExpectedBuffers(0, 4, &kDataA); 1541 CheckExpectedBuffers(0, 4, &kDataA);
1586 CheckExpectedBuffers(5, 9, &kDataB); 1542 CheckExpectedBuffers(5, 9, &kDataB);
1587 CheckExpectedBuffers(10, 14, &kDataA); 1543 CheckExpectedBuffers(10, 14, &kDataA);
1588 } 1544 }
1589 1545
1590 // This test covers the case when new buffers overlap the middle of a selected 1546 // This test covers the case when new buffers overlap the middle of a selected
1591 // range. This tests the case when there is no split and the next buffer is 1547 // range. This tests the case when there is no split and the next buffer is
1592 // after the new buffers. 1548 // after the new buffers.
1593 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1549 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1594 // old  : A a a a a A a a a a A*a*a a a 1550 // old  : A a a a a A a a a a A*a*a a a
1595 // new  : B b b b b 1551 // new  : B b b b b
1596 // after: A a a a a B b b b b A*a*a a a 1552 // after: A a a a a B b b b b A*a*a a a
1597 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_2) { 1553 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_2) {
1598 // Append 15 buffers at positions 0 through 14. 1554 // Append 15 buffers at positions 0 through 14.
1599 NewSegmentAppend(0, 15, &kDataA); 1555 NewCodedFrameGroupAppend(0, 15, &kDataA);
1600 1556
1601 // Seek to 10 then move to position 11. 1557 // Seek to 10 then move to position 11.
1602 Seek(10); 1558 Seek(10);
1603 CheckExpectedBuffers(10, 10, &kDataA); 1559 CheckExpectedBuffers(10, 10, &kDataA);
1604 1560
1605 // Now append 5 buffers at positions 5 through 9. 1561 // Now append 5 buffers at positions 5 through 9.
1606 NewSegmentAppend(5, 5, &kDataB); 1562 NewCodedFrameGroupAppend(5, 5, &kDataB);
1607 1563
1608 // Check expected range. 1564 // Check expected range.
1609 CheckExpectedRanges("{ [0,14) }"); 1565 CheckExpectedRanges("{ [0,14) }");
1610 1566
1611 // Make sure data is correct. 1567 // Make sure data is correct.
1612 CheckExpectedBuffers(11, 14, &kDataA); 1568 CheckExpectedBuffers(11, 14, &kDataA);
1613 Seek(0); 1569 Seek(0);
1614 CheckExpectedBuffers(0, 4, &kDataA); 1570 CheckExpectedBuffers(0, 4, &kDataA);
1615 CheckExpectedBuffers(5, 9, &kDataB); 1571 CheckExpectedBuffers(5, 9, &kDataB);
1616 CheckExpectedBuffers(10, 14, &kDataA); 1572 CheckExpectedBuffers(10, 14, &kDataA);
1617 } 1573 }
1618 1574
1619 // This test covers the case when new buffers overlap the middle of a selected 1575 // This test covers the case when new buffers overlap the middle of a selected
1620 // range. This tests the case when there is a split and the next buffer is 1576 // range. This tests the case when there is a split and the next buffer is
1621 // before the new buffers. 1577 // before the new buffers.
1622 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1578 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1623 // old  : A a*a*a a A a a a a A a a a a 1579 // old  : A a*a*a a A a a a a A a a a a
1624 // new  : B b b 1580 // new  : B b b
1625 // after: A a*a*a a B b b| |A a a a a 1581 // after: A a*a*a a B b b| |A a a a a
1626 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_3) { 1582 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_3) {
1627 // Append 15 buffers at positions 0 through 14. 1583 // Append 15 buffers at positions 0 through 14.
1628 NewSegmentAppend(0, 15, &kDataA); 1584 NewCodedFrameGroupAppend(0, 15, &kDataA);
1629 1585
1630 // Seek to beginning then move to position 2. 1586 // Seek to beginning then move to position 2.
1631 Seek(0); 1587 Seek(0);
1632 CheckExpectedBuffers(0, 1, &kDataA); 1588 CheckExpectedBuffers(0, 1, &kDataA);
1633 1589
1634 // Now append 3 buffers at positions 5 through 7. 1590 // Now append 3 buffers at positions 5 through 7.
1635 NewSegmentAppend(5, 3, &kDataB); 1591 NewCodedFrameGroupAppend(5, 3, &kDataB);
1636 1592
1637 // Check expected range. 1593 // Check expected range.
1638 CheckExpectedRanges("{ [0,7) [10,14) }"); 1594 CheckExpectedRanges("{ [0,7) [10,14) }");
1639 1595
1640 // Make sure data is correct. 1596 // Make sure data is correct.
1641 CheckExpectedBuffers(2, 4, &kDataA); 1597 CheckExpectedBuffers(2, 4, &kDataA);
1642 CheckExpectedBuffers(5, 7, &kDataB); 1598 CheckExpectedBuffers(5, 7, &kDataB);
1643 Seek(10); 1599 Seek(10);
1644 CheckExpectedBuffers(10, 14, &kDataA); 1600 CheckExpectedBuffers(10, 14, &kDataA);
1645 } 1601 }
1646 1602
1647 // This test covers the case when new buffers overlap the middle of a selected 1603 // This test covers the case when new buffers overlap the middle of a selected
1648 // range. This tests the case when there is a split and the next buffer is after 1604 // range. This tests the case when there is a split and the next buffer is after
1649 // the new buffers but before the split range. 1605 // the new buffers but before the split range.
1650 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1606 // index: 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0
1651 // old  : A a a a a A a a*a*a A a a a a 1607 // old  : A a a a a A a a*a*a A a a a a
1652 // new  : B b b 1608 // new  : B b b
1653 // after: |A a a a a B b b| |A a a a a| 1609 // after: |A a a a a B b b| |A a a a a|
1654 // track: |a a| 1610 // track: |a a|
1655 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_4) { 1611 TEST_F(SourceBufferStreamTest, Middle_Overlap_Selected_4) {
1656 // Append 15 buffers at positions 0 through 14. 1612 // Append 15 buffers at positions 0 through 14.
1657 NewSegmentAppend(0, 15, &kDataA); 1613 NewCodedFrameGroupAppend(0, 15, &kDataA);
1658 1614
1659 // Seek to 5 then move to position 8. 1615 // Seek to 5 then move to position 8.
1660 Seek(5); 1616 Seek(5);
1661 CheckExpectedBuffers(5, 7, &kDataA); 1617 CheckExpectedBuffers(5, 7, &kDataA);
1662 1618
1663 // Now append 3 buffers at positions 5 through 7. 1619 // Now append 3 buffers at positions 5 through 7.
1664 NewSegmentAppend(5, 3, &kDataB); 1620 NewCodedFrameGroupAppend(5, 3, &kDataB);
1665 1621
1666 // Check expected range. 1622 // Check expected range.
1667 CheckExpectedRanges("{ [0,7) [10,14) }"); 1623 CheckExpectedRanges("{ [0,7) [10,14) }");
1668 1624
1669 // Buffers 8 and 9 should be in the track buffer. 1625 // Buffers 8 and 9 should be in the track buffer.
1670 CheckExpectedBuffers(8, 9, &kDataA); 1626 CheckExpectedBuffers(8, 9, &kDataA);
1671 // The buffer immediately after the track buffer should be a keyframe. 1627 // The buffer immediately after the track buffer should be a keyframe.
1672 CheckExpectedBuffers(10, 10, &kDataA, true); 1628 CheckExpectedBuffers(10, 10, &kDataA, true);
1673 1629
1674 // Make sure all data is correct. 1630 // Make sure all data is correct.
1675 Seek(0); 1631 Seek(0);
1676 CheckExpectedBuffers(0, 4, &kDataA); 1632 CheckExpectedBuffers(0, 4, &kDataA);
1677 CheckExpectedBuffers(5, 7, &kDataB); 1633 CheckExpectedBuffers(5, 7, &kDataB);
1678 Seek(10); 1634 Seek(10);
1679 CheckExpectedBuffers(10, 14, &kDataA); 1635 CheckExpectedBuffers(10, 14, &kDataA);
1680 } 1636 }
1681 1637
1682 TEST_F(SourceBufferStreamTest, Overlap_OneByOne) { 1638 TEST_F(SourceBufferStreamTest, Overlap_OneByOne) {
1683 // Append 5 buffers starting at 10ms, 30ms apart. 1639 // Append 5 buffers starting at 10ms, 30ms apart.
1684 NewSegmentAppendOneByOne("10K 40 70 100 130"); 1640 NewCodedFrameGroupAppendOneByOne("10K 40 70 100 130");
1685 1641
1686 // The range ends at 160, accounting for the last buffer's duration. 1642 // The range ends at 160, accounting for the last buffer's duration.
1687 CheckExpectedRangesByTimestamp("{ [10,160) }"); 1643 CheckExpectedRangesByTimestamp("{ [10,160) }");
1688 1644
1689 // Overlap with 10 buffers starting at the beginning, appended one at a 1645 // Overlap with 10 buffers starting at the beginning, appended one at a
1690 // time. 1646 // time.
1691 NewSegmentAppend(0, 1, &kDataB); 1647 NewCodedFrameGroupAppend(0, 1, &kDataB);
1692 for (int i = 1; i < 10; i++) 1648 for (int i = 1; i < 10; i++)
1693 AppendBuffers(i, 1, &kDataB); 1649 AppendBuffers(i, 1, &kDataB);
1694 1650
1695 // All data should be replaced. 1651 // All data should be replaced.
1696 Seek(0); 1652 Seek(0);
1697 CheckExpectedRanges("{ [0,9) }"); 1653 CheckExpectedRanges("{ [0,9) }");
1698 CheckExpectedBuffers(0, 9, &kDataB); 1654 CheckExpectedBuffers(0, 9, &kDataB);
1699 } 1655 }
1700 1656
1701 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_DeleteGroup) { 1657 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_DeleteGroup) {
1702 NewSegmentAppendOneByOne("10K 40 70 100 130K"); 1658 NewCodedFrameGroupAppendOneByOne("10K 40 70 100 130K");
1703 CheckExpectedRangesByTimestamp("{ [10,160) }"); 1659 CheckExpectedRangesByTimestamp("{ [10,160) }");
1704 1660
1705 // Seek to 130ms. 1661 // Seek to 130ms.
1706 SeekToTimestampMs(130); 1662 SeekToTimestampMs(130);
1707 1663
1708 // Overlap with a new segment from 0 to 130ms. 1664 // Overlap with a new coded frame group from 0 to 130ms.
1709 NewSegmentAppendOneByOne("0K 120D10"); 1665 NewCodedFrameGroupAppendOneByOne("0K 120D10");
1710 1666
1711 // Next buffer should still be 130ms. 1667 // Next buffer should still be 130ms.
1712 CheckExpectedBuffers("130K"); 1668 CheckExpectedBuffers("130K");
1713 1669
1714 // Check the final buffers is correct. 1670 // Check the final buffers is correct.
1715 SeekToTimestampMs(0); 1671 SeekToTimestampMs(0);
1716 CheckExpectedBuffers("0K 120 130K"); 1672 CheckExpectedBuffers("0K 120 130K");
1717 } 1673 }
1718 1674
1719 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_BetweenMediaSegments) { 1675 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_BetweenCodedFrameGroups) {
1720 // Append 5 buffers starting at 110ms, 30ms apart. 1676 // Append 5 buffers starting at 110ms, 30ms apart.
1721 NewSegmentAppendOneByOne("110K 140 170 200 230"); 1677 NewCodedFrameGroupAppendOneByOne("110K 140 170 200 230");
1722 CheckExpectedRangesByTimestamp("{ [110,260) }"); 1678 CheckExpectedRangesByTimestamp("{ [110,260) }");
1723 1679
1724 // Now append 2 media segments from 0ms to 210ms, 30ms apart. Note that the 1680 // Now append 2 coded frame groups from 0ms to 210ms, 30ms apart. Note that
1725 // old keyframe 110ms falls in between these two segments. 1681 // the
1726 NewSegmentAppendOneByOne("0K 30 60 90"); 1682 // old keyframe 110ms falls in between these two groups.
1727 NewSegmentAppendOneByOne("120K 150 180 210"); 1683 NewCodedFrameGroupAppendOneByOne("0K 30 60 90");
1684 NewCodedFrameGroupAppendOneByOne("120K 150 180 210");
1728 CheckExpectedRangesByTimestamp("{ [0,240) }"); 1685 CheckExpectedRangesByTimestamp("{ [0,240) }");
1729 1686
1730 // Check the final buffers is correct; the keyframe at 110ms should be 1687 // Check the final buffers is correct; the keyframe at 110ms should be
1731 // deleted. 1688 // deleted.
1732 SeekToTimestampMs(0); 1689 SeekToTimestampMs(0);
1733 CheckExpectedBuffers("0K 30 60 90 120K 150 180 210"); 1690 CheckExpectedBuffers("0K 30 60 90 120K 150 180 210");
1734 } 1691 }
1735 1692
1736 // old : 10K 40 *70* 100K 125 130K 1693 // old : 10K 40 *70* 100K 125 130K
1737 // new : 0K 30 60 90 120K 1694 // new : 0K 30 60 90 120K
1738 // after: 0K 30 60 90 *120K* 130K 1695 // after: 0K 30 60 90 *120K* 130K
1739 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer) { 1696 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer) {
1740 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(50)); 1697 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(50));
1741 1698
1742 NewSegmentAppendOneByOne("10K 40 70 100K 125 130D30K"); 1699 NewCodedFrameGroupAppendOneByOne("10K 40 70 100K 125 130D30K");
1743 CheckExpectedRangesByTimestamp("{ [10,160) }"); 1700 CheckExpectedRangesByTimestamp("{ [10,160) }");
1744 1701
1745 // Seek to 70ms. 1702 // Seek to 70ms.
1746 SeekToTimestampMs(70); 1703 SeekToTimestampMs(70);
1747 CheckExpectedBuffers("10K 40"); 1704 CheckExpectedBuffers("10K 40");
1748 1705
1749 // Overlap with a new segment from 0 to 130ms. 1706 // Overlap with a new coded frame group from 0 to 130ms.
1750 NewSegmentAppendOneByOne("0K 30 60 90 120D10K"); 1707 NewCodedFrameGroupAppendOneByOne("0K 30 60 90 120D10K");
1751 CheckExpectedRangesByTimestamp("{ [0,160) }"); 1708 CheckExpectedRangesByTimestamp("{ [0,160) }");
1752 1709
1753 // Should return frame 70ms from the track buffer, then switch 1710 // Should return frame 70ms from the track buffer, then switch
1754 // to the new data at 120K, then switch back to the old data at 130K. The 1711 // to the new data at 120K, then switch back to the old data at 130K. The
1755 // frame at 125ms that depended on keyframe 100ms should have been deleted. 1712 // frame at 125ms that depended on keyframe 100ms should have been deleted.
1756 CheckExpectedBuffers("70 120K 130K"); 1713 CheckExpectedBuffers("70 120K 130K");
1757 1714
1758 // Check the final result: should not include data from the track buffer. 1715 // Check the final result: should not include data from the track buffer.
1759 SeekToTimestampMs(0); 1716 SeekToTimestampMs(0);
1760 CheckExpectedBuffers("0K 30 60 90 120K 130K"); 1717 CheckExpectedBuffers("0K 30 60 90 120K 130K");
1761 } 1718 }
1762 1719
1763 // Overlap the next keyframe after the end of the track buffer with a new 1720 // Overlap the next keyframe after the end of the track buffer with a new
1764 // keyframe. 1721 // keyframe.
1765 // old : 10K 40 *70* 100K 125 130K 1722 // old : 10K 40 *70* 100K 125 130K
1766 // new : 0K 30 60 90 120K 1723 // new : 0K 30 60 90 120K
1767 // after: 0K 30 60 90 *120K* 130K 1724 // after: 0K 30 60 90 *120K* 130K
1768 // track: 70 1725 // track: 70
1769 // new : 110K 130 1726 // new : 110K 130
1770 // after: 0K 30 60 90 *110K* 130 1727 // after: 0K 30 60 90 *110K* 130
1771 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer2) { 1728 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer2) {
1772 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(40)); 1729 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(40));
1773 1730
1774 NewSegmentAppendOneByOne("10K 40 70 100K 125 130D30K"); 1731 NewCodedFrameGroupAppendOneByOne("10K 40 70 100K 125 130D30K");
1775 CheckExpectedRangesByTimestamp("{ [10,160) }"); 1732 CheckExpectedRangesByTimestamp("{ [10,160) }");
1776 1733
1777 // Seek to 70ms. 1734 // Seek to 70ms.
1778 SeekToTimestampMs(70); 1735 SeekToTimestampMs(70);
1779 CheckExpectedBuffers("10K 40"); 1736 CheckExpectedBuffers("10K 40");
1780 1737
1781 // Overlap with a new segment from 0 to 120ms; 70ms and 100ms go in track 1738 // Overlap with a new coded frame group from 0 to 120ms; 70ms and 100ms go in
1739 // track
1782 // buffer. 1740 // buffer.
1783 NewSegmentAppendOneByOne("0K 30 60 90 120D10K"); 1741 NewCodedFrameGroupAppendOneByOne("0K 30 60 90 120D10K");
1784 CheckExpectedRangesByTimestamp("{ [0,160) }"); 1742 CheckExpectedRangesByTimestamp("{ [0,160) }");
1785 1743
1786 // Now overlap the keyframe at 120ms. 1744 // Now overlap the keyframe at 120ms.
1787 NewSegmentAppendOneByOne("110K 130"); 1745 NewCodedFrameGroupAppendOneByOne("110K 130");
1788 1746
1789 // Should return frame 70ms from the track buffer. Then it should 1747 // Should return frame 70ms from the track buffer. Then it should
1790 // return the keyframe after the track buffer, which is at 110ms. 1748 // return the keyframe after the track buffer, which is at 110ms.
1791 CheckExpectedBuffers("70 110K 130"); 1749 CheckExpectedBuffers("70 110K 130");
1792 } 1750 }
1793 1751
1794 // Overlap the next keyframe after the end of the track buffer without a 1752 // Overlap the next keyframe after the end of the track buffer without a
1795 // new keyframe. 1753 // new keyframe.
1796 // old : 10K 40 *70* 100K 125 130K 1754 // old : 10K 40 *70* 100K 125 130K
1797 // new : 0K 30 60 90 120K 1755 // new : 0K 30 60 90 120K
1798 // after: 0K 30 60 90 *120K* 130K 1756 // after: 0K 30 60 90 *120K* 130K
1799 // track: 70 1757 // track: 70
1800 // new : 50K 80 110 140 1758 // new : 50K 80 110 140
1801 // after: 0K 30 50K 80 110 140 * (waiting for keyframe) 1759 // after: 0K 30 50K 80 110 140 * (waiting for keyframe)
1802 // track: 70 1760 // track: 70
1803 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer3) { 1761 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer3) {
1804 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(80)); 1762 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(80));
1805 1763
1806 NewSegmentAppendOneByOne("10K 40 70 100K 125 130D30K"); 1764 NewCodedFrameGroupAppendOneByOne("10K 40 70 100K 125 130D30K");
1807 CheckExpectedRangesByTimestamp("{ [10,160) }"); 1765 CheckExpectedRangesByTimestamp("{ [10,160) }");
1808 1766
1809 // Seek to 70ms. 1767 // Seek to 70ms.
1810 SeekToTimestampMs(70); 1768 SeekToTimestampMs(70);
1811 CheckExpectedBuffers("10K 40"); 1769 CheckExpectedBuffers("10K 40");
1812 1770
1813 // Overlap with a new segment from 0 to 120ms; 70ms goes in track buffer. 1771 // Overlap with a new coded frame group from 0 to 120ms; 70ms goes in track
1814 NewSegmentAppendOneByOne("0K 30 60 90 120D10K"); 1772 // buffer.
1773 NewCodedFrameGroupAppendOneByOne("0K 30 60 90 120D10K");
1815 CheckExpectedRangesByTimestamp("{ [0,160) }"); 1774 CheckExpectedRangesByTimestamp("{ [0,160) }");
1816 1775
1817 // Now overlap the keyframe at 120ms and 130ms. 1776 // Now overlap the keyframe at 120ms and 130ms.
1818 NewSegmentAppendOneByOne("50K 80 110 140"); 1777 NewCodedFrameGroupAppendOneByOne("50K 80 110 140");
1819 CheckExpectedRangesByTimestamp("{ [0,170) }"); 1778 CheckExpectedRangesByTimestamp("{ [0,170) }");
1820 1779
1821 // Should have all the buffers from the track buffer, then stall. 1780 // Should have all the buffers from the track buffer, then stall.
1822 CheckExpectedBuffers("70"); 1781 CheckExpectedBuffers("70");
1823 CheckNoNextBuffer(); 1782 CheckNoNextBuffer();
1824 1783
1825 // Appending a keyframe should fulfill the read. 1784 // Appending a keyframe should fulfill the read.
1826 AppendBuffersOneByOne("150D30K"); 1785 AppendBuffersOneByOne("150D30K");
1827 CheckExpectedBuffers("150K"); 1786 CheckExpectedBuffers("150K");
1828 CheckNoNextBuffer(); 1787 CheckNoNextBuffer();
1829 } 1788 }
1830 1789
1831 // Overlap the next keyframe after the end of the track buffer with a keyframe 1790 // Overlap the next keyframe after the end of the track buffer with a keyframe
1832 // that comes before the end of the track buffer. 1791 // that comes before the end of the track buffer.
1833 // old : 10K 40 *70* 100K 125 130K 1792 // old : 10K 40 *70* 100K 125 130K
1834 // new : 0K 30 60 90 120K 1793 // new : 0K 30 60 90 120K
1835 // after: 0K 30 60 90 *120K* 130K 1794 // after: 0K 30 60 90 *120K* 130K
1836 // track: 70 1795 // track: 70
1837 // new : 80K 110 140 1796 // new : 80K 110 140
1838 // after: 0K 30 60 *80K* 110 140 1797 // after: 0K 30 60 *80K* 110 140
1839 // track: 70 1798 // track: 70
1840 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer4) { 1799 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer4) {
1841 NewSegmentAppendOneByOne("10K 40 70 100K 125 130D30K"); 1800 NewCodedFrameGroupAppendOneByOne("10K 40 70 100K 125 130D30K");
1842 CheckExpectedRangesByTimestamp("{ [10,160) }"); 1801 CheckExpectedRangesByTimestamp("{ [10,160) }");
1843 1802
1844 // Seek to 70ms. 1803 // Seek to 70ms.
1845 SeekToTimestampMs(70); 1804 SeekToTimestampMs(70);
1846 CheckExpectedBuffers("10K 40"); 1805 CheckExpectedBuffers("10K 40");
1847 1806
1848 // Overlap with a new segment from 0 to 120ms; 70ms and 100ms go in track 1807 // Overlap with a new coded frame group from 0 to 120ms; 70ms and 100ms go in
1808 // track
1849 // buffer. 1809 // buffer.
1850 NewSegmentAppendOneByOne("0K 30 60 90 120D10K"); 1810 NewCodedFrameGroupAppendOneByOne("0K 30 60 90 120D10K");
1851 CheckExpectedRangesByTimestamp("{ [0,160) }"); 1811 CheckExpectedRangesByTimestamp("{ [0,160) }");
1852 1812
1853 // Now append a keyframe at 80ms. 1813 // Now append a keyframe at 80ms.
1854 NewSegmentAppendOneByOne("80K 110 140"); 1814 NewCodedFrameGroupAppendOneByOne("80K 110 140");
1855 1815
1856 CheckExpectedBuffers("70 80K 110 140"); 1816 CheckExpectedBuffers("70 80K 110 140");
1857 CheckNoNextBuffer(); 1817 CheckNoNextBuffer();
1858 } 1818 }
1859 1819
1860 // Overlap the next keyframe after the end of the track buffer with a keyframe 1820 // Overlap the next keyframe after the end of the track buffer with a keyframe
1861 // that comes before the end of the track buffer, when the selected stream was 1821 // that comes before the end of the track buffer, when the selected stream was
1862 // waiting for the next keyframe. 1822 // waiting for the next keyframe.
1863 // old : 10K 40 *70* 100K 1823 // old : 10K 40 *70* 100K
1864 // new : 0K 30 60 90 120 1824 // new : 0K 30 60 90 120
1865 // after: 0K 30 60 90 120 * (waiting for keyframe) 1825 // after: 0K 30 60 90 120 * (waiting for keyframe)
1866 // track: 70 1826 // track: 70
1867 // new : 80K 110 140 1827 // new : 80K 110 140
1868 // after: 0K 30 60 *80K* 110 140 1828 // after: 0K 30 60 *80K* 110 140
1869 // track: 70 1829 // track: 70
1870 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer5) { 1830 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer5) {
1871 NewSegmentAppendOneByOne("10K 40 70 100K"); 1831 NewCodedFrameGroupAppendOneByOne("10K 40 70 100K");
1872 CheckExpectedRangesByTimestamp("{ [10,130) }"); 1832 CheckExpectedRangesByTimestamp("{ [10,130) }");
1873 1833
1874 // Seek to 70ms. 1834 // Seek to 70ms.
1875 SeekToTimestampMs(70); 1835 SeekToTimestampMs(70);
1876 CheckExpectedBuffers("10K 40"); 1836 CheckExpectedBuffers("10K 40");
1877 1837
1878 // Overlap with a new segment from 0 to 120ms; 70ms goes in track 1838 // Overlap with a new coded frame group from 0 to 120ms; 70ms goes in track
1879 // buffer. 1839 // buffer.
1880 NewSegmentAppendOneByOne("0K 30 60 90 120"); 1840 NewCodedFrameGroupAppendOneByOne("0K 30 60 90 120");
1881 CheckExpectedRangesByTimestamp("{ [0,150) }"); 1841 CheckExpectedRangesByTimestamp("{ [0,150) }");
1882 1842
1883 // Now append a keyframe at 80ms. 1843 // Now append a keyframe at 80ms.
1884 NewSegmentAppendOneByOne("80K 110 140"); 1844 NewCodedFrameGroupAppendOneByOne("80K 110 140");
1885 1845
1886 CheckExpectedBuffers("70 80K 110 140"); 1846 CheckExpectedBuffers("70 80K 110 140");
1887 CheckNoNextBuffer(); 1847 CheckNoNextBuffer();
1888 } 1848 }
1889 1849
1890 // Test that appending to a different range while there is data in 1850 // Test that appending to a different range while there is data in
1891 // the track buffer doesn't affect the selected range or track buffer state. 1851 // the track buffer doesn't affect the selected range or track buffer state.
1892 // old : 10K 40 *70* 100K 125 130K ... 200K 230 1852 // old : 10K 40 *70* 100K 125 130K ... 200K 230
1893 // new : 0K 30 60 90 120K 1853 // new : 0K 30 60 90 120K
1894 // after: 0K 30 60 90 *120K* 130K ... 200K 230 1854 // after: 0K 30 60 90 *120K* 130K ... 200K 230
1895 // track: 70 1855 // track: 70
1896 // old : 0K 30 60 90 *120K* 130K ... 200K 230 1856 // old : 0K 30 60 90 *120K* 130K ... 200K 230
1897 // new : 260K 290 1857 // new : 260K 290
1898 // after: 0K 30 60 90 *120K* 130K ... 200K 230 260K 290 1858 // after: 0K 30 60 90 *120K* 130K ... 200K 230 260K 290
1899 // track: 70 1859 // track: 70
1900 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer6) { 1860 TEST_F(SourceBufferStreamTest, Overlap_OneByOne_TrackBuffer6) {
1901 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(50)); 1861 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(50));
1902 1862
1903 NewSegmentAppendOneByOne("10K 40 70 100K 125 130D30K"); 1863 NewCodedFrameGroupAppendOneByOne("10K 40 70 100K 125 130D30K");
1904 NewSegmentAppendOneByOne("200K 230"); 1864 NewCodedFrameGroupAppendOneByOne("200K 230");
1905 CheckExpectedRangesByTimestamp("{ [10,160) [200,260) }"); 1865 CheckExpectedRangesByTimestamp("{ [10,160) [200,260) }");
1906 1866
1907 // Seek to 70ms. 1867 // Seek to 70ms.
1908 SeekToTimestampMs(70); 1868 SeekToTimestampMs(70);
1909 CheckExpectedBuffers("10K 40"); 1869 CheckExpectedBuffers("10K 40");
1910 1870
1911 // Overlap with a new segment from 0 to 120ms. 1871 // Overlap with a new coded frame group from 0 to 120ms.
1912 NewSegmentAppendOneByOne("0K 30 60 90 120D10K"); 1872 NewCodedFrameGroupAppendOneByOne("0K 30 60 90 120D10K");
1913 CheckExpectedRangesByTimestamp("{ [0,160) [200,260) }"); 1873 CheckExpectedRangesByTimestamp("{ [0,160) [200,260) }");
1914 1874
1915 // Verify that 70 gets read out of the track buffer. 1875 // Verify that 70 gets read out of the track buffer.
1916 CheckExpectedBuffers("70"); 1876 CheckExpectedBuffers("70");
1917 1877
1918 // Append more data to the unselected range. 1878 // Append more data to the unselected range.
1919 NewSegmentAppendOneByOne("260K 290"); 1879 NewCodedFrameGroupAppendOneByOne("260K 290");
1920 CheckExpectedRangesByTimestamp("{ [0,160) [200,320) }"); 1880 CheckExpectedRangesByTimestamp("{ [0,160) [200,320) }");
1921 1881
1922 CheckExpectedBuffers("120K 130K"); 1882 CheckExpectedBuffers("120K 130K");
1923 CheckNoNextBuffer(); 1883 CheckNoNextBuffer();
1924 1884
1925 // Check the final result: should not include data from the track buffer. 1885 // Check the final result: should not include data from the track buffer.
1926 SeekToTimestampMs(0); 1886 SeekToTimestampMs(0);
1927 CheckExpectedBuffers("0K 30 60 90 120K 130K"); 1887 CheckExpectedBuffers("0K 30 60 90 120K 130K");
1928 CheckNoNextBuffer(); 1888 CheckNoNextBuffer();
1929 } 1889 }
1930 1890
1931 TEST_F(SourceBufferStreamTest, Seek_Keyframe) { 1891 TEST_F(SourceBufferStreamTest, Seek_Keyframe) {
1932 // Append 6 buffers at positions 0 through 5. 1892 // Append 6 buffers at positions 0 through 5.
1933 NewSegmentAppend(0, 6); 1893 NewCodedFrameGroupAppend(0, 6);
1934 1894
1935 // Seek to beginning. 1895 // Seek to beginning.
1936 Seek(0); 1896 Seek(0);
1937 CheckExpectedBuffers(0, 5, true); 1897 CheckExpectedBuffers(0, 5, true);
1938 } 1898 }
1939 1899
1940 TEST_F(SourceBufferStreamTest, Seek_NonKeyframe) { 1900 TEST_F(SourceBufferStreamTest, Seek_NonKeyframe) {
1941 // Append 15 buffers at positions 0 through 14. 1901 // Append 15 buffers at positions 0 through 14.
1942 NewSegmentAppend(0, 15); 1902 NewCodedFrameGroupAppend(0, 15);
1943 1903
1944 // Seek to buffer at position 13. 1904 // Seek to buffer at position 13.
1945 Seek(13); 1905 Seek(13);
1946 1906
1947 // Expect seeking back to the nearest keyframe. 1907 // Expect seeking back to the nearest keyframe.
1948 CheckExpectedBuffers(10, 14, true); 1908 CheckExpectedBuffers(10, 14, true);
1949 1909
1950 // Seek to buffer at position 3. 1910 // Seek to buffer at position 3.
1951 Seek(3); 1911 Seek(3);
1952 1912
1953 // Expect seeking back to the nearest keyframe. 1913 // Expect seeking back to the nearest keyframe.
1954 CheckExpectedBuffers(0, 3, true); 1914 CheckExpectedBuffers(0, 3, true);
1955 } 1915 }
1956 1916
1957 TEST_F(SourceBufferStreamTest, Seek_NotBuffered) { 1917 TEST_F(SourceBufferStreamTest, Seek_NotBuffered) {
1958 // Seek to beginning. 1918 // Seek to beginning.
1959 Seek(0); 1919 Seek(0);
1960 1920
1961 // Try to get buffer; nothing's appended. 1921 // Try to get buffer; nothing's appended.
1962 CheckNoNextBuffer(); 1922 CheckNoNextBuffer();
1963 1923
1964 // Append 2 buffers at positions 0. 1924 // Append 2 buffers at positions 0.
1965 NewSegmentAppend(0, 2); 1925 NewCodedFrameGroupAppend(0, 2);
1966 Seek(0); 1926 Seek(0);
1967 CheckExpectedBuffers(0, 1); 1927 CheckExpectedBuffers(0, 1);
1968 1928
1969 // Try to get buffer out of range. 1929 // Try to get buffer out of range.
1970 Seek(2); 1930 Seek(2);
1971 CheckNoNextBuffer(); 1931 CheckNoNextBuffer();
1972 } 1932 }
1973 1933
1974 TEST_F(SourceBufferStreamTest, Seek_InBetweenTimestamps) { 1934 TEST_F(SourceBufferStreamTest, Seek_InBetweenTimestamps) {
1975 // Append 10 buffers at positions 0 through 9. 1935 // Append 10 buffers at positions 0 through 9.
1976 NewSegmentAppend(0, 10); 1936 NewCodedFrameGroupAppend(0, 10);
1977 1937
1978 base::TimeDelta bump = frame_duration() / 4; 1938 base::TimeDelta bump = frame_duration() / 4;
1979 CHECK(bump > base::TimeDelta()); 1939 CHECK(bump > base::TimeDelta());
1980 1940
1981 // Seek to buffer a little after position 5. 1941 // Seek to buffer a little after position 5.
1982 stream_->Seek(5 * frame_duration() + bump); 1942 stream_->Seek(5 * frame_duration() + bump);
1983 CheckExpectedBuffers(5, 5, true); 1943 CheckExpectedBuffers(5, 5, true);
1984 1944
1985 // Seek to buffer a little before position 5. 1945 // Seek to buffer a little before position 5.
1986 stream_->Seek(5 * frame_duration() - bump); 1946 stream_->Seek(5 * frame_duration() - bump);
1987 CheckExpectedBuffers(0, 0, true); 1947 CheckExpectedBuffers(0, 0, true);
1988 } 1948 }
1989 1949
1990 // This test will do a complete overlap of an existing range in order to add 1950 // This test will do a complete overlap of an existing range in order to add
1991 // buffers to the track buffers. Then the test does a seek to another part of 1951 // buffers to the track buffers. Then the test does a seek to another part of
1992 // the stream. The SourceBufferStream should clear its internal track buffer in 1952 // the stream. The SourceBufferStream should clear its internal track buffer in
1993 // response to the Seek(). 1953 // response to the Seek().
1994 TEST_F(SourceBufferStreamTest, Seek_After_TrackBuffer_Filled) { 1954 TEST_F(SourceBufferStreamTest, Seek_After_TrackBuffer_Filled) {
1995 // Append 10 buffers at positions 5 through 14. 1955 // Append 10 buffers at positions 5 through 14.
1996 NewSegmentAppend(5, 10, &kDataA); 1956 NewCodedFrameGroupAppend(5, 10, &kDataA);
1997 1957
1998 // Seek to buffer at position 5 and get next buffer. 1958 // Seek to buffer at position 5 and get next buffer.
1999 Seek(5); 1959 Seek(5);
2000 CheckExpectedBuffers(5, 5, &kDataA); 1960 CheckExpectedBuffers(5, 5, &kDataA);
2001 1961
2002 // Do a complete overlap by appending 20 buffers at positions 0 through 19. 1962 // Do a complete overlap by appending 20 buffers at positions 0 through 19.
2003 NewSegmentAppend(0, 20, &kDataB); 1963 NewCodedFrameGroupAppend(0, 20, &kDataB);
2004 1964
2005 // Check range is correct. 1965 // Check range is correct.
2006 CheckExpectedRanges("{ [0,19) }"); 1966 CheckExpectedRanges("{ [0,19) }");
2007 1967
2008 // Seek to beginning; all data should be new. 1968 // Seek to beginning; all data should be new.
2009 Seek(0); 1969 Seek(0);
2010 CheckExpectedBuffers(0, 19, &kDataB); 1970 CheckExpectedBuffers(0, 19, &kDataB);
2011 1971
2012 // Check range continues to be correct. 1972 // Check range continues to be correct.
2013 CheckExpectedRanges("{ [0,19) }"); 1973 CheckExpectedRanges("{ [0,19) }");
2014 } 1974 }
2015 1975
2016 TEST_F(SourceBufferStreamTest, Seek_StartOfSegment) { 1976 TEST_F(SourceBufferStreamTest, Seek_StartOfGroup) {
2017 base::TimeDelta bump = frame_duration() / 4; 1977 base::TimeDelta bump = frame_duration() / 4;
2018 CHECK(bump > base::TimeDelta()); 1978 CHECK(bump > base::TimeDelta());
2019 1979
2020 // Append 5 buffers at position (5 + |bump|) through 9, where the media 1980 // Append 5 buffers at position (5 + |bump|) through 9, where the coded frame
2021 // segment begins at position 5. 1981 // group begins at position 5.
2022 Seek(5); 1982 Seek(5);
2023 NewSegmentAppend_OffsetFirstBuffer(5, 5, bump); 1983 NewCodedFrameGroupAppend_OffsetFirstBuffer(5, 5, bump);
2024 scoped_refptr<StreamParserBuffer> buffer; 1984 scoped_refptr<StreamParserBuffer> buffer;
2025 1985
2026 // GetNextBuffer() should return the next buffer at position (5 + |bump|). 1986 // GetNextBuffer() should return the next buffer at position (5 + |bump|).
2027 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess); 1987 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess);
2028 EXPECT_EQ(buffer->GetDecodeTimestamp(), 1988 EXPECT_EQ(buffer->GetDecodeTimestamp(),
2029 DecodeTimestamp::FromPresentationTime(5 * frame_duration() + bump)); 1989 DecodeTimestamp::FromPresentationTime(5 * frame_duration() + bump));
2030 1990
2031 // Check rest of buffers. 1991 // Check rest of buffers.
2032 CheckExpectedBuffers(6, 9); 1992 CheckExpectedBuffers(6, 9);
2033 1993
2034 // Seek to position 15. 1994 // Seek to position 15.
2035 Seek(15); 1995 Seek(15);
2036 1996
2037 // Append 5 buffers at positions (15 + |bump|) through 19, where the media 1997 // Append 5 buffers at positions (15 + |bump|) through 19, where the coded
2038 // segment begins at 15. 1998 // frame group begins at 15.
2039 NewSegmentAppend_OffsetFirstBuffer(15, 5, bump); 1999 NewCodedFrameGroupAppend_OffsetFirstBuffer(15, 5, bump);
2040 2000
2041 // GetNextBuffer() should return the next buffer at position (15 + |bump|). 2001 // GetNextBuffer() should return the next buffer at position (15 + |bump|).
2042 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess); 2002 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess);
2043 EXPECT_EQ(buffer->GetDecodeTimestamp(), DecodeTimestamp::FromPresentationTime( 2003 EXPECT_EQ(buffer->GetDecodeTimestamp(), DecodeTimestamp::FromPresentationTime(
2044 15 * frame_duration() + bump)); 2004 15 * frame_duration() + bump));
2045 2005
2046 // Check rest of buffers. 2006 // Check rest of buffers.
2047 CheckExpectedBuffers(16, 19); 2007 CheckExpectedBuffers(16, 19);
2048 } 2008 }
2049 2009
2050 TEST_F(SourceBufferStreamTest, Seek_BeforeStartOfSegment) { 2010 TEST_F(SourceBufferStreamTest, Seek_BeforeStartOfGroup) {
2051 // Append 10 buffers at positions 5 through 14. 2011 // Append 10 buffers at positions 5 through 14.
2052 NewSegmentAppend(5, 10); 2012 NewCodedFrameGroupAppend(5, 10);
2053 2013
2054 // Seek to a time before the first buffer in the range. 2014 // Seek to a time before the first buffer in the range.
2055 Seek(0); 2015 Seek(0);
2056 2016
2057 // Should return buffers from the beginning of the range. 2017 // Should return buffers from the beginning of the range.
2058 CheckExpectedBuffers(5, 14); 2018 CheckExpectedBuffers(5, 14);
2059 } 2019 }
2060 2020
2061 TEST_F(SourceBufferStreamTest, OldSeekPoint_CompleteOverlap) { 2021 TEST_F(SourceBufferStreamTest, OldSeekPoint_CompleteOverlap) {
2062 // Append 5 buffers at positions 0 through 4. 2022 // Append 5 buffers at positions 0 through 4.
2063 NewSegmentAppend(0, 4); 2023 NewCodedFrameGroupAppend(0, 4);
2064 2024
2065 // Append 5 buffers at positions 10 through 14, and seek to the beginning of 2025 // Append 5 buffers at positions 10 through 14, and seek to the beginning of
2066 // this range. 2026 // this range.
2067 NewSegmentAppend(10, 5); 2027 NewCodedFrameGroupAppend(10, 5);
2068 Seek(10); 2028 Seek(10);
2069 2029
2070 // Now seek to the beginning of the first range. 2030 // Now seek to the beginning of the first range.
2071 Seek(0); 2031 Seek(0);
2072 2032
2073 // Completely overlap the old seek point. 2033 // Completely overlap the old seek point.
2074 NewSegmentAppend(5, 15); 2034 NewCodedFrameGroupAppend(5, 15);
2075 2035
2076 // The GetNextBuffer() call should respect the 2nd seek point. 2036 // The GetNextBuffer() call should respect the 2nd seek point.
2077 CheckExpectedBuffers(0, 0); 2037 CheckExpectedBuffers(0, 0);
2078 } 2038 }
2079 2039
2080 TEST_F(SourceBufferStreamTest, OldSeekPoint_CompleteOverlap_Pending) { 2040 TEST_F(SourceBufferStreamTest, OldSeekPoint_CompleteOverlap_Pending) {
2081 // Append 2 buffers at positions 0 through 1. 2041 // Append 2 buffers at positions 0 through 1.
2082 NewSegmentAppend(0, 2); 2042 NewCodedFrameGroupAppend(0, 2);
2083 2043
2084 // Append 5 buffers at positions 15 through 19 and seek to beginning of the 2044 // Append 5 buffers at positions 15 through 19 and seek to beginning of the
2085 // range. 2045 // range.
2086 NewSegmentAppend(15, 5); 2046 NewCodedFrameGroupAppend(15, 5);
2087 Seek(15); 2047 Seek(15);
2088 2048
2089 // Now seek position 5. 2049 // Now seek position 5.
2090 Seek(5); 2050 Seek(5);
2091 2051
2092 // Completely overlap the old seek point. 2052 // Completely overlap the old seek point.
2093 NewSegmentAppend(10, 15); 2053 NewCodedFrameGroupAppend(10, 15);
2094 2054
2095 // The seek at position 5 should still be pending. 2055 // The seek at position 5 should still be pending.
2096 CheckNoNextBuffer(); 2056 CheckNoNextBuffer();
2097 } 2057 }
2098 2058
2099 TEST_F(SourceBufferStreamTest, OldSeekPoint_MiddleOverlap) { 2059 TEST_F(SourceBufferStreamTest, OldSeekPoint_MiddleOverlap) {
2100 // Append 2 buffers at positions 0 through 1. 2060 // Append 2 buffers at positions 0 through 1.
2101 NewSegmentAppend(0, 2); 2061 NewCodedFrameGroupAppend(0, 2);
2102 2062
2103 // Append 15 buffers at positions 5 through 19 and seek to position 15. 2063 // Append 15 buffers at positions 5 through 19 and seek to position 15.
2104 NewSegmentAppend(5, 15); 2064 NewCodedFrameGroupAppend(5, 15);
2105 Seek(15); 2065 Seek(15);
2106 2066
2107 // Now seek to the beginning of the stream. 2067 // Now seek to the beginning of the stream.
2108 Seek(0); 2068 Seek(0);
2109 2069
2110 // Overlap the middle of the range such that there are now three ranges. 2070 // Overlap the middle of the range such that there are now three ranges.
2111 NewSegmentAppend(10, 3); 2071 NewCodedFrameGroupAppend(10, 3);
2112 CheckExpectedRanges("{ [0,1) [5,12) [15,19) }"); 2072 CheckExpectedRanges("{ [0,1) [5,12) [15,19) }");
2113 2073
2114 // The GetNextBuffer() call should respect the 2nd seek point. 2074 // The GetNextBuffer() call should respect the 2nd seek point.
2115 CheckExpectedBuffers(0, 0); 2075 CheckExpectedBuffers(0, 0);
2116 } 2076 }
2117 2077
2118 TEST_F(SourceBufferStreamTest, OldSeekPoint_MiddleOverlap_Pending) { 2078 TEST_F(SourceBufferStreamTest, OldSeekPoint_MiddleOverlap_Pending) {
2119 // Append 2 buffers at positions 0 through 1. 2079 // Append 2 buffers at positions 0 through 1.
2120 NewSegmentAppend(0, 2); 2080 NewCodedFrameGroupAppend(0, 2);
2121 2081
2122 // Append 15 buffers at positions 10 through 24 and seek to position 20. 2082 // Append 15 buffers at positions 10 through 24 and seek to position 20.
2123 NewSegmentAppend(10, 15); 2083 NewCodedFrameGroupAppend(10, 15);
2124 Seek(20); 2084 Seek(20);
2125 2085
2126 // Now seek to position 5. 2086 // Now seek to position 5.
2127 Seek(5); 2087 Seek(5);
2128 2088
2129 // Overlap the middle of the range such that it is now split into two ranges. 2089 // Overlap the middle of the range such that it is now split into two ranges.
2130 NewSegmentAppend(15, 3); 2090 NewCodedFrameGroupAppend(15, 3);
2131 CheckExpectedRanges("{ [0,1) [10,17) [20,24) }"); 2091 CheckExpectedRanges("{ [0,1) [10,17) [20,24) }");
2132 2092
2133 // The seek at position 5 should still be pending. 2093 // The seek at position 5 should still be pending.
2134 CheckNoNextBuffer(); 2094 CheckNoNextBuffer();
2135 } 2095 }
2136 2096
2137 TEST_F(SourceBufferStreamTest, OldSeekPoint_StartOverlap) { 2097 TEST_F(SourceBufferStreamTest, OldSeekPoint_StartOverlap) {
2138 // Append 2 buffers at positions 0 through 1. 2098 // Append 2 buffers at positions 0 through 1.
2139 NewSegmentAppend(0, 2); 2099 NewCodedFrameGroupAppend(0, 2);
2140 2100
2141 // Append 15 buffers at positions 5 through 19 and seek to position 15. 2101 // Append 15 buffers at positions 5 through 19 and seek to position 15.
2142 NewSegmentAppend(5, 15); 2102 NewCodedFrameGroupAppend(5, 15);
2143 Seek(15); 2103 Seek(15);
2144 2104
2145 // Now seek to the beginning of the stream. 2105 // Now seek to the beginning of the stream.
2146 Seek(0); 2106 Seek(0);
2147 2107
2148 // Start overlap the old seek point. 2108 // Start overlap the old seek point.
2149 NewSegmentAppend(10, 10); 2109 NewCodedFrameGroupAppend(10, 10);
2150 2110
2151 // The GetNextBuffer() call should respect the 2nd seek point. 2111 // The GetNextBuffer() call should respect the 2nd seek point.
2152 CheckExpectedBuffers(0, 0); 2112 CheckExpectedBuffers(0, 0);
2153 } 2113 }
2154 2114
2155 TEST_F(SourceBufferStreamTest, OldSeekPoint_StartOverlap_Pending) { 2115 TEST_F(SourceBufferStreamTest, OldSeekPoint_StartOverlap_Pending) {
2156 // Append 2 buffers at positions 0 through 1. 2116 // Append 2 buffers at positions 0 through 1.
2157 NewSegmentAppend(0, 2); 2117 NewCodedFrameGroupAppend(0, 2);
2158 2118
2159 // Append 15 buffers at positions 10 through 24 and seek to position 20. 2119 // Append 15 buffers at positions 10 through 24 and seek to position 20.
2160 NewSegmentAppend(10, 15); 2120 NewCodedFrameGroupAppend(10, 15);
2161 Seek(20); 2121 Seek(20);
2162 2122
2163 // Now seek to position 5. 2123 // Now seek to position 5.
2164 Seek(5); 2124 Seek(5);
2165 2125
2166 // Start overlap the old seek point. 2126 // Start overlap the old seek point.
2167 NewSegmentAppend(15, 10); 2127 NewCodedFrameGroupAppend(15, 10);
2168 2128
2169 // The seek at time 0 should still be pending. 2129 // The seek at time 0 should still be pending.
2170 CheckNoNextBuffer(); 2130 CheckNoNextBuffer();
2171 } 2131 }
2172 2132
2173 TEST_F(SourceBufferStreamTest, OldSeekPoint_EndOverlap) { 2133 TEST_F(SourceBufferStreamTest, OldSeekPoint_EndOverlap) {
2174 // Append 5 buffers at positions 0 through 4. 2134 // Append 5 buffers at positions 0 through 4.
2175 NewSegmentAppend(0, 4); 2135 NewCodedFrameGroupAppend(0, 4);
2176 2136
2177 // Append 15 buffers at positions 10 through 24 and seek to start of range. 2137 // Append 15 buffers at positions 10 through 24 and seek to start of range.
2178 NewSegmentAppend(10, 15); 2138 NewCodedFrameGroupAppend(10, 15);
2179 Seek(10); 2139 Seek(10);
2180 2140
2181 // Now seek to the beginning of the stream. 2141 // Now seek to the beginning of the stream.
2182 Seek(0); 2142 Seek(0);
2183 2143
2184 // End overlap the old seek point. 2144 // End overlap the old seek point.
2185 NewSegmentAppend(5, 10); 2145 NewCodedFrameGroupAppend(5, 10);
2186 2146
2187 // The GetNextBuffer() call should respect the 2nd seek point. 2147 // The GetNextBuffer() call should respect the 2nd seek point.
2188 CheckExpectedBuffers(0, 0); 2148 CheckExpectedBuffers(0, 0);
2189 } 2149 }
2190 2150
2191 TEST_F(SourceBufferStreamTest, OldSeekPoint_EndOverlap_Pending) { 2151 TEST_F(SourceBufferStreamTest, OldSeekPoint_EndOverlap_Pending) {
2192 // Append 2 buffers at positions 0 through 1. 2152 // Append 2 buffers at positions 0 through 1.
2193 NewSegmentAppend(0, 2); 2153 NewCodedFrameGroupAppend(0, 2);
2194 2154
2195 // Append 15 buffers at positions 15 through 29 and seek to start of range. 2155 // Append 15 buffers at positions 15 through 29 and seek to start of range.
2196 NewSegmentAppend(15, 15); 2156 NewCodedFrameGroupAppend(15, 15);
2197 Seek(15); 2157 Seek(15);
2198 2158
2199 // Now seek to position 5 2159 // Now seek to position 5
2200 Seek(5); 2160 Seek(5);
2201 2161
2202 // End overlap the old seek point. 2162 // End overlap the old seek point.
2203 NewSegmentAppend(10, 10); 2163 NewCodedFrameGroupAppend(10, 10);
2204 2164
2205 // The seek at time 0 should still be pending. 2165 // The seek at time 0 should still be pending.
2206 CheckNoNextBuffer(); 2166 CheckNoNextBuffer();
2207 } 2167 }
2208 2168
2209 TEST_F(SourceBufferStreamTest, GetNextBuffer_AfterMerges) { 2169 TEST_F(SourceBufferStreamTest, GetNextBuffer_AfterMerges) {
2210 // Append 5 buffers at positions 10 through 14. 2170 // Append 5 buffers at positions 10 through 14.
2211 NewSegmentAppend(10, 5); 2171 NewCodedFrameGroupAppend(10, 5);
2212 2172
2213 // Seek to buffer at position 12. 2173 // Seek to buffer at position 12.
2214 Seek(12); 2174 Seek(12);
2215 2175
2216 // Append 5 buffers at positions 5 through 9. 2176 // Append 5 buffers at positions 5 through 9.
2217 NewSegmentAppend(5, 5); 2177 NewCodedFrameGroupAppend(5, 5);
2218 2178
2219 // Make sure ranges are merged. 2179 // Make sure ranges are merged.
2220 CheckExpectedRanges("{ [5,14) }"); 2180 CheckExpectedRanges("{ [5,14) }");
2221 2181
2222 // Make sure the next buffer is correct. 2182 // Make sure the next buffer is correct.
2223 CheckExpectedBuffers(10, 10); 2183 CheckExpectedBuffers(10, 10);
2224 2184
2225 // Append 5 buffers at positions 15 through 19. 2185 // Append 5 buffers at positions 15 through 19.
2226 NewSegmentAppend(15, 5); 2186 NewCodedFrameGroupAppend(15, 5);
2227 CheckExpectedRanges("{ [5,19) }"); 2187 CheckExpectedRanges("{ [5,19) }");
2228 2188
2229 // Make sure the remaining next buffers are correct. 2189 // Make sure the remaining next buffers are correct.
2230 CheckExpectedBuffers(11, 14); 2190 CheckExpectedBuffers(11, 14);
2231 } 2191 }
2232 2192
2233 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenAppend) { 2193 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenAppend) {
2234 // Append 4 buffers at positions 0 through 3. 2194 // Append 4 buffers at positions 0 through 3.
2235 NewSegmentAppend(0, 4); 2195 NewCodedFrameGroupAppend(0, 4);
2236 2196
2237 // Seek to buffer at position 0 and get all buffers. 2197 // Seek to buffer at position 0 and get all buffers.
2238 Seek(0); 2198 Seek(0);
2239 CheckExpectedBuffers(0, 3); 2199 CheckExpectedBuffers(0, 3);
2240 2200
2241 // Next buffer is at position 4, so should not be able to fulfill request. 2201 // Next buffer is at position 4, so should not be able to fulfill request.
2242 CheckNoNextBuffer(); 2202 CheckNoNextBuffer();
2243 2203
2244 // Append 2 buffers at positions 4 through 5. 2204 // Append 2 buffers at positions 4 through 5.
2245 AppendBuffers(4, 2); 2205 AppendBuffers(4, 2);
2246 CheckExpectedBuffers(4, 5); 2206 CheckExpectedBuffers(4, 5);
2247 } 2207 }
2248 2208
2249 // This test covers the case where new buffers start-overlap a range whose next 2209 // This test covers the case where new buffers start-overlap a range whose next
2250 // buffer is not buffered. 2210 // buffer is not buffered.
2251 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenStartOverlap) { 2211 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenStartOverlap) {
2252 // Append 10 buffers at positions 0 through 9 and exhaust the buffers. 2212 // Append 10 buffers at positions 0 through 9 and exhaust the buffers.
2253 NewSegmentAppend(0, 10, &kDataA); 2213 NewCodedFrameGroupAppend(0, 10, &kDataA);
2254 Seek(0); 2214 Seek(0);
2255 CheckExpectedBuffers(0, 9, &kDataA); 2215 CheckExpectedBuffers(0, 9, &kDataA);
2256 2216
2257 // Next buffer is at position 10, so should not be able to fulfill request. 2217 // Next buffer is at position 10, so should not be able to fulfill request.
2258 CheckNoNextBuffer(); 2218 CheckNoNextBuffer();
2259 2219
2260 // Append 6 buffers at positons 5 through 10. This is to test that doing a 2220 // Append 6 buffers at positons 5 through 10. This is to test that doing a
2261 // start-overlap successfully fulfills the read at position 10, even though 2221 // start-overlap successfully fulfills the read at position 10, even though
2262 // position 10 was unbuffered. 2222 // position 10 was unbuffered.
2263 NewSegmentAppend(5, 6, &kDataB); 2223 NewCodedFrameGroupAppend(5, 6, &kDataB);
2264 CheckExpectedBuffers(10, 10, &kDataB); 2224 CheckExpectedBuffers(10, 10, &kDataB);
2265 2225
2266 // Then add 5 buffers from positions 11 though 15. 2226 // Then add 5 buffers from positions 11 though 15.
2267 AppendBuffers(11, 5, &kDataB); 2227 AppendBuffers(11, 5, &kDataB);
2268 2228
2269 // Check the next 4 buffers are correct, which also effectively seeks to 2229 // Check the next 4 buffers are correct, which also effectively seeks to
2270 // position 15. 2230 // position 15.
2271 CheckExpectedBuffers(11, 14, &kDataB); 2231 CheckExpectedBuffers(11, 14, &kDataB);
2272 2232
2273 // Replace the next buffer at position 15 with another start overlap. 2233 // Replace the next buffer at position 15 with another start overlap.
2274 NewSegmentAppend(15, 2, &kDataA); 2234 NewCodedFrameGroupAppend(15, 2, &kDataA);
2275 CheckExpectedBuffers(15, 16, &kDataA); 2235 CheckExpectedBuffers(15, 16, &kDataA);
2276 } 2236 }
2277 2237
2278 // Tests a start overlap that occurs right at the timestamp of the last output 2238 // Tests a start overlap that occurs right at the timestamp of the last output
2279 // buffer that was returned by GetNextBuffer(). This test verifies that 2239 // buffer that was returned by GetNextBuffer(). This test verifies that
2280 // GetNextBuffer() skips to second GOP in the newly appended data instead 2240 // GetNextBuffer() skips to second GOP in the newly appended data instead
2281 // of returning two buffers with the same timestamp. 2241 // of returning two buffers with the same timestamp.
2282 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenStartOverlap2) { 2242 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenStartOverlap2) {
2283 NewSegmentAppend("0K 30 60 90 120"); 2243 NewCodedFrameGroupAppend("0K 30 60 90 120");
2284 2244
2285 Seek(0); 2245 Seek(0);
2286 CheckExpectedBuffers("0K 30 60 90 120"); 2246 CheckExpectedBuffers("0K 30 60 90 120");
2287 CheckNoNextBuffer(); 2247 CheckNoNextBuffer();
2288 2248
2289 // Append a keyframe with the same timestamp as the last buffer output. 2249 // Append a keyframe with the same timestamp as the last buffer output.
2290 NewSegmentAppend("120D30K"); 2250 NewCodedFrameGroupAppend("120D30K");
2291 CheckNoNextBuffer(); 2251 CheckNoNextBuffer();
2292 2252
2293 // Append the rest of the segment and make sure that buffers are returned 2253 // Append the rest of the coded frame group and make sure that buffers are
2294 // from the first GOP after 120. 2254 // returned from the first GOP after 120.
2295 AppendBuffers("150 180 210K 240"); 2255 AppendBuffers("150 180 210K 240");
2296 CheckExpectedBuffers("210K 240"); 2256 CheckExpectedBuffers("210K 240");
2297 2257
2298 // Seek to the beginning and verify the contents of the source buffer. 2258 // Seek to the beginning and verify the contents of the source buffer.
2299 Seek(0); 2259 Seek(0);
2300 CheckExpectedBuffers("0K 30 60 90 120K 150 180 210K 240"); 2260 CheckExpectedBuffers("0K 30 60 90 120K 150 180 210K 240");
2301 CheckNoNextBuffer(); 2261 CheckNoNextBuffer();
2302 } 2262 }
2303 2263
2304 // This test covers the case where new buffers completely overlap a range 2264 // This test covers the case where new buffers completely overlap a range
2305 // whose next buffer is not buffered. 2265 // whose next buffer is not buffered.
2306 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenCompleteOverlap) { 2266 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenCompleteOverlap) {
2307 // Append 5 buffers at positions 10 through 14 and exhaust the buffers. 2267 // Append 5 buffers at positions 10 through 14 and exhaust the buffers.
2308 NewSegmentAppend(10, 5, &kDataA); 2268 NewCodedFrameGroupAppend(10, 5, &kDataA);
2309 Seek(10); 2269 Seek(10);
2310 CheckExpectedBuffers(10, 14, &kDataA); 2270 CheckExpectedBuffers(10, 14, &kDataA);
2311 2271
2312 // Next buffer is at position 15, so should not be able to fulfill request. 2272 // Next buffer is at position 15, so should not be able to fulfill request.
2313 CheckNoNextBuffer(); 2273 CheckNoNextBuffer();
2314 2274
2315 // Do a complete overlap and test that this successfully fulfills the read 2275 // Do a complete overlap and test that this successfully fulfills the read
2316 // at position 15. 2276 // at position 15.
2317 NewSegmentAppend(5, 11, &kDataB); 2277 NewCodedFrameGroupAppend(5, 11, &kDataB);
2318 CheckExpectedBuffers(15, 15, &kDataB); 2278 CheckExpectedBuffers(15, 15, &kDataB);
2319 2279
2320 // Then add 5 buffers from positions 16 though 20. 2280 // Then add 5 buffers from positions 16 though 20.
2321 AppendBuffers(16, 5, &kDataB); 2281 AppendBuffers(16, 5, &kDataB);
2322 2282
2323 // Check the next 4 buffers are correct, which also effectively seeks to 2283 // Check the next 4 buffers are correct, which also effectively seeks to
2324 // position 20. 2284 // position 20.
2325 CheckExpectedBuffers(16, 19, &kDataB); 2285 CheckExpectedBuffers(16, 19, &kDataB);
2326 2286
2327 // Do a complete overlap and replace the buffer at position 20. 2287 // Do a complete overlap and replace the buffer at position 20.
2328 NewSegmentAppend(0, 21, &kDataA); 2288 NewCodedFrameGroupAppend(0, 21, &kDataA);
2329 CheckExpectedBuffers(20, 20, &kDataA); 2289 CheckExpectedBuffers(20, 20, &kDataA);
2330 } 2290 }
2331 2291
2332 // This test covers the case where a range is stalled waiting for its next 2292 // This test covers the case where a range is stalled waiting for its next
2333 // buffer, then an end-overlap causes the end of the range to be deleted. 2293 // buffer, then an end-overlap causes the end of the range to be deleted.
2334 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenEndOverlap) { 2294 TEST_F(SourceBufferStreamTest, GetNextBuffer_ExhaustThenEndOverlap) {
2335 // Append 5 buffers at positions 10 through 14 and exhaust the buffers. 2295 // Append 5 buffers at positions 10 through 14 and exhaust the buffers.
2336 NewSegmentAppend(10, 5, &kDataA); 2296 NewCodedFrameGroupAppend(10, 5, &kDataA);
2337 Seek(10); 2297 Seek(10);
2338 CheckExpectedBuffers(10, 14, &kDataA); 2298 CheckExpectedBuffers(10, 14, &kDataA);
2339 CheckExpectedRanges("{ [10,14) }"); 2299 CheckExpectedRanges("{ [10,14) }");
2340 2300
2341 // Next buffer is at position 15, so should not be able to fulfill request. 2301 // Next buffer is at position 15, so should not be able to fulfill request.
2342 CheckNoNextBuffer(); 2302 CheckNoNextBuffer();
2343 2303
2344 // Do an end overlap that causes the latter half of the range to be deleted. 2304 // Do an end overlap that causes the latter half of the range to be deleted.
2345 NewSegmentAppend(5, 6, &kDataB); 2305 NewCodedFrameGroupAppend(5, 6, &kDataB);
2346 CheckNoNextBuffer(); 2306 CheckNoNextBuffer();
2347 CheckExpectedRanges("{ [5,10) }"); 2307 CheckExpectedRanges("{ [5,10) }");
2348 2308
2349 // Fill in the gap. Getting the next buffer should still stall at position 15. 2309 // Fill in the gap. Getting the next buffer should still stall at position 15.
2350 for (int i = 11; i <= 14; i++) { 2310 for (int i = 11; i <= 14; i++) {
2351 AppendBuffers(i, 1, &kDataB); 2311 AppendBuffers(i, 1, &kDataB);
2352 CheckNoNextBuffer(); 2312 CheckNoNextBuffer();
2353 } 2313 }
2354 2314
2355 // Append the buffer at position 15 and check to make sure all is correct. 2315 // Append the buffer at position 15 and check to make sure all is correct.
2356 AppendBuffers(15, 1); 2316 AppendBuffers(15, 1);
2357 CheckExpectedBuffers(15, 15); 2317 CheckExpectedBuffers(15, 15);
2358 CheckExpectedRanges("{ [5,15) }"); 2318 CheckExpectedRanges("{ [5,15) }");
2359 } 2319 }
2360 2320
2361 // This test is testing the "next buffer" logic after a complete overlap. In 2321 // This test is testing the "next buffer" logic after a complete overlap. In
2362 // this scenario, when the track buffer is exhausted, there is no buffered data 2322 // this scenario, when the track buffer is exhausted, there is no buffered data
2363 // to fulfill the request. The SourceBufferStream should be able to fulfill the 2323 // to fulfill the request. The SourceBufferStream should be able to fulfill the
2364 // request when the data is later appended, and should not lose track of the 2324 // request when the data is later appended, and should not lose track of the
2365 // "next buffer" position. 2325 // "next buffer" position.
2366 TEST_F(SourceBufferStreamTest, GetNextBuffer_Overlap_Selected_Complete) { 2326 TEST_F(SourceBufferStreamTest, GetNextBuffer_Overlap_Selected_Complete) {
2367 // Append 5 buffers at positions 5 through 9. 2327 // Append 5 buffers at positions 5 through 9.
2368 NewSegmentAppend(5, 5, &kDataA); 2328 NewCodedFrameGroupAppend(5, 5, &kDataA);
2369 2329
2370 // Seek to buffer at position 5 and get next buffer. 2330 // Seek to buffer at position 5 and get next buffer.
2371 Seek(5); 2331 Seek(5);
2372 CheckExpectedBuffers(5, 5, &kDataA); 2332 CheckExpectedBuffers(5, 5, &kDataA);
2373 2333
2374 // Replace existing data with new data. 2334 // Replace existing data with new data.
2375 NewSegmentAppend(5, 5, &kDataB); 2335 NewCodedFrameGroupAppend(5, 5, &kDataB);
2376 2336
2377 // Expect old data up until next keyframe in new data. 2337 // Expect old data up until next keyframe in new data.
2378 CheckExpectedBuffers(6, 9, &kDataA); 2338 CheckExpectedBuffers(6, 9, &kDataA);
2379 2339
2380 // Next buffer is at position 10, so should not be able to fulfill the 2340 // Next buffer is at position 10, so should not be able to fulfill the
2381 // request. 2341 // request.
2382 CheckNoNextBuffer(); 2342 CheckNoNextBuffer();
2383 2343
2384 // Now add 5 new buffers at positions 10 through 14. 2344 // Now add 5 new buffers at positions 10 through 14.
2385 AppendBuffers(10, 5, &kDataB); 2345 AppendBuffers(10, 5, &kDataB);
2386 CheckExpectedBuffers(10, 14, &kDataB); 2346 CheckExpectedBuffers(10, 14, &kDataB);
2387 } 2347 }
2388 2348
2389 TEST_F(SourceBufferStreamTest, PresentationTimestampIndependence) { 2349 TEST_F(SourceBufferStreamTest, PresentationTimestampIndependence) {
2390 // Append 20 buffers at position 0. 2350 // Append 20 buffers at position 0.
2391 NewSegmentAppend(0, 20); 2351 NewCodedFrameGroupAppend(0, 20);
2392 Seek(0); 2352 Seek(0);
2393 2353
2394 int last_keyframe_idx = -1; 2354 int last_keyframe_idx = -1;
2395 base::TimeDelta last_keyframe_presentation_timestamp; 2355 base::TimeDelta last_keyframe_presentation_timestamp;
2396 base::TimeDelta last_p_frame_presentation_timestamp; 2356 base::TimeDelta last_p_frame_presentation_timestamp;
2397 2357
2398 // Check for IBB...BBP pattern. 2358 // Check for IBB...BBP pattern.
2399 for (int i = 0; i < 20; i++) { 2359 for (int i = 0; i < 20; i++) {
2400 scoped_refptr<StreamParserBuffer> buffer; 2360 scoped_refptr<StreamParserBuffer> buffer;
2401 ASSERT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess); 2361 ASSERT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess);
(...skipping 15 matching lines...) Expand all
2417 buffer->GetDecodeTimestamp()); 2377 buffer->GetDecodeTimestamp());
2418 } 2378 }
2419 } 2379 }
2420 } 2380 }
2421 2381
2422 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteFront) { 2382 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteFront) {
2423 // Set memory limit to 20 buffers. 2383 // Set memory limit to 20 buffers.
2424 SetMemoryLimit(20); 2384 SetMemoryLimit(20);
2425 2385
2426 // Append 20 buffers at positions 0 through 19. 2386 // Append 20 buffers at positions 0 through 19.
2427 NewSegmentAppend(0, 1, &kDataA); 2387 NewCodedFrameGroupAppend(0, 1, &kDataA);
2428 for (int i = 1; i < 20; i++) 2388 for (int i = 1; i < 20; i++)
2429 AppendBuffers(i, 1, &kDataA); 2389 AppendBuffers(i, 1, &kDataA);
2430 2390
2431 // GC should be a no-op, since we are just under memory limit. 2391 // GC should be a no-op, since we are just under memory limit.
2432 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2392 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2433 CheckExpectedRanges("{ [0,19) }"); 2393 CheckExpectedRanges("{ [0,19) }");
2434 Seek(0); 2394 Seek(0);
2435 CheckExpectedBuffers(0, 19, &kDataA); 2395 CheckExpectedBuffers(0, 19, &kDataA);
2436 2396
2437 // Seek to the middle of the stream. 2397 // Seek to the middle of the stream.
(...skipping 11 matching lines...) Expand all
2449 CheckExpectedBuffers(10, 24, &kDataA); 2409 CheckExpectedBuffers(10, 24, &kDataA);
2450 Seek(5); 2410 Seek(5);
2451 CheckExpectedBuffers(5, 9, &kDataA); 2411 CheckExpectedBuffers(5, 9, &kDataA);
2452 } 2412 }
2453 2413
2454 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteFrontGOPsAtATime) { 2414 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteFrontGOPsAtATime) {
2455 // Set memory limit to 20 buffers. 2415 // Set memory limit to 20 buffers.
2456 SetMemoryLimit(20); 2416 SetMemoryLimit(20);
2457 2417
2458 // Append 20 buffers at positions 0 through 19. 2418 // Append 20 buffers at positions 0 through 19.
2459 NewSegmentAppend(0, 20, &kDataA); 2419 NewCodedFrameGroupAppend(0, 20, &kDataA);
2460 2420
2461 // Seek to position 10. 2421 // Seek to position 10.
2462 Seek(10); 2422 Seek(10);
2463 CheckExpectedRanges("{ [0,19) }"); 2423 CheckExpectedRanges("{ [0,19) }");
2464 2424
2465 // Add one buffer to put the memory over the cap. 2425 // Add one buffer to put the memory over the cap.
2466 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(10, 1)); 2426 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(10, 1));
2467 AppendBuffers(20, 1, &kDataA); 2427 AppendBuffers(20, 1, &kDataA);
2468 2428
2469 // GC should have deleted the first 5 buffers so that the range still begins 2429 // GC should have deleted the first 5 buffers so that the range still begins
2470 // with a keyframe. 2430 // with a keyframe.
2471 CheckExpectedRanges("{ [5,20) }"); 2431 CheckExpectedRanges("{ [5,20) }");
2472 CheckExpectedBuffers(10, 20, &kDataA); 2432 CheckExpectedBuffers(10, 20, &kDataA);
2473 Seek(5); 2433 Seek(5);
2474 CheckExpectedBuffers(5, 9, &kDataA); 2434 CheckExpectedBuffers(5, 9, &kDataA);
2475 } 2435 }
2476 2436
2477 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteBack) { 2437 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteBack) {
2478 // Set memory limit to 5 buffers. 2438 // Set memory limit to 5 buffers.
2479 SetMemoryLimit(5); 2439 SetMemoryLimit(5);
2480 2440
2481 // Append 5 buffers at positions 15 through 19. 2441 // Append 5 buffers at positions 15 through 19.
2482 NewSegmentAppend(15, 5, &kDataA); 2442 NewCodedFrameGroupAppend(15, 5, &kDataA);
2483 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2443 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2484 2444
2485 // Append 5 buffers at positions 0 through 4. 2445 // Append 5 buffers at positions 0 through 4.
2486 NewSegmentAppend(0, 5, &kDataA); 2446 NewCodedFrameGroupAppend(0, 5, &kDataA);
2487 CheckExpectedRanges("{ [0,4) [15,19) }"); 2447 CheckExpectedRanges("{ [0,4) [15,19) }");
2488 2448
2489 // Seek to position 0. 2449 // Seek to position 0.
2490 Seek(0); 2450 Seek(0);
2491 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2451 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2492 // Should leave the first 5 buffers from 0 to 4. 2452 // Should leave the first 5 buffers from 0 to 4.
2493 CheckExpectedRanges("{ [0,4) }"); 2453 CheckExpectedRanges("{ [0,4) }");
2494 CheckExpectedBuffers(0, 4, &kDataA); 2454 CheckExpectedBuffers(0, 4, &kDataA);
2495 } 2455 }
2496 2456
2497 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteFrontAndBack) { 2457 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteFrontAndBack) {
2498 // Set memory limit to 3 buffers. 2458 // Set memory limit to 3 buffers.
2499 SetMemoryLimit(3); 2459 SetMemoryLimit(3);
2500 2460
2501 // Seek to position 15. 2461 // Seek to position 15.
2502 Seek(15); 2462 Seek(15);
2503 2463
2504 // Append 40 buffers at positions 0 through 39. 2464 // Append 40 buffers at positions 0 through 39.
2505 NewSegmentAppend(0, 40, &kDataA); 2465 NewCodedFrameGroupAppend(0, 40, &kDataA);
2506 // GC will try to keep data between current playback position and last append 2466 // GC will try to keep data between current playback position and last append
2507 // position. This will ensure that the last append position is 19 and will 2467 // position. This will ensure that the last append position is 19 and will
2508 // allow GC algorithm to collect data outside of the range [15,19) 2468 // allow GC algorithm to collect data outside of the range [15,19)
2509 NewSegmentAppend(15, 5, &kDataA); 2469 NewCodedFrameGroupAppend(15, 5, &kDataA);
2510 CheckExpectedRanges("{ [0,39) }"); 2470 CheckExpectedRanges("{ [0,39) }");
2511 2471
2512 // Should leave the GOP containing the current playback position 15 and the 2472 // Should leave the GOP containing the current playback position 15 and the
2513 // last append position 19. GC returns false, since we are still above limit. 2473 // last append position 19. GC returns false, since we are still above limit.
2514 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(15, 0)); 2474 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(15, 0));
2515 CheckExpectedRanges("{ [15,19) }"); 2475 CheckExpectedRanges("{ [15,19) }");
2516 CheckExpectedBuffers(15, 19, &kDataA); 2476 CheckExpectedBuffers(15, 19, &kDataA);
2517 CheckNoNextBuffer(); 2477 CheckNoNextBuffer();
2518 } 2478 }
2519 2479
2520 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteSeveralRanges) { 2480 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteSeveralRanges) {
2521 // Append 5 buffers at positions 0 through 4. 2481 // Append 5 buffers at positions 0 through 4.
2522 NewSegmentAppend(0, 5); 2482 NewCodedFrameGroupAppend(0, 5);
2523 2483
2524 // Append 5 buffers at positions 10 through 14. 2484 // Append 5 buffers at positions 10 through 14.
2525 NewSegmentAppend(10, 5); 2485 NewCodedFrameGroupAppend(10, 5);
2526 2486
2527 // Append 5 buffers at positions 20 through 24. 2487 // Append 5 buffers at positions 20 through 24.
2528 NewSegmentAppend(20, 5); 2488 NewCodedFrameGroupAppend(20, 5);
2529 2489
2530 // Append 5 buffers at positions 40 through 44. 2490 // Append 5 buffers at positions 40 through 44.
2531 NewSegmentAppend(40, 5); 2491 NewCodedFrameGroupAppend(40, 5);
2532 2492
2533 CheckExpectedRanges("{ [0,4) [10,14) [20,24) [40,44) }"); 2493 CheckExpectedRanges("{ [0,4) [10,14) [20,24) [40,44) }");
2534 2494
2535 // Seek to position 20. 2495 // Seek to position 20.
2536 Seek(20); 2496 Seek(20);
2537 CheckExpectedBuffers(20, 20); 2497 CheckExpectedBuffers(20, 20);
2538 2498
2539 // Set memory limit to 1 buffer. 2499 // Set memory limit to 1 buffer.
2540 SetMemoryLimit(1); 2500 SetMemoryLimit(1);
2541 2501
2542 // Append 5 buffers at positions 30 through 34. 2502 // Append 5 buffers at positions 30 through 34.
2543 NewSegmentAppend(30, 5); 2503 NewCodedFrameGroupAppend(30, 5);
2544 2504
2545 // We will have more than 1 buffer left, GC will fail 2505 // We will have more than 1 buffer left, GC will fail
2546 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(20, 0)); 2506 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(20, 0));
2547 2507
2548 // Should have deleted all buffer ranges before the current buffer and after 2508 // Should have deleted all buffer ranges before the current buffer and after
2549 // last GOP 2509 // last GOP
2550 CheckExpectedRanges("{ [20,24) [30,34) }"); 2510 CheckExpectedRanges("{ [20,24) [30,34) }");
2551 CheckExpectedBuffers(21, 24); 2511 CheckExpectedBuffers(21, 24);
2552 CheckNoNextBuffer(); 2512 CheckNoNextBuffer();
2553 2513
2554 // Continue appending into the last range to make sure it didn't break. 2514 // Continue appending into the last range to make sure it didn't break.
2555 AppendBuffers(35, 10); 2515 AppendBuffers(35, 10);
2556 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(20, 0)); 2516 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(20, 0));
2557 // Should save everything between read head and last appended 2517 // Should save everything between read head and last appended
2558 CheckExpectedRanges("{ [20,24) [30,44) }"); 2518 CheckExpectedRanges("{ [20,24) [30,44) }");
2559 2519
2560 // Make sure appending before and after the ranges didn't somehow break. 2520 // Make sure appending before and after the ranges didn't somehow break.
2561 SetMemoryLimit(100); 2521 SetMemoryLimit(100);
2562 NewSegmentAppend(0, 10); 2522 NewCodedFrameGroupAppend(0, 10);
2563 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(20, 0)); 2523 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(20, 0));
2564 CheckExpectedRanges("{ [0,9) [20,24) [30,44) }"); 2524 CheckExpectedRanges("{ [0,9) [20,24) [30,44) }");
2565 Seek(0); 2525 Seek(0);
2566 CheckExpectedBuffers(0, 9); 2526 CheckExpectedBuffers(0, 9);
2567 2527
2568 NewSegmentAppend(90, 10); 2528 NewCodedFrameGroupAppend(90, 10);
2569 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2529 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2570 CheckExpectedRanges("{ [0,9) [20,24) [30,44) [90,99) }"); 2530 CheckExpectedRanges("{ [0,9) [20,24) [30,44) [90,99) }");
2571 Seek(30); 2531 Seek(30);
2572 CheckExpectedBuffers(30, 44); 2532 CheckExpectedBuffers(30, 44);
2573 CheckNoNextBuffer(); 2533 CheckNoNextBuffer();
2574 Seek(90); 2534 Seek(90);
2575 CheckExpectedBuffers(90, 99); 2535 CheckExpectedBuffers(90, 99);
2576 CheckNoNextBuffer(); 2536 CheckNoNextBuffer();
2577 } 2537 }
2578 2538
2579 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteAfterLastAppend) { 2539 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteAfterLastAppend) {
2580 // Set memory limit to 10 buffers. 2540 // Set memory limit to 10 buffers.
2581 SetMemoryLimit(10); 2541 SetMemoryLimit(10);
2582 2542
2583 // Append 1 GOP starting at 310ms, 30ms apart. 2543 // Append 1 GOP starting at 310ms, 30ms apart.
2584 NewSegmentAppend("310K 340 370"); 2544 NewCodedFrameGroupAppend("310K 340 370");
2585 2545
2586 // Append 2 GOPs starting at 490ms, 30ms apart. 2546 // Append 2 GOPs starting at 490ms, 30ms apart.
2587 NewSegmentAppend("490K 520 550 580K 610 640"); 2547 NewCodedFrameGroupAppend("490K 520 550 580K 610 640");
2588 2548
2589 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2549 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2590 2550
2591 CheckExpectedRangesByTimestamp("{ [310,400) [490,670) }"); 2551 CheckExpectedRangesByTimestamp("{ [310,400) [490,670) }");
2592 2552
2593 // Seek to the GOP at 580ms. 2553 // Seek to the GOP at 580ms.
2594 SeekToTimestampMs(580); 2554 SeekToTimestampMs(580);
2595 2555
2596 // Append 2 GOPs before the existing ranges. 2556 // Append 2 GOPs before the existing ranges.
2597 // So the ranges before GC are "{ [100,280) [310,400) [490,670) }". 2557 // So the ranges before GC are "{ [100,280) [310,400) [490,670) }".
2598 NewSegmentAppend("100K 130 160 190K 220 250K"); 2558 NewCodedFrameGroupAppend("100K 130 160 190K 220 250K");
2599 2559
2600 EXPECT_TRUE(stream_->GarbageCollectIfNeeded( 2560 EXPECT_TRUE(stream_->GarbageCollectIfNeeded(
2601 DecodeTimestamp::FromMilliseconds(580), 0)); 2561 DecodeTimestamp::FromMilliseconds(580), 0));
2602 2562
2603 // Should save the newly appended GOPs. 2563 // Should save the newly appended GOPs.
2604 CheckExpectedRangesByTimestamp("{ [100,280) [580,670) }"); 2564 CheckExpectedRangesByTimestamp("{ [100,280) [580,670) }");
2605 } 2565 }
2606 2566
2607 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteAfterLastAppendMerged) { 2567 TEST_F(SourceBufferStreamTest, GarbageCollection_DeleteAfterLastAppendMerged) {
2608 // Set memory limit to 10 buffers. 2568 // Set memory limit to 10 buffers.
2609 SetMemoryLimit(10); 2569 SetMemoryLimit(10);
2610 2570
2611 // Append 3 GOPs starting at 400ms, 30ms apart. 2571 // Append 3 GOPs starting at 400ms, 30ms apart.
2612 NewSegmentAppend("400K 430 460 490K 520 550 580K 610 640"); 2572 NewCodedFrameGroupAppend("400K 430 460 490K 520 550 580K 610 640");
2613 2573
2614 // Seek to the GOP at 580ms. 2574 // Seek to the GOP at 580ms.
2615 SeekToTimestampMs(580); 2575 SeekToTimestampMs(580);
2616 2576
2617 // Append 2 GOPs starting at 220ms, and they will be merged with the existing 2577 // Append 2 GOPs starting at 220ms, and they will be merged with the existing
2618 // range. So the range before GC is "{ [220,670) }". 2578 // range. So the range before GC is "{ [220,670) }".
2619 NewSegmentAppend("220K 250 280 310K 340 370"); 2579 NewCodedFrameGroupAppend("220K 250 280 310K 340 370");
2620 2580
2621 EXPECT_TRUE(stream_->GarbageCollectIfNeeded( 2581 EXPECT_TRUE(stream_->GarbageCollectIfNeeded(
2622 DecodeTimestamp::FromMilliseconds(580), 0)); 2582 DecodeTimestamp::FromMilliseconds(580), 0));
2623 2583
2624 // Should save the newly appended GOPs. 2584 // Should save the newly appended GOPs.
2625 CheckExpectedRangesByTimestamp("{ [220,400) [580,670) }"); 2585 CheckExpectedRangesByTimestamp("{ [220,400) [580,670) }");
2626 } 2586 }
2627 2587
2628 TEST_F(SourceBufferStreamTest, GarbageCollection_NoSeek) { 2588 TEST_F(SourceBufferStreamTest, GarbageCollection_NoSeek) {
2629 // Set memory limit to 20 buffers. 2589 // Set memory limit to 20 buffers.
2630 SetMemoryLimit(20); 2590 SetMemoryLimit(20);
2631 2591
2632 // Append 25 buffers at positions 0 through 24. 2592 // Append 25 buffers at positions 0 through 24.
2633 NewSegmentAppend(0, 25, &kDataA); 2593 NewCodedFrameGroupAppend(0, 25, &kDataA);
2634 2594
2635 // If playback is still in the first GOP (starting at 0), GC should fail. 2595 // If playback is still in the first GOP (starting at 0), GC should fail.
2636 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(2, 0)); 2596 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(2, 0));
2637 CheckExpectedRanges("{ [0,24) }"); 2597 CheckExpectedRanges("{ [0,24) }");
2638 2598
2639 // As soon as playback position moves past the first GOP, it should be removed 2599 // As soon as playback position moves past the first GOP, it should be removed
2640 // and after removing the first GOP we are under memory limit. 2600 // and after removing the first GOP we are under memory limit.
2641 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(5, 0)); 2601 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(5, 0));
2642 CheckExpectedRanges("{ [5,24) }"); 2602 CheckExpectedRanges("{ [5,24) }");
2643 CheckNoNextBuffer(); 2603 CheckNoNextBuffer();
2644 Seek(5); 2604 Seek(5);
2645 CheckExpectedBuffers(5, 24, &kDataA); 2605 CheckExpectedBuffers(5, 24, &kDataA);
2646 } 2606 }
2647 2607
2648 TEST_F(SourceBufferStreamTest, GarbageCollection_PendingSeek) { 2608 TEST_F(SourceBufferStreamTest, GarbageCollection_PendingSeek) {
2649 // Append 10 buffers at positions 0 through 9. 2609 // Append 10 buffers at positions 0 through 9.
2650 NewSegmentAppend(0, 10, &kDataA); 2610 NewCodedFrameGroupAppend(0, 10, &kDataA);
2651 2611
2652 // Append 5 buffers at positions 25 through 29. 2612 // Append 5 buffers at positions 25 through 29.
2653 NewSegmentAppend(25, 5, &kDataA); 2613 NewCodedFrameGroupAppend(25, 5, &kDataA);
2654 2614
2655 // Seek to position 15. 2615 // Seek to position 15.
2656 Seek(15); 2616 Seek(15);
2657 CheckNoNextBuffer(); 2617 CheckNoNextBuffer();
2658 CheckExpectedRanges("{ [0,9) [25,29) }"); 2618 CheckExpectedRanges("{ [0,9) [25,29) }");
2659 2619
2660 // Set memory limit to 5 buffers. 2620 // Set memory limit to 5 buffers.
2661 SetMemoryLimit(5); 2621 SetMemoryLimit(5);
2662 2622
2663 // Append 5 buffers as positions 30 to 34 to trigger GC. 2623 // Append 5 buffers as positions 30 to 34 to trigger GC.
2664 AppendBuffers(30, 5, &kDataA); 2624 AppendBuffers(30, 5, &kDataA);
2665 2625
2666 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(30, 0)); 2626 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(30, 0));
2667 2627
2668 // The current algorithm will delete from the beginning until the memory is 2628 // The current algorithm will delete from the beginning until the memory is
2669 // under cap. 2629 // under cap.
2670 CheckExpectedRanges("{ [30,34) }"); 2630 CheckExpectedRanges("{ [30,34) }");
2671 2631
2672 // Expand memory limit again so that GC won't be triggered. 2632 // Expand memory limit again so that GC won't be triggered.
2673 SetMemoryLimit(100); 2633 SetMemoryLimit(100);
2674 2634
2675 // Append data to fulfill seek. 2635 // Append data to fulfill seek.
2676 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(30, 5)); 2636 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(30, 5));
2677 NewSegmentAppend(15, 5, &kDataA); 2637 NewCodedFrameGroupAppend(15, 5, &kDataA);
2678 2638
2679 // Check to make sure all is well. 2639 // Check to make sure all is well.
2680 CheckExpectedRanges("{ [15,19) [30,34) }"); 2640 CheckExpectedRanges("{ [15,19) [30,34) }");
2681 CheckExpectedBuffers(15, 19, &kDataA); 2641 CheckExpectedBuffers(15, 19, &kDataA);
2682 Seek(30); 2642 Seek(30);
2683 CheckExpectedBuffers(30, 34, &kDataA); 2643 CheckExpectedBuffers(30, 34, &kDataA);
2684 } 2644 }
2685 2645
2686 TEST_F(SourceBufferStreamTest, GarbageCollection_NeedsMoreData) { 2646 TEST_F(SourceBufferStreamTest, GarbageCollection_NeedsMoreData) {
2687 // Set memory limit to 15 buffers. 2647 // Set memory limit to 15 buffers.
2688 SetMemoryLimit(15); 2648 SetMemoryLimit(15);
2689 2649
2690 // Append 10 buffers at positions 0 through 9. 2650 // Append 10 buffers at positions 0 through 9.
2691 NewSegmentAppend(0, 10, &kDataA); 2651 NewCodedFrameGroupAppend(0, 10, &kDataA);
2692 2652
2693 // Advance next buffer position to 10. 2653 // Advance next buffer position to 10.
2694 Seek(0); 2654 Seek(0);
2695 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2655 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2696 CheckExpectedBuffers(0, 9, &kDataA); 2656 CheckExpectedBuffers(0, 9, &kDataA);
2697 CheckNoNextBuffer(); 2657 CheckNoNextBuffer();
2698 2658
2699 // Append 20 buffers at positions 15 through 34. 2659 // Append 20 buffers at positions 15 through 34.
2700 NewSegmentAppend(15, 20, &kDataA); 2660 NewCodedFrameGroupAppend(15, 20, &kDataA);
2701 CheckExpectedRanges("{ [0,9) [15,34) }"); 2661 CheckExpectedRanges("{ [0,9) [15,34) }");
2702 2662
2703 // GC should save the keyframe before the next buffer position and the data 2663 // GC should save the keyframe before the next buffer position and the data
2704 // closest to the next buffer position. It will also save all buffers from 2664 // closest to the next buffer position. It will also save all buffers from
2705 // next buffer to the last GOP appended, which overflows limit and leads to 2665 // next buffer to the last GOP appended, which overflows limit and leads to
2706 // failure. 2666 // failure.
2707 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(5, 0)); 2667 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(5, 0));
2708 CheckExpectedRanges("{ [5,9) [15,34) }"); 2668 CheckExpectedRanges("{ [5,9) [15,34) }");
2709 2669
2710 // Now fulfill the seek at position 10. This will make GC delete the data 2670 // Now fulfill the seek at position 10. This will make GC delete the data
2711 // before position 10 to keep it within cap. 2671 // before position 10 to keep it within cap.
2712 NewSegmentAppend(10, 5, &kDataA); 2672 NewCodedFrameGroupAppend(10, 5, &kDataA);
2713 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(10, 0)); 2673 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(10, 0));
2714 CheckExpectedRanges("{ [10,24) }"); 2674 CheckExpectedRanges("{ [10,24) }");
2715 CheckExpectedBuffers(10, 24, &kDataA); 2675 CheckExpectedBuffers(10, 24, &kDataA);
2716 } 2676 }
2717 2677
2718 TEST_F(SourceBufferStreamTest, GarbageCollection_TrackBuffer) { 2678 TEST_F(SourceBufferStreamTest, GarbageCollection_TrackBuffer) {
2719 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(99)); 2679 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(99));
2720 2680
2721 // Set memory limit to 3 buffers. 2681 // Set memory limit to 3 buffers.
2722 SetMemoryLimit(3); 2682 SetMemoryLimit(3);
2723 2683
2724 // Seek to position 15. 2684 // Seek to position 15.
2725 Seek(15); 2685 Seek(15);
2726 2686
2727 // Append 18 buffers at positions 0 through 17. 2687 // Append 18 buffers at positions 0 through 17.
2728 NewSegmentAppend(0, 18, &kDataA); 2688 NewCodedFrameGroupAppend(0, 18, &kDataA);
2729 2689
2730 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(15, 0)); 2690 EXPECT_TRUE(GarbageCollectWithPlaybackAtBuffer(15, 0));
2731 2691
2732 // Should leave GOP containing seek position. 2692 // Should leave GOP containing seek position.
2733 CheckExpectedRanges("{ [15,17) }"); 2693 CheckExpectedRanges("{ [15,17) }");
2734 2694
2735 // Move next buffer position to 16. 2695 // Move next buffer position to 16.
2736 CheckExpectedBuffers(15, 15, &kDataA); 2696 CheckExpectedBuffers(15, 15, &kDataA);
2737 2697
2738 // Completely overlap the existing buffers. 2698 // Completely overlap the existing buffers.
2739 NewSegmentAppend(0, 20, &kDataB); 2699 NewCodedFrameGroupAppend(0, 20, &kDataB);
2740 2700
2741 // Final GOP [15,19) contains 5 buffers, which is more than memory limit of 2701 // Final GOP [15,19) contains 5 buffers, which is more than memory limit of
2742 // 3 buffers set at the beginning of the test, so GC will fail. 2702 // 3 buffers set at the beginning of the test, so GC will fail.
2743 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(15, 0)); 2703 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(15, 0));
2744 2704
2745 // Because buffers 16 and 17 are not keyframes, they are moved to the track 2705 // Because buffers 16 and 17 are not keyframes, they are moved to the track
2746 // buffer upon overlap. The source buffer (i.e. not the track buffer) is now 2706 // buffer upon overlap. The source buffer (i.e. not the track buffer) is now
2747 // waiting for the next keyframe. 2707 // waiting for the next keyframe.
2748 CheckExpectedRanges("{ [15,19) }"); 2708 CheckExpectedRanges("{ [15,19) }");
2749 CheckExpectedBuffers(16, 17, &kDataA); 2709 CheckExpectedBuffers(16, 17, &kDataA);
(...skipping 10 matching lines...) Expand all
2760 CheckExpectedRanges("{ [20,24) }"); 2720 CheckExpectedRanges("{ [20,24) }");
2761 CheckExpectedBuffers(20, 24, &kDataB); 2721 CheckExpectedBuffers(20, 24, &kDataB);
2762 CheckNoNextBuffer(); 2722 CheckNoNextBuffer();
2763 } 2723 }
2764 2724
2765 // Test GC preserves data starting at first GOP containing playback position. 2725 // Test GC preserves data starting at first GOP containing playback position.
2766 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveDataAtPlaybackPosition) { 2726 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveDataAtPlaybackPosition) {
2767 // Set memory limit to 30 buffers = 1 second of data. 2727 // Set memory limit to 30 buffers = 1 second of data.
2768 SetMemoryLimit(30); 2728 SetMemoryLimit(30);
2769 // And append 300 buffers = 10 seconds of data. 2729 // And append 300 buffers = 10 seconds of data.
2770 NewSegmentAppend(0, 300, &kDataA); 2730 NewCodedFrameGroupAppend(0, 300, &kDataA);
2771 CheckExpectedRanges("{ [0,299) }"); 2731 CheckExpectedRanges("{ [0,299) }");
2772 2732
2773 // Playback position at 0, all data must be preserved. 2733 // Playback position at 0, all data must be preserved.
2774 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2734 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2775 DecodeTimestamp::FromMilliseconds(0), 0)); 2735 DecodeTimestamp::FromMilliseconds(0), 0));
2776 CheckExpectedRanges("{ [0,299) }"); 2736 CheckExpectedRanges("{ [0,299) }");
2777 2737
2778 // Playback position at 1 sec, the first second of data [0,29) should be 2738 // Playback position at 1 sec, the first second of data [0,29) should be
2779 // collected, since we are way over memory limit. 2739 // collected, since we are way over memory limit.
2780 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2740 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
2818 EXPECT_TRUE(stream_->GarbageCollectIfNeeded( 2778 EXPECT_TRUE(stream_->GarbageCollectIfNeeded(
2819 DecodeTimestamp::FromMilliseconds(15000), 0)); 2779 DecodeTimestamp::FromMilliseconds(15000), 0));
2820 CheckExpectedRanges("{ [270,299) }"); 2780 CheckExpectedRanges("{ [270,299) }");
2821 } 2781 }
2822 2782
2823 // Test saving the last GOP appended when this GOP is the only GOP in its range. 2783 // Test saving the last GOP appended when this GOP is the only GOP in its range.
2824 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP) { 2784 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP) {
2825 // Set memory limit to 3 and make sure the 4-byte GOP is not garbage 2785 // Set memory limit to 3 and make sure the 4-byte GOP is not garbage
2826 // collected. 2786 // collected.
2827 SetMemoryLimit(3); 2787 SetMemoryLimit(3);
2828 NewSegmentAppend("0K 30 60 90"); 2788 NewCodedFrameGroupAppend("0K 30 60 90");
2829 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2789 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2830 CheckExpectedRangesByTimestamp("{ [0,120) }"); 2790 CheckExpectedRangesByTimestamp("{ [0,120) }");
2831 2791
2832 // Make sure you can continue appending data to this GOP; again, GC should not 2792 // Make sure you can continue appending data to this GOP; again, GC should not
2833 // wipe out anything. 2793 // wipe out anything.
2834 AppendBuffers("120D30"); 2794 AppendBuffers("120D30");
2835 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(0, 0)); 2795 EXPECT_FALSE(GarbageCollectWithPlaybackAtBuffer(0, 0));
2836 CheckExpectedRangesByTimestamp("{ [0,150) }"); 2796 CheckExpectedRangesByTimestamp("{ [0,150) }");
2837 2797
2838 // Append a 2nd range after this without triggering GC. 2798 // Append a 2nd range after this without triggering GC.
2839 NewSegmentAppend("200K 230 260 290K 320 350"); 2799 NewCodedFrameGroupAppend("200K 230 260 290K 320 350");
2840 CheckExpectedRangesByTimestamp("{ [0,150) [200,380) }"); 2800 CheckExpectedRangesByTimestamp("{ [0,150) [200,380) }");
2841 2801
2842 // Seek to 290ms. 2802 // Seek to 290ms.
2843 SeekToTimestampMs(290); 2803 SeekToTimestampMs(290);
2844 2804
2845 // Now append a GOP in a separate range after the selected range and trigger 2805 // Now append a GOP in a separate range after the selected range and trigger
2846 // GC. Because it is after 290ms, this tests that the GOP is saved when 2806 // GC. Because it is after 290ms, this tests that the GOP is saved when
2847 // deleting from the back. 2807 // deleting from the back.
2848 NewSegmentAppend("500K 530 560 590"); 2808 NewCodedFrameGroupAppend("500K 530 560 590");
2849 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2809 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2850 DecodeTimestamp::FromMilliseconds(290), 0)); 2810 DecodeTimestamp::FromMilliseconds(290), 0));
2851 2811
2852 // Should save GOPs between 290ms and the last GOP appended. 2812 // Should save GOPs between 290ms and the last GOP appended.
2853 CheckExpectedRangesByTimestamp("{ [290,380) [500,620) }"); 2813 CheckExpectedRangesByTimestamp("{ [290,380) [500,620) }");
2854 2814
2855 // Continue appending to this GOP after GC. 2815 // Continue appending to this GOP after GC.
2856 AppendBuffers("620D30"); 2816 AppendBuffers("620D30");
2857 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2817 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2858 DecodeTimestamp::FromMilliseconds(290), 0)); 2818 DecodeTimestamp::FromMilliseconds(290), 0));
2859 CheckExpectedRangesByTimestamp("{ [290,380) [500,650) }"); 2819 CheckExpectedRangesByTimestamp("{ [290,380) [500,650) }");
2860 } 2820 }
2861 2821
2862 // Test saving the last GOP appended when this GOP is in the middle of a 2822 // Test saving the last GOP appended when this GOP is in the middle of a
2863 // non-selected range. 2823 // non-selected range.
2864 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Middle) { 2824 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Middle) {
2865 // Append 3 GOPs starting at 0ms, 30ms apart. 2825 // Append 3 GOPs starting at 0ms, 30ms apart.
2866 NewSegmentAppend("0K 30 60 90K 120 150 180K 210 240"); 2826 NewCodedFrameGroupAppend("0K 30 60 90K 120 150 180K 210 240");
2867 CheckExpectedRangesByTimestamp("{ [0,270) }"); 2827 CheckExpectedRangesByTimestamp("{ [0,270) }");
2868 2828
2869 // Now set the memory limit to 1 and overlap the middle of the range with a 2829 // Now set the memory limit to 1 and overlap the middle of the range with a
2870 // new GOP. 2830 // new GOP.
2871 SetMemoryLimit(1); 2831 SetMemoryLimit(1);
2872 NewSegmentAppend("80K 110 140"); 2832 NewCodedFrameGroupAppend("80K 110 140");
2873 2833
2874 // This whole GOP should be saved after GC, which will fail due to GOP being 2834 // This whole GOP should be saved after GC, which will fail due to GOP being
2875 // larger than 1 buffer 2835 // larger than 1 buffer
2876 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2836 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2877 DecodeTimestamp::FromMilliseconds(80), 0)); 2837 DecodeTimestamp::FromMilliseconds(80), 0));
2878 CheckExpectedRangesByTimestamp("{ [80,170) }"); 2838 CheckExpectedRangesByTimestamp("{ [80,170) }");
2879 // We should still be able to continue appending data to GOP 2839 // We should still be able to continue appending data to GOP
2880 AppendBuffers("170D30"); 2840 AppendBuffers("170D30");
2881 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2841 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2882 DecodeTimestamp::FromMilliseconds(80), 0)); 2842 DecodeTimestamp::FromMilliseconds(80), 0));
2883 CheckExpectedRangesByTimestamp("{ [80,200) }"); 2843 CheckExpectedRangesByTimestamp("{ [80,200) }");
2884 2844
2885 // Append a 2nd range after this range, without triggering GC. 2845 // Append a 2nd range after this range, without triggering GC.
2886 NewSegmentAppend("400K 430 460 490K 520 550 580K 610 640"); 2846 NewCodedFrameGroupAppend("400K 430 460 490K 520 550 580K 610 640");
2887 CheckExpectedRangesByTimestamp("{ [80,200) [400,670) }"); 2847 CheckExpectedRangesByTimestamp("{ [80,200) [400,670) }");
2888 2848
2889 // Seek to 80ms to make the first range the selected range. 2849 // Seek to 80ms to make the first range the selected range.
2890 SeekToTimestampMs(80); 2850 SeekToTimestampMs(80);
2891 2851
2892 // Now append a GOP in the middle of the second range and trigger GC. Because 2852 // Now append a GOP in the middle of the second range and trigger GC. Because
2893 // it is after the selected range, this tests that the GOP is saved when 2853 // it is after the selected range, this tests that the GOP is saved when
2894 // deleting from the back. 2854 // deleting from the back.
2895 NewSegmentAppend("500K 530 560 590"); 2855 NewCodedFrameGroupAppend("500K 530 560 590");
2896 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2856 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2897 DecodeTimestamp::FromMilliseconds(80), 0)); 2857 DecodeTimestamp::FromMilliseconds(80), 0));
2898 2858
2899 // Should save the GOPs between the seek point and GOP that was last appended 2859 // Should save the GOPs between the seek point and GOP that was last appended
2900 CheckExpectedRangesByTimestamp("{ [80,200) [400,620) }"); 2860 CheckExpectedRangesByTimestamp("{ [80,200) [400,620) }");
2901 2861
2902 // Continue appending to this GOP after GC. 2862 // Continue appending to this GOP after GC.
2903 AppendBuffers("620D30"); 2863 AppendBuffers("620D30");
2904 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2864 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2905 DecodeTimestamp::FromMilliseconds(80), 0)); 2865 DecodeTimestamp::FromMilliseconds(80), 0));
2906 CheckExpectedRangesByTimestamp("{ [80,200) [400,650) }"); 2866 CheckExpectedRangesByTimestamp("{ [80,200) [400,650) }");
2907 } 2867 }
2908 2868
2909 // Test saving the last GOP appended when the GOP containing the next buffer is 2869 // Test saving the last GOP appended when the GOP containing the next buffer is
2910 // adjacent to the last GOP appended. 2870 // adjacent to the last GOP appended.
2911 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Selected1) { 2871 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Selected1) {
2912 // Append 3 GOPs at 0ms, 90ms, and 180ms. 2872 // Append 3 GOPs at 0ms, 90ms, and 180ms.
2913 NewSegmentAppend("0K 30 60 90K 120 150 180K 210 240"); 2873 NewCodedFrameGroupAppend("0K 30 60 90K 120 150 180K 210 240");
2914 CheckExpectedRangesByTimestamp("{ [0,270) }"); 2874 CheckExpectedRangesByTimestamp("{ [0,270) }");
2915 2875
2916 // Seek to the GOP at 90ms. 2876 // Seek to the GOP at 90ms.
2917 SeekToTimestampMs(90); 2877 SeekToTimestampMs(90);
2918 2878
2919 // Set the memory limit to 1, then overlap the GOP at 0. 2879 // Set the memory limit to 1, then overlap the GOP at 0.
2920 SetMemoryLimit(1); 2880 SetMemoryLimit(1);
2921 NewSegmentAppend("0K 30 60"); 2881 NewCodedFrameGroupAppend("0K 30 60");
2922 2882
2923 // GC should save the GOP at 0ms and 90ms, and will fail since GOP larger 2883 // GC should save the GOP at 0ms and 90ms, and will fail since GOP larger
2924 // than 1 buffer 2884 // than 1 buffer
2925 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2885 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2926 DecodeTimestamp::FromMilliseconds(90), 0)); 2886 DecodeTimestamp::FromMilliseconds(90), 0));
2927 CheckExpectedRangesByTimestamp("{ [0,180) }"); 2887 CheckExpectedRangesByTimestamp("{ [0,180) }");
2928 2888
2929 // Seek to 0 and check all buffers. 2889 // Seek to 0 and check all buffers.
2930 SeekToTimestampMs(0); 2890 SeekToTimestampMs(0);
2931 CheckExpectedBuffers("0K 30 60 90K 120 150"); 2891 CheckExpectedBuffers("0K 30 60 90K 120 150");
2932 CheckNoNextBuffer(); 2892 CheckNoNextBuffer();
2933 2893
2934 // Now seek back to 90ms and append a GOP at 180ms. 2894 // Now seek back to 90ms and append a GOP at 180ms.
2935 SeekToTimestampMs(90); 2895 SeekToTimestampMs(90);
2936 NewSegmentAppend("180K 210 240"); 2896 NewCodedFrameGroupAppend("180K 210 240");
2937 2897
2938 // Should save the GOP at 90ms and the GOP at 180ms. 2898 // Should save the GOP at 90ms and the GOP at 180ms.
2939 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2899 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2940 DecodeTimestamp::FromMilliseconds(90), 0)); 2900 DecodeTimestamp::FromMilliseconds(90), 0));
2941 CheckExpectedRangesByTimestamp("{ [90,270) }"); 2901 CheckExpectedRangesByTimestamp("{ [90,270) }");
2942 CheckExpectedBuffers("90K 120 150 180K 210 240"); 2902 CheckExpectedBuffers("90K 120 150 180K 210 240");
2943 CheckNoNextBuffer(); 2903 CheckNoNextBuffer();
2944 } 2904 }
2945 2905
2946 // Test saving the last GOP appended when it is at the beginning or end of the 2906 // Test saving the last GOP appended when it is at the beginning or end of the
2947 // selected range. This tests when the last GOP appended is before or after the 2907 // selected range. This tests when the last GOP appended is before or after the
2948 // GOP containing the next buffer, but not directly adjacent to this GOP. 2908 // GOP containing the next buffer, but not directly adjacent to this GOP.
2949 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Selected2) { 2909 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Selected2) {
2950 // Append 4 GOPs starting at positions 0ms, 90ms, 180ms, 270ms. 2910 // Append 4 GOPs starting at positions 0ms, 90ms, 180ms, 270ms.
2951 NewSegmentAppend("0K 30 60 90K 120 150 180K 210 240 270K 300 330"); 2911 NewCodedFrameGroupAppend("0K 30 60 90K 120 150 180K 210 240 270K 300 330");
2952 CheckExpectedRangesByTimestamp("{ [0,360) }"); 2912 CheckExpectedRangesByTimestamp("{ [0,360) }");
2953 2913
2954 // Seek to the last GOP at 270ms. 2914 // Seek to the last GOP at 270ms.
2955 SeekToTimestampMs(270); 2915 SeekToTimestampMs(270);
2956 2916
2957 // Set the memory limit to 1, then overlap the GOP at 90ms. 2917 // Set the memory limit to 1, then overlap the GOP at 90ms.
2958 SetMemoryLimit(1); 2918 SetMemoryLimit(1);
2959 NewSegmentAppend("90K 120 150"); 2919 NewCodedFrameGroupAppend("90K 120 150");
2960 2920
2961 // GC will save data in the range where the most recent append has happened 2921 // GC will save data in the range where the most recent append has happened
2962 // [0; 180) and the range where the next read position is [270;360) 2922 // [0; 180) and the range where the next read position is [270;360)
2963 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2923 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2964 DecodeTimestamp::FromMilliseconds(270), 0)); 2924 DecodeTimestamp::FromMilliseconds(270), 0));
2965 CheckExpectedRangesByTimestamp("{ [0,180) [270,360) }"); 2925 CheckExpectedRangesByTimestamp("{ [0,180) [270,360) }");
2966 2926
2967 // Add 3 GOPs to the end of the selected range at 360ms, 450ms, and 540ms. 2927 // Add 3 GOPs to the end of the selected range at 360ms, 450ms, and 540ms.
2968 NewSegmentAppend("360K 390 420 450K 480 510 540K 570 600"); 2928 NewCodedFrameGroupAppend("360K 390 420 450K 480 510 540K 570 600");
2969 CheckExpectedRangesByTimestamp("{ [0,180) [270,630) }"); 2929 CheckExpectedRangesByTimestamp("{ [0,180) [270,630) }");
2970 2930
2971 // Overlap the GOP at 450ms and garbage collect to test deleting from the 2931 // Overlap the GOP at 450ms and garbage collect to test deleting from the
2972 // back. 2932 // back.
2973 NewSegmentAppend("450K 480 510"); 2933 NewCodedFrameGroupAppend("450K 480 510");
2974 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2934 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2975 DecodeTimestamp::FromMilliseconds(270), 0)); 2935 DecodeTimestamp::FromMilliseconds(270), 0));
2976 2936
2977 // Should save GOPs from GOP at 270ms to GOP at 450ms. 2937 // Should save GOPs from GOP at 270ms to GOP at 450ms.
2978 CheckExpectedRangesByTimestamp("{ [270,540) }"); 2938 CheckExpectedRangesByTimestamp("{ [270,540) }");
2979 } 2939 }
2980 2940
2981 // Test saving the last GOP appended when it is the same as the GOP containing 2941 // Test saving the last GOP appended when it is the same as the GOP containing
2982 // the next buffer. 2942 // the next buffer.
2983 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Selected3) { 2943 TEST_F(SourceBufferStreamTest, GarbageCollection_SaveAppendGOP_Selected3) {
2984 // Seek to start of stream. 2944 // Seek to start of stream.
2985 SeekToTimestampMs(0); 2945 SeekToTimestampMs(0);
2986 2946
2987 // Append 3 GOPs starting at 0ms, 90ms, 180ms. 2947 // Append 3 GOPs starting at 0ms, 90ms, 180ms.
2988 NewSegmentAppend("0K 30 60 90K 120 150 180K 210 240"); 2948 NewCodedFrameGroupAppend("0K 30 60 90K 120 150 180K 210 240");
2989 CheckExpectedRangesByTimestamp("{ [0,270) }"); 2949 CheckExpectedRangesByTimestamp("{ [0,270) }");
2990 2950
2991 // Set the memory limit to 1 then begin appending the start of a GOP starting 2951 // Set the memory limit to 1 then begin appending the start of a GOP starting
2992 // at 0ms. 2952 // at 0ms.
2993 SetMemoryLimit(1); 2953 SetMemoryLimit(1);
2994 NewSegmentAppend("0K 30"); 2954 NewCodedFrameGroupAppend("0K 30");
2995 2955
2996 // GC should save the newly appended GOP, which is also the next GOP that 2956 // GC should save the newly appended GOP, which is also the next GOP that
2997 // will be returned from the seek request. 2957 // will be returned from the seek request.
2998 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2958 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
2999 DecodeTimestamp::FromMilliseconds(0), 0)); 2959 DecodeTimestamp::FromMilliseconds(0), 0));
3000 CheckExpectedRangesByTimestamp("{ [0,60) }"); 2960 CheckExpectedRangesByTimestamp("{ [0,60) }");
3001 2961
3002 // Check the buffers in the range. 2962 // Check the buffers in the range.
3003 CheckExpectedBuffers("0K 30"); 2963 CheckExpectedBuffers("0K 30");
3004 CheckNoNextBuffer(); 2964 CheckNoNextBuffer();
3005 2965
3006 // Continue appending to this buffer. 2966 // Continue appending to this buffer.
3007 AppendBuffers("60 90"); 2967 AppendBuffers("60 90");
3008 2968
3009 // GC should still save the rest of this GOP and should be able to fulfill 2969 // GC should still save the rest of this GOP and should be able to fulfill
3010 // the read. 2970 // the read.
3011 EXPECT_FALSE(stream_->GarbageCollectIfNeeded( 2971 EXPECT_FALSE(stream_->GarbageCollectIfNeeded(
3012 DecodeTimestamp::FromMilliseconds(0), 0)); 2972 DecodeTimestamp::FromMilliseconds(0), 0));
3013 CheckExpectedRangesByTimestamp("{ [0,120) }"); 2973 CheckExpectedRangesByTimestamp("{ [0,120) }");
3014 CheckExpectedBuffers("60 90"); 2974 CheckExpectedBuffers("60 90");
3015 CheckNoNextBuffer(); 2975 CheckNoNextBuffer();
3016 } 2976 }
3017 2977
3018 // Currently disabled because of bug: crbug.com/140875. 2978 // Currently disabled because of bug: crbug.com/140875.
3019 TEST_F(SourceBufferStreamTest, DISABLED_GarbageCollection_WaitingForKeyframe) { 2979 TEST_F(SourceBufferStreamTest, DISABLED_GarbageCollection_WaitingForKeyframe) {
3020 // Set memory limit to 10 buffers. 2980 // Set memory limit to 10 buffers.
3021 SetMemoryLimit(10); 2981 SetMemoryLimit(10);
3022 2982
3023 // Append 5 buffers at positions 10 through 14 and exhaust the buffers. 2983 // Append 5 buffers at positions 10 through 14 and exhaust the buffers.
3024 NewSegmentAppend(10, 5, &kDataA); 2984 NewCodedFrameGroupAppend(10, 5, &kDataA);
3025 Seek(10); 2985 Seek(10);
3026 CheckExpectedBuffers(10, 14, &kDataA); 2986 CheckExpectedBuffers(10, 14, &kDataA);
3027 CheckExpectedRanges("{ [10,14) }"); 2987 CheckExpectedRanges("{ [10,14) }");
3028 2988
3029 // We are now stalled at position 15. 2989 // We are now stalled at position 15.
3030 CheckNoNextBuffer(); 2990 CheckNoNextBuffer();
3031 2991
3032 // Do an end overlap that causes the latter half of the range to be deleted. 2992 // Do an end overlap that causes the latter half of the range to be deleted.
3033 NewSegmentAppend(5, 6, &kDataA); 2993 NewCodedFrameGroupAppend(5, 6, &kDataA);
3034 CheckNoNextBuffer(); 2994 CheckNoNextBuffer();
3035 CheckExpectedRanges("{ [5,10) }"); 2995 CheckExpectedRanges("{ [5,10) }");
3036 2996
3037 // Append buffers from position 20 to 29. This should trigger GC. 2997 // Append buffers from position 20 to 29. This should trigger GC.
3038 NewSegmentAppend(20, 10, &kDataA); 2998 NewCodedFrameGroupAppend(20, 10, &kDataA);
3039 2999
3040 // GC should keep the keyframe before the seek position 15, and the next 9 3000 // GC should keep the keyframe before the seek position 15, and the next 9
3041 // buffers closest to the seek position. 3001 // buffers closest to the seek position.
3042 CheckNoNextBuffer(); 3002 CheckNoNextBuffer();
3043 CheckExpectedRanges("{ [10,10) [20,28) }"); 3003 CheckExpectedRanges("{ [10,10) [20,28) }");
3044 3004
3045 // Fulfill the seek by appending one buffer at 15. 3005 // Fulfill the seek by appending one buffer at 15.
3046 NewSegmentAppend(15, 1, &kDataA); 3006 NewCodedFrameGroupAppend(15, 1, &kDataA);
3047 CheckExpectedBuffers(15, 15, &kDataA); 3007 CheckExpectedBuffers(15, 15, &kDataA);
3048 CheckExpectedRanges("{ [15,15) [20,28) }"); 3008 CheckExpectedRanges("{ [15,15) [20,28) }");
3049 } 3009 }
3050 3010
3051 // Test the performance of garbage collection. 3011 // Test the performance of garbage collection.
3052 TEST_F(SourceBufferStreamTest, GarbageCollection_Performance) { 3012 TEST_F(SourceBufferStreamTest, GarbageCollection_Performance) {
3053 // Force |keyframes_per_second_| to be equal to kDefaultFramesPerSecond. 3013 // Force |keyframes_per_second_| to be equal to kDefaultFramesPerSecond.
3054 SetStreamInfo(kDefaultFramesPerSecond, kDefaultFramesPerSecond); 3014 SetStreamInfo(kDefaultFramesPerSecond, kDefaultFramesPerSecond);
3055 3015
3056 const int kBuffersToKeep = 1000; 3016 const int kBuffersToKeep = 1000;
3057 SetMemoryLimit(kBuffersToKeep); 3017 SetMemoryLimit(kBuffersToKeep);
3058 3018
3059 int buffers_appended = 0; 3019 int buffers_appended = 0;
3060 3020
3061 NewSegmentAppend(0, kBuffersToKeep); 3021 NewCodedFrameGroupAppend(0, kBuffersToKeep);
3062 buffers_appended += kBuffersToKeep; 3022 buffers_appended += kBuffersToKeep;
3063 3023
3064 const int kBuffersToAppend = 1000; 3024 const int kBuffersToAppend = 1000;
3065 const int kGarbageCollections = 3; 3025 const int kGarbageCollections = 3;
3066 for (int i = 0; i < kGarbageCollections; ++i) { 3026 for (int i = 0; i < kGarbageCollections; ++i) {
3067 AppendBuffers(buffers_appended, kBuffersToAppend); 3027 AppendBuffers(buffers_appended, kBuffersToAppend);
3068 buffers_appended += kBuffersToAppend; 3028 buffers_appended += kBuffersToAppend;
3069 } 3029 }
3070 } 3030 }
3071 3031
3072 TEST_F(SourceBufferStreamTest, GarbageCollection_MediaTimeAfterLastAppendTime) { 3032 TEST_F(SourceBufferStreamTest, GarbageCollection_MediaTimeAfterLastAppendTime) {
3073 // Set memory limit to 10 buffers. 3033 // Set memory limit to 10 buffers.
3074 SetMemoryLimit(10); 3034 SetMemoryLimit(10);
3075 3035
3076 // Append 12 buffers. The duration of the last buffer is 30 3036 // Append 12 buffers. The duration of the last buffer is 30
3077 NewSegmentAppend("0K 30 60 90 120K 150 180 210K 240 270 300K 330D30"); 3037 NewCodedFrameGroupAppend("0K 30 60 90 120K 150 180 210K 240 270 300K 330D30");
3078 CheckExpectedRangesByTimestamp("{ [0,360) }"); 3038 CheckExpectedRangesByTimestamp("{ [0,360) }");
3079 3039
3080 // Do a garbage collection with the media time higher than the timestamp of 3040 // Do a garbage collection with the media time higher than the timestamp of
3081 // the last appended buffer (330), but still within buffered ranges, taking 3041 // the last appended buffer (330), but still within buffered ranges, taking
3082 // into account the duration of the last frame (timestamp of the last frame is 3042 // into account the duration of the last frame (timestamp of the last frame is
3083 // 330, duration is 30, so the latest valid buffered position is 330+30=360). 3043 // 330, duration is 30, so the latest valid buffered position is 330+30=360).
3084 EXPECT_TRUE(stream_->GarbageCollectIfNeeded( 3044 EXPECT_TRUE(stream_->GarbageCollectIfNeeded(
3085 DecodeTimestamp::FromMilliseconds(360), 0)); 3045 DecodeTimestamp::FromMilliseconds(360), 0));
3086 3046
3087 // GC should collect one GOP from the front to bring us back under memory 3047 // GC should collect one GOP from the front to bring us back under memory
3088 // limit of 10 buffers. 3048 // limit of 10 buffers.
3089 CheckExpectedRangesByTimestamp("{ [120,360) }"); 3049 CheckExpectedRangesByTimestamp("{ [120,360) }");
3090 } 3050 }
3091 3051
3092 TEST_F(SourceBufferStreamTest, 3052 TEST_F(SourceBufferStreamTest,
3093 GarbageCollection_MediaTimeOutsideOfStreamBufferedRange) { 3053 GarbageCollection_MediaTimeOutsideOfStreamBufferedRange) {
3094 // Set memory limit to 10 buffers. 3054 // Set memory limit to 10 buffers.
3095 SetMemoryLimit(10); 3055 SetMemoryLimit(10);
3096 3056
3097 // Append 12 buffers. 3057 // Append 12 buffers.
3098 NewSegmentAppend("0K 30 60 90 120K 150 180 210K 240 270 300K 330"); 3058 NewCodedFrameGroupAppend("0K 30 60 90 120K 150 180 210K 240 270 300K 330");
3099 CheckExpectedRangesByTimestamp("{ [0,360) }"); 3059 CheckExpectedRangesByTimestamp("{ [0,360) }");
3100 3060
3101 // Seek in order to set the stream read position to 330 an ensure that the 3061 // Seek in order to set the stream read position to 330 an ensure that the
3102 // stream selects the buffered range. 3062 // stream selects the buffered range.
3103 SeekToTimestampMs(330); 3063 SeekToTimestampMs(330);
3104 3064
3105 // Do a garbage collection with the media time outside the buffered ranges 3065 // Do a garbage collection with the media time outside the buffered ranges
3106 // (this might happen when there's both audio and video streams, audio stream 3066 // (this might happen when there's both audio and video streams, audio stream
3107 // buffered range is longer than the video stream buffered range, since 3067 // buffered range is longer than the video stream buffered range, since
3108 // media::Pipeline uses audio stream as a time source in that case, it might 3068 // media::Pipeline uses audio stream as a time source in that case, it might
3109 // return a media_time that is slightly outside of video buffered range). In 3069 // return a media_time that is slightly outside of video buffered range). In
3110 // those cases the GC algorithm should clamp the media_time value to the 3070 // those cases the GC algorithm should clamp the media_time value to the
3111 // buffered ranges to work correctly (see crbug.com/563292). 3071 // buffered ranges to work correctly (see crbug.com/563292).
3112 EXPECT_TRUE(stream_->GarbageCollectIfNeeded( 3072 EXPECT_TRUE(stream_->GarbageCollectIfNeeded(
3113 DecodeTimestamp::FromMilliseconds(361), 0)); 3073 DecodeTimestamp::FromMilliseconds(361), 0));
3114 3074
3115 // GC should collect one GOP from the front to bring us back under memory 3075 // GC should collect one GOP from the front to bring us back under memory
3116 // limit of 10 buffers. 3076 // limit of 10 buffers.
3117 CheckExpectedRangesByTimestamp("{ [120,360) }"); 3077 CheckExpectedRangesByTimestamp("{ [120,360) }");
3118 } 3078 }
3119 3079
3120 TEST_F(SourceBufferStreamTest, GetRemovalRange_BytesToFree) { 3080 TEST_F(SourceBufferStreamTest, GetRemovalRange_BytesToFree) {
3121 // Append 2 GOPs starting at 300ms, 30ms apart. 3081 // Append 2 GOPs starting at 300ms, 30ms apart.
3122 NewSegmentAppend("300K 330 360 390K 420 450"); 3082 NewCodedFrameGroupAppend("300K 330 360 390K 420 450");
3123 3083
3124 // Append 2 GOPs starting at 600ms, 30ms apart. 3084 // Append 2 GOPs starting at 600ms, 30ms apart.
3125 NewSegmentAppend("600K 630 660 690K 720 750"); 3085 NewCodedFrameGroupAppend("600K 630 660 690K 720 750");
3126 3086
3127 // Append 2 GOPs starting at 900ms, 30ms apart. 3087 // Append 2 GOPs starting at 900ms, 30ms apart.
3128 NewSegmentAppend("900K 930 960 990K 1020 1050"); 3088 NewCodedFrameGroupAppend("900K 930 960 990K 1020 1050");
3129 3089
3130 CheckExpectedRangesByTimestamp("{ [300,480) [600,780) [900,1080) }"); 3090 CheckExpectedRangesByTimestamp("{ [300,480) [600,780) [900,1080) }");
3131 3091
3132 int remove_range_end = -1; 3092 int remove_range_end = -1;
3133 int bytes_removed = -1; 3093 int bytes_removed = -1;
3134 3094
3135 // Size 0. 3095 // Size 0.
3136 bytes_removed = GetRemovalRangeInMs(300, 1080, 0, &remove_range_end); 3096 bytes_removed = GetRemovalRangeInMs(300, 1080, 0, &remove_range_end);
3137 EXPECT_EQ(-1, remove_range_end); 3097 EXPECT_EQ(-1, remove_range_end);
3138 EXPECT_EQ(0, bytes_removed); 3098 EXPECT_EQ(0, bytes_removed);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
3174 EXPECT_EQ(18, bytes_removed); 3134 EXPECT_EQ(18, bytes_removed);
3175 3135
3176 // Larger than the whole ranges. 3136 // Larger than the whole ranges.
3177 bytes_removed = GetRemovalRangeInMs(300, 1080, 20, &remove_range_end); 3137 bytes_removed = GetRemovalRangeInMs(300, 1080, 20, &remove_range_end);
3178 EXPECT_EQ(1080, remove_range_end); 3138 EXPECT_EQ(1080, remove_range_end);
3179 EXPECT_EQ(18, bytes_removed); 3139 EXPECT_EQ(18, bytes_removed);
3180 } 3140 }
3181 3141
3182 TEST_F(SourceBufferStreamTest, GetRemovalRange_Range) { 3142 TEST_F(SourceBufferStreamTest, GetRemovalRange_Range) {
3183 // Append 2 GOPs starting at 300ms, 30ms apart. 3143 // Append 2 GOPs starting at 300ms, 30ms apart.
3184 NewSegmentAppend("300K 330 360 390K 420 450"); 3144 NewCodedFrameGroupAppend("300K 330 360 390K 420 450");
3185 3145
3186 // Append 2 GOPs starting at 600ms, 30ms apart. 3146 // Append 2 GOPs starting at 600ms, 30ms apart.
3187 NewSegmentAppend("600K 630 660 690K 720 750"); 3147 NewCodedFrameGroupAppend("600K 630 660 690K 720 750");
3188 3148
3189 // Append 2 GOPs starting at 900ms, 30ms apart. 3149 // Append 2 GOPs starting at 900ms, 30ms apart.
3190 NewSegmentAppend("900K 930 960 990K 1020 1050"); 3150 NewCodedFrameGroupAppend("900K 930 960 990K 1020 1050");
3191 3151
3192 CheckExpectedRangesByTimestamp("{ [300,480) [600,780) [900,1080) }"); 3152 CheckExpectedRangesByTimestamp("{ [300,480) [600,780) [900,1080) }");
3193 3153
3194 int remove_range_end = -1; 3154 int remove_range_end = -1;
3195 int bytes_removed = -1; 3155 int bytes_removed = -1;
3196 3156
3197 // Within a GOP and no keyframe. 3157 // Within a GOP and no keyframe.
3198 bytes_removed = GetRemovalRangeInMs(630, 660, 20, &remove_range_end); 3158 bytes_removed = GetRemovalRangeInMs(630, 660, 20, &remove_range_end);
3199 EXPECT_EQ(-1, remove_range_end); 3159 EXPECT_EQ(-1, remove_range_end);
3200 EXPECT_EQ(0, bytes_removed); 3160 EXPECT_EQ(0, bytes_removed);
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
3246 } 3206 }
3247 3207
3248 TEST_F(SourceBufferStreamTest, ConfigChange_Basic) { 3208 TEST_F(SourceBufferStreamTest, ConfigChange_Basic) {
3249 VideoDecoderConfig new_config = TestVideoConfig::Large(); 3209 VideoDecoderConfig new_config = TestVideoConfig::Large();
3250 ASSERT_FALSE(new_config.Matches(video_config_)); 3210 ASSERT_FALSE(new_config.Matches(video_config_));
3251 3211
3252 Seek(0); 3212 Seek(0);
3253 CheckVideoConfig(video_config_); 3213 CheckVideoConfig(video_config_);
3254 3214
3255 // Append 5 buffers at positions 0 through 4 3215 // Append 5 buffers at positions 0 through 4
3256 NewSegmentAppend(0, 5, &kDataA); 3216 NewCodedFrameGroupAppend(0, 5, &kDataA);
3257 3217
3258 CheckVideoConfig(video_config_); 3218 CheckVideoConfig(video_config_);
3259 3219
3260 // Signal a config change. 3220 // Signal a config change.
3261 stream_->UpdateVideoConfig(new_config); 3221 stream_->UpdateVideoConfig(new_config);
3262 3222
3263 // Make sure updating the config doesn't change anything since new_config 3223 // Make sure updating the config doesn't change anything since new_config
3264 // should not be associated with the buffer GetNextBuffer() will return. 3224 // should not be associated with the buffer GetNextBuffer() will return.
3265 CheckVideoConfig(video_config_); 3225 CheckVideoConfig(video_config_);
3266 3226
3267 // Append 5 buffers at positions 5 through 9. 3227 // Append 5 buffers at positions 5 through 9.
3268 NewSegmentAppend(5, 5, &kDataB); 3228 NewCodedFrameGroupAppend(5, 5, &kDataB);
3269 3229
3270 // Consume the buffers associated with the initial config. 3230 // Consume the buffers associated with the initial config.
3271 scoped_refptr<StreamParserBuffer> buffer; 3231 scoped_refptr<StreamParserBuffer> buffer;
3272 for (int i = 0; i < 5; i++) { 3232 for (int i = 0; i < 5; i++) {
3273 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess); 3233 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess);
3274 CheckVideoConfig(video_config_); 3234 CheckVideoConfig(video_config_);
3275 } 3235 }
3276 3236
3277 // Verify the next attempt to get a buffer will signal that a config change 3237 // Verify the next attempt to get a buffer will signal that a config change
3278 // has happened. 3238 // has happened.
3279 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange); 3239 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange);
3280 3240
3281 // Verify that the new config is now returned. 3241 // Verify that the new config is now returned.
3282 CheckVideoConfig(new_config); 3242 CheckVideoConfig(new_config);
3283 3243
3284 // Consume the remaining buffers associated with the new config. 3244 // Consume the remaining buffers associated with the new config.
3285 for (int i = 0; i < 5; i++) { 3245 for (int i = 0; i < 5; i++) {
3286 CheckVideoConfig(new_config); 3246 CheckVideoConfig(new_config);
3287 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess); 3247 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kSuccess);
3288 } 3248 }
3289 } 3249 }
3290 3250
3291 TEST_F(SourceBufferStreamTest, ConfigChange_Seek) { 3251 TEST_F(SourceBufferStreamTest, ConfigChange_Seek) {
3292 scoped_refptr<StreamParserBuffer> buffer; 3252 scoped_refptr<StreamParserBuffer> buffer;
3293 VideoDecoderConfig new_config = TestVideoConfig::Large(); 3253 VideoDecoderConfig new_config = TestVideoConfig::Large();
3294 3254
3295 Seek(0); 3255 Seek(0);
3296 NewSegmentAppend(0, 5, &kDataA); 3256 NewCodedFrameGroupAppend(0, 5, &kDataA);
3297 stream_->UpdateVideoConfig(new_config); 3257 stream_->UpdateVideoConfig(new_config);
3298 NewSegmentAppend(5, 5, &kDataB); 3258 NewCodedFrameGroupAppend(5, 5, &kDataB);
3299 3259
3300 // Seek to the start of the buffers with the new config and make sure a 3260 // Seek to the start of the buffers with the new config and make sure a
3301 // config change is signalled. 3261 // config change is signalled.
3302 CheckVideoConfig(video_config_); 3262 CheckVideoConfig(video_config_);
3303 Seek(5); 3263 Seek(5);
3304 CheckVideoConfig(video_config_); 3264 CheckVideoConfig(video_config_);
3305 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange); 3265 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange);
3306 CheckVideoConfig(new_config); 3266 CheckVideoConfig(new_config);
3307 CheckExpectedBuffers(5, 9, &kDataB); 3267 CheckExpectedBuffers(5, 9, &kDataB);
3308 3268
(...skipping 11 matching lines...) Expand all
3320 CheckVideoConfig(new_config); 3280 CheckVideoConfig(new_config);
3321 Seek(0); 3281 Seek(0);
3322 CheckVideoConfig(new_config); 3282 CheckVideoConfig(new_config);
3323 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange); 3283 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange);
3324 CheckVideoConfig(video_config_); 3284 CheckVideoConfig(video_config_);
3325 CheckExpectedBuffers(0, 4, &kDataA); 3285 CheckExpectedBuffers(0, 4, &kDataA);
3326 } 3286 }
3327 3287
3328 TEST_F(SourceBufferStreamTest, SetExplicitDuration) { 3288 TEST_F(SourceBufferStreamTest, SetExplicitDuration) {
3329 // Append 2 buffers at positions 5 through 6. 3289 // Append 2 buffers at positions 5 through 6.
3330 NewSegmentAppend(5, 2); 3290 NewCodedFrameGroupAppend(5, 2);
3331 3291
3332 // Append 2 buffers at positions 10 through 11. 3292 // Append 2 buffers at positions 10 through 11.
3333 NewSegmentAppend(10, 2); 3293 NewCodedFrameGroupAppend(10, 2);
3334 3294
3335 // Append 2 buffers at positions 15 through 16. 3295 // Append 2 buffers at positions 15 through 16.
3336 NewSegmentAppend(15, 2); 3296 NewCodedFrameGroupAppend(15, 2);
3337 3297
3338 // Check expected ranges. 3298 // Check expected ranges.
3339 CheckExpectedRanges("{ [5,6) [10,11) [15,16) }"); 3299 CheckExpectedRanges("{ [5,6) [10,11) [15,16) }");
3340 3300
3341 // Set duration to be between buffers 6 and 10. 3301 // Set duration to be between buffers 6 and 10.
3342 stream_->OnSetDuration(frame_duration() * 8); 3302 stream_->OnSetDuration(frame_duration() * 8);
3343 3303
3344 // Should truncate the data after 6. 3304 // Should truncate the data after 6.
3345 CheckExpectedRanges("{ [5,6) }"); 3305 CheckExpectedRanges("{ [5,6) }");
3346 3306
3347 // Adding data past the previous duration should still work. 3307 // Adding data past the previous duration should still work.
3348 NewSegmentAppend(0, 20); 3308 NewCodedFrameGroupAppend(0, 20);
3349 CheckExpectedRanges("{ [0,19) }"); 3309 CheckExpectedRanges("{ [0,19) }");
3350 } 3310 }
3351 3311
3352 TEST_F(SourceBufferStreamTest, SetExplicitDuration_EdgeCase) { 3312 TEST_F(SourceBufferStreamTest, SetExplicitDuration_EdgeCase) {
3353 // Append 10 buffers at positions 10 through 19. 3313 // Append 10 buffers at positions 10 through 19.
3354 NewSegmentAppend(10, 10); 3314 NewCodedFrameGroupAppend(10, 10);
3355 3315
3356 // Append 5 buffers at positions 25 through 29. 3316 // Append 5 buffers at positions 25 through 29.
3357 NewSegmentAppend(25, 5); 3317 NewCodedFrameGroupAppend(25, 5);
3358 3318
3359 // Check expected ranges. 3319 // Check expected ranges.
3360 CheckExpectedRanges("{ [10,19) [25,29) }"); 3320 CheckExpectedRanges("{ [10,19) [25,29) }");
3361 3321
3362 // Set duration to be right before buffer 25. 3322 // Set duration to be right before buffer 25.
3363 stream_->OnSetDuration(frame_duration() * 25); 3323 stream_->OnSetDuration(frame_duration() * 25);
3364 3324
3365 // Should truncate the last range. 3325 // Should truncate the last range.
3366 CheckExpectedRanges("{ [10,19) }"); 3326 CheckExpectedRanges("{ [10,19) }");
3367 } 3327 }
3368 3328
3369 TEST_F(SourceBufferStreamTest, SetExplicitDuration_DeletePartialRange) { 3329 TEST_F(SourceBufferStreamTest, SetExplicitDuration_DeletePartialRange) {
3370 // Append 5 buffers at positions 0 through 4. 3330 // Append 5 buffers at positions 0 through 4.
3371 NewSegmentAppend(0, 5); 3331 NewCodedFrameGroupAppend(0, 5);
3372 3332
3373 // Append 10 buffers at positions 10 through 19. 3333 // Append 10 buffers at positions 10 through 19.
3374 NewSegmentAppend(10, 10); 3334 NewCodedFrameGroupAppend(10, 10);
3375 3335
3376 // Append 5 buffers at positions 25 through 29. 3336 // Append 5 buffers at positions 25 through 29.
3377 NewSegmentAppend(25, 5); 3337 NewCodedFrameGroupAppend(25, 5);
3378 3338
3379 // Check expected ranges. 3339 // Check expected ranges.
3380 CheckExpectedRanges("{ [0,4) [10,19) [25,29) }"); 3340 CheckExpectedRanges("{ [0,4) [10,19) [25,29) }");
3381 3341
3382 // Set duration to be between buffers 13 and 14. 3342 // Set duration to be between buffers 13 and 14.
3383 stream_->OnSetDuration(frame_duration() * 14); 3343 stream_->OnSetDuration(frame_duration() * 14);
3384 3344
3385 // Should truncate the data after 13. 3345 // Should truncate the data after 13.
3386 CheckExpectedRanges("{ [0,4) [10,13) }"); 3346 CheckExpectedRanges("{ [0,4) [10,13) }");
3387 } 3347 }
3388 3348
3389 TEST_F(SourceBufferStreamTest, SetExplicitDuration_DeleteSelectedRange) { 3349 TEST_F(SourceBufferStreamTest, SetExplicitDuration_DeleteSelectedRange) {
3390 // Append 2 buffers at positions 5 through 6. 3350 // Append 2 buffers at positions 5 through 6.
3391 NewSegmentAppend(5, 2); 3351 NewCodedFrameGroupAppend(5, 2);
3392 3352
3393 // Append 2 buffers at positions 10 through 11. 3353 // Append 2 buffers at positions 10 through 11.
3394 NewSegmentAppend(10, 2); 3354 NewCodedFrameGroupAppend(10, 2);
3395 3355
3396 // Append 2 buffers at positions 15 through 16. 3356 // Append 2 buffers at positions 15 through 16.
3397 NewSegmentAppend(15, 2); 3357 NewCodedFrameGroupAppend(15, 2);
3398 3358
3399 // Check expected ranges. 3359 // Check expected ranges.
3400 CheckExpectedRanges("{ [5,6) [10,11) [15,16) }"); 3360 CheckExpectedRanges("{ [5,6) [10,11) [15,16) }");
3401 3361
3402 // Seek to 10. 3362 // Seek to 10.
3403 Seek(10); 3363 Seek(10);
3404 3364
3405 // Set duration to be after position 3. 3365 // Set duration to be after position 3.
3406 stream_->OnSetDuration(frame_duration() * 4); 3366 stream_->OnSetDuration(frame_duration() * 4);
3407 3367
3408 // Expect everything to be deleted, and should not have next buffer anymore. 3368 // Expect everything to be deleted, and should not have next buffer anymore.
3409 CheckNoNextBuffer(); 3369 CheckNoNextBuffer();
3410 CheckExpectedRanges("{ }"); 3370 CheckExpectedRanges("{ }");
3411 3371
3412 // Appending data at position 10 should not fulfill the seek. 3372 // Appending data at position 10 should not fulfill the seek.
3413 // (If the duration is set to be something smaller than the current seek 3373 // (If the duration is set to be something smaller than the current seek
3414 // point, then the seek point is reset and the SourceBufferStream waits 3374 // point, then the seek point is reset and the SourceBufferStream waits
3415 // for a new seek request. Therefore even if the data is re-appended, it 3375 // for a new seek request. Therefore even if the data is re-appended, it
3416 // should not fulfill the old seek.) 3376 // should not fulfill the old seek.)
3417 NewSegmentAppend(0, 15); 3377 NewCodedFrameGroupAppend(0, 15);
3418 CheckNoNextBuffer(); 3378 CheckNoNextBuffer();
3419 CheckExpectedRanges("{ [0,14) }"); 3379 CheckExpectedRanges("{ [0,14) }");
3420 } 3380 }
3421 3381
3422 TEST_F(SourceBufferStreamTest, SetExplicitDuration_DeletePartialSelectedRange) { 3382 TEST_F(SourceBufferStreamTest, SetExplicitDuration_DeletePartialSelectedRange) {
3423 // Append 5 buffers at positions 0 through 4. 3383 // Append 5 buffers at positions 0 through 4.
3424 NewSegmentAppend(0, 5); 3384 NewCodedFrameGroupAppend(0, 5);
3425 3385
3426 // Append 20 buffers at positions 10 through 29. 3386 // Append 20 buffers at positions 10 through 29.
3427 NewSegmentAppend(10, 20); 3387 NewCodedFrameGroupAppend(10, 20);
3428 3388
3429 // Check expected ranges. 3389 // Check expected ranges.
3430 CheckExpectedRanges("{ [0,4) [10,29) }"); 3390 CheckExpectedRanges("{ [0,4) [10,29) }");
3431 3391
3432 // Seek to position 10. 3392 // Seek to position 10.
3433 Seek(10); 3393 Seek(10);
3434 3394
3435 // Set duration to be between buffers 24 and 25. 3395 // Set duration to be between buffers 24 and 25.
3436 stream_->OnSetDuration(frame_duration() * 25); 3396 stream_->OnSetDuration(frame_duration() * 25);
3437 3397
(...skipping 12 matching lines...) Expand all
3450 } 3410 }
3451 3411
3452 // Test the case where duration is set while the stream parser buffers 3412 // Test the case where duration is set while the stream parser buffers
3453 // already start passing the data to decoding pipeline. Selected range, 3413 // already start passing the data to decoding pipeline. Selected range,
3454 // when invalidated by getting truncated, should be updated to NULL 3414 // when invalidated by getting truncated, should be updated to NULL
3455 // accordingly so that successive append operations keep working. 3415 // accordingly so that successive append operations keep working.
3456 TEST_F(SourceBufferStreamTest, SetExplicitDuration_UpdateSelectedRange) { 3416 TEST_F(SourceBufferStreamTest, SetExplicitDuration_UpdateSelectedRange) {
3457 // Seek to start of stream. 3417 // Seek to start of stream.
3458 SeekToTimestampMs(0); 3418 SeekToTimestampMs(0);
3459 3419
3460 NewSegmentAppend("0K 30 60 90"); 3420 NewCodedFrameGroupAppend("0K 30 60 90");
3461 3421
3462 // Read out the first few buffers. 3422 // Read out the first few buffers.
3463 CheckExpectedBuffers("0K 30"); 3423 CheckExpectedBuffers("0K 30");
3464 3424
3465 // Set duration to be right before buffer 1. 3425 // Set duration to be right before buffer 1.
3466 stream_->OnSetDuration(base::TimeDelta::FromMilliseconds(60)); 3426 stream_->OnSetDuration(base::TimeDelta::FromMilliseconds(60));
3467 3427
3468 // Verify that there is no next buffer. 3428 // Verify that there is no next buffer.
3469 CheckNoNextBuffer(); 3429 CheckNoNextBuffer();
3470 3430
3471 // We should be able to append new buffers at this point. 3431 // We should be able to append new buffers at this point.
3472 NewSegmentAppend("120K 150"); 3432 NewCodedFrameGroupAppend("120K 150");
3473 3433
3474 CheckExpectedRangesByTimestamp("{ [0,60) [120,180) }"); 3434 CheckExpectedRangesByTimestamp("{ [0,60) [120,180) }");
3475 } 3435 }
3476 3436
3477 TEST_F(SourceBufferStreamTest, 3437 TEST_F(SourceBufferStreamTest,
3478 SetExplicitDuration_AfterSegmentTimestampAndBeforeFirstBufferTimestamp) { 3438 SetExplicitDuration_AfterGroupTimestampAndBeforeFirstBufferTimestamp) {
3439 NewCodedFrameGroupAppend("0K 30K 60K");
3479 3440
3480 NewSegmentAppend("0K 30K 60K"); 3441 // Append a coded frame group with a start timestamp of 200, but the first
3481
3482 // Append a segment with a start timestamp of 200, but the first
3483 // buffer starts at 230ms. This can happen in muxed content where the 3442 // buffer starts at 230ms. This can happen in muxed content where the
3484 // audio starts before the first frame. 3443 // audio starts before the first frame.
3485 NewSegmentAppend(base::TimeDelta::FromMilliseconds(200), 3444 NewCodedFrameGroupAppend(base::TimeDelta::FromMilliseconds(200),
3486 "230K 260K 290K 320K"); 3445 "230K 260K 290K 320K");
3487 3446
3488 NewSegmentAppend("400K 430K 460K"); 3447 NewCodedFrameGroupAppend("400K 430K 460K");
3489 3448
3490 CheckExpectedRangesByTimestamp("{ [0,90) [200,350) [400,490) }"); 3449 CheckExpectedRangesByTimestamp("{ [0,90) [200,350) [400,490) }");
3491 3450
3492 stream_->OnSetDuration(base::TimeDelta::FromMilliseconds(120)); 3451 stream_->OnSetDuration(base::TimeDelta::FromMilliseconds(120));
3493 3452
3494 // Verify that the buffered ranges are updated properly and we don't crash. 3453 // Verify that the buffered ranges are updated properly and we don't crash.
3495 CheckExpectedRangesByTimestamp("{ [0,90) }"); 3454 CheckExpectedRangesByTimestamp("{ [0,90) }");
3496 } 3455 }
3497 3456
3498 TEST_F(SourceBufferStreamTest, SetExplicitDuration_MarkEOS) { 3457 TEST_F(SourceBufferStreamTest, SetExplicitDuration_MarkEOS) {
3499 // Append 1 buffer at positions 0 through 8. 3458 // Append 1 buffer at positions 0 through 8.
3500 NewSegmentAppend(0, 9); 3459 NewCodedFrameGroupAppend(0, 9);
3501 3460
3502 // Check expected ranges. 3461 // Check expected ranges.
3503 CheckExpectedRanges("{ [0,8) }"); 3462 CheckExpectedRanges("{ [0,8) }");
3504 3463
3505 // Seek to 5. 3464 // Seek to 5.
3506 Seek(5); 3465 Seek(5);
3507 3466
3508 // Set duration to be before the seeked to position. 3467 // Set duration to be before the seeked to position.
3509 // This will result in truncation of the selected range and a reset 3468 // This will result in truncation of the selected range and a reset
3510 // of NextBufferPosition. 3469 // of NextBufferPosition.
3511 stream_->OnSetDuration(frame_duration() * 4); 3470 stream_->OnSetDuration(frame_duration() * 4);
3512 3471
3513 // Check the expected ranges. 3472 // Check the expected ranges.
3514 CheckExpectedRanges("{ [0,3) }"); 3473 CheckExpectedRanges("{ [0,3) }");
3515 3474
3516 // Mark EOS reached. 3475 // Mark EOS reached.
3517 stream_->MarkEndOfStream(); 3476 stream_->MarkEndOfStream();
3518 3477
3519 // Expect EOS to be reached. 3478 // Expect EOS to be reached.
3520 CheckEOSReached(); 3479 CheckEOSReached();
3521 } 3480 }
3522 3481
3523 TEST_F(SourceBufferStreamTest, SetExplicitDuration_MarkEOS_IsSeekPending) { 3482 TEST_F(SourceBufferStreamTest, SetExplicitDuration_MarkEOS_IsSeekPending) {
3524 // Append 1 buffer at positions 0 through 8. 3483 // Append 1 buffer at positions 0 through 8.
3525 NewSegmentAppend(0, 9); 3484 NewCodedFrameGroupAppend(0, 9);
3526 3485
3527 // Check expected ranges. 3486 // Check expected ranges.
3528 CheckExpectedRanges("{ [0,8) }"); 3487 CheckExpectedRanges("{ [0,8) }");
3529 3488
3530 // Seek to 9 which will result in a pending seek. 3489 // Seek to 9 which will result in a pending seek.
3531 Seek(9); 3490 Seek(9);
3532 3491
3533 // Set duration to be before the seeked to position. 3492 // Set duration to be before the seeked to position.
3534 // This will result in truncation of the selected range and a reset 3493 // This will result in truncation of the selected range and a reset
3535 // of NextBufferPosition. 3494 // of NextBufferPosition.
3536 stream_->OnSetDuration(frame_duration() * 4); 3495 stream_->OnSetDuration(frame_duration() * 4);
3537 3496
3538 // Check the expected ranges. 3497 // Check the expected ranges.
3539 CheckExpectedRanges("{ [0,3) }"); 3498 CheckExpectedRanges("{ [0,3) }");
3540 3499
3541 EXPECT_TRUE(stream_->IsSeekPending()); 3500 EXPECT_TRUE(stream_->IsSeekPending());
3542 // Mark EOS reached. 3501 // Mark EOS reached.
3543 stream_->MarkEndOfStream(); 3502 stream_->MarkEndOfStream();
3544 EXPECT_FALSE(stream_->IsSeekPending()); 3503 EXPECT_FALSE(stream_->IsSeekPending());
3545 } 3504 }
3546 3505
3547 // Test the case were the current playback position is at the end of the 3506 // Test the case were the current playback position is at the end of the
3548 // buffered data and several overlaps occur that causes the selected 3507 // buffered data and several overlaps occur that causes the selected
3549 // range to get split and then merged back into a single range. 3508 // range to get split and then merged back into a single range.
3550 TEST_F(SourceBufferStreamTest, OverlapSplitAndMergeWhileWaitingForMoreData) { 3509 TEST_F(SourceBufferStreamTest, OverlapSplitAndMergeWhileWaitingForMoreData) {
3551 // Seek to start of stream. 3510 // Seek to start of stream.
3552 SeekToTimestampMs(0); 3511 SeekToTimestampMs(0);
3553 3512
3554 NewSegmentAppend("0K 30 60 90 120K 150"); 3513 NewCodedFrameGroupAppend("0K 30 60 90 120K 150");
3555 CheckExpectedRangesByTimestamp("{ [0,180) }"); 3514 CheckExpectedRangesByTimestamp("{ [0,180) }");
3556 3515
3557 // Read all the buffered data. 3516 // Read all the buffered data.
3558 CheckExpectedBuffers("0K 30 60 90 120K 150"); 3517 CheckExpectedBuffers("0K 30 60 90 120K 150");
3559 CheckNoNextBuffer(); 3518 CheckNoNextBuffer();
3560 3519
3561 // Append data over the current GOP so that a keyframe is needed before 3520 // Append data over the current GOP so that a keyframe is needed before
3562 // playback can continue from the current position. 3521 // playback can continue from the current position.
3563 NewSegmentAppend("120K 150"); 3522 NewCodedFrameGroupAppend("120K 150");
3564 CheckExpectedRangesByTimestamp("{ [0,180) }"); 3523 CheckExpectedRangesByTimestamp("{ [0,180) }");
3565 3524
3566 // Append buffers that cause the range to get split. 3525 // Append buffers that cause the range to get split.
3567 NewSegmentAppend("0K 30"); 3526 NewCodedFrameGroupAppend("0K 30");
3568 CheckExpectedRangesByTimestamp("{ [0,60) [120,180) }"); 3527 CheckExpectedRangesByTimestamp("{ [0,60) [120,180) }");
3569 3528
3570 // Append buffers that cause the ranges to get merged. 3529 // Append buffers that cause the ranges to get merged.
3571 AppendBuffers("60 90"); 3530 AppendBuffers("60 90");
3572 3531
3573 CheckExpectedRangesByTimestamp("{ [0,180) }"); 3532 CheckExpectedRangesByTimestamp("{ [0,180) }");
3574 3533
3575 // Verify that we still don't have a next buffer. 3534 // Verify that we still don't have a next buffer.
3576 CheckNoNextBuffer(); 3535 CheckNoNextBuffer();
3577 3536
3578 // Add more data to the end and verify that this new data is read correctly. 3537 // Add more data to the end and verify that this new data is read correctly.
3579 NewSegmentAppend("180K 210"); 3538 NewCodedFrameGroupAppend("180K 210");
3580 CheckExpectedRangesByTimestamp("{ [0,240) }"); 3539 CheckExpectedRangesByTimestamp("{ [0,240) }");
3581 CheckExpectedBuffers("180K 210"); 3540 CheckExpectedBuffers("180K 210");
3582 } 3541 }
3583 3542
3584 // Verify that non-keyframes with the same timestamp in the same 3543 // Verify that non-keyframes with the same timestamp in the same
3585 // append are handled correctly. 3544 // append are handled correctly.
3586 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_SingleAppend) { 3545 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_SingleAppend) {
3587 Seek(0); 3546 Seek(0);
3588 NewSegmentAppend("0K 30 30 60 90 120K 150"); 3547 NewCodedFrameGroupAppend("0K 30 30 60 90 120K 150");
3589 CheckExpectedBuffers("0K 30 30 60 90 120K 150"); 3548 CheckExpectedBuffers("0K 30 30 60 90 120K 150");
3590 } 3549 }
3591 3550
3592 // Verify that non-keyframes with the same timestamp can occur 3551 // Verify that non-keyframes with the same timestamp can occur
3593 // in different appends. 3552 // in different appends.
3594 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_TwoAppends) { 3553 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_TwoAppends) {
3595 Seek(0); 3554 Seek(0);
3596 NewSegmentAppend("0K 30"); 3555 NewCodedFrameGroupAppend("0K 30");
3597 AppendBuffers("30 60 90 120K 150"); 3556 AppendBuffers("30 60 90 120K 150");
3598 CheckExpectedBuffers("0K 30 30 60 90 120K 150"); 3557 CheckExpectedBuffers("0K 30 30 60 90 120K 150");
3599 } 3558 }
3600 3559
3601 // Verify that a non-keyframe followed by a keyframe with the same timestamp 3560 // Verify that a non-keyframe followed by a keyframe with the same timestamp
3602 // is not allowed. 3561 // is not allowed.
3603 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Invalid_1) { 3562 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Invalid_1) {
3604 EXPECT_MEDIA_LOG(ContainsSameTimestampAt30MillisecondsLog()); 3563 EXPECT_MEDIA_LOG(ContainsSameTimestampAt30MillisecondsLog());
3605 3564
3606 Seek(0); 3565 Seek(0);
3607 NewSegmentAppend("0K 30"); 3566 NewCodedFrameGroupAppend("0K 30");
3608 AppendBuffers_ExpectFailure("30K 60"); 3567 AppendBuffers_ExpectFailure("30K 60");
3609 } 3568 }
3610 3569
3611 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Invalid_2) { 3570 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Invalid_2) {
3612 EXPECT_MEDIA_LOG(ContainsSameTimestampAt30MillisecondsLog()); 3571 EXPECT_MEDIA_LOG(ContainsSameTimestampAt30MillisecondsLog());
3613 3572
3614 Seek(0); 3573 Seek(0);
3615 NewSegmentAppend_ExpectFailure("0K 30 30K 60"); 3574 NewCodedFrameGroupAppend_ExpectFailure("0K 30 30K 60");
3616 } 3575 }
3617 3576
3618 // Verify that a keyframe followed by a non-keyframe with the same timestamp 3577 // Verify that a keyframe followed by a non-keyframe with the same timestamp
3619 // is allowed. 3578 // is allowed.
3620 TEST_F(SourceBufferStreamTest, SameTimestamp_VideoKeyFrame_TwoAppends) { 3579 TEST_F(SourceBufferStreamTest, SameTimestamp_VideoKeyFrame_TwoAppends) {
3621 Seek(0); 3580 Seek(0);
3622 NewSegmentAppend("0K 30K"); 3581 NewCodedFrameGroupAppend("0K 30K");
3623 AppendBuffers("30 60"); 3582 AppendBuffers("30 60");
3624 CheckExpectedBuffers("0K 30K 30 60"); 3583 CheckExpectedBuffers("0K 30K 30 60");
3625 } 3584 }
3626 3585
3627 TEST_F(SourceBufferStreamTest, SameTimestamp_VideoKeyFrame_SingleAppend) { 3586 TEST_F(SourceBufferStreamTest, SameTimestamp_VideoKeyFrame_SingleAppend) {
3628 Seek(0); 3587 Seek(0);
3629 NewSegmentAppend("0K 30K 30 60"); 3588 NewCodedFrameGroupAppend("0K 30K 30 60");
3630 CheckExpectedBuffers("0K 30K 30 60"); 3589 CheckExpectedBuffers("0K 30K 30 60");
3631 } 3590 }
3632 3591
3633 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Overlap_1) { 3592 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Overlap_1) {
3634 Seek(0); 3593 Seek(0);
3635 NewSegmentAppend("0K 30 60 60 90 120K 150"); 3594 NewCodedFrameGroupAppend("0K 30 60 60 90 120K 150");
3636 3595
3637 NewSegmentAppend("60K 91 121K 151"); 3596 NewCodedFrameGroupAppend("60K 91 121K 151");
3638 CheckExpectedBuffers("0K 30 60K 91 121K 151"); 3597 CheckExpectedBuffers("0K 30 60K 91 121K 151");
3639 } 3598 }
3640 3599
3641 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Overlap_2) { 3600 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Overlap_2) {
3642 Seek(0); 3601 Seek(0);
3643 NewSegmentAppend("0K 30 60 60 90 120K 150"); 3602 NewCodedFrameGroupAppend("0K 30 60 60 90 120K 150");
3644 NewSegmentAppend("0K 30 61"); 3603 NewCodedFrameGroupAppend("0K 30 61");
3645 CheckExpectedBuffers("0K 30 61 120K 150"); 3604 CheckExpectedBuffers("0K 30 61 120K 150");
3646 } 3605 }
3647 3606
3648 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Overlap_3) { 3607 TEST_F(SourceBufferStreamTest, SameTimestamp_Video_Overlap_3) {
3649 Seek(0); 3608 Seek(0);
3650 NewSegmentAppend("0K 20 40 60 80 100K 101 102 103K"); 3609 NewCodedFrameGroupAppend("0K 20 40 60 80 100K 101 102 103K");
3651 NewSegmentAppend("0K 20 40 60 80 90"); 3610 NewCodedFrameGroupAppend("0K 20 40 60 80 90");
3652 CheckExpectedBuffers("0K 20 40 60 80 90 100K 101 102 103K"); 3611 CheckExpectedBuffers("0K 20 40 60 80 90 100K 101 102 103K");
3653 AppendBuffers("90 110K 150"); 3612 AppendBuffers("90 110K 150");
3654 Seek(0); 3613 Seek(0);
3655 CheckExpectedBuffers("0K 20 40 60 80 90 90 110K 150"); 3614 CheckExpectedBuffers("0K 20 40 60 80 90 90 110K 150");
3656 CheckNoNextBuffer(); 3615 CheckNoNextBuffer();
3657 CheckExpectedRangesByTimestamp("{ [0,190) }"); 3616 CheckExpectedRangesByTimestamp("{ [0,190) }");
3658 } 3617 }
3659 3618
3660 // Test all the valid same timestamp cases for audio. 3619 // Test all the valid same timestamp cases for audio.
3661 TEST_F(SourceBufferStreamTest, SameTimestamp_Audio) { 3620 TEST_F(SourceBufferStreamTest, SameTimestamp_Audio) {
3662 AudioDecoderConfig config(kCodecMP3, kSampleFormatF32, CHANNEL_LAYOUT_STEREO, 3621 AudioDecoderConfig config(kCodecMP3, kSampleFormatF32, CHANNEL_LAYOUT_STEREO,
3663 44100, EmptyExtraData(), false); 3622 44100, EmptyExtraData(), false);
3664 stream_.reset(new SourceBufferStream(config, media_log_, true)); 3623 stream_.reset(new SourceBufferStream(config, media_log_, true));
3665 Seek(0); 3624 Seek(0);
3666 NewSegmentAppend("0K 0K 30K 30 60 60"); 3625 NewCodedFrameGroupAppend("0K 0K 30K 30 60 60");
3667 CheckExpectedBuffers("0K 0K 30K 30 60 60"); 3626 CheckExpectedBuffers("0K 0K 30K 30 60 60");
3668 } 3627 }
3669 3628
3670 TEST_F(SourceBufferStreamTest, SameTimestamp_Audio_Invalid_1) { 3629 TEST_F(SourceBufferStreamTest, SameTimestamp_Audio_Invalid_1) {
3671 EXPECT_MEDIA_LOG(ContainsSameTimestampAt30MillisecondsLog()); 3630 EXPECT_MEDIA_LOG(ContainsSameTimestampAt30MillisecondsLog());
3672 3631
3673 AudioDecoderConfig config(kCodecMP3, kSampleFormatF32, CHANNEL_LAYOUT_STEREO, 3632 AudioDecoderConfig config(kCodecMP3, kSampleFormatF32, CHANNEL_LAYOUT_STEREO,
3674 44100, EmptyExtraData(), false); 3633 44100, EmptyExtraData(), false);
3675 stream_.reset(new SourceBufferStream(config, media_log_, true)); 3634 stream_.reset(new SourceBufferStream(config, media_log_, true));
3676 Seek(0); 3635 Seek(0);
3677 NewSegmentAppend_ExpectFailure("0K 30 30K 60"); 3636 NewCodedFrameGroupAppend_ExpectFailure("0K 30 30K 60");
3678 } 3637 }
3679 3638
3680 // If seeking past any existing range and the seek is pending 3639 // If seeking past any existing range and the seek is pending
3681 // because no data has been provided for that position, 3640 // because no data has been provided for that position,
3682 // the stream position can be considered as the end of stream. 3641 // the stream position can be considered as the end of stream.
3683 TEST_F(SourceBufferStreamTest, EndSelected_During_PendingSeek) { 3642 TEST_F(SourceBufferStreamTest, EndSelected_During_PendingSeek) {
3684 // Append 15 buffers at positions 0 through 14. 3643 // Append 15 buffers at positions 0 through 14.
3685 NewSegmentAppend(0, 15); 3644 NewCodedFrameGroupAppend(0, 15);
3686 3645
3687 Seek(20); 3646 Seek(20);
3688 EXPECT_TRUE(stream_->IsSeekPending()); 3647 EXPECT_TRUE(stream_->IsSeekPending());
3689 stream_->MarkEndOfStream(); 3648 stream_->MarkEndOfStream();
3690 EXPECT_FALSE(stream_->IsSeekPending()); 3649 EXPECT_FALSE(stream_->IsSeekPending());
3691 } 3650 }
3692 3651
3693 // If there is a pending seek between 2 existing ranges, 3652 // If there is a pending seek between 2 existing ranges,
3694 // the end of the stream has not been reached. 3653 // the end of the stream has not been reached.
3695 TEST_F(SourceBufferStreamTest, EndNotSelected_During_PendingSeek) { 3654 TEST_F(SourceBufferStreamTest, EndNotSelected_During_PendingSeek) {
3696 // Append: 3655 // Append:
3697 // - 10 buffers at positions 0 through 9. 3656 // - 10 buffers at positions 0 through 9.
3698 // - 10 buffers at positions 30 through 39 3657 // - 10 buffers at positions 30 through 39
3699 NewSegmentAppend(0, 10); 3658 NewCodedFrameGroupAppend(0, 10);
3700 NewSegmentAppend(30, 10); 3659 NewCodedFrameGroupAppend(30, 10);
3701 3660
3702 Seek(20); 3661 Seek(20);
3703 EXPECT_TRUE(stream_->IsSeekPending()); 3662 EXPECT_TRUE(stream_->IsSeekPending());
3704 stream_->MarkEndOfStream(); 3663 stream_->MarkEndOfStream();
3705 EXPECT_TRUE(stream_->IsSeekPending()); 3664 EXPECT_TRUE(stream_->IsSeekPending());
3706 } 3665 }
3707 3666
3708 3667
3709 // Removing exact start & end of a range. 3668 // Removing exact start & end of a range.
3710 TEST_F(SourceBufferStreamTest, Remove_WholeRange1) { 3669 TEST_F(SourceBufferStreamTest, Remove_WholeRange1) {
3711 Seek(0); 3670 Seek(0);
3712 NewSegmentAppend("10K 40 70K 100 130K"); 3671 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3713 CheckExpectedRangesByTimestamp("{ [10,160) }"); 3672 CheckExpectedRangesByTimestamp("{ [10,160) }");
3714 RemoveInMs(10, 160, 160); 3673 RemoveInMs(10, 160, 160);
3715 CheckExpectedRangesByTimestamp("{ }"); 3674 CheckExpectedRangesByTimestamp("{ }");
3716 } 3675 }
3717 3676
3718 // Removal range starts before range and ends exactly at end. 3677 // Removal range starts before range and ends exactly at end.
3719 TEST_F(SourceBufferStreamTest, Remove_WholeRange2) { 3678 TEST_F(SourceBufferStreamTest, Remove_WholeRange2) {
3720 Seek(0); 3679 Seek(0);
3721 NewSegmentAppend("10K 40 70K 100 130K"); 3680 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3722 CheckExpectedRangesByTimestamp("{ [10,160) }"); 3681 CheckExpectedRangesByTimestamp("{ [10,160) }");
3723 RemoveInMs(0, 160, 160); 3682 RemoveInMs(0, 160, 160);
3724 CheckExpectedRangesByTimestamp("{ }"); 3683 CheckExpectedRangesByTimestamp("{ }");
3725 } 3684 }
3726 3685
3727 // Removal range starts at the start of a range and ends beyond the 3686 // Removal range starts at the start of a range and ends beyond the
3728 // range end. 3687 // range end.
3729 TEST_F(SourceBufferStreamTest, Remove_WholeRange3) { 3688 TEST_F(SourceBufferStreamTest, Remove_WholeRange3) {
3730 Seek(0); 3689 Seek(0);
3731 NewSegmentAppend("10K 40 70K 100 130K"); 3690 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3732 CheckExpectedRangesByTimestamp("{ [10,160) }"); 3691 CheckExpectedRangesByTimestamp("{ [10,160) }");
3733 RemoveInMs(10, 200, 200); 3692 RemoveInMs(10, 200, 200);
3734 CheckExpectedRangesByTimestamp("{ }"); 3693 CheckExpectedRangesByTimestamp("{ }");
3735 } 3694 }
3736 3695
3737 // Removal range starts before range start and ends after the range end. 3696 // Removal range starts before range start and ends after the range end.
3738 TEST_F(SourceBufferStreamTest, Remove_WholeRange4) { 3697 TEST_F(SourceBufferStreamTest, Remove_WholeRange4) {
3739 Seek(0); 3698 Seek(0);
3740 NewSegmentAppend("10K 40 70K 100 130K"); 3699 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3741 CheckExpectedRangesByTimestamp("{ [10,160) }"); 3700 CheckExpectedRangesByTimestamp("{ [10,160) }");
3742 RemoveInMs(0, 200, 200); 3701 RemoveInMs(0, 200, 200);
3743 CheckExpectedRangesByTimestamp("{ }"); 3702 CheckExpectedRangesByTimestamp("{ }");
3744 } 3703 }
3745 3704
3746 // Removes multiple ranges. 3705 // Removes multiple ranges.
3747 TEST_F(SourceBufferStreamTest, Remove_WholeRange5) { 3706 TEST_F(SourceBufferStreamTest, Remove_WholeRange5) {
3748 Seek(0); 3707 Seek(0);
3749 NewSegmentAppend("10K 40 70K 100 130K"); 3708 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3750 NewSegmentAppend("1000K 1030 1060K 1090 1120K"); 3709 NewCodedFrameGroupAppend("1000K 1030 1060K 1090 1120K");
3751 NewSegmentAppend("2000K 2030 2060K 2090 2120K"); 3710 NewCodedFrameGroupAppend("2000K 2030 2060K 2090 2120K");
3752 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) [2000,2150) }"); 3711 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) [2000,2150) }");
3753 RemoveInMs(10, 3000, 3000); 3712 RemoveInMs(10, 3000, 3000);
3754 CheckExpectedRangesByTimestamp("{ }"); 3713 CheckExpectedRangesByTimestamp("{ }");
3755 } 3714 }
3756 3715
3757 // Verifies a [0-infinity) range removes everything. 3716 // Verifies a [0-infinity) range removes everything.
3758 TEST_F(SourceBufferStreamTest, Remove_ZeroToInfinity) { 3717 TEST_F(SourceBufferStreamTest, Remove_ZeroToInfinity) {
3759 Seek(0); 3718 Seek(0);
3760 NewSegmentAppend("10K 40 70K 100 130K"); 3719 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3761 NewSegmentAppend("1000K 1030 1060K 1090 1120K"); 3720 NewCodedFrameGroupAppend("1000K 1030 1060K 1090 1120K");
3762 NewSegmentAppend("2000K 2030 2060K 2090 2120K"); 3721 NewCodedFrameGroupAppend("2000K 2030 2060K 2090 2120K");
3763 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) [2000,2150) }"); 3722 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) [2000,2150) }");
3764 Remove(base::TimeDelta(), kInfiniteDuration(), kInfiniteDuration()); 3723 Remove(base::TimeDelta(), kInfiniteDuration(), kInfiniteDuration());
3765 CheckExpectedRangesByTimestamp("{ }"); 3724 CheckExpectedRangesByTimestamp("{ }");
3766 } 3725 }
3767 3726
3768 // Removal range starts at the beginning of the range and ends in the 3727 // Removal range starts at the beginning of the range and ends in the
3769 // middle of the range. This test verifies that full GOPs are removed. 3728 // middle of the range. This test verifies that full GOPs are removed.
3770 TEST_F(SourceBufferStreamTest, Remove_Partial1) { 3729 TEST_F(SourceBufferStreamTest, Remove_Partial1) {
3771 Seek(0); 3730 Seek(0);
3772 NewSegmentAppend("10K 40 70K 100 130K"); 3731 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3773 NewSegmentAppend("1000K 1030 1060K 1090 1120K"); 3732 NewCodedFrameGroupAppend("1000K 1030 1060K 1090 1120K");
3774 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) }"); 3733 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) }");
3775 RemoveInMs(0, 80, 2200); 3734 RemoveInMs(0, 80, 2200);
3776 CheckExpectedRangesByTimestamp("{ [130,160) [1000,1150) }"); 3735 CheckExpectedRangesByTimestamp("{ [130,160) [1000,1150) }");
3777 } 3736 }
3778 3737
3779 // Removal range starts in the middle of a range and ends at the exact 3738 // Removal range starts in the middle of a range and ends at the exact
3780 // end of the range. 3739 // end of the range.
3781 TEST_F(SourceBufferStreamTest, Remove_Partial2) { 3740 TEST_F(SourceBufferStreamTest, Remove_Partial2) {
3782 Seek(0); 3741 Seek(0);
3783 NewSegmentAppend("10K 40 70K 100 130K"); 3742 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3784 NewSegmentAppend("1000K 1030 1060K 1090 1120K"); 3743 NewCodedFrameGroupAppend("1000K 1030 1060K 1090 1120K");
3785 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) }"); 3744 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) }");
3786 RemoveInMs(40, 160, 2200); 3745 RemoveInMs(40, 160, 2200);
3787 CheckExpectedRangesByTimestamp("{ [10,40) [1000,1150) }"); 3746 CheckExpectedRangesByTimestamp("{ [10,40) [1000,1150) }");
3788 } 3747 }
3789 3748
3790 // Removal range starts and ends within a range. 3749 // Removal range starts and ends within a range.
3791 TEST_F(SourceBufferStreamTest, Remove_Partial3) { 3750 TEST_F(SourceBufferStreamTest, Remove_Partial3) {
3792 Seek(0); 3751 Seek(0);
3793 NewSegmentAppend("10K 40 70K 100 130K"); 3752 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3794 NewSegmentAppend("1000K 1030 1060K 1090 1120K"); 3753 NewCodedFrameGroupAppend("1000K 1030 1060K 1090 1120K");
3795 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) }"); 3754 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) }");
3796 RemoveInMs(40, 120, 2200); 3755 RemoveInMs(40, 120, 2200);
3797 CheckExpectedRangesByTimestamp("{ [10,40) [130,160) [1000,1150) }"); 3756 CheckExpectedRangesByTimestamp("{ [10,40) [130,160) [1000,1150) }");
3798 } 3757 }
3799 3758
3800 // Removal range starts in the middle of one range and ends in the 3759 // Removal range starts in the middle of one range and ends in the
3801 // middle of another range. 3760 // middle of another range.
3802 TEST_F(SourceBufferStreamTest, Remove_Partial4) { 3761 TEST_F(SourceBufferStreamTest, Remove_Partial4) {
3803 Seek(0); 3762 Seek(0);
3804 NewSegmentAppend("10K 40 70K 100 130K"); 3763 NewCodedFrameGroupAppend("10K 40 70K 100 130K");
3805 NewSegmentAppend("1000K 1030 1060K 1090 1120K"); 3764 NewCodedFrameGroupAppend("1000K 1030 1060K 1090 1120K");
3806 NewSegmentAppend("2000K 2030 2060K 2090 2120K"); 3765 NewCodedFrameGroupAppend("2000K 2030 2060K 2090 2120K");
3807 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) [2000,2150) }"); 3766 CheckExpectedRangesByTimestamp("{ [10,160) [1000,1150) [2000,2150) }");
3808 RemoveInMs(40, 2030, 2200); 3767 RemoveInMs(40, 2030, 2200);
3809 CheckExpectedRangesByTimestamp("{ [10,40) [2060,2150) }"); 3768 CheckExpectedRangesByTimestamp("{ [10,40) [2060,2150) }");
3810 } 3769 }
3811 3770
3812 // Test behavior when the current position is removed and new buffers 3771 // Test behavior when the current position is removed and new buffers
3813 // are appended over the removal range. 3772 // are appended over the removal range.
3814 TEST_F(SourceBufferStreamTest, Remove_CurrentPosition) { 3773 TEST_F(SourceBufferStreamTest, Remove_CurrentPosition) {
3815 Seek(0); 3774 Seek(0);
3816 NewSegmentAppend("0K 30 60 90K 120 150 180K 210 240 270K 300 330"); 3775 NewCodedFrameGroupAppend("0K 30 60 90K 120 150 180K 210 240 270K 300 330");
3817 CheckExpectedRangesByTimestamp("{ [0,360) }"); 3776 CheckExpectedRangesByTimestamp("{ [0,360) }");
3818 CheckExpectedBuffers("0K 30 60 90K 120"); 3777 CheckExpectedBuffers("0K 30 60 90K 120");
3819 3778
3820 // Remove a range that includes the next buffer (i.e., 150). 3779 // Remove a range that includes the next buffer (i.e., 150).
3821 RemoveInMs(150, 210, 360); 3780 RemoveInMs(150, 210, 360);
3822 CheckExpectedRangesByTimestamp("{ [0,150) [270,360) }"); 3781 CheckExpectedRangesByTimestamp("{ [0,150) [270,360) }");
3823 3782
3824 // Verify that no next buffer is returned. 3783 // Verify that no next buffer is returned.
3825 CheckNoNextBuffer(); 3784 CheckNoNextBuffer();
3826 3785
3827 // Append some buffers to fill the gap that was created. 3786 // Append some buffers to fill the gap that was created.
3828 NewSegmentAppend("120K 150 180 210K 240"); 3787 NewCodedFrameGroupAppend("120K 150 180 210K 240");
3829 CheckExpectedRangesByTimestamp("{ [0,360) }"); 3788 CheckExpectedRangesByTimestamp("{ [0,360) }");
3830 3789
3831 // Verify that buffers resume at the next keyframe after the 3790 // Verify that buffers resume at the next keyframe after the
3832 // current position. 3791 // current position.
3833 CheckExpectedBuffers("210K 240 270K 300 330"); 3792 CheckExpectedBuffers("210K 240 270K 300 330");
3834 } 3793 }
3835 3794
3836 // Test behavior when buffers in the selected range before the current position 3795 // Test behavior when buffers in the selected range before the current position
3837 // are removed. 3796 // are removed.
3838 TEST_F(SourceBufferStreamTest, Remove_BeforeCurrentPosition) { 3797 TEST_F(SourceBufferStreamTest, Remove_BeforeCurrentPosition) {
3839 Seek(0); 3798 Seek(0);
3840 NewSegmentAppend("0K 30 60 90K 120 150 180K 210 240 270K 300 330"); 3799 NewCodedFrameGroupAppend("0K 30 60 90K 120 150 180K 210 240 270K 300 330");
3841 CheckExpectedRangesByTimestamp("{ [0,360) }"); 3800 CheckExpectedRangesByTimestamp("{ [0,360) }");
3842 CheckExpectedBuffers("0K 30 60 90K 120"); 3801 CheckExpectedBuffers("0K 30 60 90K 120");
3843 3802
3844 // Remove a range that is before the current playback position. 3803 // Remove a range that is before the current playback position.
3845 RemoveInMs(0, 90, 360); 3804 RemoveInMs(0, 90, 360);
3846 CheckExpectedRangesByTimestamp("{ [90,360) }"); 3805 CheckExpectedRangesByTimestamp("{ [90,360) }");
3847 3806
3848 CheckExpectedBuffers("150 180K 210 240 270K 300 330"); 3807 CheckExpectedBuffers("150 180K 210 240 270K 300 330");
3849 } 3808 }
3850 3809
3851 // Test removing the entire range for the current media segment 3810 // Test removing the entire range for the current coded frame group
3852 // being appended. 3811 // being appended.
3853 TEST_F(SourceBufferStreamTest, Remove_MidSegment) { 3812 TEST_F(SourceBufferStreamTest, Remove_MidGroup) {
3854 Seek(0); 3813 Seek(0);
3855 NewSegmentAppend("0K 30 60 90 120K 150 180 210"); 3814 NewCodedFrameGroupAppend("0K 30 60 90 120K 150 180 210");
3856 CheckExpectedRangesByTimestamp("{ [0,240) }"); 3815 CheckExpectedRangesByTimestamp("{ [0,240) }");
3857 3816
3858 NewSegmentAppend("0K 30"); 3817 NewCodedFrameGroupAppend("0K 30");
3859 3818
3860 CheckExpectedBuffers("0K"); 3819 CheckExpectedBuffers("0K");
3861 3820
3862 CheckExpectedRangesByTimestamp("{ [0,60) [120,240) }"); 3821 CheckExpectedRangesByTimestamp("{ [0,60) [120,240) }");
3863 3822
3864 // Remove the entire range that is being appended to. 3823 // Remove the entire range that is being appended to.
3865 RemoveInMs(0, 60, 240); 3824 RemoveInMs(0, 60, 240);
3866 3825
3867 // Verify that there is no next buffer since it was removed. 3826 // Verify that there is no next buffer since it was removed.
3868 CheckNoNextBuffer(); 3827 CheckNoNextBuffer();
3869 3828
3870 CheckExpectedRangesByTimestamp("{ [120,240) }"); 3829 CheckExpectedRangesByTimestamp("{ [120,240) }");
3871 3830
3872 // Continue appending frames for the current GOP. 3831 // Continue appending frames for the current GOP.
3873 AppendBuffers("60 90"); 3832 AppendBuffers("60 90");
3874 3833
3875 // Verify that the non-keyframes are not added. 3834 // Verify that the non-keyframes are not added.
3876 CheckExpectedRangesByTimestamp("{ [120,240) }"); 3835 CheckExpectedRangesByTimestamp("{ [120,240) }");
3877 3836
3878 // Finish the previous GOP and start the next one. 3837 // Finish the previous GOP and start the next one.
3879 AppendBuffers("120 150K 180"); 3838 AppendBuffers("120 150K 180");
3880 3839
3881 // Verify that new GOP replaces the existing range. 3840 // Verify that new GOP replaces the existing range.
3882 CheckExpectedRangesByTimestamp("{ [150,210) }"); 3841 CheckExpectedRangesByTimestamp("{ [150,210) }");
3883 3842
3884
3885 SeekToTimestampMs(150); 3843 SeekToTimestampMs(150);
3886 CheckExpectedBuffers("150K 180"); 3844 CheckExpectedBuffers("150K 180");
3887 CheckNoNextBuffer(); 3845 CheckNoNextBuffer();
3888 } 3846 }
3889 3847
3890 // Test removing the current GOP being appended, while not removing 3848 // Test removing the current GOP being appended, while not removing
3891 // the entire range the GOP belongs to. 3849 // the entire range the GOP belongs to.
3892 TEST_F(SourceBufferStreamTest, Remove_GOPBeingAppended) { 3850 TEST_F(SourceBufferStreamTest, Remove_GOPBeingAppended) {
3893 Seek(0); 3851 Seek(0);
3894 NewSegmentAppend("0K 30 60 90 120K 150 180"); 3852 NewCodedFrameGroupAppend("0K 30 60 90 120K 150 180");
3895 CheckExpectedRangesByTimestamp("{ [0,210) }"); 3853 CheckExpectedRangesByTimestamp("{ [0,210) }");
3896 3854
3897 // Remove the current GOP being appended. 3855 // Remove the current GOP being appended.
3898 RemoveInMs(120, 150, 240); 3856 RemoveInMs(120, 150, 240);
3899 CheckExpectedRangesByTimestamp("{ [0,120) }"); 3857 CheckExpectedRangesByTimestamp("{ [0,120) }");
3900 3858
3901 // Continue appending the current GOP and the next one. 3859 // Continue appending the current GOP and the next one.
3902 AppendBuffers("210 240K 270 300"); 3860 AppendBuffers("210 240K 270 300");
3903 3861
3904 // Verify that the non-keyframe in the previous GOP does 3862 // Verify that the non-keyframe in the previous GOP does
3905 // not effect any existing ranges and a new range is started at the 3863 // not effect any existing ranges and a new range is started at the
3906 // beginning of the next GOP. 3864 // beginning of the next GOP.
3907 CheckExpectedRangesByTimestamp("{ [0,120) [240,330) }"); 3865 CheckExpectedRangesByTimestamp("{ [0,120) [240,330) }");
3908 3866
3909 // Verify the buffers in the ranges. 3867 // Verify the buffers in the ranges.
3910 CheckExpectedBuffers("0K 30 60 90"); 3868 CheckExpectedBuffers("0K 30 60 90");
3911 CheckNoNextBuffer(); 3869 CheckNoNextBuffer();
3912 SeekToTimestampMs(240); 3870 SeekToTimestampMs(240);
3913 CheckExpectedBuffers("240K 270 300"); 3871 CheckExpectedBuffers("240K 270 300");
3914 } 3872 }
3915 3873
3916 TEST_F(SourceBufferStreamTest, Remove_WholeGOPBeingAppended) { 3874 TEST_F(SourceBufferStreamTest, Remove_WholeGOPBeingAppended) {
3917 SeekToTimestampMs(1000); 3875 SeekToTimestampMs(1000);
3918 NewSegmentAppend("1000K 1030 1060 1090"); 3876 NewCodedFrameGroupAppend("1000K 1030 1060 1090");
3919 CheckExpectedRangesByTimestamp("{ [1000,1120) }"); 3877 CheckExpectedRangesByTimestamp("{ [1000,1120) }");
3920 3878
3921 // Remove the keyframe of the current GOP being appended. 3879 // Remove the keyframe of the current GOP being appended.
3922 RemoveInMs(1000, 1030, 1120); 3880 RemoveInMs(1000, 1030, 1120);
3923 CheckExpectedRangesByTimestamp("{ }"); 3881 CheckExpectedRangesByTimestamp("{ }");
3924 3882
3925 // Continue appending the current GOP. 3883 // Continue appending the current GOP.
3926 AppendBuffers("1210 1240"); 3884 AppendBuffers("1210 1240");
3927 3885
3928 CheckExpectedRangesByTimestamp("{ }"); 3886 CheckExpectedRangesByTimestamp("{ }");
3929 3887
3930 // Append the beginning of the next GOP. 3888 // Append the beginning of the next GOP.
3931 AppendBuffers("1270K 1300"); 3889 AppendBuffers("1270K 1300");
3932 3890
3933 // Verify that the new range is started at the 3891 // Verify that the new range is started at the
3934 // beginning of the next GOP. 3892 // beginning of the next GOP.
3935 CheckExpectedRangesByTimestamp("{ [1270,1330) }"); 3893 CheckExpectedRangesByTimestamp("{ [1270,1330) }");
3936 3894
3937 // Verify the buffers in the ranges. 3895 // Verify the buffers in the ranges.
3938 CheckNoNextBuffer(); 3896 CheckNoNextBuffer();
3939 SeekToTimestampMs(1270); 3897 SeekToTimestampMs(1270);
3940 CheckExpectedBuffers("1270K 1300"); 3898 CheckExpectedBuffers("1270K 1300");
3941 } 3899 }
3942 3900
3943 TEST_F(SourceBufferStreamTest, 3901 TEST_F(SourceBufferStreamTest,
3944 Remove_PreviousAppendDestroyedAndOverwriteExistingRange) { 3902 Remove_PreviousAppendDestroyedAndOverwriteExistingRange) {
3945 SeekToTimestampMs(90); 3903 SeekToTimestampMs(90);
3946 3904
3947 NewSegmentAppend("90K 120 150"); 3905 NewCodedFrameGroupAppend("90K 120 150");
3948 CheckExpectedRangesByTimestamp("{ [90,180) }"); 3906 CheckExpectedRangesByTimestamp("{ [90,180) }");
3949 3907
3950 // Append a segment before the previously appended data. 3908 // Append a coded frame group before the previously appended data.
3951 NewSegmentAppend("0K 30 60"); 3909 NewCodedFrameGroupAppend("0K 30 60");
3952 3910
3953 // Verify that the ranges get merged. 3911 // Verify that the ranges get merged.
3954 CheckExpectedRangesByTimestamp("{ [0,180) }"); 3912 CheckExpectedRangesByTimestamp("{ [0,180) }");
3955 3913
3956 // Remove the data from the last append. 3914 // Remove the data from the last append.
3957 RemoveInMs(0, 90, 360); 3915 RemoveInMs(0, 90, 360);
3958 CheckExpectedRangesByTimestamp("{ [90,180) }"); 3916 CheckExpectedRangesByTimestamp("{ [90,180) }");
3959 3917
3960 // Append a new segment that follows the removed segment and 3918 // Append a new coded frame group that follows the removed group and
3961 // starts at the beginning of the range left over from the 3919 // starts at the beginning of the range left over from the
3962 // remove. 3920 // remove.
3963 NewSegmentAppend("90K 121 151"); 3921 NewCodedFrameGroupAppend("90K 121 151");
3964 CheckExpectedBuffers("90K 121 151"); 3922 CheckExpectedBuffers("90K 121 151");
3965 } 3923 }
3966 3924
3967 TEST_F(SourceBufferStreamTest, Remove_GapAtBeginningOfMediaSegment) { 3925 TEST_F(SourceBufferStreamTest, Remove_GapAtBeginningOfGroup) {
3968 Seek(0); 3926 Seek(0);
3969 3927
3970 // Append a media segment that has a gap at the beginning of it. 3928 // Append a coded frame group that has a gap at the beginning of it.
3971 NewSegmentAppend(base::TimeDelta::FromMilliseconds(0), 3929 NewCodedFrameGroupAppend(base::TimeDelta::FromMilliseconds(0),
3972 "30K 60 90 120K 150"); 3930 "30K 60 90 120K 150");
3973 CheckExpectedRangesByTimestamp("{ [0,180) }"); 3931 CheckExpectedRangesByTimestamp("{ [0,180) }");
3974 3932
3975 // Remove the gap that doesn't contain any buffers. 3933 // Remove the gap that doesn't contain any buffers.
3976 RemoveInMs(0, 10, 180); 3934 RemoveInMs(0, 10, 180);
3977 CheckExpectedRangesByTimestamp("{ [10,180) }"); 3935 CheckExpectedRangesByTimestamp("{ [10,180) }");
3978 3936
3979 // Verify we still get the first buffer still since only part of 3937 // Verify we still get the first buffer still since only part of
3980 // the gap was removed. 3938 // the gap was removed.
3981 // TODO(acolwell/wolenetz): Consider not returning a buffer at this 3939 // TODO(acolwell/wolenetz): Consider not returning a buffer at this
3982 // point since the current seek position has been explicitly 3940 // point since the current seek position has been explicitly
3983 // removed but didn't happen to remove any buffers. 3941 // removed but didn't happen to remove any buffers.
3984 // http://crbug.com/384016 3942 // http://crbug.com/384016
3985 CheckExpectedBuffers("30K"); 3943 CheckExpectedBuffers("30K");
3986 3944
3987 // Remove a range that includes the first GOP. 3945 // Remove a range that includes the first GOP.
3988 RemoveInMs(0, 60, 180); 3946 RemoveInMs(0, 60, 180);
3989 3947
3990 // Verify that no buffer is returned because the current buffer 3948 // Verify that no buffer is returned because the current buffer
3991 // position has been removed. 3949 // position has been removed.
3992 CheckNoNextBuffer(); 3950 CheckNoNextBuffer();
3993 3951
3994 CheckExpectedRangesByTimestamp("{ [120,180) }"); 3952 CheckExpectedRangesByTimestamp("{ [120,180) }");
3995 } 3953 }
3996 3954
3997 TEST_F(SourceBufferStreamTest, Text_Append_SingleRange) { 3955 TEST_F(SourceBufferStreamTest, Text_Append_SingleRange) {
3998 SetTextStream(); 3956 SetTextStream();
3999 NewSegmentAppend("0K 500K 1000K"); 3957 NewCodedFrameGroupAppend("0K 500K 1000K");
4000 CheckExpectedRangesByTimestamp("{ [0,1500) }"); 3958 CheckExpectedRangesByTimestamp("{ [0,1500) }");
4001 3959
4002 Seek(0); 3960 Seek(0);
4003 CheckExpectedBuffers("0K 500K 1000K"); 3961 CheckExpectedBuffers("0K 500K 1000K");
4004 } 3962 }
4005 3963
4006 TEST_F(SourceBufferStreamTest, Text_Append_DisjointAfter) { 3964 TEST_F(SourceBufferStreamTest, Text_Append_DisjointAfter) {
4007 SetTextStream(); 3965 SetTextStream();
4008 NewSegmentAppend("0K 500K 1000K"); 3966 NewCodedFrameGroupAppend("0K 500K 1000K");
4009 CheckExpectedRangesByTimestamp("{ [0,1500) }"); 3967 CheckExpectedRangesByTimestamp("{ [0,1500) }");
4010 NewSegmentAppend("3000K 3500K 4000K"); 3968 NewCodedFrameGroupAppend("3000K 3500K 4000K");
4011 CheckExpectedRangesByTimestamp("{ [0,4500) }"); 3969 CheckExpectedRangesByTimestamp("{ [0,4500) }");
4012 3970
4013 Seek(0); 3971 Seek(0);
4014 CheckExpectedBuffers("0K 500K 1000K 3000K 3500K 4000K"); 3972 CheckExpectedBuffers("0K 500K 1000K 3000K 3500K 4000K");
4015 } 3973 }
4016 3974
4017 TEST_F(SourceBufferStreamTest, Text_Append_DisjointBefore) { 3975 TEST_F(SourceBufferStreamTest, Text_Append_DisjointBefore) {
4018 SetTextStream(); 3976 SetTextStream();
4019 NewSegmentAppend("3000K 3500K 4000K"); 3977 NewCodedFrameGroupAppend("3000K 3500K 4000K");
4020 CheckExpectedRangesByTimestamp("{ [3000,4500) }"); 3978 CheckExpectedRangesByTimestamp("{ [3000,4500) }");
4021 NewSegmentAppend("0K 500K 1000K"); 3979 NewCodedFrameGroupAppend("0K 500K 1000K");
4022 CheckExpectedRangesByTimestamp("{ [0,4500) }"); 3980 CheckExpectedRangesByTimestamp("{ [0,4500) }");
4023 3981
4024 Seek(0); 3982 Seek(0);
4025 CheckExpectedBuffers("0K 500K 1000K 3000K 3500K 4000K"); 3983 CheckExpectedBuffers("0K 500K 1000K 3000K 3500K 4000K");
4026 } 3984 }
4027 3985
4028 TEST_F(SourceBufferStreamTest, Text_CompleteOverlap) { 3986 TEST_F(SourceBufferStreamTest, Text_CompleteOverlap) {
4029 SetTextStream(); 3987 SetTextStream();
4030 NewSegmentAppend("3000K 3500K 4000K"); 3988 NewCodedFrameGroupAppend("3000K 3500K 4000K");
4031 CheckExpectedRangesByTimestamp("{ [3000,4500) }"); 3989 CheckExpectedRangesByTimestamp("{ [3000,4500) }");
4032 NewSegmentAppend("0K 501K 1001K 1501K 2001K 2501K " 3990 NewCodedFrameGroupAppend(
4033 "3001K 3501K 4001K 4501K 5001K"); 3991 "0K 501K 1001K 1501K 2001K 2501K "
3992 "3001K 3501K 4001K 4501K 5001K");
4034 CheckExpectedRangesByTimestamp("{ [0,5501) }"); 3993 CheckExpectedRangesByTimestamp("{ [0,5501) }");
4035 3994
4036 Seek(0); 3995 Seek(0);
4037 CheckExpectedBuffers("0K 501K 1001K 1501K 2001K 2501K " 3996 CheckExpectedBuffers("0K 501K 1001K 1501K 2001K 2501K "
4038 "3001K 3501K 4001K 4501K 5001K"); 3997 "3001K 3501K 4001K 4501K 5001K");
4039 } 3998 }
4040 3999
4041 TEST_F(SourceBufferStreamTest, Text_OverlapAfter) { 4000 TEST_F(SourceBufferStreamTest, Text_OverlapAfter) {
4042 SetTextStream(); 4001 SetTextStream();
4043 NewSegmentAppend("0K 500K 1000K 1500K 2000K"); 4002 NewCodedFrameGroupAppend("0K 500K 1000K 1500K 2000K");
4044 CheckExpectedRangesByTimestamp("{ [0,2500) }"); 4003 CheckExpectedRangesByTimestamp("{ [0,2500) }");
4045 NewSegmentAppend("1499K 2001K 2501K 3001K"); 4004 NewCodedFrameGroupAppend("1499K 2001K 2501K 3001K");
4046 CheckExpectedRangesByTimestamp("{ [0,3501) }"); 4005 CheckExpectedRangesByTimestamp("{ [0,3501) }");
4047 4006
4048 Seek(0); 4007 Seek(0);
4049 CheckExpectedBuffers("0K 500K 1000K 1499K 2001K 2501K 3001K"); 4008 CheckExpectedBuffers("0K 500K 1000K 1499K 2001K 2501K 3001K");
4050 } 4009 }
4051 4010
4052 TEST_F(SourceBufferStreamTest, Text_OverlapBefore) { 4011 TEST_F(SourceBufferStreamTest, Text_OverlapBefore) {
4053 SetTextStream(); 4012 SetTextStream();
4054 NewSegmentAppend("1500K 2000K 2500K 3000K 3500K"); 4013 NewCodedFrameGroupAppend("1500K 2000K 2500K 3000K 3500K");
4055 CheckExpectedRangesByTimestamp("{ [1500,4000) }"); 4014 CheckExpectedRangesByTimestamp("{ [1500,4000) }");
4056 NewSegmentAppend("0K 501K 1001K 1501K 2001K"); 4015 NewCodedFrameGroupAppend("0K 501K 1001K 1501K 2001K");
4057 CheckExpectedRangesByTimestamp("{ [0,4000) }"); 4016 CheckExpectedRangesByTimestamp("{ [0,4000) }");
4058 4017
4059 Seek(0); 4018 Seek(0);
4060 CheckExpectedBuffers("0K 501K 1001K 1501K 2001K 3000K 3500K"); 4019 CheckExpectedBuffers("0K 501K 1001K 1501K 2001K 3000K 3500K");
4061 } 4020 }
4062 4021
4063 TEST_F(SourceBufferStreamTest, SpliceFrame_Basic) { 4022 TEST_F(SourceBufferStreamTest, SpliceFrame_Basic) {
4064 Seek(0); 4023 Seek(0);
4065 NewSegmentAppend("0K S(3K 6 9D3 10D5) 15 20 S(25K 30D5 35D5) 40"); 4024 NewCodedFrameGroupAppend("0K S(3K 6 9D3 10D5) 15 20 S(25K 30D5 35D5) 40");
4066 CheckExpectedBuffers("0K 3K 6 9 C 10 15 20 25K 30 C 35 40"); 4025 CheckExpectedBuffers("0K 3K 6 9 C 10 15 20 25K 30 C 35 40");
4067 CheckNoNextBuffer(); 4026 CheckNoNextBuffer();
4068 } 4027 }
4069 4028
4070 TEST_F(SourceBufferStreamTest, SpliceFrame_SeekClearsSplice) { 4029 TEST_F(SourceBufferStreamTest, SpliceFrame_SeekClearsSplice) {
4071 Seek(0); 4030 Seek(0);
4072 NewSegmentAppend("0K S(3K 6 9D3 10D5) 15K 20"); 4031 NewCodedFrameGroupAppend("0K S(3K 6 9D3 10D5) 15K 20");
4073 CheckExpectedBuffers("0K 3K 6"); 4032 CheckExpectedBuffers("0K 3K 6");
4074 4033
4075 SeekToTimestampMs(15); 4034 SeekToTimestampMs(15);
4076 CheckExpectedBuffers("15K 20"); 4035 CheckExpectedBuffers("15K 20");
4077 CheckNoNextBuffer(); 4036 CheckNoNextBuffer();
4078 } 4037 }
4079 4038
4080 TEST_F(SourceBufferStreamTest, SpliceFrame_SeekClearsSpliceFromTrackBuffer) { 4039 TEST_F(SourceBufferStreamTest, SpliceFrame_SeekClearsSpliceFromTrackBuffer) {
4081 Seek(0); 4040 Seek(0);
4082 NewSegmentAppend("0K 2K S(3K 6 9D3 10D5) 15K 20"); 4041 NewCodedFrameGroupAppend("0K 2K S(3K 6 9D3 10D5) 15K 20");
4083 CheckExpectedBuffers("0K 2K"); 4042 CheckExpectedBuffers("0K 2K");
4084 4043
4085 // Overlap the existing segment. 4044 // Overlap the existing coded frame group.
4086 NewSegmentAppend("5K 15K 20"); 4045 NewCodedFrameGroupAppend("5K 15K 20");
4087 CheckExpectedBuffers("3K 6"); 4046 CheckExpectedBuffers("3K 6");
4088 4047
4089 SeekToTimestampMs(15); 4048 SeekToTimestampMs(15);
4090 CheckExpectedBuffers("15K 20"); 4049 CheckExpectedBuffers("15K 20");
4091 CheckNoNextBuffer(); 4050 CheckNoNextBuffer();
4092 } 4051 }
4093 4052
4094 TEST_F(SourceBufferStreamTest, SpliceFrame_ConfigChangeWithinSplice) { 4053 TEST_F(SourceBufferStreamTest, SpliceFrame_ConfigChangeWithinSplice) {
4095 VideoDecoderConfig new_config = TestVideoConfig::Large(); 4054 VideoDecoderConfig new_config = TestVideoConfig::Large();
4096 ASSERT_FALSE(new_config.Matches(video_config_)); 4055 ASSERT_FALSE(new_config.Matches(video_config_));
4097 4056
4098 // Add a new video config, then reset the config index back to the original. 4057 // Add a new video config, then reset the config index back to the original.
4099 stream_->UpdateVideoConfig(new_config); 4058 stream_->UpdateVideoConfig(new_config);
4100 stream_->UpdateVideoConfig(video_config_); 4059 stream_->UpdateVideoConfig(video_config_);
4101 4060
4102 Seek(0); 4061 Seek(0);
4103 CheckVideoConfig(video_config_); 4062 CheckVideoConfig(video_config_);
4104 NewSegmentAppend("0K S(3K 6C 9D3 10D5) 15"); 4063 NewCodedFrameGroupAppend("0K S(3K 6C 9D3 10D5) 15");
4105 4064
4106 CheckExpectedBuffers("0K 3K C"); 4065 CheckExpectedBuffers("0K 3K C");
4107 CheckVideoConfig(new_config); 4066 CheckVideoConfig(new_config);
4108 CheckExpectedBuffers("6 9 C"); 4067 CheckExpectedBuffers("6 9 C");
4109 CheckExpectedBuffers("10 C"); 4068 CheckExpectedBuffers("10 C");
4110 CheckVideoConfig(video_config_); 4069 CheckVideoConfig(video_config_);
4111 CheckExpectedBuffers("15"); 4070 CheckExpectedBuffers("15");
4112 CheckNoNextBuffer(); 4071 CheckNoNextBuffer();
4113 } 4072 }
4114 4073
4115 TEST_F(SourceBufferStreamTest, SpliceFrame_BasicFromTrackBuffer) { 4074 TEST_F(SourceBufferStreamTest, SpliceFrame_BasicFromTrackBuffer) {
4116 Seek(0); 4075 Seek(0);
4117 NewSegmentAppend("0K 5K S(8K 9D1 10D10) 20"); 4076 NewCodedFrameGroupAppend("0K 5K S(8K 9D1 10D10) 20");
4118 CheckExpectedBuffers("0K 5K"); 4077 CheckExpectedBuffers("0K 5K");
4119 4078
4120 // Overlap the existing segment. 4079 // Overlap the existing coded frame group.
4121 NewSegmentAppend("5K 20"); 4080 NewCodedFrameGroupAppend("5K 20");
4122 CheckExpectedBuffers("8K 9 C 10 20"); 4081 CheckExpectedBuffers("8K 9 C 10 20");
4123 CheckNoNextBuffer(); 4082 CheckNoNextBuffer();
4124 } 4083 }
4125 4084
4126 TEST_F(SourceBufferStreamTest, 4085 TEST_F(SourceBufferStreamTest,
4127 SpliceFrame_ConfigChangeWithinSpliceFromTrackBuffer) { 4086 SpliceFrame_ConfigChangeWithinSpliceFromTrackBuffer) {
4128 VideoDecoderConfig new_config = TestVideoConfig::Large(); 4087 VideoDecoderConfig new_config = TestVideoConfig::Large();
4129 ASSERT_FALSE(new_config.Matches(video_config_)); 4088 ASSERT_FALSE(new_config.Matches(video_config_));
4130 4089
4131 // Add a new video config, then reset the config index back to the original. 4090 // Add a new video config, then reset the config index back to the original.
4132 stream_->UpdateVideoConfig(new_config); 4091 stream_->UpdateVideoConfig(new_config);
4133 stream_->UpdateVideoConfig(video_config_); 4092 stream_->UpdateVideoConfig(video_config_);
4134 4093
4135 Seek(0); 4094 Seek(0);
4136 CheckVideoConfig(video_config_); 4095 CheckVideoConfig(video_config_);
4137 NewSegmentAppend("0K 5K S(7K 8C 9D1 10D10) 20"); 4096 NewCodedFrameGroupAppend("0K 5K S(7K 8C 9D1 10D10) 20");
4138 CheckExpectedBuffers("0K 5K"); 4097 CheckExpectedBuffers("0K 5K");
4139 4098
4140 // Overlap the existing segment. 4099 // Overlap the existing coded frame group.
4141 NewSegmentAppend("5K 20"); 4100 NewCodedFrameGroupAppend("5K 20");
4142 CheckExpectedBuffers("7K C"); 4101 CheckExpectedBuffers("7K C");
4143 CheckVideoConfig(new_config); 4102 CheckVideoConfig(new_config);
4144 CheckExpectedBuffers("8 9 C"); 4103 CheckExpectedBuffers("8 9 C");
4145 CheckExpectedBuffers("10 C"); 4104 CheckExpectedBuffers("10 C");
4146 CheckVideoConfig(video_config_); 4105 CheckVideoConfig(video_config_);
4147 CheckExpectedBuffers("20"); 4106 CheckExpectedBuffers("20");
4148 CheckNoNextBuffer(); 4107 CheckNoNextBuffer();
4149 } 4108 }
4150 4109
4151 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_Basic) { 4110 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_Basic) {
4152 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 11000)); 4111 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 11000));
4153 4112
4154 SetAudioStream(); 4113 SetAudioStream();
4155 Seek(0); 4114 Seek(0);
4156 NewSegmentAppend("0K 2K 4K 6K 8K 10K 12K"); 4115 NewCodedFrameGroupAppend("0K 2K 4K 6K 8K 10K 12K");
4157 NewSegmentAppend("11K 13K 15K 17K"); 4116 NewCodedFrameGroupAppend("11K 13K 15K 17K");
4158 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K C 11K 13K 15K 17K"); 4117 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K C 11K 13K 15K 17K");
4159 CheckNoNextBuffer(); 4118 CheckNoNextBuffer();
4160 } 4119 }
4161 4120
4162 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoExactSplices) { 4121 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoExactSplices) {
4163 EXPECT_MEDIA_LOG( 4122 EXPECT_MEDIA_LOG(
4164 HasSubstr("Skipping splice frame generation: first new buffer at 10000us " 4123 HasSubstr("Skipping splice frame generation: first new buffer at 10000us "
4165 "begins at or before existing buffer at 10000us.")); 4124 "begins at or before existing buffer at 10000us."));
4166 4125
4167 SetAudioStream(); 4126 SetAudioStream();
4168 Seek(0); 4127 Seek(0);
4169 NewSegmentAppend("0K 2K 4K 6K 8K 10K 12K"); 4128 NewCodedFrameGroupAppend("0K 2K 4K 6K 8K 10K 12K");
4170 NewSegmentAppend("10K 14K"); 4129 NewCodedFrameGroupAppend("10K 14K");
4171 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 14K"); 4130 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 14K");
4172 CheckNoNextBuffer(); 4131 CheckNoNextBuffer();
4173 } 4132 }
4174 4133
4175 // Do not allow splices on top of splices. 4134 // Do not allow splices on top of splices.
4176 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoDoubleSplice) { 4135 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoDoubleSplice) {
4177 InSequence s; 4136 InSequence s;
4178 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 11000)); 4137 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 11000));
4179 EXPECT_MEDIA_LOG( 4138 EXPECT_MEDIA_LOG(
4180 HasSubstr("Skipping splice frame generation: overlapped buffers at " 4139 HasSubstr("Skipping splice frame generation: overlapped buffers at "
4181 "10000us are in a previously buffered splice.")); 4140 "10000us are in a previously buffered splice."));
4182 4141
4183 SetAudioStream(); 4142 SetAudioStream();
4184 Seek(0); 4143 Seek(0);
4185 NewSegmentAppend("0K 2K 4K 6K 8K 10K 12K"); 4144 NewCodedFrameGroupAppend("0K 2K 4K 6K 8K 10K 12K");
4186 NewSegmentAppend("11K 13K 15K 17K"); 4145 NewCodedFrameGroupAppend("11K 13K 15K 17K");
4187 4146
4188 // Verify the splice was created. 4147 // Verify the splice was created.
4189 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K C 11K 13K 15K 17K"); 4148 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K C 11K 13K 15K 17K");
4190 CheckNoNextBuffer(); 4149 CheckNoNextBuffer();
4191 Seek(0); 4150 Seek(0);
4192 4151
4193 // Create a splice before the first splice which would include it. 4152 // Create a splice before the first splice which would include it.
4194 NewSegmentAppend("9D2K"); 4153 NewCodedFrameGroupAppend("9D2K");
4195 4154
4196 // A splice on top of a splice should result in a discard of the original 4155 // A splice on top of a splice should result in a discard of the original
4197 // splice and no new splice frame being generated. 4156 // splice and no new splice frame being generated.
4198 CheckExpectedBuffers("0K 2K 4K 6K 8K 9K 13K 15K 17K"); 4157 CheckExpectedBuffers("0K 2K 4K 6K 8K 9K 13K 15K 17K");
4199 CheckNoNextBuffer(); 4158 CheckNoNextBuffer();
4200 } 4159 }
4201 4160
4202 // Test that a splice is not created if an end timestamp and start timestamp 4161 // Test that a splice is not created if an end timestamp and start timestamp
4203 // overlap. 4162 // overlap.
4204 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoSplice) { 4163 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoSplice) {
4205 SetAudioStream(); 4164 SetAudioStream();
4206 Seek(0); 4165 Seek(0);
4207 NewSegmentAppend("0K 2K 4K 6K 8K 10K"); 4166 NewCodedFrameGroupAppend("0K 2K 4K 6K 8K 10K");
4208 NewSegmentAppend("12K 14K 16K 18K"); 4167 NewCodedFrameGroupAppend("12K 14K 16K 18K");
4209 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K 14K 16K 18K"); 4168 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K 14K 16K 18K");
4210 CheckNoNextBuffer(); 4169 CheckNoNextBuffer();
4211 } 4170 }
4212 4171
4213 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_CorrectMediaSegmentStartTime) { 4172 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_CorrectGroupStartTime) {
4214 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(5000, 1000)); 4173 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(5000, 1000));
4215 4174
4216 SetAudioStream(); 4175 SetAudioStream();
4217 Seek(0); 4176 Seek(0);
4218 NewSegmentAppend("0K 2K 4K"); 4177 NewCodedFrameGroupAppend("0K 2K 4K");
4219 CheckExpectedRangesByTimestamp("{ [0,6) }"); 4178 CheckExpectedRangesByTimestamp("{ [0,6) }");
4220 NewSegmentAppend("6K 8K 10K"); 4179 NewCodedFrameGroupAppend("6K 8K 10K");
4221 CheckExpectedRangesByTimestamp("{ [0,12) }"); 4180 CheckExpectedRangesByTimestamp("{ [0,12) }");
4222 NewSegmentAppend("1K 4D2K"); 4181 NewCodedFrameGroupAppend("1K 4D2K");
4223 CheckExpectedRangesByTimestamp("{ [0,12) }"); 4182 CheckExpectedRangesByTimestamp("{ [0,12) }");
4224 CheckExpectedBuffers("0K 2K 4K C 1K 4K 6K 8K 10K"); 4183 CheckExpectedBuffers("0K 2K 4K C 1K 4K 6K 8K 10K");
4225 CheckNoNextBuffer(); 4184 CheckNoNextBuffer();
4226 } 4185 }
4227 4186
4228 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_ConfigChange) { 4187 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_ConfigChange) {
4229 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 5000)); 4188 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 5000));
4230 4189
4231 SetAudioStream(); 4190 SetAudioStream();
4232 4191
4233 AudioDecoderConfig new_config(kCodecVorbis, kSampleFormatPlanarF32, 4192 AudioDecoderConfig new_config(kCodecVorbis, kSampleFormatPlanarF32,
4234 CHANNEL_LAYOUT_MONO, 1000, EmptyExtraData(), 4193 CHANNEL_LAYOUT_MONO, 1000, EmptyExtraData(),
4235 false); 4194 false);
4236 ASSERT_NE(new_config.channel_layout(), audio_config_.channel_layout()); 4195 ASSERT_NE(new_config.channel_layout(), audio_config_.channel_layout());
4237 4196
4238 Seek(0); 4197 Seek(0);
4239 CheckAudioConfig(audio_config_); 4198 CheckAudioConfig(audio_config_);
4240 NewSegmentAppend("0K 2K 4K 6K"); 4199 NewCodedFrameGroupAppend("0K 2K 4K 6K");
4241 stream_->UpdateAudioConfig(new_config); 4200 stream_->UpdateAudioConfig(new_config);
4242 NewSegmentAppend("5K 8K 12K"); 4201 NewCodedFrameGroupAppend("5K 8K 12K");
4243 CheckExpectedBuffers("0K 2K 4K 6K C 5K 8K 12K"); 4202 CheckExpectedBuffers("0K 2K 4K 6K C 5K 8K 12K");
4244 CheckAudioConfig(new_config); 4203 CheckAudioConfig(new_config);
4245 CheckNoNextBuffer(); 4204 CheckNoNextBuffer();
4246 } 4205 }
4247 4206
4248 // Ensure splices are not created if there are not enough frames to crossfade. 4207 // Ensure splices are not created if there are not enough frames to crossfade.
4249 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoTinySplices) { 4208 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoTinySplices) {
4250 EXPECT_MEDIA_LOG(HasSubstr( 4209 EXPECT_MEDIA_LOG(HasSubstr(
4251 "Skipping splice frame generation: not enough samples for splicing new " 4210 "Skipping splice frame generation: not enough samples for splicing new "
4252 "buffer at 1000us. Have 1000us, but need 2000us.")); 4211 "buffer at 1000us. Have 1000us, but need 2000us."));
4253 4212
4254 SetAudioStream(); 4213 SetAudioStream();
4255 Seek(0); 4214 Seek(0);
4256 4215
4257 // Overlap the range [0, 2) with [1, 3). Since each frame has a duration of 4216 // Overlap the range [0, 2) with [1, 3). Since each frame has a duration of
4258 // 2ms this results in an overlap of 1ms between the ranges. A splice frame 4217 // 2ms this results in an overlap of 1ms between the ranges. A splice frame
4259 // should not be generated since it requires at least 2 frames, or 2ms in this 4218 // should not be generated since it requires at least 2 frames, or 2ms in this
4260 // case, of data to crossfade. 4219 // case, of data to crossfade.
4261 NewSegmentAppend("0D2K"); 4220 NewCodedFrameGroupAppend("0D2K");
4262 CheckExpectedRangesByTimestamp("{ [0,2) }"); 4221 CheckExpectedRangesByTimestamp("{ [0,2) }");
4263 NewSegmentAppend("1D2K"); 4222 NewCodedFrameGroupAppend("1D2K");
4264 CheckExpectedRangesByTimestamp("{ [0,3) }"); 4223 CheckExpectedRangesByTimestamp("{ [0,3) }");
4265 CheckExpectedBuffers("0K 1K"); 4224 CheckExpectedBuffers("0K 1K");
4266 CheckNoNextBuffer(); 4225 CheckNoNextBuffer();
4267 } 4226 }
4268 4227
4269 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoMillisecondSplices) { 4228 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_NoMillisecondSplices) {
4270 EXPECT_MEDIA_LOG( 4229 EXPECT_MEDIA_LOG(
4271 HasSubstr("Skipping splice frame generation: not enough samples for " 4230 HasSubstr("Skipping splice frame generation: not enough samples for "
4272 "splicing new buffer at 1250us. Have 750us, but need 1000us.")); 4231 "splicing new buffer at 1250us. Have 750us, but need 1000us."));
4273 4232
4274 video_config_ = TestVideoConfig::Invalid(); 4233 video_config_ = TestVideoConfig::Invalid();
4275 audio_config_.Initialize(kCodecVorbis, kSampleFormatPlanarF32, 4234 audio_config_.Initialize(kCodecVorbis, kSampleFormatPlanarF32,
4276 CHANNEL_LAYOUT_STEREO, 4000, EmptyExtraData(), false, 4235 CHANNEL_LAYOUT_STEREO, 4000, EmptyExtraData(), false,
4277 base::TimeDelta(), 0); 4236 base::TimeDelta(), 0);
4278 stream_.reset(new SourceBufferStream(audio_config_, media_log_, true)); 4237 stream_.reset(new SourceBufferStream(audio_config_, media_log_, true));
4279 // Equivalent to 0.5ms per frame. 4238 // Equivalent to 0.5ms per frame.
4280 SetStreamInfo(2000, 2000); 4239 SetStreamInfo(2000, 2000);
4281 Seek(0); 4240 Seek(0);
4282 4241
4283 // Append four buffers with a 0.5ms duration each. 4242 // Append four buffers with a 0.5ms duration each.
4284 NewSegmentAppend(0, 4); 4243 NewCodedFrameGroupAppend(0, 4);
4285 CheckExpectedRangesByTimestamp("{ [0,2) }"); 4244 CheckExpectedRangesByTimestamp("{ [0,2) }");
4286 4245
4287 // Overlap the range [0, 2) with [1.25, 2); this results in an overlap of 4246 // Overlap the range [0, 2) with [1.25, 2); this results in an overlap of
4288 // 0.75ms between the ranges. 4247 // 0.75ms between the ranges.
4289 NewSegmentAppend_OffsetFirstBuffer(2, 2, 4248 NewCodedFrameGroupAppend_OffsetFirstBuffer(
4290 base::TimeDelta::FromMillisecondsD(0.25)); 4249 2, 2, base::TimeDelta::FromMillisecondsD(0.25));
4291 CheckExpectedRangesByTimestamp("{ [0,2) }"); 4250 CheckExpectedRangesByTimestamp("{ [0,2) }");
4292 4251
4293 // A splice frame should not be generated (indicated by the lack of a config 4252 // A splice frame should not be generated (indicated by the lack of a config
4294 // change in the expected buffer string) since it requires at least 1ms of 4253 // change in the expected buffer string) since it requires at least 1ms of
4295 // data to crossfade. 4254 // data to crossfade.
4296 CheckExpectedBuffers("0K 0K 1K 1K 1K"); 4255 CheckExpectedBuffers("0K 0K 1K 1K 1K");
4297 CheckNoNextBuffer(); 4256 CheckNoNextBuffer();
4298 } 4257 }
4299 4258
4300 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_Preroll) { 4259 TEST_F(SourceBufferStreamTest, Audio_SpliceFrame_Preroll) {
4301 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 11000)); 4260 EXPECT_MEDIA_LOG(ContainsGeneratedSpliceLog(3000, 11000));
4302 4261
4303 SetAudioStream(); 4262 SetAudioStream();
4304 Seek(0); 4263 Seek(0);
4305 NewSegmentAppend("0K 2K 4K 6K 8K 10K 12K"); 4264 NewCodedFrameGroupAppend("0K 2K 4K 6K 8K 10K 12K");
4306 NewSegmentAppend("11P 13K 15K 17K"); 4265 NewCodedFrameGroupAppend("11P 13K 15K 17K");
4307 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K C 11P 13K 15K 17K"); 4266 CheckExpectedBuffers("0K 2K 4K 6K 8K 10K 12K C 11P 13K 15K 17K");
4308 CheckNoNextBuffer(); 4267 CheckNoNextBuffer();
4309 } 4268 }
4310 4269
4311 TEST_F(SourceBufferStreamTest, Audio_PrerollFrame) { 4270 TEST_F(SourceBufferStreamTest, Audio_PrerollFrame) {
4312 Seek(0); 4271 Seek(0);
4313 NewSegmentAppend("0K 3P 6K"); 4272 NewCodedFrameGroupAppend("0K 3P 6K");
4314 CheckExpectedBuffers("0K 3P 6K"); 4273 CheckExpectedBuffers("0K 3P 6K");
4315 CheckNoNextBuffer(); 4274 CheckNoNextBuffer();
4316 } 4275 }
4317 4276
4318 TEST_F(SourceBufferStreamTest, BFrames) { 4277 TEST_F(SourceBufferStreamTest, BFrames) {
4319 Seek(0); 4278 Seek(0);
4320 NewSegmentAppend("0K 120|30 30|60 60|90 90|120"); 4279 NewCodedFrameGroupAppend("0K 120|30 30|60 60|90 90|120");
4321 CheckExpectedRangesByTimestamp("{ [0,150) }"); 4280 CheckExpectedRangesByTimestamp("{ [0,150) }");
4322 4281
4323 CheckExpectedBuffers("0K 120|30 30|60 60|90 90|120"); 4282 CheckExpectedBuffers("0K 120|30 30|60 60|90 90|120");
4324 CheckNoNextBuffer(); 4283 CheckNoNextBuffer();
4325 } 4284 }
4326 4285
4327 TEST_F(SourceBufferStreamTest, RemoveShouldAlwaysExcludeEnd) { 4286 TEST_F(SourceBufferStreamTest, RemoveShouldAlwaysExcludeEnd) {
4328 NewSegmentAppend("10D2K 12D2 14D2"); 4287 NewCodedFrameGroupAppend("10D2K 12D2 14D2");
4329 CheckExpectedRangesByTimestamp("{ [10,16) }"); 4288 CheckExpectedRangesByTimestamp("{ [10,16) }");
4330 4289
4331 // Start new segment, appending KF to abut the start of previous segment. 4290 // Start new coded frame group, appending KF to abut the start of previous
4332 NewSegmentAppend("0D10K"); 4291 // group.
4292 NewCodedFrameGroupAppend("0D10K");
4333 Seek(0); 4293 Seek(0);
4334 CheckExpectedRangesByTimestamp("{ [0,16) }"); 4294 CheckExpectedRangesByTimestamp("{ [0,16) }");
4335 CheckExpectedBuffers("0K 10K 12 14"); 4295 CheckExpectedBuffers("0K 10K 12 14");
4336 CheckNoNextBuffer(); 4296 CheckNoNextBuffer();
4337 4297
4338 // Append another buffer with the same timestamp as the last KF. This triggers 4298 // Append another buffer with the same timestamp as the last KF. This triggers
4339 // special logic that allows two buffers to have the same timestamp. When 4299 // special logic that allows two buffers to have the same timestamp. When
4340 // preparing for this new append, there is no reason to remove the later GOP 4300 // preparing for this new append, there is no reason to remove the later GOP
4341 // starting at timestamp 10. This verifies the fix for http://crbug.com/469325 4301 // starting at timestamp 10. This verifies the fix for http://crbug.com/469325
4342 // where the decision *not* to remove the start of the overlapped range was 4302 // where the decision *not* to remove the start of the overlapped range was
4343 // erroneously triggering buffers with a timestamp matching the end 4303 // erroneously triggering buffers with a timestamp matching the end
4344 // of the append (and any later dependent frames) to be removed. 4304 // of the append (and any later dependent frames) to be removed.
4345 AppendBuffers("0D10"); 4305 AppendBuffers("0D10");
4346 Seek(0); 4306 Seek(0);
4347 CheckExpectedRangesByTimestamp("{ [0,16) }"); 4307 CheckExpectedRangesByTimestamp("{ [0,16) }");
4348 CheckExpectedBuffers("0K 0 10K 12 14"); 4308 CheckExpectedBuffers("0K 0 10K 12 14");
4349 CheckNoNextBuffer(); 4309 CheckNoNextBuffer();
4350 } 4310 }
4351 4311
4352 TEST_F(SourceBufferStreamTest, RefinedDurationEstimates_BackOverlap) { 4312 TEST_F(SourceBufferStreamTest, RefinedDurationEstimates_BackOverlap) {
4353 // Append a few buffers, the last one having estimated duration. 4313 // Append a few buffers, the last one having estimated duration.
4354 NewSegmentAppend("0K 5 10 20D10E"); 4314 NewCodedFrameGroupAppend("0K 5 10 20D10E");
4355 CheckExpectedRangesByTimestamp("{ [0,30) }"); 4315 CheckExpectedRangesByTimestamp("{ [0,30) }");
4356 Seek(0); 4316 Seek(0);
4357 CheckExpectedBuffers("0K 5 10 20D10E"); 4317 CheckExpectedBuffers("0K 5 10 20D10E");
4358 CheckNoNextBuffer(); 4318 CheckNoNextBuffer();
4359 4319
4360 // Append a buffer to the end that overlaps the *back* of the existing range. 4320 // Append a buffer to the end that overlaps the *back* of the existing range.
4361 // This should trigger the estimated duration to be recomputed as a timestamp 4321 // This should trigger the estimated duration to be recomputed as a timestamp
4362 // delta. 4322 // delta.
4363 AppendBuffers("25D10"); 4323 AppendBuffers("25D10");
4364 CheckExpectedRangesByTimestamp("{ [0,35) }"); 4324 CheckExpectedRangesByTimestamp("{ [0,35) }");
4365 Seek(0); 4325 Seek(0);
4366 // The duration of the buffer at time 20 has changed from 10ms to 5ms. 4326 // The duration of the buffer at time 20 has changed from 10ms to 5ms.
4367 CheckExpectedBuffers("0K 5 10 20D5E 25"); 4327 CheckExpectedBuffers("0K 5 10 20D5E 25");
4368 CheckNoNextBuffer(); 4328 CheckNoNextBuffer();
4369 4329
4370 // If the last buffer is removed, the adjusted duration should remain at 5ms. 4330 // If the last buffer is removed, the adjusted duration should remain at 5ms.
4371 RemoveInMs(25, 35, 35); 4331 RemoveInMs(25, 35, 35);
4372 CheckExpectedRangesByTimestamp("{ [0,25) }"); 4332 CheckExpectedRangesByTimestamp("{ [0,25) }");
4373 Seek(0); 4333 Seek(0);
4374 CheckExpectedBuffers("0K 5 10 20D5E"); 4334 CheckExpectedBuffers("0K 5 10 20D5E");
4375 CheckNoNextBuffer(); 4335 CheckNoNextBuffer();
4376 } 4336 }
4377 4337
4378 TEST_F(SourceBufferStreamTest, RefinedDurationEstimates_FrontOverlap) { 4338 TEST_F(SourceBufferStreamTest, RefinedDurationEstimates_FrontOverlap) {
4379 // Append a few buffers. 4339 // Append a few buffers.
4380 NewSegmentAppend("10K 15 20D5"); 4340 NewCodedFrameGroupAppend("10K 15 20D5");
4381 CheckExpectedRangesByTimestamp("{ [10,25) }"); 4341 CheckExpectedRangesByTimestamp("{ [10,25) }");
4382 SeekToTimestampMs(10); 4342 SeekToTimestampMs(10);
4383 CheckExpectedBuffers("10K 15 20"); 4343 CheckExpectedBuffers("10K 15 20");
4384 CheckNoNextBuffer(); 4344 CheckNoNextBuffer();
4385 4345
4386 // Append new buffers, where the last has estimated duration that overlaps the 4346 // Append new buffers, where the last has estimated duration that overlaps the
4387 // *front* of the existing range. The overlap should trigger refinement of the 4347 // *front* of the existing range. The overlap should trigger refinement of the
4388 // estimated duration from 7ms to 5ms. 4348 // estimated duration from 7ms to 5ms.
4389 NewSegmentAppend("0K 5D7E"); 4349 NewCodedFrameGroupAppend("0K 5D7E");
4390 CheckExpectedRangesByTimestamp("{ [0,25) }"); 4350 CheckExpectedRangesByTimestamp("{ [0,25) }");
4391 Seek(0); 4351 Seek(0);
4392 CheckExpectedBuffers("0K 5D5E 10K 15 20"); 4352 CheckExpectedBuffers("0K 5D5E 10K 15 20");
4393 CheckNoNextBuffer(); 4353 CheckNoNextBuffer();
4394 4354
4395 // If the overlapped buffer at timestamp 10 is removed, the adjusted duration 4355 // If the overlapped buffer at timestamp 10 is removed, the adjusted duration
4396 // should remain adjusted. 4356 // should remain adjusted.
4397 RemoveInMs(10, 20, 25); 4357 RemoveInMs(10, 20, 25);
4398 CheckExpectedRangesByTimestamp("{ [0,10) }"); 4358 CheckExpectedRangesByTimestamp("{ [0,10) }");
4399 Seek(0); 4359 Seek(0);
4400 CheckExpectedBuffers("0K 5D5E"); 4360 CheckExpectedBuffers("0K 5D5E");
4401 CheckNoNextBuffer(); 4361 CheckNoNextBuffer();
4402 } 4362 }
4403 4363
4404 TEST_F(SourceBufferStreamTest, SeekToStartSatisfiedUpToThreshold) { 4364 TEST_F(SourceBufferStreamTest, SeekToStartSatisfiedUpToThreshold) {
4405 NewSegmentAppend("999K 1010 1020D10"); 4365 NewCodedFrameGroupAppend("999K 1010 1020D10");
4406 CheckExpectedRangesByTimestamp("{ [999,1030) }"); 4366 CheckExpectedRangesByTimestamp("{ [999,1030) }");
4407 4367
4408 SeekToTimestampMs(0); 4368 SeekToTimestampMs(0);
4409 CheckExpectedBuffers("999K 1010 1020D10"); 4369 CheckExpectedBuffers("999K 1010 1020D10");
4410 CheckNoNextBuffer(); 4370 CheckNoNextBuffer();
4411 } 4371 }
4412 4372
4413 TEST_F(SourceBufferStreamTest, SeekToStartUnsatisfiedBeyondThreshold) { 4373 TEST_F(SourceBufferStreamTest, SeekToStartUnsatisfiedBeyondThreshold) {
4414 NewSegmentAppend("1000K 1010 1020D10"); 4374 NewCodedFrameGroupAppend("1000K 1010 1020D10");
4415 CheckExpectedRangesByTimestamp("{ [1000,1030) }"); 4375 CheckExpectedRangesByTimestamp("{ [1000,1030) }");
4416 4376
4417 SeekToTimestampMs(0); 4377 SeekToTimestampMs(0);
4418 CheckNoNextBuffer(); 4378 CheckNoNextBuffer();
4419 } 4379 }
4420 4380
4421 TEST_F(SourceBufferStreamTest, 4381 TEST_F(SourceBufferStreamTest,
4422 ReSeekToStartSatisfiedUpToThreshold_SameTimestamps) { 4382 ReSeekToStartSatisfiedUpToThreshold_SameTimestamps) {
4423 // Append a few buffers. 4383 // Append a few buffers.
4424 NewSegmentAppend("999K 1010 1020D10"); 4384 NewCodedFrameGroupAppend("999K 1010 1020D10");
4425 CheckExpectedRangesByTimestamp("{ [999,1030) }"); 4385 CheckExpectedRangesByTimestamp("{ [999,1030) }");
4426 4386
4427 // Don't read any buffers between Seek and Remove. 4387 // Don't read any buffers between Seek and Remove.
4428 SeekToTimestampMs(0); 4388 SeekToTimestampMs(0);
4429 RemoveInMs(999, 1030, 1030); 4389 RemoveInMs(999, 1030, 1030);
4430 CheckExpectedRangesByTimestamp("{ }"); 4390 CheckExpectedRangesByTimestamp("{ }");
4431 CheckNoNextBuffer(); 4391 CheckNoNextBuffer();
4432 4392
4433 // Append buffers at the original timestamps and verify no stall. 4393 // Append buffers at the original timestamps and verify no stall.
4434 NewSegmentAppend("999K 1010 1020D10"); 4394 NewCodedFrameGroupAppend("999K 1010 1020D10");
4435 CheckExpectedRangesByTimestamp("{ [999,1030) }"); 4395 CheckExpectedRangesByTimestamp("{ [999,1030) }");
4436 CheckExpectedBuffers("999K 1010 1020D10"); 4396 CheckExpectedBuffers("999K 1010 1020D10");
4437 CheckNoNextBuffer(); 4397 CheckNoNextBuffer();
4438 } 4398 }
4439 4399
4440 TEST_F(SourceBufferStreamTest, 4400 TEST_F(SourceBufferStreamTest,
4441 ReSeekToStartSatisfiedUpToThreshold_EarlierTimestamps) { 4401 ReSeekToStartSatisfiedUpToThreshold_EarlierTimestamps) {
4442 // Append a few buffers. 4402 // Append a few buffers.
4443 NewSegmentAppend("999K 1010 1020D10"); 4403 NewCodedFrameGroupAppend("999K 1010 1020D10");
4444 CheckExpectedRangesByTimestamp("{ [999,1030) }"); 4404 CheckExpectedRangesByTimestamp("{ [999,1030) }");
4445 4405
4446 // Don't read any buffers between Seek and Remove. 4406 // Don't read any buffers between Seek and Remove.
4447 SeekToTimestampMs(0); 4407 SeekToTimestampMs(0);
4448 RemoveInMs(999, 1030, 1030); 4408 RemoveInMs(999, 1030, 1030);
4449 CheckExpectedRangesByTimestamp("{ }"); 4409 CheckExpectedRangesByTimestamp("{ }");
4450 CheckNoNextBuffer(); 4410 CheckNoNextBuffer();
4451 4411
4452 // Append buffers before the original timestamps and verify no stall (the 4412 // Append buffers before the original timestamps and verify no stall (the
4453 // re-seek to time 0 should still be satisfied with the new buffers). 4413 // re-seek to time 0 should still be satisfied with the new buffers).
4454 NewSegmentAppend("500K 510 520D10"); 4414 NewCodedFrameGroupAppend("500K 510 520D10");
4455 CheckExpectedRangesByTimestamp("{ [500,530) }"); 4415 CheckExpectedRangesByTimestamp("{ [500,530) }");
4456 CheckExpectedBuffers("500K 510 520D10"); 4416 CheckExpectedBuffers("500K 510 520D10");
4457 CheckNoNextBuffer(); 4417 CheckNoNextBuffer();
4458 } 4418 }
4459 4419
4460 TEST_F(SourceBufferStreamTest, 4420 TEST_F(SourceBufferStreamTest,
4461 ReSeekToStartSatisfiedUpToThreshold_LaterTimestamps) { 4421 ReSeekToStartSatisfiedUpToThreshold_LaterTimestamps) {
4462 // Append a few buffers. 4422 // Append a few buffers.
4463 NewSegmentAppend("500K 510 520D10"); 4423 NewCodedFrameGroupAppend("500K 510 520D10");
4464 CheckExpectedRangesByTimestamp("{ [500,530) }"); 4424 CheckExpectedRangesByTimestamp("{ [500,530) }");
4465 4425
4466 // Don't read any buffers between Seek and Remove. 4426 // Don't read any buffers between Seek and Remove.
4467 SeekToTimestampMs(0); 4427 SeekToTimestampMs(0);
4468 RemoveInMs(500, 530, 530); 4428 RemoveInMs(500, 530, 530);
4469 CheckExpectedRangesByTimestamp("{ }"); 4429 CheckExpectedRangesByTimestamp("{ }");
4470 CheckNoNextBuffer(); 4430 CheckNoNextBuffer();
4471 4431
4472 // Append buffers beginning after original timestamps, but still below the 4432 // Append buffers beginning after original timestamps, but still below the
4473 // start threshold, and verify no stall (the re-seek to time 0 should still be 4433 // start threshold, and verify no stall (the re-seek to time 0 should still be
4474 // satisfied with the new buffers). 4434 // satisfied with the new buffers).
4475 NewSegmentAppend("999K 1010 1020D10"); 4435 NewCodedFrameGroupAppend("999K 1010 1020D10");
4476 CheckExpectedRangesByTimestamp("{ [999,1030) }"); 4436 CheckExpectedRangesByTimestamp("{ [999,1030) }");
4477 CheckExpectedBuffers("999K 1010 1020D10"); 4437 CheckExpectedBuffers("999K 1010 1020D10");
4478 CheckNoNextBuffer(); 4438 CheckNoNextBuffer();
4479 } 4439 }
4480 4440
4481 TEST_F(SourceBufferStreamTest, ReSeekBeyondStartThreshold_SameTimestamps) { 4441 TEST_F(SourceBufferStreamTest, ReSeekBeyondStartThreshold_SameTimestamps) {
4482 // Append a few buffers. 4442 // Append a few buffers.
4483 NewSegmentAppend("1000K 1010 1020D10"); 4443 NewCodedFrameGroupAppend("1000K 1010 1020D10");
4484 CheckExpectedRangesByTimestamp("{ [1000,1030) }"); 4444 CheckExpectedRangesByTimestamp("{ [1000,1030) }");
4485 4445
4486 // Don't read any buffers between Seek and Remove. 4446 // Don't read any buffers between Seek and Remove.
4487 SeekToTimestampMs(1000); 4447 SeekToTimestampMs(1000);
4488 RemoveInMs(1000, 1030, 1030); 4448 RemoveInMs(1000, 1030, 1030);
4489 CheckExpectedRangesByTimestamp("{ }"); 4449 CheckExpectedRangesByTimestamp("{ }");
4490 CheckNoNextBuffer(); 4450 CheckNoNextBuffer();
4491 4451
4492 // Append buffers at the original timestamps and verify no stall. 4452 // Append buffers at the original timestamps and verify no stall.
4493 NewSegmentAppend("1000K 1010 1020D10"); 4453 NewCodedFrameGroupAppend("1000K 1010 1020D10");
4494 CheckExpectedRangesByTimestamp("{ [1000,1030) }"); 4454 CheckExpectedRangesByTimestamp("{ [1000,1030) }");
4495 CheckExpectedBuffers("1000K 1010 1020D10"); 4455 CheckExpectedBuffers("1000K 1010 1020D10");
4496 CheckNoNextBuffer(); 4456 CheckNoNextBuffer();
4497 } 4457 }
4498 4458
4499 TEST_F(SourceBufferStreamTest, ReSeekBeyondThreshold_EarlierTimestamps) { 4459 TEST_F(SourceBufferStreamTest, ReSeekBeyondThreshold_EarlierTimestamps) {
4500 // Append a few buffers. 4460 // Append a few buffers.
4501 NewSegmentAppend("2000K 2010 2020D10"); 4461 NewCodedFrameGroupAppend("2000K 2010 2020D10");
4502 CheckExpectedRangesByTimestamp("{ [2000,2030) }"); 4462 CheckExpectedRangesByTimestamp("{ [2000,2030) }");
4503 4463
4504 // Don't read any buffers between Seek and Remove. 4464 // Don't read any buffers between Seek and Remove.
4505 SeekToTimestampMs(2000); 4465 SeekToTimestampMs(2000);
4506 RemoveInMs(2000, 2030, 2030); 4466 RemoveInMs(2000, 2030, 2030);
4507 CheckExpectedRangesByTimestamp("{ }"); 4467 CheckExpectedRangesByTimestamp("{ }");
4508 CheckNoNextBuffer(); 4468 CheckNoNextBuffer();
4509 4469
4510 // Append buffers before the original timestamps and verify no stall (the 4470 // Append buffers before the original timestamps and verify no stall (the
4511 // re-seek to time 2 seconds should still be satisfied with the new buffers 4471 // re-seek to time 2 seconds should still be satisfied with the new buffers
4512 // and should emit preroll from last keyframe). 4472 // and should emit preroll from last keyframe).
4513 NewSegmentAppend("1080K 1090 2000D10"); 4473 NewCodedFrameGroupAppend("1080K 1090 2000D10");
4514 CheckExpectedRangesByTimestamp("{ [1080,2010) }"); 4474 CheckExpectedRangesByTimestamp("{ [1080,2010) }");
4515 CheckExpectedBuffers("1080K 1090 2000D10"); 4475 CheckExpectedBuffers("1080K 1090 2000D10");
4516 CheckNoNextBuffer(); 4476 CheckNoNextBuffer();
4517 } 4477 }
4518 4478
4519 TEST_F(SourceBufferStreamTest, ConfigChange_ReSeek) { 4479 TEST_F(SourceBufferStreamTest, ConfigChange_ReSeek) {
4520 // Append a few buffers, with a config change in the middle. 4480 // Append a few buffers, with a config change in the middle.
4521 VideoDecoderConfig new_config = TestVideoConfig::Large(); 4481 VideoDecoderConfig new_config = TestVideoConfig::Large();
4522 NewSegmentAppend("2000K 2010 2020D10"); 4482 NewCodedFrameGroupAppend("2000K 2010 2020D10");
4523 stream_->UpdateVideoConfig(new_config); 4483 stream_->UpdateVideoConfig(new_config);
4524 NewSegmentAppend("2030K 2040 2050D10"); 4484 NewCodedFrameGroupAppend("2030K 2040 2050D10");
4525 CheckExpectedRangesByTimestamp("{ [2000,2060) }"); 4485 CheckExpectedRangesByTimestamp("{ [2000,2060) }");
4526 4486
4527 // Read the config change, but don't read any non-config-change buffer between 4487 // Read the config change, but don't read any non-config-change buffer between
4528 // Seek and Remove. 4488 // Seek and Remove.
4529 scoped_refptr<StreamParserBuffer> buffer; 4489 scoped_refptr<StreamParserBuffer> buffer;
4530 CheckVideoConfig(video_config_); 4490 CheckVideoConfig(video_config_);
4531 SeekToTimestampMs(2030); 4491 SeekToTimestampMs(2030);
4532 CheckVideoConfig(video_config_); 4492 CheckVideoConfig(video_config_);
4533 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange); 4493 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange);
4534 CheckVideoConfig(new_config); 4494 CheckVideoConfig(new_config);
4535 4495
4536 // Trigger the re-seek. 4496 // Trigger the re-seek.
4537 RemoveInMs(2030, 2060, 2060); 4497 RemoveInMs(2030, 2060, 2060);
4538 CheckExpectedRangesByTimestamp("{ [2000,2030) }"); 4498 CheckExpectedRangesByTimestamp("{ [2000,2030) }");
4539 CheckNoNextBuffer(); 4499 CheckNoNextBuffer();
4540 4500
4541 // Append buffers at the original timestamps and verify no stall or redundant 4501 // Append buffers at the original timestamps and verify no stall or redundant
4542 // signalling of config change. 4502 // signalling of config change.
4543 NewSegmentAppend("2030K 2040 2050D10"); 4503 NewCodedFrameGroupAppend("2030K 2040 2050D10");
4544 CheckVideoConfig(new_config); 4504 CheckVideoConfig(new_config);
4545 CheckExpectedRangesByTimestamp("{ [2000,2060) }"); 4505 CheckExpectedRangesByTimestamp("{ [2000,2060) }");
4546 CheckExpectedBuffers("2030K 2040 2050D10"); 4506 CheckExpectedBuffers("2030K 2040 2050D10");
4547 CheckNoNextBuffer(); 4507 CheckNoNextBuffer();
4548 CheckVideoConfig(new_config); 4508 CheckVideoConfig(new_config);
4549 4509
4550 // Seek to the start of buffered and verify config changes and buffers. 4510 // Seek to the start of buffered and verify config changes and buffers.
4551 SeekToTimestampMs(2000); 4511 SeekToTimestampMs(2000);
4552 CheckVideoConfig(new_config); 4512 CheckVideoConfig(new_config);
4553 ASSERT_FALSE(new_config.Matches(video_config_)); 4513 ASSERT_FALSE(new_config.Matches(video_config_));
4554 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange); 4514 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange);
4555 CheckVideoConfig(video_config_); 4515 CheckVideoConfig(video_config_);
4556 CheckExpectedBuffers("2000K 2010 2020D10"); 4516 CheckExpectedBuffers("2000K 2010 2020D10");
4557 CheckVideoConfig(video_config_); 4517 CheckVideoConfig(video_config_);
4558 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange); 4518 EXPECT_EQ(stream_->GetNextBuffer(&buffer), SourceBufferStream::kConfigChange);
4559 CheckVideoConfig(new_config); 4519 CheckVideoConfig(new_config);
4560 CheckExpectedBuffers("2030K 2040 2050D10"); 4520 CheckExpectedBuffers("2030K 2040 2050D10");
4561 CheckNoNextBuffer(); 4521 CheckNoNextBuffer();
4562 CheckVideoConfig(new_config); 4522 CheckVideoConfig(new_config);
4563 } 4523 }
4564 4524
4565 TEST_F(SourceBufferStreamTest, TrackBuffer_ExhaustionWithSkipForward) { 4525 TEST_F(SourceBufferStreamTest, TrackBuffer_ExhaustionWithSkipForward) {
4566 NewSegmentAppend("0K 10 20 30 40"); 4526 NewCodedFrameGroupAppend("0K 10 20 30 40");
4567 4527
4568 // Read the first 4 buffers, so next buffer is at time 40. 4528 // Read the first 4 buffers, so next buffer is at time 40.
4569 Seek(0); 4529 Seek(0);
4570 CheckExpectedRangesByTimestamp("{ [0,50) }"); 4530 CheckExpectedRangesByTimestamp("{ [0,50) }");
4571 CheckExpectedBuffers("0K 10 20 30"); 4531 CheckExpectedBuffers("0K 10 20 30");
4572 4532
4573 // Overlap-append, populating track buffer with timestamp 40 from original 4533 // Overlap-append, populating track buffer with timestamp 40 from original
4574 // append. Confirm there could be a large jump in time until the next key 4534 // append. Confirm there could be a large jump in time until the next key
4575 // frame after exhausting the track buffer. 4535 // frame after exhausting the track buffer.
4576 NewSegmentAppend( 4536 NewCodedFrameGroupAppend(
4577 "31K 41 51 61 71 81 91 101 111 121 " 4537 "31K 41 51 61 71 81 91 101 111 121 "
4578 "131K 141"); 4538 "131K 141");
4579 CheckExpectedRangesByTimestamp("{ [0,151) }"); 4539 CheckExpectedRangesByTimestamp("{ [0,151) }");
4580 4540
4581 // Confirm the large jump occurs and warning log is generated. 4541 // Confirm the large jump occurs and warning log is generated.
4582 // If this test is changed, update 4542 // If this test is changed, update
4583 // TrackBufferExhaustion_ImmediateNewTrackBuffer accordingly. 4543 // TrackBufferExhaustion_ImmediateNewTrackBuffer accordingly.
4584 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(91)); 4544 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(91));
4585 4545
4586 CheckExpectedBuffers("40 131K 141"); 4546 CheckExpectedBuffers("40 131K 141");
4587 CheckNoNextBuffer(); 4547 CheckNoNextBuffer();
4588 } 4548 }
4589 4549
4590 TEST_F(SourceBufferStreamTest, 4550 TEST_F(SourceBufferStreamTest,
4591 TrackBuffer_ExhaustionAndImmediateNewTrackBuffer) { 4551 TrackBuffer_ExhaustionAndImmediateNewTrackBuffer) {
4592 NewSegmentAppend("0K 10 20 30 40"); 4552 NewCodedFrameGroupAppend("0K 10 20 30 40");
4593 4553
4594 // Read the first 4 buffers, so next buffer is at time 40. 4554 // Read the first 4 buffers, so next buffer is at time 40.
4595 Seek(0); 4555 Seek(0);
4596 CheckExpectedRangesByTimestamp("{ [0,50) }"); 4556 CheckExpectedRangesByTimestamp("{ [0,50) }");
4597 CheckExpectedBuffers("0K 10 20 30"); 4557 CheckExpectedBuffers("0K 10 20 30");
4598 4558
4599 // Overlap-append 4559 // Overlap-append
4600 NewSegmentAppend( 4560 NewCodedFrameGroupAppend(
4601 "31K 41 51 61 71 81 91 101 111 121 " 4561 "31K 41 51 61 71 81 91 101 111 121 "
4602 "131K 141"); 4562 "131K 141");
4603 CheckExpectedRangesByTimestamp("{ [0,151) }"); 4563 CheckExpectedRangesByTimestamp("{ [0,151) }");
4604 4564
4605 // Exhaust the track buffer, but don't read any of the overlapping append yet. 4565 // Exhaust the track buffer, but don't read any of the overlapping append yet.
4606 CheckExpectedBuffers("40"); 4566 CheckExpectedBuffers("40");
4607 4567
4608 // Selected range's next buffer is now the 131K buffer from the overlapping 4568 // Selected range's next buffer is now the 131K buffer from the overlapping
4609 // append. (See TrackBuffer_ExhaustionWithSkipForward for that verification.) 4569 // append. (See TrackBuffer_ExhaustionWithSkipForward for that verification.)
4610 // Do another overlap-append to immediately create another track buffer and 4570 // Do another overlap-append to immediately create another track buffer and
4611 // verify both track buffer exhaustions skip forward and emit log warnings. 4571 // verify both track buffer exhaustions skip forward and emit log warnings.
4612 NewSegmentAppend("22K 32 42 52 62 72 82 92 102 112 122K 132 142 152K 162"); 4572 NewCodedFrameGroupAppend(
4573 "22K 32 42 52 62 72 82 92 102 112 122K 132 142 152K 162");
4613 CheckExpectedRangesByTimestamp("{ [0,172) }"); 4574 CheckExpectedRangesByTimestamp("{ [0,172) }");
4614 4575
4615 InSequence s; 4576 InSequence s;
4616 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(91)); 4577 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(91));
4617 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(11)); 4578 EXPECT_MEDIA_LOG(ContainsTrackBufferExhaustionSkipLog(11));
4618 4579
4619 CheckExpectedBuffers("131K 141 152K 162"); 4580 CheckExpectedBuffers("131K 141 152K 162");
4620 CheckNoNextBuffer(); 4581 CheckNoNextBuffer();
4621 } 4582 }
4622 4583
4623 // TODO(vrk): Add unit tests where keyframes are unaligned between streams. 4584 // TODO(vrk): Add unit tests where keyframes are unaligned between streams.
4624 // (crbug.com/133557) 4585 // (crbug.com/133557)
4625 4586
4626 // TODO(vrk): Add unit tests with end of stream being called at interesting 4587 // TODO(vrk): Add unit tests with end of stream being called at interesting
4627 // times. 4588 // times.
4628 4589
4629 } // namespace media 4590 } // namespace media
OLDNEW
« no previous file with comments | « media/filters/source_buffer_stream.cc ('k') | media/formats/mp2t/mp2t_stream_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698