Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1091293004: [Chromoting] Build webapp package with browser test JavaScript files loaded. (Closed)

Created:
5 years, 8 months ago by kelvinp
Modified:
5 years, 7 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Build webapp package with browser test JavaScript files loaded. This CL creates a new target webapp with browser test JavaScript files loaded. This will enable us to run a JavaScript browser test using a regular chrome binary to speed up development and debugging. BUG= Committed: https://crrev.com/14c59714c821b5c05a4b8a088b65f0a2fef4b910 Cr-Commit-Position: refs/heads/master@{#327438}

Patch Set 1 #

Patch Set 2 : building it on trybots #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : Reviewer's feedback #

Patch Set 5 : Fix android build #

Patch Set 6 : Fix Nacl #

Patch Set 7 : Final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -18 lines) Patch
M remoting/remoting_all.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_client.gypi View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M remoting/remoting_test.gypi View 1 2 3 4 5 2 chunks +55 lines, -3 lines 0 comments Download
M remoting/remoting_webapp.gypi View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 41 (24 generated)
kelvinp
PTAL
5 years, 8 months ago (2015-04-25 00:01:55 UTC) #2
kelvinp
On 2015/04/25 00:01:55, kelvinp wrote: > PTAL ping
5 years, 8 months ago (2015-04-27 18:38:52 UTC) #3
garykac
lgtm with comments https://codereview.chromium.org/1091293004/diff/20001/remoting/remoting_webapp.gypi File remoting/remoting_webapp.gypi (right): https://codereview.chromium.org/1091293004/diff/20001/remoting/remoting_webapp.gypi#newcode11 remoting/remoting_webapp.gypi:11: 'main_html_file%': '<(SHARED_INTERMEDIATE_DIR)/main.html', We shouldn't be putting ...
5 years, 8 months ago (2015-04-28 00:05:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/60001
5 years, 8 months ago (2015-04-28 00:51:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/10588)
5 years, 8 months ago (2015-04-28 01:00:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/60001
5 years, 7 months ago (2015-04-28 17:44:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/70567) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-04-28 17:55:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/80001
5 years, 7 months ago (2015-04-28 18:30:28 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/70597) android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-04-28 18:40:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/100001
5 years, 7 months ago (2015-04-28 18:50:01 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/10873)
5 years, 7 months ago (2015-04-28 19:00:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/120001
5 years, 7 months ago (2015-04-28 21:26:48 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/140001
5 years, 7 months ago (2015-04-28 21:42:50 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/70702) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-04-28 21:55:08 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091293004/200001
5 years, 7 months ago (2015-04-29 01:43:41 UTC) #39
commit-bot: I haz the power
Committed patchset #7 (id:200001)
5 years, 7 months ago (2015-04-29 05:20:54 UTC) #40
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 05:21:48 UTC) #41
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/14c59714c821b5c05a4b8a088b65f0a2fef4b910
Cr-Commit-Position: refs/heads/master@{#327438}

Powered by Google App Engine
This is Rietveld 408576698