Rename methods and members and const variables to alternative service.

chrome/browser/io_thread_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/test/mock_entropy_provider.h"
 #include "chrome/browser/io_thread.h"
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 #include "net/http/http_network_session.h"
@@ skipping 175 matching lines @@
 TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
   field_trial_group_ = "Enabled";
 
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params default_params;
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_TRUE(params.enable_quic);
   EXPECT_TRUE(params.enable_quic_for_proxies);
   EXPECT_EQ(1350u, params.quic_max_packet_length);
-  EXPECT_EQ(1.0, params.alternate_protocol_probability_threshold);
+  EXPECT_EQ(1.0, params.alternative_service_probability_threshold);
   EXPECT_EQ(default_params.quic_supported_versions,
             params.quic_supported_versions);
   EXPECT_EQ(net::QuicTagVector(), params.quic_connection_options);
   EXPECT_FALSE(params.quic_always_require_handshake_confirmation);
   EXPECT_FALSE(params.quic_disable_connection_pooling);
   EXPECT_EQ(0.25f, params.quic_load_server_info_timeout_srtt_multiplier);
   EXPECT_FALSE(params.quic_enable_connection_racing);
   EXPECT_FALSE(params.quic_enable_non_blocking_io);
   EXPECT_FALSE(params.quic_disable_disk_cache);
   EXPECT_EQ(0, params.quic_max_number_of_lossy_connections);
@@ skipping 207 matching lines @@
 
 TEST_F(IOThreadTest, QuicReceiveBufferSize) {
   field_trial_group_ = "Enabled";
   field_trial_params_["receive_buffer_size"] = "1048576";
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
   EXPECT_EQ(1048576, params.quic_socket_receive_buffer_size);
 }
 
-TEST_F(IOThreadTest,
-       AlternateProtocolProbabilityThresholdFromFlag) {
+TEST_F(IOThreadTest, AlternativeServiceProbabilityThresholdFromFlag) {
   command_line_.AppendSwitchASCII("alternate-protocol-probability-threshold",

[Ryan Hamilton, 2015/04/24 14:35:59]

I'm surprised you're keeping the command line flag. Did you intend to change it?

[Bence, 2015/04/24 21:36:02]

See reply to comment in chrome_flags.cc.  I did not intend to change it, but I
can if you think it's a good idea.

                                   ".5");
 
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
-  EXPECT_EQ(.5, params.alternate_protocol_probability_threshold);
+  EXPECT_EQ(.5, params.alternative_service_probability_threshold);
 }
 
-TEST_F(IOThreadTest,
-       AlternateProtocolProbabilityThresholdFromEnableQuicFlag) {
+TEST_F(IOThreadTest, AlternativeServiceProbabilityThresholdFromEnableQuicFlag) {
   command_line_.AppendSwitch("enable-quic");
 
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
-  EXPECT_EQ(0, params.alternate_protocol_probability_threshold);
+  EXPECT_EQ(0, params.alternative_service_probability_threshold);
 }
 
-TEST_F(IOThreadTest,
-       AlternateProtocolProbabilityThresholdFromParams) {
+TEST_F(IOThreadTest, AlternativeServiceProbabilityThresholdFromParams) {
   field_trial_group_ = "Enabled";
-  field_trial_params_["alternate_protocol_probability_threshold"] = ".5";
+  field_trial_params_["alternative_service_probability_threshold"] = ".5";

[Ryan Hamilton, 2015/04/24 14:35:59]

The old version of this test needs to continue to pass after this change. Feel
free to add a new one for the new behavior.

[Bence, 2015/04/24 21:36:02]

Done.

 
   ConfigureQuicGlobals();
   net::HttpNetworkSession::Params params;
   InitializeNetworkSessionParams(&params);
-  EXPECT_EQ(.5, params.alternate_protocol_probability_threshold);
+  EXPECT_EQ(.5, params.alternative_service_probability_threshold);
 }
 
 }  // namespace test