use acquire/release in SkEventTracer.cpp

use acquire/release in SkEventTracer.cpp

BUG=chromium:437044
Committed: https://skia.googlesource.com/skia/+/743be194eda4c1f37c4a5f62f38ef88f09f30649

[mtklein_C, 2015-04-21 16:48:36]

mtklein@chromium.org changed reviewers:
+ glider@chromium.org

[mtklein_C, 2015-04-21 16:48:41]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-21 16:48:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091283006/1

[commit-bot: I haz the power, 2015-04-21 17:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-21 17:05:58]

Dry run: This issue passed the CQ dry run.

[Alexander Potapenko, 2015-04-22 17:47:50]

LGTM with a nit.
Thanks for the quick turnaround!

https://codereview.chromium.org/1091283006/diff/1/src/utils/SkEventTracer.cpp
File src/utils/SkEventTracer.cpp (right):

https://codereview.chromium.org/1091283006/diff/1/src/utils/SkEventTracer.cpp...
src/utils/SkEventTracer.cpp:45: SkASSERT(nullptr == sk_atomic_load(&gUserTracer,
sk_memory_order_acquire));
I may be mistaking, but this one can be demoted to a nobarrier read, since
you're not using the value.

[mtklein, 2015-04-22 18:56:24]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-04-22 18:56:25]

https://codereview.chromium.org/1091283006/diff/1/src/utils/SkEventTracer.cpp
File src/utils/SkEventTracer.cpp (right):

https://codereview.chromium.org/1091283006/diff/1/src/utils/SkEventTracer.cpp...
src/utils/SkEventTracer.cpp:45: SkASSERT(nullptr == sk_atomic_load(&gUserTracer,
sk_memory_order_acquire));
On 2015/04/22 17:47:50, Alexander Potapenko wrote:
> I may be mistaking, but this one can be demoted to a nobarrier read, since
> you're not using the value.

Yeah, seemed simpler to keep it all as _acquire so I don't get confused and try
to make things all _relaxed again, especially because it's just a debug-only
assert.

[mtklein, 2015-04-22 18:56:52]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-04-22 18:57:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091283006/1

[commit-bot: I haz the power, 2015-04-22 18:57:06]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-04-23 00:57 UTC

[commit-bot: I haz the power, 2015-04-23 00:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-23 00:57:10]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[mtklein, 2015-04-23 03:29:44]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-04-23 03:29:44]

lgtm

Boy you're dumb CQ...

[commit-bot: I haz the power, 2015-04-23 03:29:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091283006/1

[commit-bot: I haz the power, 2015-04-23 03:30:16]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/743be194eda4c1f37c4a5f62f38ef88f09f30649