Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1091283005: Make CSSKeyframesRule.insertRule an alias of appendRule (Closed)

Created:
5 years, 8 months ago by philipj_slow
Modified:
5 years, 8 months ago
Reviewers:
davve
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-css, ed+blinkwatch_opera.com, vivekg, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make CSSKeyframesRule.insertRule an alias of appendRule As opposed to the other way around, as insertRule is deprecated. BUG=470400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/css/CSSKeyframesRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSKeyframesRule.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 8 months ago (2015-04-21 10:55:54 UTC) #2
davve
LGTM I'd suggest adding something simple about why you're doing this to the description, such ...
5 years, 8 months ago (2015-04-21 11:02:47 UTC) #3
philipj_slow
On 2015/04/21 11:02:47, David Vest wrote: > LGTM > > I'd suggest adding something simple ...
5 years, 8 months ago (2015-04-21 11:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091283005/1
5 years, 8 months ago (2015-04-21 11:06:16 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 12:59:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194122

Powered by Google App Engine
This is Rietveld 408576698