content/browser/renderer_host/render_widget_host_impl.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/external_protocol_dialog.cc ('K') | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/public/browser/resource_dispatcher_host_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index 0923657632c9eabcf91d2ec323cdbfeb7373cac5..65c4971f8e8c82109752edd1fc2f2670b2c1c1c3 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -1783,8 +1783,10 @@ InputEventAckState RenderWidgetHostImpl::FilterInputEvent(

if (!process_->HasConnection())

return INPUT_EVENT_ACK_STATE_UNKNOWN;

- if (event.type == WebInputEvent::MouseDown)

+ if (event.type == WebInputEvent::MouseDown ||

+ event.type == WebInputEvent::GestureTapDown) {

OnUserGesture();

+ }

return view_ ? view_->FilterInputEvent(event)

: INPUT_EVENT_ACK_STATE_NOT_CONSUMED;