components/navigation_interception/navigation_params_android.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/navigation_params_android.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/external_protocol_dialog.cc ('K') | « components/navigation_interception/navigation_params.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/navigation_params_android.cc

diff --git a/components/navigation_interception/navigation_params_android.cc b/components/navigation_interception/navigation_params_android.cc

index 2ef21126a4a2c792cb2c654ba7d475a8e38167ff..3da3bd9dd2de047004b686b64e2bd4d10447194b 100644

--- a/components/navigation_interception/navigation_params_android.cc

+++ b/components/navigation_interception/navigation_params_android.cc

@@ -21,7 +21,8 @@ base::android::ScopedJavaLocalRef<jobject> CreateJavaNavigationParams(

return Java_NavigationParams_create(

env, jstring_url.obj(), params.is_post(), params.has_user_gesture(),

params.transition_type(), params.is_redirect(),

- params.is_external_protocol(), has_user_gesture_carryover);

+ params.is_external_protocol(), params.is_main_frame(),

+ has_user_gesture_carryover);

}

// Register native methods.