components/navigation_interception/navigation_params.h - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/navigation_params.h

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/external_protocol_dialog.cc ('K') | « components/navigation_interception/intercept_navigation_resource_throttle.cc ('k') | components/navigation_interception/navigation_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/navigation_params.h

diff --git a/components/navigation_interception/navigation_params.h b/components/navigation_interception/navigation_params.h

index 0fb10d94e7a896229ac9605a89c9d6aaff76d665..3417816590e2fb4fcf7b78e83f1c776fdf086b5c 100644

--- a/components/navigation_interception/navigation_params.h

+++ b/components/navigation_interception/navigation_params.h

@@ -20,7 +20,8 @@ class NavigationParams {

bool is_post,

ui::PageTransition page_transition_type,

bool is_redirect,

- bool is_external_protocol);

+ bool is_external_protocol,

+ bool is_main_frame);

NavigationParams(const NavigationParams& other);

void operator=(const NavigationParams& rhs);

@@ -32,6 +33,7 @@ class NavigationParams {

ui::PageTransition transition_type() const { return transition_type_; }

bool is_redirect() const { return is_redirect_; }

bool is_external_protocol() const { return is_external_protocol_; }

+ bool is_main_frame() const { return is_main_frame_; }

private:

void Assign(const NavigationParams& other);

@@ -43,6 +45,7 @@ class NavigationParams {

ui::PageTransition transition_type_;

bool is_redirect_;

bool is_external_protocol_;

+ bool is_main_frame_;

};

} // namespace navigation_interception