chrome/chrome_browser.gypi - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/external_protocol_dialog.cc ('K') | « chrome/browser/ui/views/external_protocol_dialog.cc ('k') | components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 38e0ce61399e57058cbb5ff7c7945a7f62c26162..1d69563eb388e334cf2a0d45f5ef22e3a615c238 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -393,6 +393,8 @@

# chrome/chrome_browser_extensions.gypi.

'browser/external_protocol/external_protocol_handler.cc',

'browser/external_protocol/external_protocol_handler.h',

+ 'browser/external_protocol/external_protocol_observer.cc',

+ 'browser/external_protocol/external_protocol_observer.h',

'browser/file_select_helper.cc',

'browser/file_select_helper.h',

'browser/file_select_helper_mac.mm',

@@ -923,8 +925,6 @@

'browser/download/notification/download_notification_item.h',

'browser/download/notification/download_notification_manager.cc',

'browser/download/notification/download_notification_manager.h',

- 'browser/external_protocol/external_protocol_observer.cc',

- 'browser/external_protocol/external_protocol_observer.h',

'browser/feedback/feedback_profile_observer.cc',

'browser/feedback/feedback_profile_observer.h',

'browser/feedback/show_feedback_page.cc',