chrome/browser/chromeos/external_protocol_dialog.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/external_protocol_dialog.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java ('k') | chrome/browser/external_protocol/external_protocol_handler.h » ('j') | chrome/browser/external_protocol/external_protocol_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/external_protocol_dialog.cc

diff --git a/chrome/browser/chromeos/external_protocol_dialog.cc b/chrome/browser/chromeos/external_protocol_dialog.cc

index ce72f71fa24359ff2094e6a5069ad19da5e0d80d..a3cd36001c553878b7ddbe7ce9f31e16f89ac203 100644

--- a/chrome/browser/chromeos/external_protocol_dialog.cc

+++ b/chrome/browser/chromeos/external_protocol_dialog.cc

@@ -31,7 +31,11 @@ const int kMessageWidth = 400;

// static

void ExternalProtocolHandler::RunExternalProtocolDialog(

- const GURL& url, int render_process_host_id, int routing_id) {

+ const GURL& url,

+ int render_process_host_id,

+ int routing_id,

+ ui::PageTransition page_transition,

+ bool has_user_gesture) {

WebContents* web_contents = tab_util::GetWebContentsByID(

render_process_host_id, routing_id);

new ExternalProtocolDialog(web_contents, url);