chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java » ('j') | chrome/browser/external_protocol/external_protocol_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

index e03416ecf2ade457a1be2623974cef6ac9e48b07..154fe1965475155b0111e02aaac8ed713267aba8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

@@ -356,6 +356,11 @@ public class ExternalNavigationHandler {

private OverrideUrlLoadingResult clobberCurrentTabWithFallbackUrl(

String browserFallbackUrl, ExternalNavigationParams params) {

+ if (!params.isMainFrame()) {

+ // For subframes, we don't support fallback url for now.

+ // http://crbug.com/364522.

+ return OverrideUrlLoadingResult.NO_OVERRIDE;

+ }

// NOTE: any further redirection from fall-back URL should not override URL loading.

// Otherwise, it can be used in chain for fingerprinting multiple app installation

// status in one shot. In order to prevent this scenario, we notify redirection