android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding isSubFrame to ExternalNavigationParams Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc » ('j') | chrome/browser/external_protocol/external_protocol_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h

diff --git a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h

index 3add2032afa3e0ec940e38159db89480c4309e12..505e004feca9641c8a0005997c007d9543647866 100644

--- a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h

+++ b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h

@@ -49,7 +49,10 @@ class AwResourceDispatcherHostDelegate

net::URLRequest* request) override;

bool HandleExternalProtocol(const GURL& url,

int child_id,

- int route_id) override;

+ int route_id,

+ bool is_main_frame,

+ ui::PageTransition page_transition,

+ bool has_user_gesture) override;

void OnResponseStarted(net::URLRequest* request,

content::ResourceContext* resource_context,

content::ResourceResponse* response,