content/public/browser/resource_dispatcher_host_delegate.h - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/resource_dispatcher_host_delegate.h

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and fix test Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/tab_helpers.cc ('K') | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/public/browser/resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/resource_dispatcher_host_delegate.h

diff --git a/content/public/browser/resource_dispatcher_host_delegate.h b/content/public/browser/resource_dispatcher_host_delegate.h

index 7942df568989229cab7c5e389328dff3b864becf..9a08117d2fb9f2b7a847fd0dc723babe58a77a71 100644

--- a/content/public/browser/resource_dispatcher_host_delegate.h

+++ b/content/public/browser/resource_dispatcher_host_delegate.h

@@ -11,6 +11,7 @@

#include "base/memory/scoped_ptr.h"

#include "content/common/content_export.h"

#include "content/public/common/resource_type.h"

+#include "ui/base/page_transition_types.h"

class GURL;

template <class T> class ScopedVector;

@@ -74,7 +75,10 @@ class CONTENT_EXPORT ResourceDispatcherHostDelegate {

// guarantee that the app successfully handled it.

virtual bool HandleExternalProtocol(const GURL& url,

int child_id,

- int route_id);

+ int route_id,

+ bool is_main_frame,

+ ui::PageTransition page_transition,

+ bool has_user_gesture);

// Returns true if we should force the given resource to be downloaded.

// Otherwise, the content layer decides.