Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chrome/browser/ui/cocoa/external_protocol_dialog.mm

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase and fix test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/external_protocol_dialog.mm
diff --git a/chrome/browser/ui/cocoa/external_protocol_dialog.mm b/chrome/browser/ui/cocoa/external_protocol_dialog.mm
index 555913d574c9327b7b44ff933f62ccc32e08ea31..8355c008dbc6e577154ded38c4ea3e77b27bc3fa 100644
--- a/chrome/browser/ui/cocoa/external_protocol_dialog.mm
+++ b/chrome/browser/ui/cocoa/external_protocol_dialog.mm
@@ -20,7 +20,8 @@
// static
void ExternalProtocolHandler::RunExternalProtocolDialog(
- const GURL& url, int render_process_host_id, int routing_id) {
+ const GURL& url, int render_process_host_id, int routing_id,
+ ui::PageTransition page_transition, bool has_user_gesture) {
[[ExternalProtocolDialogController alloc] initWithGURL:&url
renderProcessHostId:render_process_host_id
routingId:routing_id];

Powered by Google App Engine
This is Rietveld 408576698