chrome/browser/ui/views/external_protocol_dialog.cc - Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 1091253008: Fix an issue that external protocol in subframes are not handled on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('K') | « chrome/browser/ui/views/external_protocol_dialog.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/external_protocol_dialog.cc

diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc

index 6b9098c319a1ba976d9c963ba49be05d1714e951..9a0426dc2d42b428674bb621bdb28c553ec4194b 100644

--- a/chrome/browser/ui/views/external_protocol_dialog.cc

+++ b/chrome/browser/ui/views/external_protocol_dialog.cc

@@ -31,7 +31,8 @@ const int kMessageWidth = 400;

// static

void ExternalProtocolHandler::RunExternalProtocolDialog(

- const GURL& url, int render_process_host_id, int routing_id) {

+ const GURL& url, int render_process_host_id, int routing_id,

+ ui::PageTransition page_transition) {

scoped_ptr<ExternalProtocolDialogDelegate> delegate(

new ExternalProtocolDialogDelegate(url,

render_process_host_id,

@@ -119,7 +120,8 @@ const views::Widget* ExternalProtocolDialog::GetWidget() const {

ExternalProtocolDialog::ExternalProtocolDialog(

scoped_ptr<const ProtocolDialogDelegate> delegate,

int render_process_host_id,

- int routing_id)

+ int routing_id,

+ ui::PageTransition page_transition)

: delegate_(delegate.Pass()),

render_process_host_id_(render_process_host_id),

routing_id_(routing_id),