Fix an issue that external protocol in subframes are not handled on Android

chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 220 matching lines @@
                                              url,
                                              GURL(),
                                              &plugin)) {
       return true;
     }
   }
   return false;
 }
 #endif  // !defined(ENABLE_EXTENSIONS)
 
-#if !defined(OS_ANDROID)
-void LaunchURL(const GURL& url, int render_process_id, int render_view_id) {
+void LaunchURL(
+    const GURL& url,
+    int render_process_id,
+    int render_view_id,
+    ui::PageTransition page_transition) {
   // If there is no longer a WebContents, the request may have raced with tab
   // closing. Don't fire the external request. (It may have been a prerender.)
   content::WebContents* web_contents =
       tab_util::GetWebContentsByID(render_process_id, render_view_id);
   if (!web_contents)
     return;
 
   // Do not launch external requests attached to unswapped prerenders.
   prerender::PrerenderContents* prerender_contents =
       prerender::PrerenderContents::FromWebContents(web_contents);
   if (prerender_contents) {
     prerender_contents->Destroy(prerender::FINAL_STATUS_UNSUPPORTED_SCHEME);
     prerender::ReportPrerenderExternalURL();
     return;
   }
 
   ExternalProtocolHandler::LaunchUrlWithDelegate(
       url,
       render_process_id,
       render_view_id,
+      page_transition,
       g_external_protocol_handler_delegate);
 }
-#endif  // !defined(OS_ANDROID)
 
 #if !defined(DISABLE_NACL)
 void AppendComponentUpdaterThrottles(
     net::URLRequest* request,
     content::ResourceContext* resource_context,
     ResourceType resource_type,
     ScopedVector<content::ResourceThrottle>* throttles) {
   const char* crx_id = NULL;
   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
@@ skipping 232 matching lines @@
 
 ResourceDispatcherHostLoginDelegate*
     ChromeResourceDispatcherHostDelegate::CreateLoginDelegate(
         net::AuthChallengeInfo* auth_info, net::URLRequest* request) {
   return CreateLoginPrompt(auth_info, request);
 }
 
 bool ChromeResourceDispatcherHostDelegate::HandleExternalProtocol(
     const GURL& url,
     int child_id,
-    int route_id) {
-#if defined(OS_ANDROID)
-  // Android use a resource throttle to handle external as well as internal
-  // protocols.
-  return false;
-#else
-
+    int route_id,
+    ui::PageTransition page_transition) {

[Jaekyun Seok (inactive), 2015/04/23 03:59:41]

How about running HandleExternalProtocol only when the request type isn't main
frame to keep the current behavior for main frame request?

 #if defined(ENABLE_EXTENSIONS)
   if (extensions::WebViewRendererState::GetInstance()->IsGuest(child_id))
     return false;
 
 #endif  // defined(ENABLE_EXTENSIONS)
 
-  BrowserThread::PostTask(BrowserThread::UI,
-                          FROM_HERE,
-                          base::Bind(&LaunchURL, url, child_id, route_id));
+  BrowserThread::PostTask(
+      BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(&LaunchURL, url, child_id, route_id, page_transition));
   return true;
-#endif
 }
 
 void ChromeResourceDispatcherHostDelegate::AppendStandardResourceThrottles(
     net::URLRequest* request,
     content::ResourceContext* resource_context,
     ResourceType resource_type,
     ScopedVector<content::ResourceThrottle>* throttles) {
   ProfileIOData* io_data = ProfileIOData::FromResourceContext(resource_context);
 #if defined(SAFE_BROWSING_SERVICE)
   // Insert safe browsing at the front of the list, so it gets to decide on
@@ skipping 215 matching lines @@
                                        url_request->GetTotalReceivedBytes()));
   }
 }
 
 // static
 void ChromeResourceDispatcherHostDelegate::
     SetExternalProtocolHandlerDelegateForTesting(
     ExternalProtocolHandler::Delegate* delegate) {
   g_external_protocol_handler_delegate = delegate;
 }