Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2920)

Unified Diff: chrome/test/data/extensions/api_test/mime_handler_view/index.js

Issue 1091253004: Fix MimeHandlerView plugin loading for data: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/mime_handler_view/index.js
diff --git a/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js b/chrome/test/data/extensions/api_test/mime_handler_view/index.js
similarity index 88%
rename from chrome/test/data/extensions/api_test/mime_handler_view/embedded.js
rename to chrome/test/data/extensions/api_test/mime_handler_view/index.js
index 7341521355693c9d2cc18bd0b347e6fb8485c0a5..297cc9ec0bece69775ede07df4f29e3045cd956c 100644
--- a/chrome/test/data/extensions/api_test/mime_handler_view/embedded.js
+++ b/chrome/test/data/extensions/api_test/mime_handler_view/index.js
@@ -39,14 +39,18 @@ function expectSuccessfulRead(response) {
}
function checkStreamDetails(name, embedded) {
- chrome.test.assertTrue(streamDetails.originalUrl.indexOf(name) != -1);
- chrome.test.assertEq('text/csv', streamDetails.mimeType);
- chrome.test.assertTrue(streamDetails.tabId != -1);
+ checkStreamDetailsNoFile();
chrome.test.assertEq(embedded, streamDetails.embedded);
+ chrome.test.assertTrue(streamDetails.originalUrl.indexOf(name) != -1);
chrome.test.assertEq('text/csv',
streamDetails.responseHeaders['Content-Type']);
}
+function checkStreamDetailsNoFile() {
+ chrome.test.assertEq('text/csv', streamDetails.mimeType);
+ chrome.test.assertTrue(streamDetails.tabId != -1);
+}
+
var tests = [
function testBasic() {
checkStreamDetails('testBasic.csv', false);
@@ -107,6 +111,14 @@ var tests = [
handleMessage(queuedMessages.shift());
}
+ },
+
+ function testDataUrl() {
+ // TODO(raymes): have separate checks for embedded/unembedded data URLs.
+ checkStreamDetailsNoFile();
+ fetchUrl(streamDetails.streamUrl)
+ .then(expectSuccessfulRead)
+ .then(chrome.test.succeed);
}
];
@@ -128,4 +140,10 @@ chrome.mimeHandlerPrivate.getStreamInfo(function(streamInfo) {
window.removeEventListener('message', queueMessage);
chrome.test.runTests([testsByName[test]]);
}
+
+ // Run the test for data URLs.
+ if (streamInfo.originalUrl.indexOf("data:") === 0) {
+ window.removeEventListener('message', queueMessage);
+ chrome.test.runTests([testsByName['testDataUrl']]);
+ }
});

Powered by Google App Engine
This is Rietveld 408576698