Fix MimeHandlerView plugin loading for data: URLs

Fix MimeHandlerView plugin loading for data: URLs

MimeHandlerView plugins are passed access to the URL data by intercepting
the stream (in buffered_resource_handler.cc). This means that all URL
requests for these plugins need to go via the browser, otherwise they
won't be correctly intercepted. WebURLRequests for data: URLs have a fast
path for being loaded in the renderer which cannot be taken in the case
of loading these URLs.

BUG=477866
Committed: https://crrev.com/96cd5860a98bab78d22feb5d77866b466f45a982
Cr-Commit-Position: refs/heads/master@{#326421}

[raymes, 2015-04-22 03:52:55]

raymes@chromium.org changed reviewers:
+ sammc@chromium.org

[Sam McNally, 2015-04-22 04:05:04]

https://codereview.chromium.org/1091253004/diff/20001/chrome/test/data/extens...
File
chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url.html
(right):

https://codereview.chromium.org/1091253004/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url.html:3:
<object id="plugin" width="200" height="200"
data="data:text/csv;base64,Y29udGVudCB0byByZWFkCg==" type="text/csv"></object>
Please add a test that uses <embed>

https://codereview.chromium.org/1091253004/diff/20001/content/child/web_url_l...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/1091253004/diff/20001/content/child/web_url_l...
content/child/web_url_loader_impl.cc:783: if (request_.requestContext() ==
WebURLRequest::RequestContextObject)
What about WebURLRequest::RequestContextEmbed?

https://codereview.chromium.org/1091253004/diff/20001/extensions/browser/gues...
File
extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
(right):

https://codereview.chromium.org/1091253004/diff/20001/extensions/browser/gues...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc:74:
const char* kDataUrlCsv = "data:text/csv;base64,Y29udGVudCB0byByZWFkCg==";
Would this navigation have bypassed the browser previously?

[raymes, 2015-04-22 04:11:48]

https://codereview.chromium.org/1091253004/diff/20001/chrome/test/data/extens...
File
chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url.html
(right):

https://codereview.chromium.org/1091253004/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/mime_handler_view/test_embedded_data_url.html:3:
<object id="plugin" width="200" height="200"
data="data:text/csv;base64,Y29udGVudCB0byByZWFkCg==" type="text/csv"></object>
On 2015/04/22 04:05:03, Sam McNally wrote:
> Please add a test that uses <embed>

Done.

https://codereview.chromium.org/1091253004/diff/20001/content/child/web_url_l...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/1091253004/diff/20001/content/child/web_url_l...
content/child/web_url_loader_impl.cc:783: if (request_.requestContext() ==
WebURLRequest::RequestContextObject)
It's not used for MimeHandlers so we don't need to check for it.

https://codereview.chromium.org/1091253004/diff/20001/extensions/browser/gues...
File
extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc
(right):

https://codereview.chromium.org/1091253004/diff/20001/extensions/browser/gues...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc:74:
const char* kDataUrlCsv = "data:text/csv;base64,Y29udGVudCB0byByZWFkCg==";
No, this one would have worked. The one below would have failed (I tested that
it did :).

[raymes, 2015-04-22 04:12:19]

raymes@chromium.org changed reviewers:
+ davidben@chromium.org

[raymes, 2015-04-22 04:12:20]

+davidben for content/child/web_url_loader_impl.cc

[Sam McNally, 2015-04-22 04:32:18]

lgtm

[davidben, 2015-04-22 15:19:19]

lgtm

[raymes, 2015-04-22 23:56:13]

The CQ bit was checked by raymes@chromium.org

[raymes, 2015-04-22 23:56:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/1091253004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-04-22 23:56:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1091253004/80001

[commit-bot: I haz the power, 2015-04-23 01:44:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-23 01:45:00]

Patchset 5 (id:??) landed as
https://crrev.com/96cd5860a98bab78d22feb5d77866b466f45a982
Cr-Commit-Position: refs/heads/master@{#326421}