ui/ozone/platform/drm/gpu/page_flip_request.h - Issue 1091253003: [ozone] Keep the queue of surfaceless buffers inside gl_surface_ozone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/platform/drm/gpu/page_flip_request.h

Issue 1091253003: [ozone] Keep the queue of surfaceless buffers inside gl_surface_ozone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/ozone/platform/drm/gpu/hardware_display_controller.cc ('K') | « ui/ozone/platform/drm/gpu/page_flip_observer.h ('k') | ui/ozone/platform/drm/gpu/page_flip_request.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_

	6 #define UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_

	7

	8 #include "base/callback.h"

	9 #include "base/memory/scoped_ptr.h"

	10 #include "ui/ozone/ozone_export.h"

	11

	12 namespace ui {

	13

	14 class PageFlipRequest : public base::RefCounted<PageFlipRequest> {

	15 public:

	16 PageFlipRequest(int crtc_count, const base::Closure& callback);

	17 ~PageFlipRequest();
	dnicoara 2015/04/23 15:34:57 I believe you'll need to make the destructor priva I believe you'll need to make the destructor private due to ref counting; otherwise clang will complain.
	18

	19 base::Closure callback;
	dnicoara 2015/04/23 15:34:56 And for style guide consistency this should be pri And for style guide consistency this should be private. Just add a Signal()/OnPageflip() function to run the callback.
	20 };

	21

	22 } // namespace ui

	23

	24 #endif // UI_OZONE_PLATFORM_DRM_GPU_PAGE_FLIP_REQUEST_H_

OLD	NEW