build/get_landmines.py - Issue 109123005: Add landmine to clober mac and win to fix bad dependency for create_nmf.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_landmines.py

Issue 109123005: Add landmine to clober mac and win to fix bad dependency for create_nmf.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/get_landmines.py

===================================================================

--- build/get_landmines.py (revision 241031)

+++ build/get_landmines.py (working copy)

@@ -37,6 +37,9 @@

print 'Builders switching from make to ninja will clobber on this.'

if platform() == 'mac':

print 'Switching from bundle to unbundled dylib (issue 14743002).'

+ if platform() in ('win', 'mac'):

+ print ('Improper dependency for create_nmf.py broke in r240802, '

+ 'fixed in r240860.')

if (platform() == 'win' and builder() == 'ninja' and

gyp_msvs_version() == '2012' and

gyp_defines().get('target_arch') == 'x64' and

« no previous file with comments | « no previous file | no next file » | no next file with comments »