Removed the context menu in kiosk mode

chrome/browser/chrome_browser_application_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/chrome_browser_application_mac.h"
 
 #import "base/auto_reset.h"
+#include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/debug/stack_trace.h"
 #import "base/logging.h"
 #import "base/mac/scoped_nsexception_enabler.h"
 #import "base/mac/scoped_nsobject.h"
 #import "base/mac/scoped_objc_class_swizzler.h"
 #import "base/metrics/histogram.h"
 #include "base/profiler/scoped_tracker.h"
 #include "base/strings/stringprintf.h"
 #import "base/strings/sys_string_conversions.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
 #import "chrome/common/mac/objc_zombie.h"
 #include "content/public/browser/browser_accessibility_state.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 
 namespace {
 
 // Tracking for cases being hit by -crInitWithName:reason:userInfo:.
 enum ExceptionEventType {
@@ skipping 450 matching lines @@
     case NSLeftMouseDragged:
     case NSRightMouseDragged:
     case NSMouseEntered:
     case NSMouseExited:
     case NSOtherMouseDown:
     case NSOtherMouseUp:
     case NSOtherMouseDragged: {
       tracked_objects::ScopedTracker tracking_profile(
           FROM_HERE_WITH_EXPLICIT_FUNCTION(
               "463272 -[BrowserCrApplication sendEvent:] Mouse"));
-      base::mac::ScopedSendingEvent sendingEventScoper;
-      [super sendEvent:event];
+      const base::CommandLine* command_line =

[Robert Sesek, 2015/06/24 18:36:12]

nit: blank line before

[Robert Sesek, 2015/06/24 18:36:12]

naming: commandLine

[frederic.jacob.78, 2015/06/24 21:35:03]

Acknowledged.

[frederic.jacob.78, 2015/06/24 21:35:03]

Done.

+          base::CommandLine::ForCurrentProcess();
+      const bool kioskMode = command_line->HasSwitch(switches::kKioskMode);

[Peter Kasting, 2015/06/24 20:40:56]

Nit: Personally I think the explosion of temps here is a bit excessive.  I would
at least inline |command_line| into |kioskMode|, and I would probably inline
that into the conditional below.  |isLeftMouseMenu| is probably good to keep as
a separate temp; |isRightMouseMenu| I would perhaps inline, but up to you.

[frederic.jacob.78, 2015/06/24 21:35:03]

I finally changed the code to only use the isLeftMouseMenu temp and embedded all
the rest in the if.

+      const bool isRightMouseMenu = (event.type == NSRightMouseDown);
+      const bool isLeftMouseMenu = (event.type == NSLeftMouseDown) &&
+                                   ([event modifierFlags] & NSControlKeyMask);
+
+      if (!kioskMode || (!isRightMouseMenu && !isLeftMouseMenu)) {

[Robert Sesek, 2015/06/24 18:36:12]

Leave a comment as to why this is here.

[frederic.jacob.78, 2015/06/24 21:35:03]

Done.

+        base::mac::ScopedSendingEvent sendingEventScoper;
+        [super sendEvent:event];
+      }
       break;
     }
 
     case NSKeyDown:
     case NSKeyUp: {
       tracked_objects::ScopedTracker tracking_profile(
           FROM_HERE_WITH_EXPLICIT_FUNCTION(
               "463272 -[BrowserCrApplication sendEvent:] Key"));
       base::mac::ScopedSendingEvent sendingEventScoper;
       [super sendEvent:event];
@@ skipping 183 matching lines @@
   std::vector<NSWindow*>::iterator window_iterator =
       std::find(previousKeyWindows_.begin(),
                 previousKeyWindows_.end(),
                 window);
   if (window_iterator != previousKeyWindows_.end()) {
     previousKeyWindows_.erase(window_iterator);
   }
 }
 
 @end