chrome/browser/ui/tab_contents/tab_contents.cc - Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/tab_contents.cc

Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents.h ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_contents/tab_contents.cc

diff --git a/chrome/browser/ui/tab_contents/tab_contents.cc b/chrome/browser/ui/tab_contents/tab_contents.cc

index b035de4c5ce65d79dced5822e5b890d58559696f..04bba0a51b33c1e36b74fe80c32dbc2cd9d05d3c 100644

--- a/chrome/browser/ui/tab_contents/tab_contents.cc

+++ b/chrome/browser/ui/tab_contents/tab_contents.cc

@@ -186,8 +186,8 @@ TabContents::TabContents(WebContents* contents)

#endif

#if defined(ENABLE_PRINTING)

- print_view_manager_.reset(new printing::PrintViewManager(this));

- print_preview_.reset(new printing::PrintPreviewMessageHandler(contents));

+ printing::PrintPreviewMessageHandler::CreateForWebContents(contents);

+ printing::PrintViewManager::CreateForWebContents(contents);

Scott Byer 2012/09/18 17:24:40 Did you intend to reverse the creation order? (Not

#endif

// Start the in-browser thumbnailing if the feature is enabled.

« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents.h ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »