Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: lib/compiler/implementation/closure.dart

Issue 10911344: Fix for issue #5227: do not declare type variables in the closure analyzer when they are not needed. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/closure_in_constructor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/closure.dart
===================================================================
--- lib/compiler/implementation/closure.dart (revision 12455)
+++ lib/compiler/implementation/closure.dart (working copy)
@@ -374,11 +374,13 @@
}
}
- if (outermostFunctionElement.isInstanceMember()
- || outermostFunctionElement.isGenerativeConstructor()) {
- if (hasTypeVariable(type)) useLocal(closureData.thisElement);
- } else if (outermostFunctionElement.isFactoryConstructor()) {
- analyzeTypeVariables(type);
+ if (compiler.world.needsRti(outermostFunctionElement.enclosingElement)) {
+ if (outermostFunctionElement.isInstanceMember()
+ || outermostFunctionElement.isGenerativeConstructor()) {
+ if (hasTypeVariable(type)) useLocal(closureData.thisElement);
+ } else if (outermostFunctionElement.isFactoryConstructor()) {
+ analyzeTypeVariables(type);
+ }
}
node.visitChildren(this);
@@ -547,7 +549,8 @@
declareLocal(element);
}
- if (currentFunctionElement.isFactoryConstructor()) {
+ if (currentFunctionElement.isFactoryConstructor()
+ && compiler.world.needsRti(currentFunctionElement.enclosingElement)) {
// Declare the type parameters in the scope. Generative
// constructors just use 'this'.
ClassElement cls = currentFunctionElement.enclosingElement;
« no previous file with comments | « no previous file | tests/language/closure_in_constructor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698