Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: lib/core/date.dart

Issue 10911325: Normalization of patch signatures. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Long lines fixed. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/core/date.dart
diff --git a/lib/core/date.dart b/lib/core/date.dart
index e36a8ba57a21edeb0ebfad583dff903c8b4a0bd7..0db2132db71b2a1d2dc4809e69b816aef9973d77 100644
--- a/lib/core/date.dart
+++ b/lib/core/date.dart
@@ -48,13 +48,13 @@ interface Date extends Comparable, Hashable default DateImplementation {
// TODO(floitsch): the spec allows default values in interfaces, but our
// tools don't yet. Eventually we want to have default values here.
Date(int year,
- [int month,
- int day,
- int hour,
- int minute,
- int second,
- int millisecond,
- bool isUtc]);
+ [int month = 1,
Mads Ager (google) 2012/09/17 05:52:56 Are default values allowed in interfaces now? They
Lasse Reichstein Nielsen 2012/09/17 11:32:43 It's allowed since v. 0.09. But it's true that it'
Mads Ager (google) 2012/09/17 11:37:26 Great, now that it is allowed I'm actually strongl
Johnni Winther 2012/09/19 09:03:30 It seems to be allowed now and the TODO above want
+ int day = 1,
+ int hour = 0,
+ int minute = 0,
+ int second = 0,
+ int millisecond = 0,
+ bool isUtc = false]);
/**
* Constructs a new [Date] instance with current date time value in the

Powered by Google App Engine
This is Rietveld 408576698