Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10911318: Revert "Make unittest follow the new package layout." (Closed)

Created:
8 years, 3 months ago by Bob Nystrom
Modified:
8 years, 3 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Make unittest follow the new package layout." This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01. Committed: https://code.google.com/p/dart/source/detail?r=12400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -6368 lines) Patch
M pkg/args/test/args_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/dartdoc/test/dartdoc_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/dartdoc/test/markdown_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/intl/test/bidi_format_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/intl/test/bidi_utils_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/intl/test/date_time_format_test_core.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/intl/test/intl_message_basic_example_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/intl/test/intl_message_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/intl/test/intl_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/intl/test/number_format_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/logging/test/logging_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/unittest/collection_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/config.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/core_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/description.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/expect.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/future_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/html_config.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/unittest/html_enhanced_config.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/html_layout_config.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/html_print.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/interactive_html_config.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/interfaces.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/unittest/lib/html_config.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D pkg/unittest/lib/html_enhanced_config.dart View 1 chunk +0 lines, -382 lines 0 comments Download
D pkg/unittest/lib/html_layout_config.dart View 1 chunk +0 lines, -310 lines 0 comments Download
D pkg/unittest/lib/interactive_html_config.dart View 1 chunk +0 lines, -658 lines 0 comments Download
D pkg/unittest/lib/src/collection_matchers.dart View 1 chunk +0 lines, -199 lines 0 comments Download
D pkg/unittest/lib/src/config.dart View 1 chunk +0 lines, -151 lines 0 comments Download
D pkg/unittest/lib/src/core_matchers.dart View 1 chunk +0 lines, -626 lines 0 comments Download
D pkg/unittest/lib/src/description.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D pkg/unittest/lib/src/expect.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D pkg/unittest/lib/src/future_matchers.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/unittest/lib/src/html_print.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D pkg/unittest/lib/src/interfaces.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D pkg/unittest/lib/src/map_matchers.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D pkg/unittest/lib/src/matcher.dart View 1 chunk +0 lines, -56 lines 0 comments Download
D pkg/unittest/lib/src/mock.dart View 1 chunk +0 lines, -1459 lines 0 comments Download
D pkg/unittest/lib/src/numeric_matchers.dart View 1 chunk +0 lines, -229 lines 0 comments Download
D pkg/unittest/lib/src/operator_matchers.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D pkg/unittest/lib/src/string_matchers.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D pkg/unittest/lib/src/test_case.dart View 1 chunk +0 lines, -126 lines 0 comments Download
D pkg/unittest/lib/unittest.dart View 1 chunk +0 lines, -874 lines 0 comments Download
D pkg/unittest/lib/vm_config.dart View 1 chunk +0 lines, -28 lines 0 comments Download
A + pkg/unittest/map_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/matcher.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/mock.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/numeric_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/operator_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/string_matchers.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/unittest/test/instance_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/test/mock_regexp_negative_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/unittest/test/mock_stepwise_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/test/mock_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/unittest/test/unittest_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/unittest/test_case.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/unittest/unittest.dart View 2 chunks +15 lines, -15 lines 0 comments Download
A + pkg/unittest/vm_config.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M samples/markdown/test/markdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/tests/samples/dartcombat/dartcombat_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/tests/samples/lib/layout/layout_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/tests/samples/lib/observable/observable_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/touch/touch_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/util/util_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/view/view_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/swarm/swarm_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/async_window_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audiocontext_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audioelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/b_element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/blob_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cache_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/callbacks_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_pixel_array_type_alias_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_using_html_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cross_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/css_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dart_object_local_storage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/datalistelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/document_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/documentfragment_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dom_constructors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dom_isolates_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/domparser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_add_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_constructor_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_customevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/events_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/exceptions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/fileapi_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/form_data_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/form_element_test.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M tests/html/hidden_dom_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/hidden_dom_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/history_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlaudioelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmloptionscollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_3_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/indexeddb_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/inner_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/instance_of_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/isolates_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/key_name_location_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/localstorage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/location_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/measurement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/messageevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/mutationobserver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/native_gc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/performance_api_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/query_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/queryall_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/request_animation_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/serialized_script_value_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/shadow_dom_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/html/storage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svg_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svg_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svg_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svgelement2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/svgelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/transferables_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_5_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_arraybuffer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_range_checks_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typing_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/unknownelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/url_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/webgl_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/websocket_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/websql_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_eq_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_mangling_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_nosuchmethod_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_open_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xhr_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xmldocument_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xmlelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xsltprocessor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/compute_this_script_browser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/count_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/cross_isolate_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate3_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate_complex_messages_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/mandel_isolate_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/message2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/mint_maker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/nested_spawn2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/nested_spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/request_reply_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_function_custom_class_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_function_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_function_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_vm_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/unresolved_ports_negative_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/unresolved_ports_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/json/json_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/mirrors_test.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -2 lines 0 comments Download
M utils/tests/archive/reader_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/archive/utils_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/lock_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_install_git_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_install_hosted_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_install_sdk_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_install_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_update_git_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_update_hosted_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pub_update_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/pubspec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/version_solver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/pub/yaml_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Bob Nystrom
TBR.
8 years, 3 months ago (2012-09-14 19:42:18 UTC) #1
Emily Fortuna
8 years, 3 months ago (2012-09-14 19:46:03 UTC) #2
lgtm. 
Please email me the output of that script when you get a chance, so I can figure
out why it wasn't working on your machine. Thanks!

Powered by Google App Engine
This is Rietveld 408576698