Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10911283: Implement 'Do Not Track' header (Closed)

Created:
8 years, 3 months ago by battre
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, arv (Not doing code reviews), Patrick Nepper
Visibility:
Public.

Description

Implement 'Do Not Track' header DNT support is currently under development. BUG=81844 TBR=pkasting@chromium.org for chrome/browser/ui TBR=brettw@chromium.org for chrome/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156566

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed Jochen's comments #

Patch Set 3 : Merged with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -33 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/do_not_track_browsertest.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 4 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 4 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A + chrome/browser/resources/options/do_not_track_confirm_overlay.css View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/resources/options/do_not_track_confirm_overlay.html View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/do_not_track_confirm_overlay.js View 1 chunk +44 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_ui_prefs.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
battre
Hi Jochen, please review. Thanks, Dominic
8 years, 3 months ago (2012-09-13 15:31:05 UTC) #1
battre
Evan, can you please review chrome/browser/ui/webui/options and chrome/browser/resources/options. Thanks. Dominic
8 years, 3 months ago (2012-09-13 15:31:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/10911283/diff/1/chrome/browser/do_not_track_browsertest.cc File chrome/browser/do_not_track_browsertest.cc (right): https://codereview.chromium.org/10911283/diff/1/chrome/browser/do_not_track_browsertest.cc#newcode5 chrome/browser/do_not_track_browsertest.cc:5: #include "base/file_path.h" nit. not required https://codereview.chromium.org/10911283/diff/1/chrome/browser/do_not_track_browsertest.cc#newcode11 ...
8 years, 3 months ago (2012-09-13 15:35:47 UTC) #3
Evan Stade
webui/ and resources/ lgtm
8 years, 3 months ago (2012-09-13 15:38:23 UTC) #4
battre
https://codereview.chromium.org/10911283/diff/1/chrome/browser/do_not_track_browsertest.cc File chrome/browser/do_not_track_browsertest.cc (right): https://codereview.chromium.org/10911283/diff/1/chrome/browser/do_not_track_browsertest.cc#newcode5 chrome/browser/do_not_track_browsertest.cc:5: #include "base/file_path.h" On 2012/09/13 15:35:48, jochen wrote: > nit. ...
8 years, 3 months ago (2012-09-13 16:16:07 UTC) #5
battre
willchan, please LGTM for chrome/browser/net, chrome/browser/profiles
8 years, 3 months ago (2012-09-13 16:37:34 UTC) #6
willchan no longer on Chromium
chrome/browser/net/ + chrome/browser/profiles lgtm :P
8 years, 3 months ago (2012-09-13 16:39:12 UTC) #7
battre
TBR pkasting for chrome/browser/ui
8 years, 3 months ago (2012-09-13 16:44:33 UTC) #8
Peter Kasting
8 years, 3 months ago (2012-09-14 17:11:39 UTC) #9 
LGTM, I thought I already r+ed this change publicly elsewhere...

Powered by Google App Engine
This is Rietveld 408576698