Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: tests/language/optimized_lists.dart

Issue 10911277: Optimize code for bound checks if array is constant. Skip unnecessary Smi checks if they still surv… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/optimized_lists.dart
===================================================================
--- tests/language/optimized_lists.dart (revision 12301)
+++ tests/language/optimized_lists.dart (working copy)
@@ -6,18 +6,24 @@
main() {
// Trigger optimization of 'test' method.
for (int i = 0; i < 1000; i++) {
- test();
+ test(2);
}
}
-test() {
+test(n) {
var a = new List(); // Growable list.
var b = new List(10); // Fixed size list.
+ var c = const [1, 2, 3, 4]; // Constant aray.
// In optimized mode the class checks will be eliminated since the
// constructors above provide information about exact types.
a.add(4);
b[0] = 5;
Expect.equals(4, a[0]);
Expect.equals(5, b[0]);
+ // Test bound check elimination.
+ Expect.equals(2, c[1]);
+ // Test elimination of array length computation.
+ var v = c[n];
+ Expet equals(v, c[n]);
}
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698