fix aura windows link error

fix aura windows link error

[14->1/15 ~0] LINK(DLL) initial\chrome.dll
FAILED: d:\src\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x86 link.exe /nologo /IMPLIB:initial\chrome.dll.lib /DLL /OUT:initial\chrome.dll /PDB:initial\chrome.dll.pdb @initial\chrome.dll.rsp && d:\src\depot_tools\python_bin\python.exe
gyp-win-tool manifest-wrapper environment.x86 mt.exe -nologo -manifest ..\..\chrome\app\chrome.dll.manifest obj\chrome\chrome_main_dll.chrome.dll.intermediate.manifest -out:initial\chrome.dll.manifest
browser_ui.opaque_browser_frame_view.obj : error LNK2019: unresolved external symbol "public: bool __thiscall BrowserFrame::ShouldLeaveOffsetNearTopBorder(void)" (?ShouldLeaveOffsetNearTopBorder@BrowserFrame@@QAE_NXZ) referenced in function "protected: int __thiscall OpaqueBrowserFrameView::NonClientTopBorderHeight(bool)const " (?NonClientTopBorderHeight@OpaqueBrowserFrameView@@IBEH_N@Z)
initial\chrome.dll : fatal error LNK1120: 1 unresolved externals

started here: https://chromiumcodereview.appspot.com/10919223/

TBR=ben@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156324

[Ben Goodger (Google), 2012-09-12 17:50:22]

lgtm


On Wed, Sep 12, 2012 at 10:49 AM, <scottmg@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> fix aura windows link error
>
> [14->1/15 ~0] LINK(DLL) initial\chrome.dll
> FAILED: d:\src\depot_tools\python_bin\**python.exe gyp-win-tool
> link-wrapper
> environment.x86 link.exe /nologo /IMPLIB:initial\chrome.dll.lib /DLL
> /OUT:initial\chrome.dll /PDB:initial\chrome.dll.pdb
> @initial\chrome.dll.rsp &&
> d:\src\depot_tools\python_bin\**python.exe
> gyp-win-tool manifest-wrapper environment.x86 mt.exe -nologo -manifest
> ..\..\chrome\app\chrome.dll.**manifest
> obj\chrome\chrome_main_dll.**chrome.dll.intermediate.**manifest
> -out:initial\chrome.dll.**manifest
> browser_ui.opaque_browser_**frame_view.obj : error LNK2019: unresolved
> external
> symbol "public: bool __thiscall
> BrowserFrame::**ShouldLeaveOffsetNearTopBorder**(void)"
> (?**ShouldLeaveOffsetNearTopBorder**@BrowserFrame@@QAE_NXZ) referenced in
> function
> "protected: int __thiscall
> OpaqueBrowserFrameView::**NonClientTopBorderHeight(bool)**const "
> (?NonClientTopBorderHeight@**OpaqueBrowserFrameView@@IBEH_**N@Z)
> initial\chrome.dll : fatal error LNK1120: 1 unresolved externals
>
> started here:
https://chromiumcodereview.**appspot.com/10919223/<https://chromiumcodereview...
>
> R=ben@chromium.org
> BUG=
>
> Please review this at
https://codereview.chromium.**org/10911255/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/views/frame/**browser_frame.cc
>
>
> Index: chrome/browser/ui/views/frame/**browser_frame.cc
> diff --git a/chrome/browser/ui/views/**frame/browser_frame.cc
> b/chrome/browser/ui/views/**frame/browser_frame.cc
> index 207b1a8f4a75af18f501f420841f61**ea24c07b8f..**
> cf380f069f585c5199ef8eccfaf126**f77a8f4fd1 100644
> --- a/chrome/browser/ui/views/**frame/browser_frame.cc
> +++ b/chrome/browser/ui/views/**frame/browser_frame.cc
> @@ -153,8 +153,8 @@ AvatarMenuButton* BrowserFrame::**GetAvatarMenuButton()
> {
>    return browser_frame_view_->avatar_**button();
>  }
>
> -#if !defined(OS_WIN)
> +#if !defined(OS_WIN) || defined(USE_AURA)
>  bool BrowserFrame::**ShouldLeaveOffsetNearTopBorder**() {
>    return !IsMaximized();
>  }
> -#endif  // OS_WIN
> \ No newline at end of file
> +#endif  // OS_WIN
>
>
>