Runtime support for the new parameter specification.

lib/compiler/implementation/js_backend/namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
 class Namer {
   final Compiler compiler;
 
@@ skipping 80 matching lines @@
       String libName = getName(lib);
       // If a library name does not start with the [LIBRARY_PREFIX] then our
       // assumptions about clashing with mangled private members do not hold.
       assert(libName.startsWith(LIBRARY_PREFIX));
       return '_$libName$nameString';
     } else {
       return name.slowToString();
     }
   }
 
-  String instanceMethodName(LibraryElement lib, SourceString name, int arity) {
-    return '${privateName(lib, name)}\$$arity';
+  String instanceMethodName(FunctionElement element) {
+    SourceString name = element.name;
+    LibraryElement lib = element.getLibrary();
+    if (element.kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY) {
+      ConstructorBodyElement bodyElement = element;
+      name = bodyElement.constructor.name;
+    }
+    FunctionSignature signature = element.computeSignature(compiler);
+    String methodName =
+        '${privateName(lib, name)}\$${signature.parameterCount}';
+    if (!signature.optionalParametersAreNamed) {
+      return methodName;
+    } else {
+      StringBuffer suffix = new StringBuffer();
+      signature.forEachOptionalParameter((Element element) {
+        String jsName = JsNames.getValid(element.name.slowToString());        
+        suffix.add('\$$jsName');
+      });
+      return '$methodName$suffix';
+    }
+  }
+
+  String instanceMethodNameByArity(SourceString name, int arity) {
+    return '${name.slowToString()}\$$arity';

[ahe, 2012/09/13 14:29:10]

assert(!name.isPrivate());

[ngeoffray, 2012/09/17 12:21:01]

Done.

   }
 
   String instanceMethodInvocationName(LibraryElement lib, SourceString name,
                                       Selector selector) {
     // TODO(floitsch): mangle, while preserving uniqueness.
     StringBuffer buffer = new StringBuffer();
     List<SourceString> names = selector.getOrderedNamedArguments();
     for (SourceString argumentName in names) {
       buffer.add(@'$');
       argumentName.printOn(buffer);
@@ skipping 87 matching lines @@
   /**
    * Returns a preferred JS-id for the given element. The returned id is
    * guaranteed to be a valid JS-id. Globals and static fields are furthermore
    * guaranteed to be unique.
    *
    * For accessing statics consider calling
    * [isolateAccess]/[isolateBailoutAccess] or [isolatePropertyAccess] instead.
    */
   String getName(Element element) {
     if (element.isInstanceMember()) {
-      if (element.kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY) {
-        ConstructorBodyElement bodyElement = element;
-        SourceString name = bodyElement.constructor.name;
-        return instanceMethodName(element.getLibrary(),
-                                  name, bodyElement.parameterCount(compiler));
-      } else if (element.kind == ElementKind.FUNCTION) {
-        FunctionElement functionElement = element;
-        return instanceMethodName(element.getLibrary(),
-                                  element.name,
-                                  functionElement.parameterCount(compiler));
+      if (element.kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY
+          || element.kind == ElementKind.FUNCTION) {
+        return instanceMethodName(element);
       } else if (element.kind == ElementKind.GETTER) {
         return getterName(element.getLibrary(), element.name);
       } else if (element.kind == ElementKind.SETTER) {
         return setterName(element.getLibrary(), element.name);
       } else if (element.kind == ElementKind.FIELD) {
         return instanceFieldName(element.getLibrary(), element.name);
       } else {
         compiler.internalError('getName for bad kind: ${element.kind}',
                                node: element.parseNode(compiler));
       }
@@ skipping 57 matching lines @@
   }
 
   String safeName(String name) {
     if (jsReserved.contains(name) || name.startsWith('\$')) {
       name = "\$$name";
       assert(!jsReserved.contains(name));
     }
     return name;
   }
 }