Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1494)

Issue 10911141: Adds localized strings for accessibility of input type "time" (Closed)

Created:
8 years, 3 months ago by yosin_UTC9
Modified:
8 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dmazzoni, forms-bugs_chromium.org
Visibility:
Public.

Description

Adds localized strings for accessibility of multiple field date time input UI. Newly added strings are used in "aria-help" and "aria-valuetext" HTML attribute for AX. Usage of these strings are found in https://bugs.webkit.org/show_bug.cgi?id=96032 BUG=146961 TEST=done in WebKit layout test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155713

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch 2 - Update descriptions in webkit_strings.grd #

Total comments: 2

Patch Set 3 : Patch 3 - Simplify message description and make labels Capital and use plural for time fields, e.g.… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M webkit/glue/webkit_strings.grd View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. Note: This patch requires WebKit r127843. I'll ...
8 years, 3 months ago (2012-09-07 09:18:05 UTC) #1
tkent
http://codereview.chromium.org/10911141/diff/1/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): http://codereview.chromium.org/10911141/diff/1/webkit/glue/webkit_strings.grd#newcode317 webkit/glue/webkit_strings.grd:317: <message name="IDS_AX_AM_PM_FIELD_TEXT" desc="description of AM/PM field used as value ...
8 years, 3 months ago (2012-09-07 09:35:39 UTC) #2
yosin_UTC9
I updated descriptions in webkit_strings.grd. Could you review this patch? Thanks in advance. Note: This ...
8 years, 3 months ago (2012-09-07 09:56:50 UTC) #3
dmazzoni
http://codereview.chromium.org/10911141/diff/1/webkit/glue/webkit_strings.grd File webkit/glue/webkit_strings.grd (right): http://codereview.chromium.org/10911141/diff/1/webkit/glue/webkit_strings.grd#newcode317 webkit/glue/webkit_strings.grd:317: <message name="IDS_AX_AM_PM_FIELD_TEXT" desc="description of AM/PM field used as value ...
8 years, 3 months ago (2012-09-07 10:00:01 UTC) #4
yosin_UTC9
I updated descriptions and messages in webkit_strings.grd. Could you review this patch? Thanks in advance. ...
8 years, 3 months ago (2012-09-07 10:22:50 UTC) #5
dmazzoni
lgtm
8 years, 3 months ago (2012-09-07 14:48:30 UTC) #6
tony
rs lgtm
8 years, 3 months ago (2012-09-07 17:32:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/10911141/6
8 years, 3 months ago (2012-09-10 09:22:32 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 13:24:06 UTC) #9
Change committed as 155713

Powered by Google App Engine
This is Rietveld 408576698