Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Issue 1091073004: Fix dart generation to work on windows (Closed)

Created:
5 years, 8 months ago by sky
Modified:
5 years, 8 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix dart generation to work on windows os.symlink is linux specific. R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8563c3d4162bd74e96783e823e076e99869d7385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
5 years, 8 months ago (2015-04-16 23:13:24 UTC) #1
zra
lgtm
5 years, 8 months ago (2015-04-16 23:30:12 UTC) #2
sky
5 years, 8 months ago (2015-04-16 23:31:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8563c3d4162bd74e96783e823e076e99869d7385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698