Issue 1091063002: Get sublime's syntax highlighting working in css_checker.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1091063002: Get sublime's syntax highlighting working in css_checker.py (Closed)

Created:
5 years, 8 months ago by Daniel Imms

Modified:
5 years, 8 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Get sublime's syntax highlighting working in css_checker.py Multi-line Python regex's with inner python comments was breaking sublime text's syntax highlighting. BUG=NONE Committed: https://crrev.com/d8ea0a1241094c63dedee58ebdc4888aa5e7f2f8 Cr-Commit-Position: refs/heads/master@{#325493}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -15 lines)			Patch
	M	chrome/browser/web_dev_style/css_checker.py	View		12 chunks	+29 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tyler Breisacher (Chromium)

this actually looks nicer anyway. lgtm

5 years, 8 months ago (2015-04-16 18:26:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091063002/1

5 years, 8 months ago (2015-04-16 18:51:34 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-16 19:18:14 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d8ea0a1241094c63dedee58ebdc4888aa5e7f2f8
Cr-Commit-Position: refs/heads/master@{#325493}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages