Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1091053002: Add a test for decoding a gif with sampleSize 4. (Closed)

Created:
5 years, 8 months ago by scroggo
Modified:
5 years, 7 months ago
Reviewers:
msarett
CC:
reviews_skia.org, Zoran Jovanovic
Base URL:
https://skia.googlesource.com/skia.git@zoran
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a test for decoding a gif with sampleSize 4. Prior to https://codereview.chromium.org/1085253002/, this would crash. Only happens with interlaced gif images with an odd height. (Maybe there are more restrictions?) Test image provided by zoran.jovanovic@sonymobile.com for checking in. Add include before includes. Committed: https://skia.googlesource.com/skia/+/9d214295e47405019d1494182a5182a92a22f0a6

Patch Set 1 #

Patch Set 2 : Use a test image provided by SonyMobile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A resources/test640x479.gif View 1 Binary file 0 comments Download
M tests/GifTest.cpp View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091053002/20001
5 years, 8 months ago (2015-04-21 16:24:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-21 16:37:52 UTC) #5
scroggo
PTAL
5 years, 7 months ago (2015-05-13 17:48:35 UTC) #6
msarett
lgtm
5 years, 7 months ago (2015-05-14 21:25:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091053002/20001
5 years, 7 months ago (2015-05-14 21:37:15 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 21:44:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9d214295e47405019d1494182a5182a92a22f0a6

Powered by Google App Engine
This is Rietveld 408576698