Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1091043002: Use networkingPrivate.startConnect (Take 2) (Closed)

Created:
5 years, 8 months ago by stevenjb
Modified:
5 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-options_chromium.org, hashimoto+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use networkingPrivate.startConnect (Take 2) This adds checks for unconfigured or non-activated networks to internet_details.js since it no longer uses the checks in network_connect.cc. It also moves some notification handling from network_connect.cc to network_state_notifier.cc so that it does not rely on network_connect.cc. Original CL (reverted for unrelated failure): https://codereview.chromium.org/1043343002/ BUG=430115 TBR=michaelpg, pneubeck, mpearson@chromium.org Committed: https://crrev.com/ac04fd8970250987d888f557a328dabc7548941a Cr-Commit-Position: refs/heads/master@{#325484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -104 lines) Patch
M chrome/browser/chromeos/options/network_config_view.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 chunk +51 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 3 chunks +0 lines, -26 lines 0 comments Download
M chrome/test/data/extensions/api_test/networking_private/chromeos/test.js View 1 chunk +13 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 4 chunks +16 lines, -18 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_impl.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chromeos/network/network_state.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/network/network_state.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chromeos/network/network_state_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chromeos/network/network_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M chromeos/network/onc/onc_translator.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 7 chunks +31 lines, -11 lines 0 comments Download
M chromeos/network/onc/onc_translator_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/policy_applicator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/device_event_log/device_event_log_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/onc/docs/onc_spec.html View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/chromeos/network/network_connect.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M ui/chromeos/network/network_state_notifier.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/chromeos/network/network_state_notifier.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1091043002/1
5 years, 8 months ago (2015-04-16 17:33:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 19:03:23 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 19:04:22 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ac04fd8970250987d888f557a328dabc7548941a
Cr-Commit-Position: refs/heads/master@{#325484}

Powered by Google App Engine
This is Rietveld 408576698