If desktop chrome is launched via the New Window/the recently opened url shortcuts on the chrome sh…

If desktop chrome is launched via the New Window/the recently opened url shortcuts on the chrome shortcut or simply from the
command line, if we defer to immersive chrome if it is already running, then we should also activate the metro chrome instance.

Added a helper function IsProcessImmersive which takes in the process handle to determine if it is immersive to base\win\metro.cc/.h

BUG=144297
R=cpu
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157250

[cpu_(ooo_6.6-7.5), 2012-09-17 20:39:06]

lgtm

http://codereview.chromium.org/10910311/diff/1/base/win/metro.h
File base/win/metro.h (right):

http://codereview.chromium.org/10910311/diff/1/base/win/metro.h#newcode55
base/win/metro.h:55: BASE_EXPORT bool IsImmersiveProcess(HANDLE process);
rename so it does not clash with sdk's IsImmersiveProcess

IsProcessImmersive ?

http://codereview.chromium.org/10910311/diff/1/chrome/browser/process_singlet...
File chrome/browser/process_singleton_win.cc (right):

http://codereview.chromium.org/10910311/diff/1/chrome/browser/process_singlet...
chrome/browser/process_singleton_win.cc:129: base::win::ScopedCOMInitializer
com_init;
we are trying to limit the com initialization to only once per thread. This
being the main thread probably has com initialized already?

Last I looked ScopedCOMInitializer had a dcheck to prevent nested
initialization.

http://codereview.chromium.org/10910311/diff/1/chrome/browser/process_singlet...
chrome/browser/process_singleton_win.cc:353: 
check for win8 or bigger here, that is less expensive that opening and closing a
process handle.

[ananta, 2012-09-17 22:16:31]

http://codereview.chromium.org/10910311/diff/1/base/win/metro.h
File base/win/metro.h (right):

http://codereview.chromium.org/10910311/diff/1/base/win/metro.h#newcode55
base/win/metro.h:55: BASE_EXPORT bool IsImmersiveProcess(HANDLE process);
On 2012/09/17 20:39:06, cpu wrote:
> rename so it does not clash with sdk's IsImmersiveProcess
> 
> IsProcessImmersive ?

Done.

http://codereview.chromium.org/10910311/diff/1/chrome/browser/process_singlet...
File chrome/browser/process_singleton_win.cc (right):

http://codereview.chromium.org/10910311/diff/1/chrome/browser/process_singlet...
chrome/browser/process_singleton_win.cc:129: base::win::ScopedCOMInitializer
com_init;
On 2012/09/17 20:39:06, cpu wrote:
> we are trying to limit the com initialization to only once per thread. This
> being the main thread probably has com initialized already?
> 
> Last I looked ScopedCOMInitializer had a dcheck to prevent nested
> initialization.

Removed

http://codereview.chromium.org/10910311/diff/1/chrome/browser/process_singlet...
chrome/browser/process_singleton_win.cc:353: 
On 2012/09/17 20:39:06, cpu wrote:
> check for win8 or bigger here, that is less expensive that opening and closing
a
> process handle.

Done.

[Mark Mentovai, 2012-09-17 22:20:58]

LGTM for base OWNERS approval.

[Mark Mentovai, 2012-09-17 22:23:02]

Fix the change description to name IsProcessImmersive instead of
IsImmersiveProcess.

[jam, 2012-09-18 00:04:44]

lgtm