chrome/browser/extensions/api/app_window/app_window_api.cc - Issue 10910304: Cache the object given to the chrome.app.window.create callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 10910304: Cache the object given to the chrome.app.window.create callback (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: improve cohesion with the prototype / JS context based on verbal feedback Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/app_window/app_window_api.cc

diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc

index 6d5205c5550a770578bfc673f36836e19f81ef36..a896a9abf7af2627fa84b0c143d1030716600aa9 100644

--- a/chrome/browser/extensions/api/app_window/app_window_api.cc

+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc

@@ -112,7 +112,11 @@ bool AppWindowCreateFunction::RunImpl() {

content::WebContents* created_contents = shell_window->web_contents();

int view_id = created_contents->GetRenderViewHost()->GetRoutingID();

- SetResult(base::Value::CreateIntegerValue(view_id));

+ scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue);

+ result->SetInteger("viewId", view_id);

+ result->SetString("id", shell_window->window_key());

+ SetResult(result.release());

return true;

}

« no previous file with comments | « no previous file | chrome/browser/ui/extensions/shell_window.h » ('j') | chrome/renderer/resources/extensions/app_window_custom_bindings.js » ('J')