Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: runtime/vm/parser.cc

Issue 10910284: Stop making classes implicitly abstract (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 12390)
+++ runtime/vm/parser.cc (working copy)
@@ -533,7 +533,6 @@
: clazz_(cls),
class_name_(cls_name),
is_interface_(is_interface),
- is_abstract_(false),
token_pos_(token_pos),
functions_(GrowableObjectArray::Handle(GrowableObjectArray::New())),
fields_(GrowableObjectArray::Handle(GrowableObjectArray::New())) {
@@ -609,14 +608,6 @@
return is_interface_;
}
- void set_is_abstract() {
- is_abstract_ = true;
- }
-
- bool is_abstract() const {
- return is_abstract_;
- }
-
bool has_constructor() const {
Function& func = Function::Handle();
for (int i = 0; i < functions_.Length(); i++) {
@@ -667,7 +658,6 @@
const Class& clazz_;
const String& class_name_;
const bool is_interface_;
- bool is_abstract_;
intptr_t token_pos_; // Token index of "class" keyword.
GrowableObjectArray& functions_;
GrowableObjectArray& fields_;
@@ -2602,9 +2592,6 @@
ASSERT(is_top_level_);
AddFormalParamsToFunction(&method->params, func);
members->AddFunction(func);
- if (method->has_abstract) {
- members->set_is_abstract();
- }
}
@@ -3112,7 +3099,7 @@
}
ExpectToken(Token::kRBRACE);
- if (is_abstract || members.is_abstract()) {
+ if (is_abstract) {
cls.set_is_abstract();
}
« no previous file with comments | « no previous file | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698