Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10910264: Move wallpapers to ash/resource (Closed)

Created:
8 years, 3 months ago by oshima
Modified:
8 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Move wallpapers to ash/resource TBR=sky@chromium.org BUG=141663 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156728

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : mac fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -234 lines) Patch
M ash/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_resources.gypi View 1 chunk +21 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/resources/ash_wallpaper_resources.grd View 1 1 chunk +89 lines, -91 lines 0 comments Download
M chrome/chrome_repack_chrome.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/tools/check_grd_for_unused_strings.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +5 lines, -5 lines 0 comments Download
D ui/resources/ui_resources_wallpapers.grd View 1 chunk +0 lines, -111 lines 0 comments Download
M ui/ui_resources.gypi View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
8 years, 3 months ago (2012-09-13 23:18:58 UTC) #1
oshima
8 years, 3 months ago (2012-09-14 00:28:06 UTC) #2
benrg
lgtm
8 years, 3 months ago (2012-09-14 00:34:06 UTC) #3
Emmanuel Saint-loubert-Bié
Awesome! LGTM!
8 years, 3 months ago (2012-09-14 00:35:08 UTC) #4
oshima
8 years, 3 months ago (2012-09-14 00:46:33 UTC) #5
scott,  this is basically resource only change so i'm tbring.

Powered by Google App Engine
This is Rietveld 408576698