Issue 10910144: Get mouse events to work with win aura, and make the combobox function in the views examples app.

Issue 10910144: Get mouse events to work with win aura, and make the combobox function in the views examples app. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)

Modified:
8 years, 3 months ago

Reviewers:
Peter Kasting, sky

CC:
chromium-reviews, ben+watch_chromium.org, tfarina, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get mouse events to work with win aura, and make the combobox function in the views examples app. http://crbug.com/146077 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155832 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156223

Patch Set 8 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -22 lines)			Patch
M	ui/views/controls/menu/menu_host.cc	View	1 2 3 4 5 6 7	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/views/views.gyp	View	1 2 3 4 5 6 7	2 chunks	+12 lines, -11 lines	0 comments	Download
M	ui/views/widget/desktop_capture_client.h	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -1 line	0 comments	Download
A	ui/views/widget/desktop_capture_client.cc	View	1 2 3 4 5 6 7	1 chunk	+44 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_native_widget_aura.cc	View	1 2 3 4 5 6 7	7 chunks	+29 lines, -5 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host.h	View	1 2 3 4 5 6 7	2 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host_linux.h	View	1 2 3 4 5 6 7	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host_linux.cc	View	1 2 3 4 5 6 7	1 chunk	+28 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host_win.h	View	1 2 3 4 5 6 7	3 chunks	+16 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_root_window_host_win.cc	View	1 2 3 4 5 6 7	6 chunks	+47 lines, -4 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.h	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

http://codereview.chromium.org/10910144/diff/4003/ui/views/widget/desktop_native_widget_aura.cc File ui/views/widget/desktop_native_widget_aura.cc (right): http://codereview.chromium.org/10910144/diff/4003/ui/views/widget/desktop_native_widget_aura.cc#newcode382 ui/views/widget/desktop_native_widget_aura.cc:382: return native_widget_delegate_->OnMouseEvent(*event) ? Random drive-by nit: Can these delegate ...

8 years, 3 months ago (2012-09-07 22:32:15 UTC) #3

Ben Goodger (Google)

8 years, 3 months ago (2012-09-07 22:37:26 UTC) #4

Yeah eventually... sadrul is incrementally replacing all of this as part of
his dispatcher rework.


On Fri, Sep 7, 2012 at 3:32 PM, <pkasting@chromium.org> wrote:

>
> http://codereview.chromium.**org/10910144/diff/4003/ui/**
>
views/widget/desktop_native_**widget_aura.cc<http://codereview.chromium.org/10910144/diff/4003/ui/views/widget/desktop_native_widget_aura.cc>
> File ui/views/widget/desktop_**native_widget_aura.cc (right):
>
> http://codereview.chromium.**org/10910144/diff/4003/ui/**
>
views/widget/desktop_native_**widget_aura.cc#newcode382<http://codereview.chromium.org/10910144/diff/4003/ui/views/widget/desktop_native_widget_aura.cc#newcode382>
> ui/views/widget/desktop_**native_widget_aura.cc:382: return
> native_widget_delegate_->**OnMouseEvent(*event) ?
> Random drive-by nit: Can these delegate functions be made to return
> EventResult values directly?
>
>
http://codereview.chromium.**org/10910144/<http://codereview.chromium.org/109...
>

Expand Messages | Collapse Messages