Move undo files into //components/undo

components/undo/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("managed") {
+static_library("undo") {
   sources = [
-    "managed_bookmarks_tracker.cc",
-    "managed_bookmarks_tracker.h",
+    "bookmark_renumber_observer.h",
+    "bookmark_undo_service.cc",
+    "bookmark_undo_service.h",
+    "undo_manager.cc",
+    "undo_manager.h",
+    "undo_manager_observer.h",
+    "undo_operation.h",
   ]
 
   deps = [
+    "//base",
     "//components/bookmarks/browser",
+    "//components/keyed_service/core",
     "//components/strings",
+    "//ui/base",
   ]
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
-    "managed_bookmarks_tracker_unittest.cc",
+    "bookmark_undo_service_test.cc",
+    "undo_manager_test.cc",
   ]
 
-  configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
-
   deps = [
-    ":managed",
     "//components/bookmarks/test",
-    "//components/strings",
-    "//testing/gmock",
+    "//components/undo",

[droger, 2015/04/17 09:06:21]

Should it be ":undo" instead? I don't know if this makes a difference or not.

[sdefresne, 2015/04/17 13:52:00]

There is no need, as //a/b is the same as //a/b:b.

[tfarina, 2015/04/17 20:53:15]

I think that is not Roger was suggesting.

What I think he was suggesting is something like this:

deps = [
  ":undo",
  "//components/bookmarks/test",
]

And yes, I agree with him. This is because the target 'undo' is defined in the
same BUILD.gn file as unit_tests, so it can refer to it by just ':undo', so the
full path is not needed. And this is a standard practice among all other
BUILD.gn deps we have.

Would you mind following up with another CL for this?

     "//testing/gtest",
   ]
 }