Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1090953002: Small cleanups in the Mojo HTML viewer (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dcheng, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small cleanups in the Mojo HTML viewer This CL removes the "override" keyword from all Blink API implementations. We don't use the keyword for the Blink API since it's in a different repository, and it makes changes to the API much harder. Additionally, clean up some minor camelCase -> under_score variables. R=sky@chromium.org BUG= Committed: https://crrev.com/2f01fbf00550feb1647cda41fe1303243328fc16 Cr-Commit-Position: refs/heads/master@{#325468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -222 lines) Patch
M mojo/services/html_viewer/blink_platform_impl.h View 1 chunk +34 lines, -34 lines 0 comments Download
M mojo/services/html_viewer/html_document.h View 2 chunks +18 lines, -18 lines 0 comments Download
M mojo/services/html_viewer/mojo_blink_platform_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/test_blink_platform_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/webclipboard_impl.h View 1 chunk +17 lines, -17 lines 0 comments Download
M mojo/services/html_viewer/webclipboard_impl.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M mojo/services/html_viewer/webcookiejar_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 chunk +36 lines, -36 lines 0 comments Download
M mojo/services/html_viewer/webmimeregistry_impl.h View 1 chunk +19 lines, -19 lines 0 comments Download
M mojo/services/html_viewer/webnotificationmanager_impl.h View 1 chunk +20 lines, -20 lines 0 comments Download
M mojo/services/html_viewer/webscheduler_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/html_viewer/websockethandle_impl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/services/html_viewer/webstoragenamespace_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/webthemeengine_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/webthread_impl.h View 3 chunks +18 lines, -18 lines 0 comments Download
M mojo/services/html_viewer/weburlloader_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Peter Beverloo
PTAL
5 years, 8 months ago (2015-04-16 16:56:17 UTC) #1
sky
LGTM
5 years, 8 months ago (2015-04-16 17:07:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1090953002/1
5 years, 8 months ago (2015-04-16 17:08:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 17:36:59 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:38:33 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2f01fbf00550feb1647cda41fe1303243328fc16
Cr-Commit-Position: refs/heads/master@{#325468}

Powered by Google App Engine
This is Rietveld 408576698